)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"935de7989c678d35438f970d582d0bc26a7f6ba2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add cinder::backup test to scenario0001"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch add the cinder::backup check to scenario001 using ceph"},{"line_number":10,"context_line":"as the drier"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95ac0828cb16c9ead4ce8302ef8e6d2454be2f1d"},{"line_number":13,"context_line":"Depends-On: I94d9b35e65fd0cf202c3b39f835821a0eebbac42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a98d1f4_85559d51","line":10,"range":{"start_line":10,"start_character":7,"end_line":10,"end_character":12},"updated":"2016-09-29 15:10:06.000000000","message":"driver :)","commit_id":"e1c6e596e6664e721866630ac10da44e68327591"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"935de7989c678d35438f970d582d0bc26a7f6ba2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"as the drier"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95ac0828cb16c9ead4ce8302ef8e6d2454be2f1d"},{"line_number":13,"context_line":"Depends-On: I94d9b35e65fd0cf202c3b39f835821a0eebbac42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a98d1f4_25c049e0","line":13,"updated":"2016-09-29 15:10:06.000000000","message":"You can drop the Depends-On, the change merged","commit_id":"e1c6e596e6664e721866630ac10da44e68327591"}],"manifests/cinder.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"935de7989c678d35438f970d582d0bc26a7f6ba2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    properties \u003d\u003e [\u0027volume_backend_name\u003dBACKEND_1\u0027],"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if( $enable_backups )"},{"line_number":146,"context_line":"  {"},{"line_number":147,"context_line":"    class { \u0027::cinder::backup::ceph\u0027:"},{"line_number":148,"context_line":"      backup_ceph_user \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_65489188","line":145,"updated":"2016-09-29 15:10:06.000000000","message":"redundant parenthesis, also please put curly bracket on same line:\n\n   if $enable_backups {\n     ...\n   }","commit_id":"e1c6e596e6664e721866630ac10da44e68327591"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"fff0008a46c771ff511afcc651b8bd4fedab31c1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    properties \u003d\u003e [\u0027volume_backend_name\u003dBACKEND_1\u0027],"},{"line_number":143,"context_line":"  }"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"  if( $enable_backups )"},{"line_number":146,"context_line":"  {"},{"line_number":147,"context_line":"    class { \u0027::cinder::backup::ceph\u0027:"},{"line_number":148,"context_line":"      backup_ceph_user \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_80274b11","line":145,"in_reply_to":"3a98d1f4_65489188","updated":"2016-09-29 15:19:23.000000000","message":"Got it. I blame Perl.","commit_id":"e1c6e596e6664e721866630ac10da44e68327591"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cb4d8475e79bf92e63f057624d713a8524397343","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#   (optional) Boolean to configure or not volume encryption"},{"line_number":10,"context_line":"#   Defaults to false."},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"# [*enable_backups*]"},{"line_number":13,"context_line":"#   (optional) Boolean to enable cinder backups"},{"line_number":14,"context_line":"#   Defaults to true."},{"line_number":15,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a98d1f4_647ae289","line":12,"updated":"2016-10-03 01:31:59.000000000","message":"I would rather creates something like \"cinder_backup\" parameter. Default to false. Possible values: \u0027rbd\u0027, \u0027swift\u0027, so later we can have a case statement to choose which cinder backup backend to configure.","commit_id":"9e48bd6cb168bc55209a2f8d696490252b3c1df7"}],"manifests/tempest.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"935de7989c678d35438f970d582d0bc26a7f6ba2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  $ceilometer              \u003d false,"},{"line_number":77,"context_line":"  $cinder                  \u003d false,"},{"line_number":78,"context_line":"  $designate               \u003d false,"},{"line_number":79,"context_line":"  $cinder_backup           \u003d false,"},{"line_number":80,"context_line":"  $glance                  \u003d true,"},{"line_number":81,"context_line":"  $gnocchi                 \u003d false,"},{"line_number":82,"context_line":"  $heat                    \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_605cffed","line":79,"updated":"2016-09-29 15:10:06.000000000","message":"Can you put it right under Cinder instead of after designate ? (needs fixed for all three additions)","commit_id":"e1c6e596e6664e721866630ac10da44e68327591"},{"author":{"_account_id":19564,"name":"Keith Schincke","email":"keith.schincke@gmail.com","username":"colonwq"},"change_message_id":"fff0008a46c771ff511afcc651b8bd4fedab31c1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  $ceilometer              \u003d false,"},{"line_number":77,"context_line":"  $cinder                  \u003d false,"},{"line_number":78,"context_line":"  $designate               \u003d false,"},{"line_number":79,"context_line":"  $cinder_backup           \u003d false,"},{"line_number":80,"context_line":"  $glance                  \u003d true,"},{"line_number":81,"context_line":"  $gnocchi                 \u003d false,"},{"line_number":82,"context_line":"  $heat                    \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a98d1f4_00325b10","line":79,"in_reply_to":"3a98d1f4_605cffed","updated":"2016-09-29 15:19:23.000000000","message":"fixored. The rebase made the wrong decision.","commit_id":"e1c6e596e6664e721866630ac10da44e68327591"}]}
