)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"71de38b97058029b53b99341c2a7b2d467ac3e45","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use a diffrent smoke test for vitrage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"choose a test without heat"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I554e1a34fba135b52d7b92ba23702c3dadd2f1da"},{"line_number":12,"context_line":"Change-Id: I0bc2eb459e1ac4458833bac2d319a94b23b98b6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a1ced50_ef5408ff","line":9,"updated":"2017-03-22 00:57:28.000000000","message":"It would be great to document what this patch does in the commit message.\nAlso, someone is working on adding Heat on scenario001: https://review.openstack.org/#/c/410865/\n\nIs it something interesting for us to keep the same tests as before? Which tests do you think are relevant?","commit_id":"c1e61a88e7e1bdd0369e140481d479cf1f5ed419"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"2e9b5e85fee367740d85d38a862becd4693acbaf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use a diffrent smoke test for vitrage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"choose a test without heat"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I554e1a34fba135b52d7b92ba23702c3dadd2f1da"},{"line_number":12,"context_line":"Change-Id: I0bc2eb459e1ac4458833bac2d319a94b23b98b6a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a1ced50_2389d475","line":9,"in_reply_to":"1a1ced50_ef5408ff","updated":"2017-03-22 07:17:16.000000000","message":"I think this basic test is enough I don\u0027t have to check it with heat","commit_id":"c1e61a88e7e1bdd0369e140481d479cf1f5ed419"}],"manifests/vitrage.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"575684f595c3daf8db843c05e573ad2e6e2b6cc3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    internal_url \u003d\u003e \"${::openstack_integration::config::base_url}:8999\","},{"line_number":59,"context_line":"    admin_url    \u003d\u003e \"${::openstack_integration::config::base_url}:8999\","},{"line_number":60,"context_line":"    password     \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":61,"context_line":"    tenant       \u003d\u003e \u0027admin\u0027"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"  class { \u0027::vitrage::keystone::authtoken\u0027:"},{"line_number":64,"context_line":"    password            \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_866d959a","line":61,"updated":"2017-03-20 11:32:19.000000000","message":"I\u0027m confused why we need admin tenant (which should be \u0027services\u0027).","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"236df8de84f35fe697189957caf5a6a2d5166b05","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    internal_url \u003d\u003e \"${::openstack_integration::config::base_url}:8999\","},{"line_number":59,"context_line":"    admin_url    \u003d\u003e \"${::openstack_integration::config::base_url}:8999\","},{"line_number":60,"context_line":"    password     \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":61,"context_line":"    tenant       \u003d\u003e \u0027admin\u0027"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"  class { \u0027::vitrage::keystone::authtoken\u0027:"},{"line_number":64,"context_line":"    password            \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_29e112ff","line":61,"in_reply_to":"1a1ced50_866d959a","updated":"2017-03-20 12:02:04.000000000","message":"In production vitrage user must be an admin otherwise some API won\u0027t work. for the smoke test i am using it might work\nI can remove it and try","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"575684f595c3daf8db843c05e573ad2e6e2b6cc3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    auth_url            \u003d\u003e $::openstack_integration::config::keystone_admin_uri,"},{"line_number":68,"context_line":"    auth_uri            \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"},{"line_number":69,"context_line":"    memcached_servers   \u003d\u003e $::openstack_integration::config::memcached_servers,"},{"line_number":70,"context_line":"    project_name        \u003d\u003e \u0027admin\u0027,"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":"  class { \u0027::vitrage::api\u0027:"},{"line_number":73,"context_line":"    enabled      \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_a668d188","line":70,"updated":"2017-03-20 11:32:19.000000000","message":"ditto","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"236df8de84f35fe697189957caf5a6a2d5166b05","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    auth_url            \u003d\u003e $::openstack_integration::config::keystone_admin_uri,"},{"line_number":68,"context_line":"    auth_uri            \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"},{"line_number":69,"context_line":"    memcached_servers   \u003d\u003e $::openstack_integration::config::memcached_servers,"},{"line_number":70,"context_line":"    project_name        \u003d\u003e \u0027admin\u0027,"},{"line_number":71,"context_line":"  }"},{"line_number":72,"context_line":"  class { \u0027::vitrage::api\u0027:"},{"line_number":73,"context_line":"    enabled      \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_a9ed02f1","line":70,"in_reply_to":"1a1ced50_a668d188","updated":"2017-03-20 12:02:04.000000000","message":"see above","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"575684f595c3daf8db843c05e573ad2e6e2b6cc3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  class { \u0027::vitrage::auth\u0027:"},{"line_number":85,"context_line":"    auth_url         \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"},{"line_number":86,"context_line":"    auth_password    \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":87,"context_line":"    auth_tenant_name \u003d\u003e \u0027admin\u0027,"},{"line_number":88,"context_line":"  }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # for testing purposes need a lower interval then default 600"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_c605cdc2","line":87,"updated":"2017-03-20 11:32:19.000000000","message":"ditto","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"236df8de84f35fe697189957caf5a6a2d5166b05","unresolved":false,"context_lines":[{"line_number":84,"context_line":"  class { \u0027::vitrage::auth\u0027:"},{"line_number":85,"context_line":"    auth_url         \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"},{"line_number":86,"context_line":"    auth_password    \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":87,"context_line":"    auth_tenant_name \u003d\u003e \u0027admin\u0027,"},{"line_number":88,"context_line":"  }"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # for testing purposes need a lower interval then default 600"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_89c9267b","line":87,"in_reply_to":"1a1ced50_c605cdc2","updated":"2017-03-20 12:02:04.000000000","message":"see above","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"575684f595c3daf8db843c05e573ad2e6e2b6cc3","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # for testing purposes need a lower interval then default 600"},{"line_number":91,"context_line":"  # add the doctor datasource to the deafult ones"},{"line_number":92,"context_line":"  vitrage_config {"},{"line_number":93,"context_line":"    \u0027datasources/snapshots_interval\u0027 : value \u003d\u003e 120;"},{"line_number":94,"context_line":"    \u0027datasources/types\u0027              : value \u003d\u003e \u0027nova.host,nova.instance,nova.zone,cinder.volume,neutron.port,neutron.network,doctor\u0027;"},{"line_number":95,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_66f5f9c9","line":92,"updated":"2017-03-20 11:32:19.000000000","message":"could we add the 2 parameters into puppet-vitrage? puppet-openstack-integration is supposed to use classes and parameters, to show that it works out of the box.","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":19134,"name":"Eyal","email":"eyalb1@gmail.com","username":"eyalb"},"change_message_id":"236df8de84f35fe697189957caf5a6a2d5166b05","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # for testing purposes need a lower interval then default 600"},{"line_number":91,"context_line":"  # add the doctor datasource to the deafult ones"},{"line_number":92,"context_line":"  vitrage_config {"},{"line_number":93,"context_line":"    \u0027datasources/snapshots_interval\u0027 : value \u003d\u003e 120;"},{"line_number":94,"context_line":"    \u0027datasources/types\u0027              : value \u003d\u003e \u0027nova.host,nova.instance,nova.zone,cinder.volume,neutron.port,neutron.network,doctor\u0027;"},{"line_number":95,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a1ced50_895686d0","line":92,"in_reply_to":"1a1ced50_66f5f9c9","updated":"2017-03-20 12:02:04.000000000","message":"yes I will move it to puppet-vitrage I just wanted to see that the test passes","commit_id":"b38069163289e294828c7c461ad4da6e000c9423"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"71de38b97058029b53b99341c2a7b2d467ac3e45","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    auth_url      \u003d\u003e $::openstack_integration::config::keystone_auth_uri,"},{"line_number":86,"context_line":"    auth_password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  class { \u0027::vitrage::graph\u0027: }"},{"line_number":90,"context_line":"  class { \u0027::vitrage::notifier\u0027: }"},{"line_number":91,"context_line":"  class { \u0027::vitrage::client\u0027: }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a1ced50_4f399cd6","line":88,"updated":"2017-03-22 00:57:28.000000000","message":"this change is not needed","commit_id":"c1e61a88e7e1bdd0369e140481d479cf1f5ed419"}]}