)]}'
{"id":"openstack%2Fpuppet-openstack-integration~448426","triplet_id":"openstack%2Fpuppet-openstack-integration~master~Ib051d713ce4d4110ff315315e23779e53bef0493","project":"openstack/puppet-openstack-integration","branch":"master","hashtags":[],"change_id":"Ib051d713ce4d4110ff315315e23779e53bef0493","subject":"make tenant_network_types support vlan","status":"MERGED","created":"2017-03-22 07:47:15.000000000","updated":"2017-04-03 13:52:30.000000000","submitted":"2017-04-03 13:52:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a6556b4c42012b4c941718e94c31a05b1efe6a58","_number":448426,"virtual_id_number":448426,"owner":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2017-04-03 13:52:30.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2017-04-03 11:51:41.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-03-30 14:21:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2017-04-03 11:51:41.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-30 14:21:42.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2017-04-03 11:51:41.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2017-04-03 13:52:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4e18e3e19b684a59f709626d375b42a9a9227ba4","author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"date":"2017-03-22 07:47:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7053d6575aa05872884c9787162f1930e5e2f4fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-22 08:32:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-puppet-lint/56517e4/ : SUCCESS in 2m 16s\n- gate-puppet-openstack-integration-puppet-syntax-3-centos-7 http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-puppet-syntax-3-centos-7/302adf7/ : SUCCESS in 3m 09s\n- gate-puppet-openstack-integration-puppet-syntax-4-centos-7 http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-puppet-syntax-4-centos-7/c757185/ : SUCCESS in 1m 54s\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7/80430c2/ : SUCCESS in 32m 35s\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/87a3837/ : SUCCESS in 40m 09s\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/40fbfea/ : SUCCESS in 36m 37s\n- gate-puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/fde472e/ : SUCCESS in 30m 59s\n- gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/b2ab9bc/ : SUCCESS in 33m 10s\n- gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/72f4e3b/ : SUCCESS in 43m 27s\n- gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/0be6282/ : SUCCESS in 35m 45s\n- gate-puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/52a1e73/ : SUCCESS in 28m 41s","accounts_in_message":[],"_revision_number":1},{"id":"f8355b4e3b151e10393e08fd10b2b9e4624a53cb","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2017-03-29 17:11:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d6030834da3fcf3d6e288a8037dc809e2729f497","author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"date":"2017-03-30 05:47:21.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n\nHi Alex Schultz,in openstack teant_network support Vxlan ,vlan and so on.\nIn private cloud environment,user may use vlan for teant_network instead of vxlan.\nSo I add some test in api.network.teant_network.py for tempest,but now gate-puppet-openstack-integration not support vlan.(2017-03-30 05:35:07.846868 |     Details: {u\u0027message\u0027: u\"Invalid input for operation: network_type value \u0027vlan\u0027 not supported.\", u\u0027type\u0027: u\u0027InvalidInput\u0027, u\u0027detail\u0027: u\u0027\u0027})\nthe detail log you can check \"http://logs.openstack.org/10/451610/2/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7-nv/e69378c/console.html\",the tempest patch is https://review.openstack.org/#/c/451610/","accounts_in_message":[],"_revision_number":1},{"id":"95324103e28360c87c93d8fa6c7cb50bce60e74e","author":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"date":"2017-03-30 05:54:16.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"b839cc8e0105621f5f9ec02ac15e8a8a419229c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-30 06:40:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-puppet-lint/3e16753/ : SUCCESS in 1m 25s\n- gate-puppet-openstack-integration-puppet-syntax-4-centos-7 http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-puppet-syntax-4-centos-7/d221c68/ : SUCCESS in 3m 18s\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7/cb2ef36/ : SUCCESS in 34m 28s\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/2c7136c/ : SUCCESS in 45m 27s\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/fb6cd53/ : SUCCESS in 36m 49s\n- gate-puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/db5e602/ : SUCCESS in 24m 37s\n- gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/018d3b9/ : SUCCESS in 25m 01s\n- gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/eea09d7/ : SUCCESS in 30m 00s\n- gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/b0954c4/ : SUCCESS in 34m 20s\n- gate-puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/check/gate-puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/960b376/ : SUCCESS in 27m 34s","accounts_in_message":[],"_revision_number":2},{"id":"148b8f30b1cf98b113035d1d9ba4f08f7385e77b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2017-03-30 14:21:42.000000000","message":"Patch Set 2: Code-Review+2\n\nI\u0027m OK adding it, just wondering if the tempest test could be smarter to check the supported tenant_network_types prior to trying to execute tests that are not supported on the cloud.  Since this is our test configuration for our cloud I think it\u0027s a bit weird to try and test vlan in tempest if the cloud does not support it.","accounts_in_message":[],"_revision_number":2},{"id":"2e449bc9124e850f7eb86127a9705050157147e3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-04-03 11:51:41.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"e6a72841fddf483f7fbfed44a7dc21421f60f97a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 11:51:51.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3f5d0ca86dbcf0dd896094bb52023f05e1fdcaf6","date":"2017-04-03 13:52:30.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"a6556b4c42012b4c941718e94c31a05b1efe6a58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-03 13:52:30.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-openstack-integration-puppet-lint http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-puppet-lint/4c092d4/ : SUCCESS in 7m 01s\n- gate-puppet-openstack-integration-puppet-syntax-4-centos-7 http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-puppet-syntax-4-centos-7/edc456d/ : SUCCESS in 4m 59s\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7/7be0669/ : SUCCESS in 35m 17s\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/60e829c/ : SUCCESS in 33m 06s\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/c24fd5c/ : SUCCESS in 42m 40s\n- gate-puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/2a11aed/ : SUCCESS in 31m 41s\n- gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/8f2f9af/ : SUCCESS in 32m 12s\n- gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/cec4efe/ : SUCCESS in 34m 27s\n- gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/2c0eff9/ : SUCCESS in 32m 25s\n- gate-puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/26/448426/2/gate/gate-puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/cc5f599/ : SUCCESS in 24m 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"86f50e77b549db8f2d5b6625336b13c860693922","revisions":{"20cba4526688303a59677c8be48f1ce86e503272":{"kind":"REWORK","_number":1,"created":"2017-03-22 07:47:15.000000000","uploader":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"ref":"refs/changes/26/448426/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/26/448426/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/1"}}},"commit":{"parents":[{"commit":"86ab85e9c2b0f0e55c5e1eabf0da7a8d8a8634d5","subject":"Switch trunk/cbs/buildlogs to use https","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/86ab85e9c2b0f0e55c5e1eabf0da7a8d8a8634d5"}]}],"author":{"name":"lianghao","email":"lianghao@cmss.chinamobile.com","date":"2017-03-22 07:41:02.000000000","tz":480},"committer":{"name":"lianghao","email":"lianghao@cmss.chinamobile.com","date":"2017-03-22 07:42:43.000000000","tz":480},"subject":"make tenant_network_types support vlan","message":"make tenant_network_types support vlan\n\nChange-Id: Ib051d713ce4d4110ff315315e23779e53bef0493\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/20cba4526688303a59677c8be48f1ce86e503272"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/20cba4526688303a59677c8be48f1ce86e503272"}]},"branch":"refs/heads/master"},"86f50e77b549db8f2d5b6625336b13c860693922":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-03-30 05:54:16.000000000","uploader":{"_account_id":21897,"name":"lianghao","email":"lianghao@cmss.chinamobile.com","username":"cloud-liang"},"ref":"refs/changes/26/448426/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/26/448426/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/26/448426/2"}}},"commit":{"parents":[{"commit":"86ab85e9c2b0f0e55c5e1eabf0da7a8d8a8634d5","subject":"Switch trunk/cbs/buildlogs to use https","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/86ab85e9c2b0f0e55c5e1eabf0da7a8d8a8634d5"}]}],"author":{"name":"lianghao","email":"lianghao@cmss.chinamobile.com","date":"2017-03-22 07:41:02.000000000","tz":480},"committer":{"name":"Liang Hao","email":"lianghao@cmss.chinamobile.com","date":"2017-03-30 05:54:07.000000000","tz":0},"subject":"make tenant_network_types support vlan","message":"make tenant_network_types support vlan\n\nChange-Id: Ib051d713ce4d4110ff315315e23779e53bef0493\nCloses-Bug: #1677459\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/86f50e77b549db8f2d5b6625336b13c860693922"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/86f50e77b549db8f2d5b6625336b13c860693922"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
