)]}'
{"fixtures/scenario004.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0830ef2027d3cc944e3d5a8d5a24883eedf9148b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  $ssl_enabled     \u003d false"},{"line_number":20,"context_line":"  $ipv6            \u003d false"},{"line_number":21,"context_line":"  # Watcher packages are not available in Ubuntu repository."},{"line_number":22,"context_line":"  $watcher_enabled \u003d false"},{"line_number":23,"context_line":"} else {"},{"line_number":24,"context_line":"  $ssl_enabled     \u003d true"},{"line_number":25,"context_line":"  $ipv6            \u003d true"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7ffa3b31_8b1c006b","line":22,"updated":"2017-04-17 17:24:26.000000000","message":"If there\u0027s no debian packaging for this, you need to create an OS specific flag for enablement here.","commit_id":"d763b76bb00d81a376ee943a54f8e29a55551d8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"89cafcc866c80c5b243fcb30eca22dafd2b762bc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  # Watcher packages are not available in Ubuntu repository."},{"line_number":22,"context_line":"  $watcher_enabled \u003d false"},{"line_number":23,"context_line":"  # TODO(rnoriega) Enable testing for BGPVPN when UCA releases pike-m1"},{"line_number":24,"context_line":"  test_bgpvpn_api  \u003d false"},{"line_number":25,"context_line":"} else {"},{"line_number":26,"context_line":"  $ssl_enabled     \u003d true"},{"line_number":27,"context_line":"  $ipv6            \u003d true"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7ffa3b31_b738faed","line":24,"range":{"start_line":24,"start_character":2,"end_line":24,"end_character":17},"updated":"2017-04-19 15:48:44.000000000","message":"$test_bgpvpn_api","commit_id":"a414909ff629d501ba6658cb8ef7f2504c660b89"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"89cafcc866c80c5b243fcb30eca22dafd2b762bc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  $ssl_enabled     \u003d true"},{"line_number":27,"context_line":"  $ipv6            \u003d true"},{"line_number":28,"context_line":"  $watcher_enabled \u003d true"},{"line_number":29,"context_line":"  test_bgpvpn_api  \u003d true"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"include ::openstack_integration"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7ffa3b31_7726f2d0","line":29,"range":{"start_line":29,"start_character":2,"end_line":29,"end_character":17},"updated":"2017-04-19 15:48:44.000000000","message":"$test_bgpvpn_api","commit_id":"a414909ff629d501ba6658cb8ef7f2504c660b89"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"89cafcc866c80c5b243fcb30eca22dafd2b762bc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  backend \u003d\u003e \u0027swift\u0027,"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":"if $test_bgpvpn_api {"},{"line_number":49,"context_line":"  include ::openstack_integration::neutron"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":"class { \u0027::openstack_integration::nova\u0027:"},{"line_number":52,"context_line":"  libvirt_rbd \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7ffa3b31_f7320210","line":49,"updated":"2017-04-19 15:48:44.000000000","message":"I think we need this still.  You want...\n\nclass { \u0027::openstack_integration::neutron\u0027:\n  test_bgpvpn_api \u003d\u003e $test_bgpvpn_api\n}","commit_id":"a414909ff629d501ba6658cb8ef7f2504c660b89"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"89cafcc866c80c5b243fcb30eca22dafd2b762bc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  backend \u003d\u003e \u0027swift\u0027,"},{"line_number":47,"context_line":"}"},{"line_number":48,"context_line":"if $test_bgpvpn_api {"},{"line_number":49,"context_line":"  include ::openstack_integration::neutron"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":"class { \u0027::openstack_integration::nova\u0027:"},{"line_number":52,"context_line":"  libvirt_rbd \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7ffa3b31_77615205","line":49,"updated":"2017-04-19 15:48:44.000000000","message":"no we need this.\n\nYou want","commit_id":"a414909ff629d501ba6658cb8ef7f2504c660b89"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3100c1afb7b9d1397b019b6d138d60fd29e7af20","unresolved":false,"context_lines":[{"line_number":65,"context_line":"# Don\u0027t test swift, radosgw won\u0027t pass the current tests"},{"line_number":66,"context_line":"# Glance, nova, neutron are true by default."},{"line_number":67,"context_line":"class { \u0027::openstack_integration::tempest\u0027:"},{"line_number":68,"context_line":"  watcher \u003d\u003e $watcher_enabled,"},{"line_number":69,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7ffa3b31_8b96f24b","line":68,"updated":"2017-04-19 19:08:02.000000000","message":"you need to add the parameter here and and in tempest.pp to enable the tempest tests","commit_id":"b0393c5250f967106fca8237c18d8c88ef7156c7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cf00f1ba95cb0c1f064899a4cf48af61c4b90282","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# Glance, nova, neutron are true by default."},{"line_number":67,"context_line":"class { \u0027::openstack_integration::tempest\u0027:"},{"line_number":68,"context_line":"  watcher \u003d\u003e $watcher_enabled,"},{"line_number":69,"context_line":"  bgpvpn  \u003d\u003e $test_bgpvpn_api,"},{"line_number":70,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7ffa3b31_b9744c37","line":69,"updated":"2017-04-20 14:59:36.000000000","message":"please be consistent and call it bgpvpn_enabled","commit_id":"407216680774c7aa8f5e717d74c9a273c9b02e7f"}],"manifests/neutron.pp":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"e99e058b38f4ca209e2773def5d698d6edfa0890","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    driver        \u003d\u003e \u0027neutron_fwaas.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\u0027,"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"  }"},{"line_number":195,"context_line":"  if $::openstack_integration::neutron::test_bgpvpn_api {"},{"line_number":196,"context_line":"    class {\u0027::neutron::services::bgpvpn\u0027:"},{"line_number":197,"context_line":"      service_providers \u003d\u003e \u0027BGPVPN:Dummy:networking_bgpvpn.neutron.services.service_drivers.driver_api.BGPVPNDriver:default\u0027"},{"line_number":198,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_177c0681","line":195,"updated":"2017-04-11 14:48:26.000000000","message":"Can be accessed via if $test_bgpvpn_api {","commit_id":"f14222c29278cf754f36c038225d69b5f062c599"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"39ceb978d0cd244673e0b30fa1ea4e70aa312764","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    rabbit_use_ssl        \u003d\u003e $::openstack_integration::config::ssl,"},{"line_number":115,"context_line":"    allow_overlapping_ips \u003d\u003e true,"},{"line_number":116,"context_line":"    core_plugin           \u003d\u003e \u0027ml2\u0027,"},{"line_number":117,"context_line":"    service_plugins       \u003d\u003e [\u0027router\u0027, \u0027metering\u0027, \u0027firewall\u0027, \u0027lbaasv2\u0027, \u0027bgpvpn\u0027],"},{"line_number":118,"context_line":"    debug                 \u003d\u003e true,"},{"line_number":119,"context_line":"    bind_host             \u003d\u003e $::openstack_integration::config::host,"},{"line_number":120,"context_line":"    use_ssl               \u003d\u003e $::openstack_integration::config::ssl,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bff0334d_f1d299ff","line":117,"range":{"start_line":117,"start_character":76,"end_line":117,"end_character":82},"updated":"2017-04-12 20:45:40.000000000","message":"This needs to be conditional and it is why all other scenarios are failing - the bgpvpn plugin is enabled but bgpvpn is not set up:\n\n    http://logs.openstack.org/35/455735/3/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/00ffc27/logs/neutron/server.txt.gz#_2017-04-12_09_14_54_172","commit_id":"99ade33264d823ff142a189b76013926c29c4dab"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0bd0247255cd6f8b9d6b0c5d6127bec0f924884b","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    sync_db             \u003d\u003e true,"},{"line_number":140,"context_line":"    api_workers         \u003d\u003e 2,"},{"line_number":141,"context_line":"    rpc_workers         \u003d\u003e 2,"},{"line_number":142,"context_line":"    service_providers   \u003d\u003e [\u0027LOADBALANCER:Haproxy:neutron_lbaas.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default\u0027,"},{"line_number":143,"context_line":"                            \u0027LOADBALANCERV2:Haproxy:neutron_lbaas.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default\u0027,"},{"line_number":144,"context_line":"                            \u0027FIREWALL:Iptables:neutron.agent.linux.iptables_firewall.OVSHybridIptablesFirewallDriver:default\u0027],"},{"line_number":145,"context_line":"  }"},{"line_number":146,"context_line":"  class { \u0027::neutron::services::lbaas\u0027: }"},{"line_number":147,"context_line":"  class { \u0027::neutron::plugins::ml2\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7ffa3b31_5d6b171d","line":144,"range":{"start_line":142,"start_character":4,"end_line":144,"end_character":127},"updated":"2017-04-19 16:31:52.000000000","message":"So i think the workaround for ubuntu is to extract this bit to an array and use merge if $test_bgpvpn_api since ubuntu doesn\u0027t like the extra config file.  But we can do this later","commit_id":"b0393c5250f967106fca8237c18d8c88ef7156c7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cf00f1ba95cb0c1f064899a4cf48af61c4b90282","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class openstack_integration::neutron ("},{"line_number":13,"context_line":"  $driver \u003d \u0027openvswitch\u0027,"},{"line_number":14,"context_line":"  $test_bgpvpn_api \u003d false,"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::openstack_integration::config"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7ffa3b31_d97b9825","line":14,"updated":"2017-04-20 14:59:36.000000000","message":"ditto","commit_id":"407216680774c7aa8f5e717d74c9a273c9b02e7f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56f4841294f749ab5358b9f78ca25b7b03b5430d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*bgpvpn_enabled*]"},{"line_number":9,"context_line":"#   (optional) Flag to enable BGPVPN"},{"line_number":10,"context_line":"#   API extensions"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class openstack_integration::neutron ("},{"line_number":13,"context_line":"  $driver \u003d \u0027openvswitch\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7ffa3b31_ad92a655","line":10,"updated":"2017-04-21 12:54:13.000000000","message":"Defaults to false.","commit_id":"1b9e69d7247bdd4be78183518fe5fce1be763c4d"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"6eff5a31bc2a9e7bf07deeeadbf23d4d099661b6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*bgpvpn_enabled*]"},{"line_number":9,"context_line":"#   (optional) Flag to enable BGPVPN"},{"line_number":10,"context_line":"#   API extensions"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class openstack_integration::neutron ("},{"line_number":13,"context_line":"  $driver \u003d \u0027openvswitch\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7ffa3b31_b0dafd74","line":10,"in_reply_to":"7ffa3b31_ad92a655","updated":"2017-04-21 13:18:32.000000000","message":"Done","commit_id":"1b9e69d7247bdd4be78183518fe5fce1be763c4d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56f4841294f749ab5358b9f78ca25b7b03b5430d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   API extensions"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class openstack_integration::neutron ("},{"line_number":13,"context_line":"  $driver \u003d \u0027openvswitch\u0027,"},{"line_number":14,"context_line":"  $bgpvpn_enabled \u003d false,"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7ffa3b31_4d8d6230","line":13,"updated":"2017-04-21 12:54:13.000000000","message":"we like to align the \u003d","commit_id":"1b9e69d7247bdd4be78183518fe5fce1be763c4d"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"6eff5a31bc2a9e7bf07deeeadbf23d4d099661b6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   API extensions"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"class openstack_integration::neutron ("},{"line_number":13,"context_line":"  $driver \u003d \u0027openvswitch\u0027,"},{"line_number":14,"context_line":"  $bgpvpn_enabled \u003d false,"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7ffa3b31_f0f405f3","line":13,"in_reply_to":"7ffa3b31_4d8d6230","updated":"2017-04-21 13:18:32.000000000","message":"Done","commit_id":"1b9e69d7247bdd4be78183518fe5fce1be763c4d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"56f4841294f749ab5358b9f78ca25b7b03b5430d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    password     \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":"  $plugins_list \u003d $bgpvpn_enabled ? {"},{"line_number":107,"context_line":"    true \u003d\u003e [\u0027router\u0027, \u0027metering\u0027, \u0027firewall\u0027, \u0027lbaasv2\u0027, \u0027networking_bgpvpn.neutron.services.plugin.BGPVPNPlugin\u0027],"},{"line_number":108,"context_line":"    default \u003d\u003e [\u0027router\u0027, \u0027metering\u0027, \u0027firewall\u0027, \u0027lbaasv2\u0027],"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  class { \u0027::neutron\u0027:"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7ffa3b31_ed854e08","line":107,"updated":"2017-04-21 12:54:13.000000000","message":"could we use the shortname ?","commit_id":"1b9e69d7247bdd4be78183518fe5fce1be763c4d"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"6eff5a31bc2a9e7bf07deeeadbf23d4d099661b6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    password     \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":105,"context_line":"  }"},{"line_number":106,"context_line":"  $plugins_list \u003d $bgpvpn_enabled ? {"},{"line_number":107,"context_line":"    true \u003d\u003e [\u0027router\u0027, \u0027metering\u0027, \u0027firewall\u0027, \u0027lbaasv2\u0027, \u0027networking_bgpvpn.neutron.services.plugin.BGPVPNPlugin\u0027],"},{"line_number":108,"context_line":"    default \u003d\u003e [\u0027router\u0027, \u0027metering\u0027, \u0027firewall\u0027, \u0027lbaasv2\u0027],"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  class { \u0027::neutron\u0027:"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7ffa3b31_90bee1fc","line":107,"in_reply_to":"7ffa3b31_ed854e08","updated":"2017-04-21 13:18:32.000000000","message":"Ubuntu package for python-networking-bgpvpn does not contain this patch that enables stevedore alias support: \n\nhttps://review.openstack.org/#/c/444886/","commit_id":"1b9e69d7247bdd4be78183518fe5fce1be763c4d"}]}