)]}'
{"configure_facts.sh":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"99bb30f997ba281cfe8590c340b31deb732c307f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# Write out facts to the facter folder when we generate them."},{"line_number":17,"context_line":"export WRITE_FACTS\u003d${WRITE_FACTS:-true}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RDO_MIRROR_HOST\u003d`curl --silent https://trunk.rdoproject.org/centos7-master/puppet-passed-ci/delorean.repo | grep baseurl | cut -d\u003d -f2`"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if [ -f /etc/ci/mirror_info.sh ]; then"},{"line_number":22,"context_line":"    source /etc/ci/mirror_info.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7f287b81_459ff302","line":19,"updated":"2017-08-24 22:01:04.000000000","message":"This is a potential issue, since we curl trunk.rdoproject.org directly, we\u0027ve been seeing some potential networking issue.  Do you mind doing what we did in:  Ia06ebad96c8db2a4eb732e80f04c72ad4c9bc6a3\n\nA follow up patch also works","commit_id":"bc920c57c1332a95a10c1af4c45d5a95597278f4"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"4229947ad5a5bdd486e50ca8c5face9d0131a73f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"export WRITE_FACTS\u003d${WRITE_FACTS:-true}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"RDO_MIRROR_HOST\u003d`curl --silent ${NODEPOOL_RDO_PROXY}/centos7-master/puppet-passed-ci/delorean.repo | grep baseurl | cut -d\u003d -f2`"},{"line_number":21,"context_line":"if [[ -z \"$RDO_MIRROR_HOST\" ]]; then"},{"line_number":22,"context_line":"    echo \"Failed to parse dlrn hash\""},{"line_number":23,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_0013195e","line":20,"updated":"2017-08-24 22:10:21.000000000","message":"This wil always be unset because we haven\u0027t source\u0027d /etc/ci/mirror_info.sh\n\nMaybe move this down inside in\n\n-f /etc/ci/mirror_info.sh\n\n?","commit_id":"5fce1511a482774dfd8d65af875ff18599e08dda"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"4cfd4567f2ca3f93f287b843b5b75ebd5fb28e31","unresolved":false,"context_lines":[{"line_number":17,"context_line":"export WRITE_FACTS\u003d${WRITE_FACTS:-true}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"RDO_MIRROR_HOST\u003d`curl --silent ${NODEPOOL_RDO_PROXY}/centos7-master/puppet-passed-ci/delorean.repo | grep baseurl | cut -d\u003d -f2`"},{"line_number":21,"context_line":"if [[ -z \"$RDO_MIRROR_HOST\" ]]; then"},{"line_number":22,"context_line":"    echo \"Failed to parse dlrn hash\""},{"line_number":23,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_a502170a","line":20,"updated":"2017-08-24 22:12:47.000000000","message":"This will need to move to line 45, since NODEPOOL_RDO_PROXY isn\u0027t sources yet.","commit_id":"5fce1511a482774dfd8d65af875ff18599e08dda"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"4cfd4567f2ca3f93f287b843b5b75ebd5fb28e31","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    source /etc/ci/mirror_info.sh"},{"line_number":28,"context_line":"    CENTOS_MIRROR_HOST\u003d\"http://${NODEPOOL_MIRROR_HOST}\""},{"line_number":29,"context_line":"    BUILDLOGS_MIRROR_HOST\u003d\"${NODEPOOL_BUILDLOGS_CENTOS_PROXY}/centos/7/cloud/x86_64/openstack-pike\""},{"line_number":30,"context_line":"    RDO_MIRROR_HOST\u003d${RDO_MIRROR_HOST/https:\\/\\/trunk.rdoproject.org/$NODEPOOL_MIRROR_HOST:8080/rdo}"},{"line_number":31,"context_line":"    if uses_debs; then"},{"line_number":32,"context_line":"        CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/ceph-deb-jewel\""},{"line_number":33,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_c01cf16b","line":30,"updated":"2017-08-24 22:12:47.000000000","message":"this logic would then move to line 46","commit_id":"5fce1511a482774dfd8d65af875ff18599e08dda"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"4cfd4567f2ca3f93f287b843b5b75ebd5fb28e31","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/7/storage/x86_64/ceph-jewel/\""},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"else"},{"line_number":37,"context_line":"    CENTOS_MIRROR_HOST\u003d\u0027http://mirror.centos.org\u0027"},{"line_number":38,"context_line":"    BUILDLOGS_MIRROR_HOST\u003d\u0027https://buildlogs.centos.org/centos/7/cloud/x86_64/openstack-pike\u0027"},{"line_number":39,"context_line":"    if uses_debs; then"},{"line_number":40,"context_line":"        CEPH_MIRROR_HOST\u003d\u0027https://download.ceph.com/debian-jewel\u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_200cd539","line":37,"updated":"2017-08-24 22:12:47.000000000","message":"you\u0027ll also have to define a default here","commit_id":"5fce1511a482774dfd8d65af875ff18599e08dda"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"566c07c04bcd9f16d6629ce815ca1117541001bd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/7/storage/x86_64/ceph-jewel/\""},{"line_number":35,"context_line":"    fi"},{"line_number":36,"context_line":"else"},{"line_number":37,"context_line":"    CENTOS_MIRROR_HOST\u003d\u0027http://mirror.centos.org\u0027"},{"line_number":38,"context_line":"    BUILDLOGS_MIRROR_HOST\u003d\u0027https://buildlogs.centos.org/centos/7/cloud/x86_64/openstack-pike\u0027"},{"line_number":39,"context_line":"    if uses_debs; then"},{"line_number":40,"context_line":"        CEPH_MIRROR_HOST\u003d\u0027https://download.ceph.com/debian-jewel\u0027"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7f287b81_00af99e3","line":37,"in_reply_to":"7f287b81_200cd539","updated":"2017-08-24 22:20:49.000000000","message":"default for what?  I think if it\u0027s undef in the facts it\u0027ll trigger our defaults in puppet since we use a pick($::centos_mirror_host, \u0027http...\u0027)","commit_id":"5fce1511a482774dfd8d65af875ff18599e08dda"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e80a4dae7f9d4a798f7f25711c5c434c3092656b","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    $SUDO mkdir -p /etc/facter/facts.d/"},{"line_number":57,"context_line":"    $SUDO tee /etc/facter/facts.d/mirrors.txt \u003c\u003cEOF"},{"line_number":58,"context_line":"centos_mirror_host\u003d${FACTER_centos_mirror_host}"},{"line_number":59,"context_line":"uca_mirror_host\u003d${FACTER_uca_mirror_host}"},{"line_number":60,"context_line":"buildlogs_mirror_host\u003d${FACTER_buildlogs_mirror_host}"},{"line_number":61,"context_line":"ceph_mirror_host\u003d${FACTER_ceph_mirror_host}"},{"line_number":62,"context_line":"rdo_mirror_host\u003d${FACTER_rdo_mirror_host}"},{"line_number":63,"context_line":"EOF"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f287b81_4041210b","line":62,"range":{"start_line":58,"start_character":0,"end_line":62,"end_character":41},"updated":"2017-08-24 22:21:40.000000000","message":"So what should happen if any of these are undef is that we\u0027ll end up with undef in factor which will cause the repo stuff from openstack_extras to use what we have there. This should be tested","commit_id":"4a7821cf04ff2206cdffc8357dd3ce4967e71809"}]}