)]}'
{".zuul.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"69bdea3f64fcba3c4b575b6bd3b4dddc329d9fb7","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    check:"},{"line_number":178,"context_line":"      jobs:"},{"line_number":179,"context_line":"        - puppet-openstack-integration-scenario001-centos-7-puppet-4"},{"line_number":180,"context_line":"        - puppet-openstack-integration-scenario002-centos-7-puppet-4"},{"line_number":181,"context_line":"        - puppet-openstack-integration-scenario003-centos-7-puppet-4"},{"line_number":182,"context_line":"        - puppet-openstack-integration-scenario004-centos-7-puppet-4"},{"line_number":183,"context_line":"        - puppet-openstack-integration-scenario001-centos-7-puppet-5"},{"line_number":184,"context_line":"        - puppet-openstack-integration-scenario002-centos-7-puppet-5"},{"line_number":185,"context_line":"        - puppet-openstack-integration-scenario003-centos-7-puppet-5"},{"line_number":186,"context_line":"        - puppet-openstack-integration-scenario004-centos-7-puppet-5"},{"line_number":187,"context_line":"        - puppet-openstack-integration-scenario001-ubuntu-xenial-puppet-4"},{"line_number":188,"context_line":"        - puppet-openstack-integration-scenario002-ubuntu-xenial-puppet-4"},{"line_number":189,"context_line":"        - puppet-openstack-integration-scenario003-ubuntu-xenial-puppet-4"},{"line_number":190,"context_line":"        - puppet-openstack-integration-scenario004-ubuntu-xenial-puppet-4"},{"line_number":191,"context_line":"        - puppet-openstack-integration-scenario001-ubuntu-xenial-puppet-5"},{"line_number":192,"context_line":"        - puppet-openstack-integration-scenario002-ubuntu-xenial-puppet-5"},{"line_number":193,"context_line":"        - puppet-openstack-integration-scenario003-ubuntu-xenial-puppet-5"},{"line_number":194,"context_line":"        - puppet-openstack-integration-scenario004-ubuntu-xenial-puppet-5"},{"line_number":195,"context_line":"    gate:"},{"line_number":196,"context_line":"      jobs:"},{"line_number":197,"context_line":"        - puppet-openstack-integration-scenario001-centos-7-puppet-4"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_590bfa22","line":194,"range":{"start_line":180,"start_character":0,"end_line":194,"end_character":73},"updated":"2017-09-28 20:55:36.000000000","message":"If you\u0027re going to iterate and test things, I would only start with one job and then copy pasta once you have the first job working. Otherwise it\u0027s just wasteful.","commit_id":"06df542753235a4b9ce39bf3a00a78ad06892f92"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9754c66d9653e48989dc70dbdc49e3e4284aa480","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    run: playbooks/run-integration-tests"},{"line_number":12,"context_line":"    post-run: playbooks/upload-logs"},{"line_number":13,"context_line":"    timeout: 5400"},{"line_number":14,"context_line":"    required-projects:"},{"line_number":15,"context_line":"      - openstack/openstack"},{"line_number":16,"context_line":"      - openstack/puppet-aodh"},{"line_number":17,"context_line":"      - openstack/puppet-barbican"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7f515b1d_7e71ee43","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":22},"updated":"2017-09-29 12:49:07.000000000","message":"Do we need puppet-magnum and puppet-glare here?","commit_id":"bde052c8e488485925017e5a1806dee5b397c2aa"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"2c4dd0f2a4d01487a5130af3585c7d7024a47fa5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    run: playbooks/run-integration-tests"},{"line_number":12,"context_line":"    post-run: playbooks/upload-logs"},{"line_number":13,"context_line":"    timeout: 5400"},{"line_number":14,"context_line":"    required-projects:"},{"line_number":15,"context_line":"      - openstack/openstack"},{"line_number":16,"context_line":"      - openstack/puppet-aodh"},{"line_number":17,"context_line":"      - openstack/puppet-barbican"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7f515b1d_8f1592e7","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":22},"in_reply_to":"7f515b1d_7e71ee43","updated":"2017-09-29 18:15:17.000000000","message":"Due to the fact that they are actually not tested in the integration, we can avoid the extra clones for no reason.","commit_id":"bde052c8e488485925017e5a1806dee5b397c2aa"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"32dafc1d26de15bdddf843df3d2514a141feed52","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    run: playbooks/run-integration-tests"},{"line_number":12,"context_line":"    post-run: playbooks/upload-logs"},{"line_number":13,"context_line":"    timeout: 5400"},{"line_number":14,"context_line":"    required-projects:"},{"line_number":15,"context_line":"      - openstack/openstack"},{"line_number":16,"context_line":"      - openstack/puppet-aodh"},{"line_number":17,"context_line":"      - openstack/puppet-barbican"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7f515b1d_55f2889b","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":22},"in_reply_to":"7f515b1d_8f1592e7","updated":"2017-09-29 19:32:55.000000000","message":"Ty Mohammed, I will review the other files ;)","commit_id":"bde052c8e488485925017e5a1806dee5b397c2aa"}],"playbooks/run-tests.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"48d15f7f766bcc6ea9397a27fd49d4360031a3f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  name: Puppet OpenStack Integration"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":"    - name: Ensure legacy workspace directory"},{"line_number":5,"context_line":"      file:"},{"line_number":6,"context_line":"        path: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":7,"context_line":"        state: directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - shell:"},{"line_number":10,"context_line":"        cmd: |"},{"line_number":11,"context_line":"          set -e"},{"line_number":12,"context_line":"          set -x"},{"line_number":13,"context_line":"          ZUUL_BRANCH_REAL\u003d${ZUUL_BRANCH:-master}"},{"line_number":14,"context_line":"          # Workaround for puppet-ceph, where we need to checkout"},{"line_number":15,"context_line":"          # puppet-openstack-integration from stable/pike when working on"},{"line_number":16,"context_line":"          # stable/jewel."},{"line_number":17,"context_line":"          # Ceph Jewel works with Newton to Pike"},{"line_number":18,"context_line":"          if [[ \"$ZUUL_BRANCH\" \u003d\u003d \"stable/jewel\" ]]; then"},{"line_number":19,"context_line":"              ZUUL_BRANCH_REAL\u003d\u0027stable/pike\u0027"},{"line_number":20,"context_line":"          fi"},{"line_number":21,"context_line":"          export ZUUL_REF\u003d${ZUUL_REF:-None}"},{"line_number":22,"context_line":"          CLONEMAP\u003d`mktemp`"},{"line_number":23,"context_line":"          function cleanup {"},{"line_number":24,"context_line":"              rm -f $CLONEMAP"},{"line_number":25,"context_line":"          }"},{"line_number":26,"context_line":"          trap cleanup EXIT"},{"line_number":27,"context_line":"          cat \u003e $CLONEMAP \u003c\u003c EOF"},{"line_number":28,"context_line":"          clonemap:"},{"line_number":29,"context_line":"            - name: openstack/puppet-openstack-integration"},{"line_number":30,"context_line":"              dest: puppet-openstack-integration"},{"line_number":31,"context_line":"          EOF"},{"line_number":32,"context_line":"          /usr/zuul-env/bin/zuul-cloner -m $CLONEMAP \\"},{"line_number":33,"context_line":"              --cache-dir /opt/git \\"},{"line_number":34,"context_line":"              --zuul-branch $ZUUL_BRANCH_REAL \\"},{"line_number":35,"context_line":"              git://git.openstack.org openstack/puppet-openstack-integration"},{"line_number":36,"context_line":"        executable: /bin/bash"},{"line_number":37,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace\u0027"},{"line_number":38,"context_line":"      environment: \u0027{{ zuul | zuul_legacy_vars }}\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - include_role:"},{"line_number":41,"context_line":"        name: bindep"},{"line_number":42,"context_line":"      vars:"},{"line_number":43,"context_line":"        bindep_dir: \"src/git.openstack.org/openstack/puppet-openstack-integration\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: Clean-up system state (RedHat)"},{"line_number":46,"context_line":"      yum:"},{"line_number":47,"context_line":"        name: \"{{ item }}\""},{"line_number":48,"context_line":"        state: absent"},{"line_number":49,"context_line":"      become: true"},{"line_number":50,"context_line":"      when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":51,"context_line":"      with_items:"},{"line_number":52,"context_line":"        - rdo-release"},{"line_number":53,"context_line":"        - centos-release-openstack-*"},{"line_number":54,"context_line":"        - centos-release-ceph-*"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    - name: Install Ruby dependencies (RedHat)"},{"line_number":57,"context_line":"      yum:"},{"line_number":58,"context_line":"        name: \"{{ item }}\""},{"line_number":59,"context_line":"      become: true"},{"line_number":60,"context_line":"      when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":61,"context_line":"      with_items:"},{"line_number":62,"context_line":"        - \"@Development tools\""},{"line_number":63,"context_line":"        - libxml2-devel"},{"line_number":64,"context_line":"        - libxslt-devel"},{"line_number":65,"context_line":"        - ruby-devel"},{"line_number":66,"context_line":"        - zlib-devel"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    - name: Install Ruby dependencies (Debian)"},{"line_number":69,"context_line":"      apt:"},{"line_number":70,"context_line":"        name: \"{{ item }}\""},{"line_number":71,"context_line":"      become: true"},{"line_number":72,"context_line":"      when: ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":73,"context_line":"      with_items:"},{"line_number":74,"context_line":"        - libxml2-dev"},{"line_number":75,"context_line":"        - libxslt-dev"},{"line_number":76,"context_line":"        - ruby-dev"},{"line_number":77,"context_line":"        - zlib1g-dev"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    - name: Create folder for gems"},{"line_number":80,"context_line":"      file:"},{"line_number":81,"context_line":"        path: \"{{ ansible_user_dir }}/workspace/puppet-openstack-integration/.bundled_gems\""},{"line_number":82,"context_line":"        state: directory"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    - name: Install bundler"},{"line_number":85,"context_line":"      gem:"},{"line_number":86,"context_line":"        name: bundler"},{"line_number":87,"context_line":"        user_install: false"},{"line_number":88,"context_line":"      environment:"},{"line_number":89,"context_line":"        GEM_HOME: \"{{ ansible_user_dir }}/workspace/puppet-openstack-integration/.bundled_gems\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    - shell:"},{"line_number":92,"context_line":"        cmd: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_5959ba32","line":89,"range":{"start_line":4,"start_character":1,"end_line":89,"end_character":95},"updated":"2017-09-28 20:57:39.000000000","message":"fwiw this is probably what we\u0027d consider a good candidate for a \"pre\" playbook.","commit_id":"06df542753235a4b9ce39bf3a00a78ad06892f92"}],"playbooks/upload-logs.yaml":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"cf66e0c0f8c7dfaff2cb1877d7f6f91867bf5809","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Upload log files"},{"line_number":4,"context_line":"      synchronize:"},{"line_number":5,"context_line":"        src: \u0027{{ ansible_user_dir }}/workspace/\u0027"},{"line_number":6,"context_line":"        dest: \u0027{{ zuul.executor.log_root }}\u0027"},{"line_number":7,"context_line":"        mode: pull"},{"line_number":8,"context_line":"        copy_links: true"},{"line_number":9,"context_line":"        verify_host: true"},{"line_number":10,"context_line":"        rsync_opts:"},{"line_number":11,"context_line":"          - --include\u003d/logs/**"},{"line_number":12,"context_line":"          - --include\u003d*/"},{"line_number":13,"context_line":"          - --exclude\u003d*"},{"line_number":14,"context_line":"          - --prune-empty-dirs"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f515b1d_f96066d1","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":30},"updated":"2017-09-28 21:00:12.000000000","message":"This isn\u0027t going to work because you do not have access to run tasks which involves the zuul executor.\n\nThe base job already takes care of uploading logs, you just need to put them in the right place: \n- https://github.com/openstack-infra/project-config/blob/98ee420cb81007b0ba10227239e8558250c244f3/zuul.d/jobs.yaml#L22\n- https://github.com/openstack-infra/project-config/blob/master/playbooks/base/post-logs.yaml","commit_id":"06df542753235a4b9ce39bf3a00a78ad06892f92"}]}