)]}'
{"id":"openstack%2Fpuppet-openstack-integration~514865","triplet_id":"openstack%2Fpuppet-openstack-integration~master~I277619847ed3a4c99845471a541820e559efab5d","project":"openstack/puppet-openstack-integration","branch":"master","hashtags":[],"change_id":"I277619847ed3a4c99845471a541820e559efab5d","subject":"Fix up prepare-node-common playbook","status":"MERGED","created":"2017-10-24 23:53:41.000000000","updated":"2017-10-25 02:13:18.000000000","submitted":"2017-10-25 02:13:18.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"514865-1508897598914-b2449cc6","meta_rev_id":"d72c339282f578824c0bda6f33ef6ff3bc641f0f","_number":514865,"virtual_id_number":514865,"owner":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2017-10-25 02:13:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2017-10-25 01:05:40.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2017-10-25 01:05:40.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-25 01:05:40.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2017-10-25 02:13:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a52ff670e44408b4e37da1b152b4303dae53a198","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2017-10-24 23:53:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"be66bd8626759bacd6cdcfc8af20fa977a35ef10","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2017-10-25 00:01:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"40c115977988cf3c26771d54092ad2d36c9a7882","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-10-25 01:05:40.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"147b64da38043b6b095e26f3f86bc7f771415cbe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-25 01:08:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- puppet-openstack-lint http://logs.openstack.org/65/514865/2/check/puppet-openstack-lint/0e0b6ff/ : SUCCESS in 4m 42s\n- puppet-openstack-syntax-4 http://logs.openstack.org/65/514865/2/check/puppet-openstack-syntax-4/690d6c5/ : SUCCESS in 3m 37s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario001-tempest-centos-7/bd6f5d0/ : SUCCESS in 1h 05m 52s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario002-tempest-centos-7/d91a71c/ : SUCCESS in 57m 21s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/cb19791/ : SUCCESS in 59m 44s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario004-tempest-centos-7/c631fd0/ : SUCCESS in 42m 05s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/dc48911/ : SUCCESS in 46m 06s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/ee36ae6/ : SUCCESS in 43m 10s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/9e4a7dd/ : SUCCESS in 35m 10s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/check/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/d0dfec2/ : SUCCESS in 40m 10s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"aeb8659d7dc6c383a2945d6178a70328d45d030e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-25 01:09:04.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"7619123d953b1d6a6d9a1d2bfcb0533bee2b660a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-25 02:13:18.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/65/514865/2/gate/puppet-openstack-lint/82367ec/ : SUCCESS in 3m 12s\n- puppet-openstack-syntax-4 http://logs.openstack.org/65/514865/2/gate/puppet-openstack-syntax-4/80882ec/ : SUCCESS in 3m 12s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario001-tempest-centos-7/7b8d17a/ : SUCCESS in 59m 34s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario002-tempest-centos-7/cf92344/ : SUCCESS in 59m 13s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario003-tempest-centos-7/6584b30/ : SUCCESS in 50m 24s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario004-tempest-centos-7/b74102c/ : SUCCESS in 46m 54s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/3ca178c/ : SUCCESS in 42m 19s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/35c6ece/ : SUCCESS in 41m 50s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/a3bd376/ : SUCCESS in 37m 46s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/65/514865/2/gate/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/b6177ec/ : SUCCESS in 37m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d72c339282f578824c0bda6f33ef6ff3bc641f0f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-10-25 02:13:18.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bf878a5c6e9525be3665233662fb244d4043e178","revisions":{"d804ab183f805006b0e257277fa401c0a7930757":{"kind":"REWORK","_number":1,"created":"2017-10-24 23:53:41.000000000","uploader":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"ref":"refs/changes/65/514865/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/65/514865/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/1"}}},"commit":{"parents":[{"commit":"f6cdcd2b7d4a97230cc77e520ae256b36aabcef8","subject":"cinder: update key_manager when barbican isn\u0027t deployed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/f6cdcd2b7d4a97230cc77e520ae256b36aabcef8"}]}],"author":{"name":"Paul Belanger","email":"pabelanger@redhat.com","date":"2017-10-24 23:52:46.000000000","tz":-240},"committer":{"name":"Paul Belanger","email":"pabelanger@redhat.com","date":"2017-10-24 23:52:46.000000000","tz":-240},"subject":"Fix up prepare-node-common playbook","message":"Fix up prepare-node-common playbook\n\nUse the bool filter to default to false, if use_puppetlabs is missing.\nAlso attempt to fix up vars setting in .zuul.yaml\n\nChange-Id: I277619847ed3a4c99845471a541820e559efab5d\nSigned-off-by: Paul Belanger \u003cpabelanger@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/d804ab183f805006b0e257277fa401c0a7930757"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/d804ab183f805006b0e257277fa401c0a7930757"}]},"branch":"refs/heads/master"},"bf878a5c6e9525be3665233662fb244d4043e178":{"kind":"REWORK","_number":2,"created":"2017-10-25 00:01:24.000000000","uploader":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"ref":"refs/changes/65/514865/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/65/514865/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/514865/2"}}},"commit":{"parents":[{"commit":"f6cdcd2b7d4a97230cc77e520ae256b36aabcef8","subject":"cinder: update key_manager when barbican isn\u0027t deployed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/f6cdcd2b7d4a97230cc77e520ae256b36aabcef8"}]}],"author":{"name":"Paul Belanger","email":"pabelanger@redhat.com","date":"2017-10-24 23:52:46.000000000","tz":-240},"committer":{"name":"Paul Belanger","email":"pabelanger@redhat.com","date":"2017-10-25 00:01:17.000000000","tz":-240},"subject":"Fix up prepare-node-common playbook","message":"Fix up prepare-node-common playbook\n\nUse the bool filter to default to false, if use_puppetlabs is missing.\nAlso attempt to fix up vars setting in .zuul.yaml\n\nChange-Id: I277619847ed3a4c99845471a541820e559efab5d\nSigned-off-by: Paul Belanger \u003cpabelanger@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/bf878a5c6e9525be3665233662fb244d4043e178"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/bf878a5c6e9525be3665233662fb244d4043e178"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}