)]}'
{"id":"openstack%2Fpuppet-openstack-integration~546901","triplet_id":"openstack%2Fpuppet-openstack-integration~master~Ie27ea416aabdb882eb8b5b5bf06280e98c51c7e0","project":"openstack/puppet-openstack-integration","branch":"master","hashtags":[],"change_id":"Ie27ea416aabdb882eb8b5b5bf06280e98c51c7e0","subject":"Do not use \"y\" for package install","status":"ABANDONED","created":"2018-02-22 07:50:31.000000000","updated":"2018-02-22 11:03:30.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"313238c449a1383cc2222670172a8e982ced9cd6","_number":546901,"virtual_id_number":546901,"owner":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2018-02-22 10:02:19.000000000","_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"recommended":{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},"all":[{"value":-2,"date":"2018-02-22 10:14:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2018-02-22 10:05:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-22 09:03:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-02-22 10:05:52.000000000","updated_by":{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},"reviewer":{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},"state":"REVIEWER"},{"updated":"2018-02-22 10:14:16.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"}],"messages":[{"id":"ac2f63ec7ee43bcd09f7f51f2110796868a904c1","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-22 07:50:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"660097f41b18fc6e0ef9664ead186430bda9706f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-22 09:03:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/01/546901/1/check/puppet-openstack-lint/d578b8b/ : SUCCESS in 3m 16s\n- puppet-openstack-syntax-4 http://logs.openstack.org/01/546901/1/check/puppet-openstack-syntax-4/fb804c5/ : SUCCESS in 2m 54s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario001-tempest-centos-7/68ee419/ : SUCCESS in 1h 01m 01s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario002-tempest-centos-7/c4cbf12/ : SUCCESS in 54m 30s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/48e0d24/ : SUCCESS in 1h 06m 32s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario004-tempest-centos-7/2abce21/ : SUCCESS in 45m 57s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/8f66010/ : FAILURE in 13m 28s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/823c737/ : SUCCESS in 39m 47s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/c85a6e6/ : SUCCESS in 31m 56s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/01/546901/1/check/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/ba1e7c2/ : SUCCESS in 29m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3b11c95cff30f4726762caedbc8fc16e4764cf29","author":{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},"date":"2018-02-22 09:26:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8f438bb71f5d9201da5dfe3c61427e335e2f3825","author":{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},"date":"2018-02-22 09:29:30.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nPlease also fix others.","accounts_in_message":[],"_revision_number":1},{"id":"80ff69671c2e9f8a54e35151ab018d7dddd69cb0","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-22 10:01:51.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"c2d639b14bd2a7171e3d34733414672d819487a5","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-22 10:02:19.000000000","message":"Patch Set 2:\n\nHoang Trung Hieu: Thank for your comment, it is done.","accounts_in_message":[],"_revision_number":2},{"id":"0cd3bdc52fa344fa6c59698d09fb0f6d0665a642","author":{"_account_id":26310,"name":"Hoang Trung Hieu","email":"hieuht@vn.fujitsu.com","username":"alanhoang"},"date":"2018-02-22 10:05:52.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"df7d547c6098b138316e4c23d94163d4e5717a80","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-02-22 10:14:16.000000000","message":"Patch Set 2: Code-Review-2\n\nWe\u0027re not interested by this patch. We\u0027re doing -y because the script automates a deployment without user interaction.","accounts_in_message":[],"_revision_number":2},{"id":"313238c449a1383cc2222670172a8e982ced9cd6","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-22 11:03:30.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0fb0bb8c4a52875ef1d697c26dd3b679453e7692","revisions":{"b00b913560f0291394056e54f9c2802b0061b36b":{"kind":"REWORK","_number":1,"created":"2018-02-22 07:50:31.000000000","uploader":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"ref":"refs/changes/01/546901/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/01/546901/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/1"}}},"commit":{"parents":[{"commit":"e2eb1ff97daf302d143f20144a77ee3a50f90a0b","subject":"Fix occasional Tempest failures with invalid tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/e2eb1ff97daf302d143f20144a77ee3a50f90a0b"}]}],"author":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-22 07:46:56.000000000","tz":420},"committer":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-22 07:48:45.000000000","tz":420},"subject":"Do not use \"y\" for package install","message":"Do not use \"y\" for package install\n\nAccording to \"code conventions\" [1], do not use \"-y\" option.\nInstead, use apt-get install package, yum install package,\nor zypper install package.\n\n[1] https://docs.openstack.org/doc-contrib-guide/writing-style/code-conventions.html\n\nChange-Id: Ie27ea416aabdb882eb8b5b5bf06280e98c51c7e0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/b00b913560f0291394056e54f9c2802b0061b36b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/b00b913560f0291394056e54f9c2802b0061b36b"}]},"branch":"refs/heads/master"},"0fb0bb8c4a52875ef1d697c26dd3b679453e7692":{"kind":"REWORK","_number":2,"created":"2018-02-22 10:01:51.000000000","uploader":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"ref":"refs/changes/01/546901/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/01/546901/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/01/546901/2"}}},"commit":{"parents":[{"commit":"e2eb1ff97daf302d143f20144a77ee3a50f90a0b","subject":"Fix occasional Tempest failures with invalid tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/e2eb1ff97daf302d143f20144a77ee3a50f90a0b"}]}],"author":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-22 07:46:56.000000000","tz":420},"committer":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-22 10:01:42.000000000","tz":0},"subject":"Do not use \"y\" for package install","message":"Do not use \"y\" for package install\n\nAccording to \"code conventions\" [1], do not use \"-y\" option.\nInstead, use apt-get install package, yum install package,\nor zypper install package.\n\n[1] https://docs.openstack.org/doc-contrib-guide/writing-style/code-conventions.html\n\nChange-Id: Ie27ea416aabdb882eb8b5b5bf06280e98c51c7e0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/0fb0bb8c4a52875ef1d697c26dd3b679453e7692"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/0fb0bb8c4a52875ef1d697c26dd3b679453e7692"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}