)]}'
{"id":"openstack%2Fpuppet-openstack-integration~571557","triplet_id":"openstack%2Fpuppet-openstack-integration~master~I1b37524ff1071d87e8a7df2fa3bca66aed162d1b","project":"openstack/puppet-openstack-integration","branch":"master","topic":"fix-systemctl-enable","hashtags":[],"change_id":"I1b37524ff1071d87e8a7df2fa3bca66aed162d1b","subject":"Debian: fix redis service setup","status":"MERGED","created":"2018-05-31 19:24:35.000000000","updated":"2018-06-01 15:34:28.000000000","submitted":"2018-06-01 15:34:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"571557-1527867268376-357742b2","meta_rev_id":"268b3502e9e8bde8e881bb62bfd9b41ab9f39103","_number":571557,"virtual_id_number":571557,"owner":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":2,"date":"2018-06-01 15:34:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2018-06-01 01:25:22.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2018-06-01 14:06:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2018-06-01 12:01:35.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"date":"2018-06-01 01:05:34.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":1,"date":"2018-06-01 14:06:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"date":"2018-06-01 01:05:20.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-01 01:05:20.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2018-06-01 01:05:34.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2018-06-01 01:25:22.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2018-06-01 12:01:35.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2018-06-01 14:06:44.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2018-06-01 15:34:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b2493c2a689f2b9bf6b1818055c9a85282002788","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2018-05-31 19:24:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"76229f049d03f4e3a6947946f9f98e89db3f7966","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2018-05-31 20:44:26.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c83d93070b3ef1f420c52c506e0bd26d9b4fa73f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-31 22:21:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/57/571557/2/check/puppet-openstack-lint/163ece4/ : SUCCESS in 3m 35s\n- puppet-openstack-syntax-4 http://logs.openstack.org/57/571557/2/check/puppet-openstack-syntax-4/0077922/ : SUCCESS in 3m 14s\n- puppet-openstack-syntax-5 http://logs.openstack.org/57/571557/2/check/puppet-openstack-syntax-5/54b45d0/ : SUCCESS in 3m 49s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario001-tempest-centos-7/cfb7c61/ : SUCCESS in 1h 04m 01s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario002-tempest-centos-7/346e923/ : SUCCESS in 1h 01m 42s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/2690510/ : SUCCESS in 1h 14m 53s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario004-tempest-centos-7/5ad9dac/ : SUCCESS in 54m 18s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/450e28a/ : SUCCESS in 39m 03s\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/48405f4/ : SUCCESS in 42m 05s\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/7b18657/ : SUCCESS in 40m 57s\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/7670b4e/ : SUCCESS in 33m 03s (non-voting)\n- puppet-openstack-integration-4-scenario001-tempest-debian-stable http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario001-tempest-debian-stable/da77069/ : FAILURE in 34m 25s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-debian-stable http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario002-tempest-debian-stable/660f498/ : FAILURE in 34m 26s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-debian-stable http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario003-tempest-debian-stable/692f31e/ : FAILURE in 26m 56s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-debian-stable http://logs.openstack.org/57/571557/2/check/puppet-openstack-integration-4-scenario004-tempest-debian-stable/e138e25/ : TIMED_OUT in 1h 31m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6029ef8586c672cd1ac7b3382aeb458cb3c74c00","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-06-01 01:25:22.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2c65c1d446a77daa2e35559a7490bba7a1782b9d","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2018-06-01 14:06:44.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"6b4074f9a8ad6bbe732c6e65568bf7c65c9dab56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-01 14:06:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"76113aa8c284d5b5c0e47120b781065fd9ba14ca","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-01 15:34:28.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/57/571557/2/gate/puppet-openstack-lint/f7269ac/ : SUCCESS in 3m 26s\n- puppet-openstack-syntax-4 http://logs.openstack.org/57/571557/2/gate/puppet-openstack-syntax-4/cd3b080/ : SUCCESS in 3m 38s\n- puppet-openstack-syntax-5 http://logs.openstack.org/57/571557/2/gate/puppet-openstack-syntax-5/3305060/ : SUCCESS in 4m 02s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario001-tempest-centos-7/838b73a/ : SUCCESS in 1h 04m 35s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario002-tempest-centos-7/bb34eb5/ : SUCCESS in 1h 08m 40s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario003-tempest-centos-7/e423e59/ : SUCCESS in 1h 22m 21s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7 http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario004-tempest-centos-7/33faedf/ : SUCCESS in 51m 38s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/20d7d30/ : SUCCESS in 43m 16s\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/3b75290/ : SUCCESS in 39m 20s\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/e165184/ : SUCCESS in 44m 57s\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial http://logs.openstack.org/57/571557/2/gate/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial/e1ac406/ : SUCCESS in 31m 49s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ea19a60b55984be49d14e2cd7900ec1b16a1ffbc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-01 15:34:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"74022b48ddb6312bcc3b82a92b9bc45fdcbf04f1","revisions":{"a9c5b97e78dc7332eb0d5c5c4baa7648751d55b6":{"kind":"REWORK","_number":1,"created":"2018-05-31 19:24:35.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/57/571557/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/57/571557/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/1"}}},"commit":{"parents":[{"commit":"c10f0115206b21371dee36cb0a8bb218b3f2cf92","subject":"Revert \"Debian: Setup Cinder using cinder-api uwsgi\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/c10f0115206b21371dee36cb0a8bb218b3f2cf92"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-05-31 19:24:10.000000000","tz":120},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-05-31 19:24:10.000000000","tz":120},"subject":"WIP: redis service debian test","message":"WIP: redis service debian test\n\nChange-Id: I1b37524ff1071d87e8a7df2fa3bca66aed162d1b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/a9c5b97e78dc7332eb0d5c5c4baa7648751d55b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/a9c5b97e78dc7332eb0d5c5c4baa7648751d55b6"}]},"branch":"refs/heads/master"},"74022b48ddb6312bcc3b82a92b9bc45fdcbf04f1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-05-31 20:44:26.000000000","uploader":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"ref":"refs/changes/57/571557/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/57/571557/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/57/571557/2"}}},"commit":{"parents":[{"commit":"c10f0115206b21371dee36cb0a8bb218b3f2cf92","subject":"Revert \"Debian: Setup Cinder using cinder-api uwsgi\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/c10f0115206b21371dee36cb0a8bb218b3f2cf92"}]}],"author":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-05-31 19:24:10.000000000","tz":120},"committer":{"name":"Thomas Goirand","email":"zigo@debian.org","date":"2018-05-31 20:41:23.000000000","tz":120},"subject":"Debian: fix redis service setup","message":"Debian: fix redis service setup\n\nThe redis-server appears as \"masked\" in the OpenStack CI, even though it\ndid not in my test VM. As a consequence, \"systemctl enable redis-server\"\nfails, and consequently, the puppet run fails in OpenStack CI. The thing\nis, there\u0027s no need to enable this service, as in all distros, it\u0027s\nalready enabled by default. Even in the OpenStack CI, the service appears\nas enabled, but masked (which by the way, should never happen, as this\nisn\u0027t a working systemd state).\n\nThis patch simply removes the enabling of the systemd service, so that\nit also works in Debian in the CI.\n\nChange-Id: I1b37524ff1071d87e8a7df2fa3bca66aed162d1b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/74022b48ddb6312bcc3b82a92b9bc45fdcbf04f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/74022b48ddb6312bcc3b82a92b9bc45fdcbf04f1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
