)]}'
{"id":"openstack%2Fpuppet-openstack-integration~579995","triplet_id":"openstack%2Fpuppet-openstack-integration~stable%2Fqueens~I3767645807279afac77c1c367a70af6f0f9f4084","project":"openstack/puppet-openstack-integration","branch":"stable/queens","hashtags":[],"change_id":"I3767645807279afac77c1c367a70af6f0f9f4084","subject":"Change ceph caps to profile rbd","status":"MERGED","created":"2018-07-03 21:49:41.000000000","updated":"2018-07-09 14:01:53.000000000","submitted":"2018-07-09 14:01:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"579995-1531144913282-31707b30","meta_rev_id":"7b8123dd37c46e5f6dd75b7ad0cc88c3fb2bf18a","_number":579995,"virtual_id_number":579995,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":2,"date":"2018-07-09 14:01:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2018-07-09 12:46:11.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2018-07-09 08:43:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2018-07-09 12:46:11.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-09 08:43:02.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2018-07-09 12:46:11.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2018-07-09 14:01:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"28a2c017a86eb13de5c7423ea309702b71bd0516","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2018-07-03 21:49:41.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"2dee7791991540cb9f82f82aa271ba86dd4904cb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-04 01:39:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/95/579995/1/check/puppet-openstack-lint/484632e/ : SUCCESS in 4m 31s\n- puppet-openstack-syntax-4 http://logs.openstack.org/95/579995/1/check/puppet-openstack-syntax-4/22f20c5/ : SUCCESS in 5m 05s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous/7884df1/ : SUCCESS in 1h 01m 38s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario002-tempest-centos-7/ef67833/ : SUCCESS in 1h 00m 39s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/4298f48/ : SUCCESS in 1h 04m 34s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-mimic http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario004-tempest-centos-7-mimic/d4c0710/ : SUCCESS in 49m 26s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous/1e60268/ : SUCCESS in 41m 13s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/10c71e9/ : SUCCESS in 40m 37s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/7b184d8/ : SUCCESS in 34m 00s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-mimic http://logs.openstack.org/95/579995/1/check/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-mimic/e707cbf/ : SUCCESS in 34m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b87c06030cebe86c8d0dbd8c01f83b00db7547de","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2018-07-09 08:43:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"46321067b870a99894d158871d3189f85e322e23","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2018-07-09 12:46:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a22f9dd3868fc857104c7c94908efc6925f8de1c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-09 12:46:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"2b1d4584bf169a748db8227f07a2b58a954221c6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-09 14:01:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"7b8123dd37c46e5f6dd75b7ad0cc88c3fb2bf18a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-09 14:01:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint http://logs.openstack.org/95/579995/1/gate/puppet-openstack-lint/1a75700/ : SUCCESS in 5m 09s\n- puppet-openstack-syntax-4 http://logs.openstack.org/95/579995/1/gate/puppet-openstack-syntax-4/14629fb/ : SUCCESS in 4m 04s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous/94e7860/ : SUCCESS in 1h 03m 16s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario002-tempest-centos-7/6169e74/ : SUCCESS in 1h 03m 19s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario003-tempest-centos-7/d1e8203/ : SUCCESS in 1h 09m 50s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-mimic http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario004-tempest-centos-7-mimic/8162989/ : SUCCESS in 49m 01s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous/2e6e449/ : SUCCESS in 40m 39s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/deaf98a/ : SUCCESS in 37m 45s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/fd6ba58/ : SUCCESS in 41m 18s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-mimic http://logs.openstack.org/95/579995/1/gate/puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-mimic/60b7b0f/ : SUCCESS in 34m 50s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1e3e83c0270daf3bd9b813263c5185dd3f5f17b6","revisions":{"1e3e83c0270daf3bd9b813263c5185dd3f5f17b6":{"kind":"REWORK","_number":1,"created":"2018-07-03 21:49:41.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/95/579995/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/95/579995/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/95/579995/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/95/579995/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/95/579995/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/95/579995/1"}}},"commit":{"parents":[{"commit":"d46e33d2049174e2efbdebc07a655a6b12a49153","subject":"Add support to select ceph version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/d46e33d2049174e2efbdebc07a655a6b12a49153"}]}],"author":{"name":"Tobias Urdin","email":"tobias@busybox.se","date":"2018-06-26 15:35:02.000000000","tz":120},"committer":{"name":"Tobias Urdin","email":"tobias@busybox.se","date":"2018-07-03 21:49:41.000000000","tz":0},"subject":"Change ceph caps to profile rbd","message":"Change ceph caps to profile rbd\n\nBased on the documentation [1] and this\nbug [2] we should set caps for ceph keys\nthat use RBD to use the profile.\n\nAs we can see in the bug [2] setting it to wrong\ncan have cause very bad issues, this should direct\nas a guideline since we will not hit this in CI.\n\n[1] http://docs.ceph.com/docs/luminous/rbd/rbd-openstack/#setup-ceph-client-authentication\n[2] https://bugs.launchpad.net/nova/+bug/1773449\n\nChange-Id: I3767645807279afac77c1c367a70af6f0f9f4084\n(cherry picked from commit 70cb017808e2f783bcb7fdeb782ef5553036e6eb)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/1e3e83c0270daf3bd9b813263c5185dd3f5f17b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/1e3e83c0270daf3bd9b813263c5185dd3f5f17b6"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}