)]}'
{"manifests/placement.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"67d59ca7c4a1c5e0ddd9b3242cb727200b472349","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":"  } else {"},{"line_number":30,"context_line":"    class { \u0027::placement::keystone::auth\u0027:"},{"line_number":31,"context_line":"      public_url   \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":32,"context_line":"      internal_url \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":33,"context_line":"      admin_url    \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":34,"context_line":"      password     \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"dfd5e7cf_3ed0e2f7","line":31,"updated":"2019-01-07 18:40:14.000000000","message":"aw, still on a port :(\n\n;)","commit_id":"5a4d1bdeba947ef702d2adf3f1500e4db67d2851"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"06ae2ae6f2fa7d1e28e84ca013440e30ae6bf540","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":"  } else {"},{"line_number":30,"context_line":"    class { \u0027::placement::keystone::auth\u0027:"},{"line_number":31,"context_line":"      public_url   \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":32,"context_line":"      internal_url \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":33,"context_line":"      admin_url    \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":34,"context_line":"      password     \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"dfd5e7cf_54ea27ac","line":31,"in_reply_to":"dfd5e7cf_3ed0e2f7","updated":"2019-01-10 13:24:55.000000000","message":"Happy move it off if that\u0027s an issue, I can\u0027t recall why it\u0027s there at the moment within puppet-nova.","commit_id":"5a4d1bdeba947ef702d2adf3f1500e4db67d2851"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2b637dbfc5075c2b5656b868a6cc9f61cea8e623","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    }"},{"line_number":29,"context_line":"  } else {"},{"line_number":30,"context_line":"    class { \u0027::placement::keystone::auth\u0027:"},{"line_number":31,"context_line":"      public_url   \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":32,"context_line":"      internal_url \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":33,"context_line":"      admin_url    \u003d\u003e \"${::openstack_integration::config::base_url}:8778/placement\","},{"line_number":34,"context_line":"      password     \u003d\u003e \u0027a_big_secret\u0027,"}],"source_content_type":"text/x-puppet","patch_set":31,"id":"dfd5e7cf_54d467bd","line":31,"in_reply_to":"dfd5e7cf_54ea27ac","updated":"2019-01-10 13:39:33.000000000","message":"It\u0027s not really an issue in any specific sense. It\u0027s just that for at least the last 4 years some people have been hoping that we\u0027d stop putting the services on ports because it\u0027s not really necessary and is icky from a variety of management standpoints.\n\nSo it\u0027s really up to what standards puppet has set. If services on ports is the norma, then may as well go with that.\n\nWhat is weird, however is service-on-port-with-a-prefix.\n\nNot on a port, with a prefix (or service-specific-hostname) makes sense.","commit_id":"5a4d1bdeba947ef702d2adf3f1500e4db67d2851"}]}