)]}'
{"functions":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"111d885f38aefd41d06803654314827c58a6280f","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            if [ $PUPPET_CODENAME \u003d\u003d \"bionic\" ]; then"},{"line_number":175,"context_line":"                # For some reason this directory does not exist in Bionic"},{"line_number":176,"context_line":"                $SUDO mkdir -p /etc/apt/sources.list.d"},{"line_number":177,"context_line":"            fi"},{"line_number":178,"context_line":"            if [ $PUPPET_CODENAME !\u003d \"buster\" ]; then"},{"line_number":179,"context_line":"                echo \"deb ${NODEPOOL_PUPPETLABS_MIRROR} ${PUPPET_CODENAME} ${PUPPET_APT_POOL}\" | $SUDO tee /etc/apt/sources.list.d/puppetlabs.list"},{"line_number":180,"context_line":"                $SUDO apt-key add files/GPG-KEY-puppetlabs"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_8e78c9f8","line":177,"updated":"2019-06-03 14:23:48.000000000","message":"Why not use PuppetLabs packaged Puppet? With this we cannot test different versions","commit_id":"bb63c686595a10053f6c38d90b3aa0efa62a6f4c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"0fdd3201e7f4a1f02ef4ae214a36140ce5bfcd41","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            if [ $PUPPET_CODENAME \u003d\u003d \"bionic\" ]; then"},{"line_number":175,"context_line":"                # For some reason this directory does not exist in Bionic"},{"line_number":176,"context_line":"                $SUDO mkdir -p /etc/apt/sources.list.d"},{"line_number":177,"context_line":"            fi"},{"line_number":178,"context_line":"            if [ $PUPPET_CODENAME !\u003d \"buster\" ]; then"},{"line_number":179,"context_line":"                echo \"deb ${NODEPOOL_PUPPETLABS_MIRROR} ${PUPPET_CODENAME} ${PUPPET_APT_POOL}\" | $SUDO tee /etc/apt/sources.list.d/puppetlabs.list"},{"line_number":180,"context_line":"                $SUDO apt-key add files/GPG-KEY-puppetlabs"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_c4d92157","line":177,"in_reply_to":"9fb8cfa7_8e78c9f8","updated":"2019-06-12 09:28:16.000000000","message":"Because puppetlabs doesn\u0027t provide puppet for Buster.","commit_id":"bb63c686595a10053f6c38d90b3aa0efa62a6f4c"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"111d885f38aefd41d06803654314827c58a6280f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            $SUDO apt-key add files/GPG-KEY-ceph"},{"line_number":183,"context_line":"            $SUDO apt-get update"},{"line_number":184,"context_line":"        fi"},{"line_number":185,"context_line":"        if [ $PUPPET_CODENAME !\u003d \"buster\" ]; then"},{"line_number":186,"context_line":"\t    $SUDO apt-get install -y ${PUPPET_PKG}"},{"line_number":187,"context_line":"\telse"},{"line_number":188,"context_line":"\t    $SUDO apt-get install -y puppet"},{"line_number":189,"context_line":"\tfi"},{"line_number":190,"context_line":"    elif is_fedora; then"},{"line_number":191,"context_line":"        print_header \u0027Setup (RedHat based)\u0027"},{"line_number":192,"context_line":"        # EPEL does not work fine with RDO, we need to make sure EPEL is really disabled"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_ce4ec1c0","line":189,"range":{"start_line":185,"start_character":8,"end_line":189,"end_character":3},"updated":"2019-06-03 14:23:48.000000000","message":"This if statement seems redundant, you can just set PUPPET_PKG, which I think you already did in functions file","commit_id":"bb63c686595a10053f6c38d90b3aa0efa62a6f4c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"0fdd3201e7f4a1f02ef4ae214a36140ce5bfcd41","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            $SUDO apt-key add files/GPG-KEY-ceph"},{"line_number":183,"context_line":"            $SUDO apt-get update"},{"line_number":184,"context_line":"        fi"},{"line_number":185,"context_line":"        if [ $PUPPET_CODENAME !\u003d \"buster\" ]; then"},{"line_number":186,"context_line":"\t    $SUDO apt-get install -y ${PUPPET_PKG}"},{"line_number":187,"context_line":"\telse"},{"line_number":188,"context_line":"\t    $SUDO apt-get install -y puppet"},{"line_number":189,"context_line":"\tfi"},{"line_number":190,"context_line":"    elif is_fedora; then"},{"line_number":191,"context_line":"        print_header \u0027Setup (RedHat based)\u0027"},{"line_number":192,"context_line":"        # EPEL does not work fine with RDO, we need to make sure EPEL is really disabled"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9fb8cfa7_24d11d24","line":189,"range":{"start_line":185,"start_character":8,"end_line":189,"end_character":3},"in_reply_to":"9fb8cfa7_ce4ec1c0","updated":"2019-06-12 09:28:16.000000000","message":"I don\u0027t know why, but it looks like PUPPET_PKG doesn\u0027t work (it\u0027s not set).","commit_id":"bb63c686595a10053f6c38d90b3aa0efa62a6f4c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9442f0793f6f50237e3e63d947a6c9db2cb06ff7","unresolved":false,"context_lines":[{"line_number":186,"context_line":"\t    $SUDO apt-get install -y ${PUPPET_PKG}"},{"line_number":187,"context_line":"\telse"},{"line_number":188,"context_line":"\t    $SUDO apt-get install -y puppet"},{"line_number":189,"context_line":"\tfi"},{"line_number":190,"context_line":"    elif is_fedora; then"},{"line_number":191,"context_line":"        print_header \u0027Setup (RedHat based)\u0027"},{"line_number":192,"context_line":"        # EPEL does not work fine with RDO, we need to make sure EPEL is really disabled"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_91863bb9","line":189,"updated":"2019-10-09 19:34:25.000000000","message":"some sneaky tabs in here","commit_id":"f31f670b3fb1ac5ff17788b326a51dce60b1473c"}],"manifests/repos.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"daf4ada263290833dd14611ed6e1089fdf24ecea","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"\u003c\u003c\u003c\u003c\u003c\u003c\u003c HEAD"},{"line_number":101,"context_line":"  class { \u0027ceph::repo\u0027:"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":103,"context_line":"  if $facts[\u0027os\u0027][\u0027lsb\u0027] !\u003d undef{"},{"line_number":104,"context_line":"    $mycodename \u003d $facts[\u0027os\u0027][\u0027lsb\u0027][\u0027distcodename\u0027]"},{"line_number":105,"context_line":"  }else{"},{"line_number":106,"context_line":"    $mycodename \u003d $facts[\u0027os\u0027][\u0027distro\u0027][\u0027codename\u0027]"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":"  if $mycodename \u003d\u003d \u0027buster\u0027{"},{"line_number":109,"context_line":"    $ceph_repo_ensure \u003d absent"},{"line_number":110,"context_line":"  }else{"},{"line_number":111,"context_line":"    $ceph_repo_ensure \u003d present"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"  class { \u0027::ceph::repo\u0027:"},{"line_number":115,"context_line":"    ensure      \u003d\u003e $ceph_repo_ensure,"},{"line_number":116,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Use puppet from Buster"},{"line_number":117,"context_line":"    enable_sig  \u003d\u003e $enable_sig,"},{"line_number":118,"context_line":"    enable_epel \u003d\u003e $enable_epel,"},{"line_number":119,"context_line":"    ceph_mirror \u003d\u003e $ceph_mirror,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3fa7e38b_d3194c24","line":116,"range":{"start_line":100,"start_character":1,"end_line":116,"end_character":30},"updated":"2020-02-21 13:50:57.000000000","message":"faulty rebase here","commit_id":"c1c5f6bd42ef0f4b4f829b636fe0c35f7b3600e3"}],"run_tests.sh":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"111d885f38aefd41d06803654314827c58a6280f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    export PUPPET_PKG\u003dpuppet"},{"line_number":58,"context_line":"else"},{"line_number":59,"context_line":"    export PATH\u003d${PATH}:/opt/puppetlabs/bin:/opt/puppetlabs/puppet/bin"},{"line_number":60,"context_line":"    export PUPPET_BASE_PATH\u003d/etc/puppet/code/environments/production"},{"line_number":61,"context_line":"    export PUPPET_PKG\u003d${PUPPET_PKG:-puppet-agent}"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_ce7561fc","line":60,"range":{"start_line":60,"start_character":28,"end_line":60,"end_character":68},"updated":"2019-06-03 14:23:48.000000000","message":"This change looks wrong","commit_id":"bb63c686595a10053f6c38d90b3aa0efa62a6f4c"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"0fdd3201e7f4a1f02ef4ae214a36140ce5bfcd41","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    export PUPPET_PKG\u003dpuppet"},{"line_number":58,"context_line":"else"},{"line_number":59,"context_line":"    export PATH\u003d${PATH}:/opt/puppetlabs/bin:/opt/puppetlabs/puppet/bin"},{"line_number":60,"context_line":"    export PUPPET_BASE_PATH\u003d/etc/puppet/code/environments/production"},{"line_number":61,"context_line":"    export PUPPET_PKG\u003d${PUPPET_PKG:-puppet-agent}"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_4493f15b","line":60,"range":{"start_line":60,"start_character":28,"end_line":60,"end_character":68},"in_reply_to":"9fb8cfa7_ce7561fc","updated":"2019-06-12 09:28:16.000000000","message":"I believe this should have been above, in the \u003d \"buster\" part. I\u0027m fixing.","commit_id":"bb63c686595a10053f6c38d90b3aa0efa62a6f4c"}]}