)]}'
{"configure_facts.sh":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6163070b60893ce7e80e752553d3656bb20f809c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":45,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027https://trunk.rdoproject.org/centos7/deps/storage/storage7-ceph-mimic/x86_64/\u0027"},{"line_number":46,"context_line":"        elif [ \"$CEPH_VERSION\" \u003d\u003d \"nautilus\" ]; then"},{"line_number":47,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027http://cbs.centos.org/repos/storage7-ceph-nautilus-candidate/x86_64/os/\u0027"},{"line_number":48,"context_line":"        else"},{"line_number":49,"context_line":"            CEPH_MIRROR_HOST\u003d\"${NODEPOOL_BUILDLOGS_CENTOS_PROXY}/centos/7/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":50,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df33271e_33464051","line":47,"updated":"2020-03-25 16:05:17.000000000","message":"same here, we can remove this now if it\u0027s available in buildslogs?","commit_id":"6a8ae33ce55600cebb7046ec826fb9ac94c37fd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6163070b60893ce7e80e752553d3656bb20f809c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":64,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027https://trunk.rdoproject.org/centos7/deps/storage/storage7-ceph-mimic/x86_64/\u0027"},{"line_number":65,"context_line":"        elif [ \"$CEPH_VERSION\" \u003d\u003d \"nautilus\" ]; then"},{"line_number":66,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027${CENTOS_MIRROR_HOST}/centos/7/storage/x86_64/ceph-nautilus/\u0027"},{"line_number":67,"context_line":"        else"},{"line_number":68,"context_line":"            CEPH_MIRROR_HOST\u003d\"https://buildlogs.centos.org/centos/7/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":69,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"df33271e_93762ca4","line":66,"updated":"2020-03-25 16:05:17.000000000","message":"same","commit_id":"6a8ae33ce55600cebb7046ec826fb9ac94c37fd4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"57618d4cbb5296ec7a4456b6cdf89cf48f8ba9af","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":62,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027https://trunk.rdoproject.org/centos7/deps/storage/storage7-ceph-mimic/x86_64/\u0027"},{"line_number":63,"context_line":"        else"},{"line_number":64,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027${CENTOS_MIRROR_HOST}/centos/7/storage/x86_64/ceph-${CEPH_VERSION}/\u0027"},{"line_number":65,"context_line":"        fi"},{"line_number":66,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\"https://yum.puppetlabs.com\""},{"line_number":67,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"df33271e_3bf0c967","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":50},"updated":"2020-03-26 10:20:13.000000000","message":"We are using buildlogs in line 47 and mirror here. Usually content is the same, but at some specific cases may be different as buildlogs follow -testing tag while mirror.c.o follow -release.\n\nI\u0027d go with mirror in the general case as -testing may be less stable although historically ceph minor updates have not been too problematic.","commit_id":"3ded6008732985ace44e739b248367acc1abc8ca"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"ae47b9afbce284eb2b9bc72770959d9e1df5932f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":62,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027https://trunk.rdoproject.org/centos7/deps/storage/storage7-ceph-mimic/x86_64/\u0027"},{"line_number":63,"context_line":"        else"},{"line_number":64,"context_line":"            CEPH_MIRROR_HOST\u003d\u0027${CENTOS_MIRROR_HOST}/centos/7/storage/x86_64/ceph-${CEPH_VERSION}/\u0027"},{"line_number":65,"context_line":"        fi"},{"line_number":66,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\"https://yum.puppetlabs.com\""},{"line_number":67,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"df33271e_d5f40089","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":50},"in_reply_to":"df33271e_3bf0c967","updated":"2020-03-26 19:52:18.000000000","message":"I agree, so CENTOS_MIRROR_HOST is correct and we should change line 47?","commit_id":"3ded6008732985ace44e739b248367acc1abc8ca"}],"manifests/repos.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6163070b60893ce7e80e752553d3656bb20f809c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          },"},{"line_number":66,"context_line":"        },"},{"line_number":67,"context_line":"      }"},{"line_number":68,"context_line":"      # TODO(tobasco): Remove this CBS candidate repo for Mimic and Nautilus when Storage SIG release it."},{"line_number":69,"context_line":"      $ceph_mirror_fallback \u003d $ceph_version_real ? {"},{"line_number":70,"context_line":"        \u0027mimic\u0027    \u003d\u003e \u0027https://trunk.rdoproject.org/centos7/deps/storage/storage7-ceph-mimic/x86_64/\u0027,"},{"line_number":71,"context_line":"        \u0027nautilus\u0027 \u003d\u003e \u0027http://mirror.centos.org/centos/7/storage/x86_64/ceph-nautilus/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df33271e_534b0458","line":68,"range":{"start_line":68,"start_character":6,"end_line":68,"end_character":105},"updated":"2020-03-25 16:05:17.000000000","message":"can you change my old comment or remove it completely if we aren\u0027t waiting for anything to change this again.","commit_id":"6a8ae33ce55600cebb7046ec826fb9ac94c37fd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6163070b60893ce7e80e752553d3656bb20f809c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      # TODO(tobasco): Remove this CBS candidate repo for Mimic and Nautilus when Storage SIG release it."},{"line_number":69,"context_line":"      $ceph_mirror_fallback \u003d $ceph_version_real ? {"},{"line_number":70,"context_line":"        \u0027mimic\u0027    \u003d\u003e \u0027https://trunk.rdoproject.org/centos7/deps/storage/storage7-ceph-mimic/x86_64/\u0027,"},{"line_number":71,"context_line":"        \u0027nautilus\u0027 \u003d\u003e \u0027http://mirror.centos.org/centos/7/storage/x86_64/ceph-nautilus/\u0027,"},{"line_number":72,"context_line":"        default    \u003d\u003e \"https://buildlogs.centos.org/centos/7/storage/x86_64/ceph-${ceph_version_real}/\""},{"line_number":73,"context_line":"      }"},{"line_number":74,"context_line":"      $ceph_mirror \u003d pick($::ceph_mirror_host, $ceph_mirror_fallback)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df33271e_13417c3a","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":88},"updated":"2020-03-25 16:05:17.000000000","message":"we can prob remove this through right? seems like same ones is available on the default buildlogs there unless the correct URL has changed","commit_id":"6a8ae33ce55600cebb7046ec826fb9ac94c37fd4"}]}
