)]}'
{"configure_facts.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e010610cc5de69ae518714360b6e3ce70465be99","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    else"},{"line_number":43,"context_line":"        # NOTE(tobias-urdin): Mimic was never released by Storage SIG to official mirros."},{"line_number":44,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":45,"context_line":"            CEPH_MIRROR_HOST\u003d\"https://trunk.rdoproject.org/centos${REDHAT_SUPPORT_PRODUCT_VERSION}/deps/storage/storage${REDHAT_SUPPORT_PRODUCT_VERSION}-ceph-mimic/x86_64/\""},{"line_number":46,"context_line":"        else"},{"line_number":47,"context_line":"            CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/${REDHAT_SUPPORT_PRODUCT_VERSION}/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":48,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_80eb2fda","line":45,"range":{"start_line":45,"start_character":67,"end_line":45,"end_character":97},"updated":"2020-05-15 22:56:58.000000000","message":"As far as I\u0027ve checked in my local rhel machine, this parameter shows version in x.y format (like 7.7) but we should use only major version here.","commit_id":"fe17c6632ca52b3d568608b57277a61a57ac8b5b"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"11bb4a4f7a0a1cf2a24f8621984c94c289df62f7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    else"},{"line_number":43,"context_line":"        # NOTE(tobias-urdin): Mimic was never released by Storage SIG to official mirros."},{"line_number":44,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":45,"context_line":"            CEPH_MIRROR_HOST\u003d\"https://trunk.rdoproject.org/centos${REDHAT_SUPPORT_PRODUCT_VERSION}/deps/storage/storage${REDHAT_SUPPORT_PRODUCT_VERSION}-ceph-mimic/x86_64/\""},{"line_number":46,"context_line":"        else"},{"line_number":47,"context_line":"            CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/${REDHAT_SUPPORT_PRODUCT_VERSION}/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":48,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_c1d8861f","line":45,"range":{"start_line":45,"start_character":67,"end_line":45,"end_character":97},"in_reply_to":"ff570b3c_80eb2fda","updated":"2020-05-16 10:35:41.000000000","message":"REDHAT_SUPPORT_PRODUCT_VERSION expands to the major version, now thinking about it we could even use the OS_NAME_VERS variable defined above instead of hardcoding the \"centos\" part even though it doesn\u0027t really matter.","commit_id":"fe17c6632ca52b3d568608b57277a61a57ac8b5b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e9465244c1f2239bfeeadc28f1c21885cde03d98","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    else"},{"line_number":43,"context_line":"        # NOTE(tobias-urdin): Mimic was never released by Storage SIG to official mirros."},{"line_number":44,"context_line":"        if [ \"$CEPH_VERSION\" \u003d\u003d \"mimic\" ]; then"},{"line_number":45,"context_line":"            CEPH_MIRROR_HOST\u003d\"https://trunk.rdoproject.org/centos${REDHAT_SUPPORT_PRODUCT_VERSION}/deps/storage/storage${REDHAT_SUPPORT_PRODUCT_VERSION}-ceph-mimic/x86_64/\""},{"line_number":46,"context_line":"        else"},{"line_number":47,"context_line":"            CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/${REDHAT_SUPPORT_PRODUCT_VERSION}/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":48,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_52f8c679","line":45,"range":{"start_line":45,"start_character":67,"end_line":45,"end_character":97},"in_reply_to":"ff570b3c_c1d8861f","updated":"2020-05-16 23:54:03.000000000","message":"Sorry about missing this in my first review, but seems like REDHAT_SUPPORT_PRODUCT_VERSION has only major version, which is different from RHEL.\n\nOur current support scope here is only for centos, so I\u0027m ok to go ahead with current situation.","commit_id":"fe17c6632ca52b3d568608b57277a61a57ac8b5b"}]}