)]}'
{"id":"openstack%2Fpuppet-openstack-integration~766803","triplet_id":"openstack%2Fpuppet-openstack-integration~stable%2Fvictoria~If14f4edad391fd9ee61851859ecdd3a51b97a215","project":"openstack/puppet-openstack-integration","branch":"stable/victoria","topic":"distro_detect-stable/victoria","hashtags":[],"change_id":"If14f4edad391fd9ee61851859ecdd3a51b97a215","subject":"Rely on ID/VERSION_ID to detect distro","status":"MERGED","created":"2020-12-14 06:17:09.000000000","updated":"2020-12-14 14:47:24.000000000","submitted":"2020-12-14 14:47:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"766803-distro_detect-stable/victoria","cherry_pick_of_change":766692,"cherry_pick_of_patch_set":1,"meta_rev_id":"7b28ad096254cce3864a0f56f8cdf23b1e8fa819","_number":766803,"virtual_id_number":766803,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-14 14:47:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"all":[{"value":2,"date":"2020-12-14 12:46:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":2,"date":"2020-12-14 12:38:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"all":[{"value":1,"date":"2020-12-14 12:46:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}],"reviewers":{"REVIEWER":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-14 08:02:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-14 10:43:56.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2020-12-14 10:43:56.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"REVIEWER"},{"updated":"2020-12-14 12:38:28.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"}],"messages":[{"id":"acb3f863827f49fbfbe833b2e45bcce800cfedd9","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2020-12-14 06:17:09.000000000","message":"Patch Set 1: Cherry Picked from branch master.\n\nThe following files contain Git conflicts:\n* configure_facts.sh","accounts_in_message":[],"_revision_number":1},{"id":"c183b3fa2fba8b112f24637e7bc9cb39415a6d40","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2020-12-14 06:23:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c820c9fec12a071c159584db896f86e0002034e7","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2020-12-14 06:24:27.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":2},{"id":"02f08cc962ac8e640fe488d2b1bda15770cac379","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-14 08:02:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/76cd4345f6ca46deb30510787a3aac8c : SUCCESS in 4m 40s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f3ec70bda5f9474f9665778337054420 : SUCCESS in 4m 04s\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2593ec0aa8a143038ff0f2468aa74f6c : SUCCESS in 1h 04m 21s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/524a26f8970f4d85b9c39c9e9f2524da : SUCCESS in 1h 07m 36s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f9ed93776e35476dbbf78087fa4804ae : SUCCESS in 56m 14s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e18b4fb64a874706a478d5bebf77b161 : SUCCESS in 39m 34s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/f261bc73564145678e32efebe13fc081 : SUCCESS in 1h 32m 30s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/670c5ebc96254da290e67bfd378cbd5b : SUCCESS in 1h 29m 52s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/0aa544dee3be43a6af70dab1541b8136 : SUCCESS in 1h 30m 22s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/90552178cd6f41acbf9f393c4504a155 : SUCCESS in 1h 00m 44s","accounts_in_message":[],"_revision_number":2},{"id":"62cb081beeb12ec7f527f6d6b6ca0cd625f4b000","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-12-14 12:38:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"184b950c45d5f3419af4facb721793a793afe844","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2020-12-14 12:46:36.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"aa465c99ac5de82167e5867f9e8b0afde1bca376","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-14 12:46:48.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"509ff5f9c89940ca9531713438e9d10464cd2528","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-14 14:47:23.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b509d85b169a40b280e316c2f95f1504 : SUCCESS in 3m 20s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d4387ac9f9354830a78871a79915ec9d : SUCCESS in 3m 13s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/2bc8862adb8e4b95b4683e1441e8fab4 : SUCCESS in 1h 53m 36s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/ce64f53d9a294de8acc57a908aa8e972 : SUCCESS in 1h 40m 04s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/0a37fc4cc5af433b80aac9ea00507fa8 : SUCCESS in 1h 41m 21s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/6b1c6e2a897742e8b55e3141fee9796e : SUCCESS in 1h 02m 07s","accounts_in_message":[],"_revision_number":2},{"id":"7b28ad096254cce3864a0f56f8cdf23b1e8fa819","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-14 14:47:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"288c9e84ed15a75334d51b45237f29efed17c920","revisions":{"39e89448c3a4fb8a74b4b4f8754d94d3ba2870c0":{"kind":"REWORK","_number":1,"created":"2020-12-14 06:17:09.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/03/766803/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/03/766803/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/1"}}},"commit":{"parents":[{"commit":"42e31b7b432ff1788bcb02ca377b68e6c54408cf","subject":"Use Ceph Naitulus for Ubuntu","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/42e31b7b432ff1788bcb02ca377b68e6c54408cf"}]}],"author":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2020-12-11 10:25:04.000000000","tz":330},"committer":{"name":"yatin","email":"ykarel@redhat.com","date":"2020-12-14 06:17:09.000000000","tz":0},"subject":"Rely on ID/VERSION_ID to detect distro","message":"Rely on ID/VERSION_ID to detect distro\n\nREDHAT_SUPPORT_PRODUCT* are removed from recent\nCentOS8.3 release[1], Let\u0027s use ID/VERSION_ID instead\nwhich are available[2] and would serve our purpose.\n\n[1] https://git.centos.org/rpms/centos-linux-release/c/2e3df0\n[2] https://www.freedesktop.org/software/systemd/man/os-release.html\n\nChange-Id: If14f4edad391fd9ee61851859ecdd3a51b97a215\n(cherry picked from commit cb965268672a1d7a5ebc7cfd3a379e73e0869247)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/39e89448c3a4fb8a74b4b4f8754d94d3ba2870c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/39e89448c3a4fb8a74b4b4f8754d94d3ba2870c0"}]},"branch":"refs/heads/stable/victoria"},"288c9e84ed15a75334d51b45237f29efed17c920":{"kind":"REWORK","_number":2,"created":"2020-12-14 06:23:44.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/03/766803/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/03/766803/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/03/766803/2"}}},"commit":{"parents":[{"commit":"42e31b7b432ff1788bcb02ca377b68e6c54408cf","subject":"Use Ceph Naitulus for Ubuntu","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/42e31b7b432ff1788bcb02ca377b68e6c54408cf"}]}],"author":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2020-12-11 10:25:04.000000000","tz":330},"committer":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2020-12-14 06:23:14.000000000","tz":330},"subject":"Rely on ID/VERSION_ID to detect distro","message":"Rely on ID/VERSION_ID to detect distro\n\nREDHAT_SUPPORT_PRODUCT* are removed from recent\nCentOS8.3 release[1], Let\u0027s use ID/VERSION_ID instead\nwhich are available[2] and would serve our purpose.\n\n[1] https://git.centos.org/rpms/centos-linux-release/c/2e3df0\n[2] https://www.freedesktop.org/software/systemd/man/os-release.html\n\nConflicts:\n    configure_facts.sh\n\nChange-Id: If14f4edad391fd9ee61851859ecdd3a51b97a215\n(cherry picked from commit cb965268672a1d7a5ebc7cfd3a379e73e0869247)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/288c9e84ed15a75334d51b45237f29efed17c920"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/288c9e84ed15a75334d51b45237f29efed17c920"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}