)]}'
{"id":"openstack%2Fpuppet-openstack-integration~776317","triplet_id":"openstack%2Fpuppet-openstack-integration~stable%2Fvictoria~I5f3b94eaa5a65c76877363e9ca41684445c9cb12","project":"openstack/puppet-openstack-integration","branch":"stable/victoria","hashtags":[],"change_id":"I5f3b94eaa5a65c76877363e9ca41684445c9cb12","subject":"Add retries to module installation with r10k","status":"MERGED","created":"2021-02-18 06:15:16.000000000","updated":"2021-02-19 05:02:43.000000000","submitted":"2021-02-19 05:02:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"776317","meta_rev_id":"2587c834a60ac9981a33fd88e8aa4b0a391da80b","_number":776317,"virtual_id_number":776317,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-19 05:02:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":2,"date":"2021-02-19 03:01:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":1,"date":"2021-02-19 03:01:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-18 07:54:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-18 12:13:17.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"CC"},{"updated":"2021-02-19 03:01:19.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"}],"messages":[{"id":"f9e01fe4b73dd2a4e8a3e1a12da3ec2805d0003b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-18 06:15:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"619bf4143f9a5cfa417d05c28ef6e94329520d6b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 07:54:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f15fc42f5f8c42419adf487e49c53b19 : SUCCESS in 4m 08s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/42e2e59cba184c9fb1993131efd5ceb7 : SUCCESS in 5m 03s\n- puppet-openstack-integration-6-scenario001-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e15ecfbf0fbb4659be89e48d3c2cf012 : FAILURE in 36m 24s (non-voting)\n- puppet-openstack-integration-6-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/d209670ced8f44c796cf8172e65943e0 : FAILURE in 36m 13s (non-voting)\n- puppet-openstack-integration-6-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/53754d88bbfd4ffa8985f51fb5b87f05 : FAILURE in 32m 15s (non-voting)\n- puppet-openstack-integration-6-scenario004-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/87500f63c1c7493992c9e82d53f42c2e : FAILURE in 27m 28s (non-voting)\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/34a552d7c2ba4e5cb6c83548bea030d8 : SUCCESS in 1h 24m 36s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/3e6e795f609d4d8aa1f21066e56c715d : SUCCESS in 1h 33m 04s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/05c35b758dbe4dedbdf68b6f50ff94bf : SUCCESS in 1h 22m 23s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/71bf1ee54a7a4b45b55a3aa2e14890d6 : SUCCESS in 1h 06m 04s","accounts_in_message":[],"_revision_number":1},{"id":"3e1640d2f22463f388e33b3582a4d5f318cf7dee","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-02-18 12:13:17.000000000","message":"Patch Set 1:\n\nDo you mind backporting each patch independently ?\nI understand your intent to have all fixes merged at the same time, but I believe independent backport still has profits because it allows us to track backport more easily.","accounts_in_message":[],"_revision_number":1},{"id":"8bee43232a5e7ff878922787ce725e0458051f43","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-18 12:33:42.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Do you mind backporting each patch independently ?\n\u003e I understand your intent to have all fixes merged at the same time, but I believe independent backport still has profits because it allows us to track backport more easily.\n\nyeap i understand the merits, but in this case i thought of combining as all are related(1 of which missed in first commit) and wanted to avoid extra patches for each one. But if u still want i can post separate patches.","accounts_in_message":[],"_revision_number":1},{"id":"956963632850e354c60b5887503a4a59f8786acc","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-02-18 14:53:28.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e Do you mind backporting each patch independently ?\n\u003e \u003e I understand your intent to have all fixes merged at the same time, but I believe independent backport still has profits because it allows us to track backport more easily.\n\u003e \n\u003e yeap i understand the merits, but in this case i thought of combining as all are related(1 of which missed in first commit) and wanted to avoid extra patches for each one. But if u still want i can post separate patches.\n\nMy only concern here is that this patch is doing much more than what is described in its commit title.\nHow the updated commit message look like to you ?","accounts_in_message":[],"_revision_number":1},{"id":"c9e60b986c35d12d4df3d6961b9bcdb9d4ab1074","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-02-18 14:55:36.000000000","message":"Patch Set 1:\n\nI assigned an independent change id and it seems that it made that patch recognized as a different one...\n https://review.opendev.org/c/openstack/puppet-openstack-integration/+/776474","accounts_in_message":[],"_revision_number":1},{"id":"a9bde52438f9f654ef16b6acfaf66f8cab6e7486","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-18 15:53:51.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e I assigned an independent change id and it seems that it made that patch recognized as a different one...\n\u003e  https://review.opendev.org/c/openstack/puppet-openstack-integration/+/776474\n\nNo strong opinion on that, but i am ok with that patch too.","accounts_in_message":[],"_revision_number":1},{"id":"911bd399f182355e95f191112be7bc4d70c85082","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2021-02-19 03:01:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c9697acaa4e533a8d014a779f222814025b66a79","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 03:01:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b15729874e6cd77d44e10c9ea9dd9a8d3837d2c1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 05:02:42.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/2e061f7650384d499cf6a3606a6becf0 : SUCCESS in 4m 06s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9c7c442af01a42f1879c75a2ebbb2ed9 : SUCCESS in 3m 54s\n- puppet-openstack-integration-6-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/86a944f25387441bb291d5da3c98b6e2 : SUCCESS in 1h 02m 55s\n- puppet-openstack-integration-6-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/7eb2d885dd884acab4f292cede745f37 : SUCCESS in 1h 48m 59s\n- puppet-openstack-integration-6-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/e5095975405c4154b29d12c1a4a0844d : SUCCESS in 1h 42m 51s\n- puppet-openstack-integration-6-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/9c95d7a1b64e4652bed406c54d0ad3bb : SUCCESS in 1h 02m 48s","accounts_in_message":[],"_revision_number":1},{"id":"2587c834a60ac9981a33fd88e8aa4b0a391da80b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 05:02:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6113fe2268cf7c4d1742d3b2631fd0963011efc7","revisions":{"6113fe2268cf7c4d1742d3b2631fd0963011efc7":{"kind":"REWORK","_number":1,"created":"2021-02-18 06:15:16.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/17/776317/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/17/776317/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/17/776317/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/17/776317/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/17/776317/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/17/776317/1"}}},"commit":{"parents":[{"commit":"4d3a00664f28e8f1c1ad291b8548b7fbd0908500","subject":"Set override-checkout to Victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/4d3a00664f28e8f1c1ad291b8548b7fbd0908500"}]}],"author":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2021-02-02 08:33:36.000000000","tz":330},"committer":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2021-02-18 06:13:01.000000000","tz":330},"subject":"Add retries to module installation with r10k","message":"Add retries to module installation with r10k\n\nSince the modules are git cloned when installed via r10k and\nclones may fail due to some network glich, adding retries should\nhelp in these cases.\n\nWe randomly hit failures during git clone in RDO promotion\njobs running on ci.centos.org, adding retries to r10k\ninstallation to handle those random failures.\n\nAdded function \u0027retry_cmd\u0027 which can also be used\nwith other commands.\n\nAlso squashed below two commits:-\n\nRetry sealert command on failure\n\nWe randomly see issues while running sealert\nin RDO puppet promotion pipeline, sealert fails with:-\n\"SELinux is disabled or we can\u0027t open a policy file\"\nAs per logs selinux is enabled and selinuxfs is mounted\nso seems it\u0027s some filesystem issue.\n\nLocally was able to reproduce only with selinux disabled\nor umount /sys/fs/selinux. Adding retries in hope to\nfix these random failures.\n\nChange-Id: Icb07742d328827a41132cdd6a6c2bcfa3cde11ec\n(cherry picked from commit 425f454bdcb264eb80b305b67a5d4bcd4e04aadb)\n\nImprove retry_cmd function to handle set -e\n\nIn run_tests.sh we use \u0027set -e\u0027 which makes\nscript fail as soon as error hit but we don\u0027t\nwant to fail in case of retries, this patch fixes it.\n\nChange-Id: Ia33ff3dbb88317171143a43e5b1c674038187254\n(cherry picked from commit ec57a35931babc9698a8399ca5c76773f069e377)\n\nChange-Id: I5f3b94eaa5a65c76877363e9ca41684445c9cb12\n(cherry picked from commit 8d5b34c5522c17f0246d208d0104c86e3325250e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/6113fe2268cf7c4d1742d3b2631fd0963011efc7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/6113fe2268cf7c4d1742d3b2631fd0963011efc7"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}