)]}'
{"id":"openstack%2Fpuppet-openstack-integration~776465","triplet_id":"openstack%2Fpuppet-openstack-integration~stable%2Ftrain~Ia4c3431fb002cf58f8b5494b53903380e6fcb9c9","project":"openstack/puppet-openstack-integration","branch":"stable/train","hashtags":[],"change_id":"Ia4c3431fb002cf58f8b5494b53903380e6fcb9c9","subject":"[Train Only] Move resource default statements above other calls","status":"MERGED","created":"2021-02-18 14:16:39.000000000","updated":"2021-02-19 09:21:51.000000000","submitted":"2021-02-19 09:21:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"776465","meta_rev_id":"7fb61911472af83d9788f8d4be6eb22d0db496a6","_number":776465,"virtual_id_number":776465,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-19 09:21:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"recommended":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"all":[{"value":1,"date":"2021-02-18 16:43:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-19 08:07:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":2,"date":"2021-02-18 15:51:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"all":[{"value":0,"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-02-19 08:07:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"}],"reviewers":{"REVIEWER":[{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-18 15:38:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-18 15:49:04.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2021-02-18 15:49:04.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2021-02-18 15:49:04.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"REVIEWER"},{"updated":"2021-02-18 15:49:04.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-02-18 16:43:16.000000000","updated_by":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"reviewer":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"state":"REVIEWER"},{"updated":"2021-02-19 05:00:40.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"}],"messages":[{"id":"60f496b2faa8fd0bc55528c51feb8dcd9bd2f721","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-18 14:16:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8d65a52c3a26528f0fffb1427d03e3ff2c5f06b9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-18 15:38:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4df07cf21e7f41769addba19362ab785 : SUCCESS in 5m 57s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c936b5fdaa4943ee9af826719fa1acf8 : SUCCESS in 4m 35s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/12c95a91529c4434a35736400972d8e6 : SUCCESS in 4m 45s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/70c3fde2d6bb496bb94cd93993853716 : SUCCESS in 1h 01m 20s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/34724ff2692b41499c949d37cb51795b : SUCCESS in 55m 25s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/9ebde998dd504a0db577cf8c8e3a1dba : SUCCESS in 1h 09m 09s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/2a3de18cf3d1497ab939591386649492 : SUCCESS in 47m 30s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/60ad9f57bb954c1396980b100110b8e3 : FAILURE in 57m 25s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4f49442b037d4dd5ac79a9b1f99d02c2 : FAILURE in 28m 56s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ade9e94110384086a97f04a16b1cfa51 : FAILURE in 22m 38s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/12243e4be37f483b8a5800ab866e5413 : FAILURE in 40m 10s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/514d15ab3e1f407d87db8533ec625e04 : SUCCESS in 59m 06s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/143ecde84b4741498d9af49b8daf2e44 : SUCCESS in 54m 10s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/525b84f4c7e44e0ba032378503b74cb0 : SUCCESS in 1h 00m 49s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/71dd4857d40c4627b7d29a54cd591bc9 : SUCCESS in 57m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bf23ca33e4fc9a1cfd05a79d6c1ae7d7b2a0dc0a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-02-18 15:51:45.000000000","message":"Patch Set 1: Code-Review+2\n\nDid something change in puppet? My understanding was that this was applied at catalog build time which means the order shouldn\u0027t affect it.","accounts_in_message":[],"_revision_number":1},{"id":"35085206b49b9201082e7fcdc57abafa84c39d13","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-18 15:58:13.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review+2\n\u003e \n\u003e Did something change in puppet? My understanding was that this was applied at catalog build time which means the order shouldn\u0027t affect it.\n\nFrom what i read is resource defaults are dynamically applied https://puppet.com/docs/puppet/5.5/lang_defaults.html#behavior, i see same behavior in both puppet 5 and puppet 6, didn\u0027t checked older releases.","accounts_in_message":[],"_revision_number":1},{"id":"b513c60e769be8f84ba8fbdb940322d1d3445f20","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-02-18 16:04:25.000000000","message":"Patch Set 1:\n\nAh maybe i\u0027m confusing it with the ordering which can be anywhere.  It\u0027s been a while. It makes sense that it\u0027ll change things going forward in the file processing rather than being retroactive","accounts_in_message":[],"_revision_number":1},{"id":"b610d8ea087dc746e7926cc7c0dfa67d8fa8a6e6","author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"date":"2021-02-18 16:43:16.000000000","message":"Patch Set 1: Code-Review+1\n\nI tested locally on CentOS Stream 8 and it works.\nThough I don\u0027t understand why it\u0027s working in CentOS 8\nbut not in Stream without this patch.","accounts_in_message":[],"_revision_number":1},{"id":"8a726f73fd07acfc7f3e6a4960584627e06a689a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-02-18 19:38:48.000000000","message":"Patch Set 1:\n\nOh yea we could probably also do the following which would work retroactively\n\nConcat \u003c||\u003e { selinux_ignore_defaults \u003d\u003e true }\nFile \u003c||\u003e { selinux_ignore_defaults \u003d\u003e true }","accounts_in_message":[],"_revision_number":1},{"id":"e4793a09793f5ea6f72b76f87437e96294d286db","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-19 05:00:08.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review+1\n\u003e \n\u003e I tested locally on CentOS Stream 8 and it works.\n\u003e Though I don\u0027t understand why it\u0027s working in CentOS 8\n\u003e but not in Stream without this patch.\n\nIt\u0027s because of latest selinux-policy rpm in stream-8, with next centos8 release i.e 8.4 it will be seen there too. Some more context in https://review.opendev.org/c/openstack/puppet-openstack-integration/+/769962.","accounts_in_message":[],"_revision_number":1},{"id":"93ce569505c7fd56b1df2af9f5354a7aac4c0b4d","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2021-02-19 07:23:00.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Oh yea we could probably also do the following which would work retroactively\n\u003e \n\u003e Concat \u003c||\u003e { selinux_ignore_defaults \u003d\u003e true }\n\u003e File \u003c||\u003e { selinux_ignore_defaults \u003d\u003e true }\n\nYeap it works too, Thanks for sharing.","accounts_in_message":[],"_revision_number":1},{"id":"376c2f609fa1a4fd45482bc1ce07f67e75506268","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2021-02-19 08:07:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"299b5871c0b6243e27196e552e4bd71bf31f2e80","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 08:08:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"304113f14b5b2082ab7a76570bc3b4d76ee1aead","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 09:21:49.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/f249fa0605a74a4aa09dc1723f68facb : SUCCESS in 5m 54s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/a18a5d1124244cfbb7bfd7ae499e843b : SUCCESS in 4m 48s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/681822251ec64abb900780223dc5cc34 : SUCCESS in 4m 55s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/58814aa71659496fb78b67383e98063b : SUCCESS in 55m 06s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/cdf58843f4d84d0f90b523e40bc18fe1 : SUCCESS in 1h 02m 53s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/720f61d0a3b44450baa3d9b7dd45e271 : SUCCESS in 1h 07m 23s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/885cfa38e8b94d79a46aa13ddf861ebb : SUCCESS in 55m 00s","accounts_in_message":[],"_revision_number":1},{"id":"7fb61911472af83d9788f8d4be6eb22d0db496a6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-19 09:21:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4723defd23fd35be270490049475c0ca29b8de0d","revisions":{"4723defd23fd35be270490049475c0ca29b8de0d":{"kind":"REWORK","_number":1,"created":"2021-02-18 14:16:39.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/65/776465/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack-integration","ref":"refs/changes/65/776465/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/776465/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/776465/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/776465/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack-integration refs/changes/65/776465/1"}}},"commit":{"parents":[{"commit":"afb64ae611325acf0015d5550c7af7aea5aac44a","subject":"Remove reference to tempest-horizon repo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/afb64ae611325acf0015d5550c7af7aea5aac44a"}]}],"author":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2021-02-18 14:10:17.000000000","tz":330},"committer":{"name":"yatinkarel","email":"ykarel@redhat.com","date":"2021-02-18 14:10:19.000000000","tz":330},"subject":"[Train Only] Move resource default statements above other calls","message":"[Train Only] Move resource default statements above other calls\n\nThese defaults need to be moved before any other \"include\"\ncalls.\n\nThis is Train Only as in ussuri+ releases there is not\nany \"include\" call before it.\n\nChange-Id: Ia4c3431fb002cf58f8b5494b53903380e6fcb9c9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/4723defd23fd35be270490049475c0ca29b8de0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack-integration/commit/4723defd23fd35be270490049475c0ca29b8de0d"}]},"parents_data":[{"branch_name":"refs/heads/stable/train","commit_id":"afb64ae611325acf0015d5550c7af7aea5aac44a","is_merged_in_target_branch":false,"change_id":"I96760e4e4f35b3f044ba03156a0fa449a9854b5b","change_number":775847,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}