)]}'
{"playbooks/copy-logs.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ed4aa40123955158134d48c1167c31ed448c859b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"        cmd: |"},{"line_number":6,"context_line":"          set -ex"},{"line_number":7,"context_line":"          if [[ ! -d \"${WORKSPACE}/logs/etc\" ]]; then"},{"line_number":8,"context_line":"              ./copy_logs.sh"},{"line_number":9,"context_line":"          fi"},{"line_number":10,"context_line":"        executable: /bin/bash"},{"line_number":11,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace/puppet-openstack-integration\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3cc37fb8_ee05391e","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":25},"updated":"2021-03-18 00:38:02.000000000","message":"I think we can remove usage of copy_logs.sh from the playbook to make this simple. What do you think about that approach ?\n\nhttps://github.com/openstack/puppet-openstack-integration/blob/master/playbooks/run-integration-tests.yaml#L6","commit_id":"e6f762f780810a24dbd6d924d4384a4f5385288b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fe76b697302285b1f4e6d559669d69d33e2759ea","unresolved":true,"context_lines":[{"line_number":5,"context_line":"        cmd: |"},{"line_number":6,"context_line":"          set -ex"},{"line_number":7,"context_line":"          if [[ ! -d \"${WORKSPACE}/logs/etc\" ]]; then"},{"line_number":8,"context_line":"              ./copy_logs.sh"},{"line_number":9,"context_line":"          fi"},{"line_number":10,"context_line":"        executable: /bin/bash"},{"line_number":11,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace/puppet-openstack-integration\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6d3cefc1_28e14c0f","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":25},"in_reply_to":"3cc37fb8_ee05391e","updated":"2021-03-18 05:21:11.000000000","message":"I think it\u0027s better to have fallback like this as both run and post playbooks have different timeouts and we already have enough time in run so we should utilize that and if that doesn\u0027t work run copy_logs in post, this will work if pre-run or run phase fails or timeout.","commit_id":"e6f762f780810a24dbd6d924d4384a4f5385288b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bf4e1dc177b4931316b8332d78ae25c15b300190","unresolved":true,"context_lines":[{"line_number":5,"context_line":"        cmd: |"},{"line_number":6,"context_line":"          set -ex"},{"line_number":7,"context_line":"          if [[ ! -d \"${WORKSPACE}/logs/etc\" ]]; then"},{"line_number":8,"context_line":"              ./copy_logs.sh"},{"line_number":9,"context_line":"          fi"},{"line_number":10,"context_line":"        executable: /bin/bash"},{"line_number":11,"context_line":"        chdir: \u0027{{ ansible_user_dir }}/workspace/puppet-openstack-integration\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6107e95b_6b23ede4","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":25},"in_reply_to":"6d3cefc1_28e14c0f","updated":"2021-03-18 05:48:41.000000000","message":"Makes sense.\nThat simplification can be done later if we introduce timeout in copy_logs.sh.","commit_id":"e6f762f780810a24dbd6d924d4384a4f5385288b"}]}