)]}'
{"fixtures/scenario000.pp":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"183c9ac93d31106ec32cdf31e508de3697028523","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  nova               \u003d\u003e false,"},{"line_number":87,"context_line":"  neutron            \u003d\u003e false,"},{"line_number":88,"context_line":"  configure_images   \u003d\u003e false,"},{"line_number":89,"context_line":"  configure_networks \u003d\u003e false,"},{"line_number":90,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"75c067f8_6b45ad7a","side":"PARENT","line":89,"updated":"2021-04-20 15:41:25.000000000","message":"During my testing, these variables for tempest need to be left in or the puppet execution of keystone will try to configure these services and also run glance and neutron commands","commit_id":"70a2bb8b09eeade87b07d107b86f4758c12befb3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"478de017ed7f43a2770a23eafd7a097e1f5321ba","unresolved":true,"context_lines":[{"line_number":86,"context_line":"  nova               \u003d\u003e false,"},{"line_number":87,"context_line":"  neutron            \u003d\u003e false,"},{"line_number":88,"context_line":"  configure_images   \u003d\u003e false,"},{"line_number":89,"context_line":"  configure_networks \u003d\u003e false,"},{"line_number":90,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dacef6b0_037ca2fa","side":"PARENT","line":89,"in_reply_to":"75c067f8_6b45ad7a","updated":"2021-04-20 15:48:01.000000000","message":"No I think you can get rid of the whole openstack_integration::tempest resource because tempest is not invoked in scenario000. As I mentioned in the previous patch, openstack_integration::keystone include resource to trigger user creation thus API functionality is already validated by that resource.","commit_id":"70a2bb8b09eeade87b07d107b86f4758c12befb3"}],"playbooks/run-integration-tests.yaml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"183c9ac93d31106ec32cdf31e508de3697028523","unresolved":true,"context_lines":[{"line_number":7,"context_line":"          export CEPH_VERSION\u003d{{ ceph }}"},{"line_number":8,"context_line":"          export PUPPET_MAJ_VERSION\u003d{{ puppet }}"},{"line_number":9,"context_line":"          export SCENARIO\u003d{{ scenario }}"},{"line_number":10,"context_line":"          export SKIP_TEMPEST\u003d{{ skip_tempest }}"},{"line_number":11,"context_line":"          export GEM_HOME\u003d`pwd`/.bundled_gems"},{"line_number":12,"context_line":"          ./run_tests.sh"},{"line_number":13,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b709ac3d_da2b7f7d","line":10,"updated":"2021-04-20 15:41:25.000000000","message":"I like this","commit_id":"9aecb58d6b63ce62df9519bcb454461652276997"}],"run_tests.sh":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"183c9ac93d31106ec32cdf31e508de3697028523","unresolved":true,"context_lines":[{"line_number":239,"context_line":"timestamp_puppet_log"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"if [ \"$SKIP_TEMPEST\" \u003d\u003d \"true\" ]; then"},{"line_number":242,"context_line":"    echo \"Skipping tempest tests\""},{"line_number":243,"context_line":"    exit 0"},{"line_number":244,"context_line":"fi"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"885735ee_f4839407","line":242,"updated":"2021-04-20 15:41:25.000000000","message":"+1","commit_id":"9aecb58d6b63ce62df9519bcb454461652276997"}],"zuul.d/base.yaml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"183c9ac93d31106ec32cdf31e508de3697028523","unresolved":true,"context_lines":[{"line_number":78,"context_line":"      - zuul: zuul/zuul-jobs"},{"line_number":79,"context_line":"    vars:"},{"line_number":80,"context_line":"      ceph: octopus"},{"line_number":81,"context_line":"      skip_tempest: false"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"- job:"},{"line_number":84,"context_line":"    name: puppet-openstack-base"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f961e58e_046ade14","line":81,"updated":"2021-04-20 15:41:25.000000000","message":"+1","commit_id":"9aecb58d6b63ce62df9519bcb454461652276997"}],"zuul.d/integration.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3addc9d345d2f19cdfbca41037b524f196393988","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    vars:"},{"line_number":27,"context_line":"      scenario: scenario001"},{"line_number":28,"context_line":"      ceph: octopus"},{"line_number":29,"context_line":"      skip_tempest: true"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- job:"},{"line_number":32,"context_line":"    name: puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d48960e7_edf10194","line":29,"updated":"2021-04-20 23:45:27.000000000","message":"This should be added to scenario000","commit_id":"9aecb58d6b63ce62df9519bcb454461652276997"}],"zuul.d/tripleo.yaml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"183c9ac93d31106ec32cdf31e508de3697028523","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    name: tripleo-puppet-standalone"},{"line_number":60,"context_line":"    check:"},{"line_number":61,"context_line":"      jobs:"},{"line_number":62,"context_line":"        - puppet-openstack-integration-6-scenario000-tempest-centos-8-stream"},{"line_number":63,"context_line":"        - tripleo-puppet-ci-centos-8-content-provider"},{"line_number":64,"context_line":"        - tripleo-puppet-ci-centos-8-standalone:"},{"line_number":65,"context_line":"            vars: \u0026standalone_consumer_vars"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4bb3df7b_309ba36d","side":"PARENT","line":62,"updated":"2021-04-20 15:41:25.000000000","message":"my latest change in the parent review has taken this out","commit_id":"70a2bb8b09eeade87b07d107b86f4758c12befb3"}]}
