)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"18be3e0bc34a59cf76dda70d3f0257d39da36e9e","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- puppet-apache needs some changes https://review.rdoproject.org/r/c/puppet/puppet-apache-distgit/+/33781"},{"line_number":26,"context_line":"- puppet-vswitch needs to be fixed https://bugs.launchpad.net/puppet-vswitch/+bug/1929707"},{"line_number":27,"context_line":"  a workaround *for CI only* can be to uninstall NetworkManager"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Note that i\u0027m removing c8 jobs from check just to save some CI resources"},{"line_number":30,"context_line":"as this review is not intended to be commited as is."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1cf1f3d4_cefab0b8","line":27,"updated":"2021-06-08 13:09:18.000000000","message":"FTR workaround is that puppet-vswitch will configure but not presist networking interface configuration when if* commands are missing","commit_id":"3e49c32d4787c3322bac4dc92038c0d1f7854f7c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"44dcf7f8e093f0a419bdc3d1daec3f52d335f59e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"- Disabled ceph deployment (there are no ceph builds yet)"},{"line_number":17,"context_line":"- Disabled amqp driver (there is some issue with cyrus-sasl currently in"},{"line_number":18,"context_line":"  CS9)"},{"line_number":19,"context_line":"- Added the creation of initiatorname.iscsi (unclear where this will go)"},{"line_number":20,"context_line":"- Disabled ironic as tftp-server and xinetd are not available in CS9."},{"line_number":21,"context_line":"- Force rsync to be executed without xinetd (xinetd is not in CS9)"},{"line_number":22,"context_line":"- Replace wget by curl as there is a bug fetching cirros image."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"86456839_656b7273","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":72},"updated":"2021-07-05 09:12:44.000000000","message":"You can follow what I\u0027ve implemented in https://review.opendev.org/c/openstack/puppet-openstack-integration/+/794635 . It\u0027d make sense to remove WIP from that patch and merge the patch separately.","commit_id":"19975540898986c1943698bc96ded8cad3f2d64d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"af41673d6e26505951334d3278dc459db8ad5663","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"92d2188c_47c0bd91","updated":"2021-11-19 11:54:46.000000000","message":"recheck","commit_id":"83b00d8bba9263980529cb20ae0e5fd5c4ebafe0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"9f274c28_ab716706","updated":"2021-11-22 12:57:28.000000000","message":"The proposed change looks almost good to me. -1 mainly because of missing TODO comments, which helps us update pending items later.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"73c0fdf4_7cd65f32","updated":"2021-11-22 14:25:53.000000000","message":"sending new ps with your comments","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8d4752666ff4c899264c622108d997f0df46ce9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"a602a5ee_bc137bf6","updated":"2021-11-23 11:16:38.000000000","message":"Please keep in mind, if something is required for CentOS 9 we might need to fix puppet-openstack_extras repo part as well.","commit_id":"eae94e1bef5c111783d67aaab4db4d7e2136acd2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"ee23bf53234630f0815ed28cf03217915ef9f472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"938f4927_c6185356","updated":"2021-11-26 08:20:34.000000000","message":"recheck","commit_id":"f384effdb42e0cbe19e137f0411b09ac8fef5b48"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"717d664934b3181872fbdae65a44acc917e1345b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"972e8ac5_9173b8ba","updated":"2021-11-25 23:11:25.000000000","message":"recheck","commit_id":"f384effdb42e0cbe19e137f0411b09ac8fef5b48"}],"Puppetfile":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"35bab3206359163e6b1f93a347b05b790baaa5ee","unresolved":true,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"mod \u0027rsync\u0027,"},{"line_number":202,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-rsync\u0027,"},{"line_number":203,"context_line":"  :ref \u003d\u003e \u0027ea6397ef55273b7e20d8eccece493cceb795f5eb\u0027"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"mod \u0027stdlib\u0027,"},{"line_number":206,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-stdlib\u0027,"}],"source_content_type":"application/octet-stream","patch_set":35,"id":"3bdc8c97_9e18169f","line":203,"range":{"start_line":203,"start_character":11,"end_line":203,"end_character":51},"updated":"2021-11-16 13:09:32.000000000","message":"basically we should not update this manually. This is supposed to be updated by automation when a new release is created in this repo. I\u0027ll look into this later but we need to request a new release of puppetlabs-rsync here.","commit_id":"98cb3d91ea0ccda46eab5478848905931cace9bc"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"28f4ab7d9814653eec3c3db8ce1cf9fdd2cb5e93","unresolved":true,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"mod \u0027rsync\u0027,"},{"line_number":202,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-rsync\u0027,"},{"line_number":203,"context_line":"  :ref \u003d\u003e \u0027ea6397ef55273b7e20d8eccece493cceb795f5eb\u0027"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"mod \u0027stdlib\u0027,"},{"line_number":206,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-stdlib\u0027,"}],"source_content_type":"application/octet-stream","patch_set":35,"id":"593f890c_449b07d7","line":203,"range":{"start_line":203,"start_character":11,"end_line":203,"end_character":51},"in_reply_to":"3bdc8c97_9e18169f","updated":"2021-11-16 13:54:49.000000000","message":"https://tickets.puppetlabs.com/browse/MODULES-11230","commit_id":"98cb3d91ea0ccda46eab5478848905931cace9bc"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"79ea87882367e5fe4494e9b373ccec5a9a2b2add","unresolved":true,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"mod \u0027rsync\u0027,"},{"line_number":202,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-rsync\u0027,"},{"line_number":203,"context_line":"  :ref \u003d\u003e \u0027ea6397ef55273b7e20d8eccece493cceb795f5eb\u0027"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"mod \u0027stdlib\u0027,"},{"line_number":206,"context_line":"  :git \u003d\u003e \u0027https://github.com/puppetlabs/puppetlabs-stdlib\u0027,"}],"source_content_type":"application/octet-stream","patch_set":35,"id":"bd0e4a3d_7440418a","line":203,"range":{"start_line":203,"start_character":11,"end_line":203,"end_character":51},"in_reply_to":"593f890c_449b07d7","updated":"2021-11-18 08:22:07.000000000","message":"May we get this get this merged with this commit pinned and get automatic update when new release is created in puppet-rsync?","commit_id":"98cb3d91ea0ccda46eab5478848905931cace9bc"}],"configure_facts.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"783f8354bfccabf51c3e82edbdf10341ff0a16b7","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"curl -o /tmp/delorean.repo \"${NODEPOOL_RDO_PROXY}/${OS_NAME_VERS}-master/puppet-passed-ci/delorean.repo\""},{"line_number":65,"context_line":"sed -i -e \"s|https://trunk.rdoproject.org|${NODEPOOL_RDO_PROXY}|g\" /tmp/delorean.repo"},{"line_number":66,"context_line":"curl -o /tmp/delorean-deps.repo \"${NODEPOOL_RDO_PROXY}/${OS_NAME_VERS}master/delorean-deps.repo\""},{"line_number":67,"context_line":"sed -i -e \"s|https://trunk.rdoproject.org|${NODEPOOL_RDO_PROXY}|g\" /tmp/delorean-deps.repo"},{"line_number":68,"context_line":"sed -i -e \"s|http://mirror.centos.org|${CENTOS_MIRROR_HOST}|g\" /tmp/delorean-deps.repo"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"55df3d73_e3d7097f","line":66,"range":{"start_line":66,"start_character":70,"end_line":66,"end_character":76},"updated":"2021-10-12 00:49:34.000000000","message":"seems \u0027-\u0027 was removed unintentionally ?","commit_id":"a54caaef320277cdfeeda2dbc8aa42f51a36ad58"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        CEPH_MIRROR_HOST\u003d\"http://download.ceph.com/debian-${CEPH_VERSION}\""},{"line_number":41,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\"http://${NODEPOOL_MIRROR_HOST}/apt-puppetlabs\""},{"line_number":42,"context_line":"    else"},{"line_number":43,"context_line":"        # centos9 content is still not mirrored"},{"line_number":44,"context_line":"        if [ \"${OS_NAME_VERS}\" \u003d\u003d \"centos9\" ]; then"},{"line_number":45,"context_line":"            CEPH_MIRROR_HOST\u003d\"https://buildlogs.centos.org/centos/9-stream/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":46,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":37,"id":"00e56e75_b523b5aa","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":47},"updated":"2021-11-22 12:57:28.000000000","message":"Let\u0027s leave an explicit TODO comment. This should be updated once CentOS9 content is mirrored.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        CEPH_MIRROR_HOST\u003d\"http://download.ceph.com/debian-${CEPH_VERSION}\""},{"line_number":41,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\"http://${NODEPOOL_MIRROR_HOST}/apt-puppetlabs\""},{"line_number":42,"context_line":"    else"},{"line_number":43,"context_line":"        # centos9 content is still not mirrored"},{"line_number":44,"context_line":"        if [ \"${OS_NAME_VERS}\" \u003d\u003d \"centos9\" ]; then"},{"line_number":45,"context_line":"            CEPH_MIRROR_HOST\u003d\"https://buildlogs.centos.org/centos/9-stream/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":46,"context_line":"        else"}],"source_content_type":"text/x-sh","patch_set":37,"id":"4534b489_276e1a0a","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":47},"in_reply_to":"00e56e75_b523b5aa","updated":"2021-11-22 14:25:53.000000000","message":"Done","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        CEPH_MIRROR_HOST\u003d\"https://download.ceph.com/debian-${CEPH_VERSION}\""},{"line_number":58,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\u0027https://apt.puppetlabs.com\u0027"},{"line_number":59,"context_line":"    else"},{"line_number":60,"context_line":"        CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/${VERSION_ID}-stream/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":61,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\"https://yum.puppetlabs.com\""},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":37,"id":"58c83bd7_5c25a051","line":60,"range":{"start_line":60,"start_character":68,"end_line":60,"end_character":75},"updated":"2021-11-22 12:57:28.000000000","message":"This like like the change required in older stable branches as part of migration from CentOS8 to CentOS8 Stream. Am I correct ?","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        CEPH_MIRROR_HOST\u003d\"https://download.ceph.com/debian-${CEPH_VERSION}\""},{"line_number":58,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\u0027https://apt.puppetlabs.com\u0027"},{"line_number":59,"context_line":"    else"},{"line_number":60,"context_line":"        CEPH_MIRROR_HOST\u003d\"${CENTOS_MIRROR_HOST}/centos/${VERSION_ID}-stream/storage/x86_64/ceph-${CEPH_VERSION}/\""},{"line_number":61,"context_line":"        NODEPOOL_PUPPETLABS_MIRROR\u003d\"https://yum.puppetlabs.com\""},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":37,"id":"7e34c362_9a77c569","line":60,"range":{"start_line":60,"start_character":68,"end_line":60,"end_character":75},"in_reply_to":"58c83bd7_5c25a051","updated":"2021-11-22 14:25:53.000000000","message":"yes, correct.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"}],"functions":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":true,"context_lines":[{"line_number":218,"context_line":"            $SUDO $YUM remove -y epel-release"},{"line_number":219,"context_line":"        fi"},{"line_number":220,"context_line":"        source /etc/os-release"},{"line_number":221,"context_line":"        if [ \"${MANAGE_REPOS}\" \u003d\u003d \"true\" ] \u0026\u0026 [ ${VERSION_ID} -ne 9 ] ; then"},{"line_number":222,"context_line":"            $SUDO rpm --import ${NODEPOOL_PUPPETLABS_MIRROR}/RPM-GPG-KEY-puppetlabs"},{"line_number":223,"context_line":"            $SUDO rpm --import ${NODEPOOL_PUPPETLABS_MIRROR}/RPM-GPG-KEY-puppet"},{"line_number":224,"context_line":"            $SUDO rpm --import ${NODEPOOL_PUPPETLABS_MIRROR}/RPM-GPG-KEY-puppet-20250406"}],"source_content_type":"application/x-shellscript","patch_set":37,"id":"63ce5779_93c59b99","line":221,"range":{"start_line":221,"start_character":43,"end_line":221,"end_character":76},"updated":"2021-11-22 12:57:28.000000000","message":"I tend to make this an independent block for better readability.\nAlso, please put a TODO note because we should consider switching back to puppetlabs repo later.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            $SUDO $YUM remove -y epel-release"},{"line_number":219,"context_line":"        fi"},{"line_number":220,"context_line":"        source /etc/os-release"},{"line_number":221,"context_line":"        if [ \"${MANAGE_REPOS}\" \u003d\u003d \"true\" ] \u0026\u0026 [ ${VERSION_ID} -ne 9 ] ; then"},{"line_number":222,"context_line":"            $SUDO rpm --import ${NODEPOOL_PUPPETLABS_MIRROR}/RPM-GPG-KEY-puppetlabs"},{"line_number":223,"context_line":"            $SUDO rpm --import ${NODEPOOL_PUPPETLABS_MIRROR}/RPM-GPG-KEY-puppet"},{"line_number":224,"context_line":"            $SUDO rpm --import ${NODEPOOL_PUPPETLABS_MIRROR}/RPM-GPG-KEY-puppet-20250406"}],"source_content_type":"application/x-shellscript","patch_set":37,"id":"5a3add3b_0ffb761e","line":221,"range":{"start_line":221,"start_character":43,"end_line":221,"end_character":76},"in_reply_to":"63ce5779_93c59b99","updated":"2021-11-22 14:25:53.000000000","message":"Done","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"}],"manifests/repos.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":50,"context_line":"      # Set specific variables for CentOS Stream 9"},{"line_number":51,"context_line":"      if $::os[\u0027release\u0027][\u0027major\u0027] \u003d\u003d \u00279\u0027 {"},{"line_number":52,"context_line":"        $powertools_repo \u003d \u0027crb\u0027"},{"line_number":53,"context_line":"        $manage_virt     \u003d false"},{"line_number":54,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"f8f992b9_992cf7ab","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":42},"updated":"2021-11-22 12:57:28.000000000","message":"Integer.new($::os[\u0027release\u0027][\u0027major\u0027]) \u003e 9\n\nwould make more sense if we don\u0027t expect this is reverted in CentOS10 at this moment.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":50,"context_line":"      # Set specific variables for CentOS Stream 9"},{"line_number":51,"context_line":"      if $::os[\u0027release\u0027][\u0027major\u0027] \u003d\u003d \u00279\u0027 {"},{"line_number":52,"context_line":"        $powertools_repo \u003d \u0027crb\u0027"},{"line_number":53,"context_line":"        $manage_virt     \u003d false"},{"line_number":54,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":37,"id":"43e6218b_eb1eaa6f","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":42},"in_reply_to":"f8f992b9_992cf7ab","updated":"2021-11-22 14:25:53.000000000","message":"Who knows what may happen in 10... 😊","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"}],"manifests/swift.pp":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a75363a7255b4c8e41a166f603f149bbb368a5a9","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    zone   \u003d\u003e 1,"},{"line_number":135,"context_line":"    weight \u003d\u003e 1,"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":"  # Until https://github.com/puppetlabs/puppetlabs-rsync/pull/139/ is merged"},{"line_number":138,"context_line":"  if ($facts[\u0027os\u0027][\u0027family\u0027] \u003d\u003d \u0027RedHat\u0027) and (Integer($facts[\u0027os\u0027][\u0027release\u0027][\u0027major\u0027])) \u003e\u003d 8 {"},{"line_number":139,"context_line":"    package { \u0027rsync-daemon\u0027:"},{"line_number":140,"context_line":"      ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"b64eab9b_78a7a4ae","line":137,"range":{"start_line":137,"start_character":10,"end_line":137,"end_character":66},"updated":"2021-09-30 12:02:16.000000000","message":"merged, let\u0027s clean","commit_id":"63c197261c7012f2af886020f5efb5fe658a6ded"}],"playbooks/prepare-node-common.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"5d4b9def14f12ba6c015a749069d641bdc712fb4","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        - ansible_distribution \u003d\u003d \"Fedora\" or ansible_distribution_major_version \u003e\u003d \"8\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    - block:"},{"line_number":88,"context_line":"      - name: install required packages for CentOS 9"},{"line_number":89,"context_line":"        dnf:"},{"line_number":90,"context_line":"          name: \"{{ item }}\""},{"line_number":91,"context_line":"          state: absent"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"97f39bc3_5682c424","line":88,"updated":"2021-11-22 12:00:27.000000000","message":"name is wrong based on that state\u003dabsent for the task","commit_id":"83b00d8bba9263980529cb20ae0e5fd5c4ebafe0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":true,"context_lines":[{"line_number":88,"context_line":"      - name: install required packages for CentOS 9"},{"line_number":89,"context_line":"        dnf:"},{"line_number":90,"context_line":"          name: \"{{ item }}\""},{"line_number":91,"context_line":"          state: present"},{"line_number":92,"context_line":"        become: true"},{"line_number":93,"context_line":"        ignore_errors: true"},{"line_number":94,"context_line":"        with_items:"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"ba16d966_181158fe","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":24},"updated":"2021-11-22 12:57:28.000000000","message":"I\u0027m wondering whether this is really needed, seeing the jobs passed with state: absent ?","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      - name: install required packages for CentOS 9"},{"line_number":89,"context_line":"        dnf:"},{"line_number":90,"context_line":"          name: \"{{ item }}\""},{"line_number":91,"context_line":"          state: present"},{"line_number":92,"context_line":"        become: true"},{"line_number":93,"context_line":"        ignore_errors: true"},{"line_number":94,"context_line":"        with_items:"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"1501994d_63f9c341","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":24},"in_reply_to":"ba16d966_181158fe","updated":"2021-11-22 14:25:53.000000000","message":"It\u0027s needed. It passed because i have dnf install rubygem-rexml -y in run-tests.sh from a previous patchset but i removed it.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"}],"run_tests.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e32fc7b479120e1f097399ec571be7f786842045","unresolved":true,"context_lines":[{"line_number":48,"context_line":"source ${SCRIPT_DIR}/configure_facts.sh"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"export PATH\u003d${PATH}:/opt/puppetlabs/bin:/opt/puppetlabs/puppet/bin"},{"line_number":51,"context_line":"# In CentOS9 there is no puppetlabs package yet, so we use RDO one."},{"line_number":52,"context_line":"if [ \"${OS_NAME_VERS}\" \u003d\u003d \"centos9\" ]; then"},{"line_number":53,"context_line":"    export PUPPET_BASE_PATH\u003d/etc/puppet"},{"line_number":54,"context_line":"    export PUPPET_PKG\u003d\"puppet\""}],"source_content_type":"text/x-sh","patch_set":37,"id":"4b930b50_ac3068d1","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":67},"updated":"2021-11-22 12:57:28.000000000","message":"Let\u0027s leave TODO comment here.","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4a68419d76b2fb1386ba63f779fc1b2c70168bab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"source ${SCRIPT_DIR}/configure_facts.sh"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"export PATH\u003d${PATH}:/opt/puppetlabs/bin:/opt/puppetlabs/puppet/bin"},{"line_number":51,"context_line":"# In CentOS9 there is no puppetlabs package yet, so we use RDO one."},{"line_number":52,"context_line":"if [ \"${OS_NAME_VERS}\" \u003d\u003d \"centos9\" ]; then"},{"line_number":53,"context_line":"    export PUPPET_BASE_PATH\u003d/etc/puppet"},{"line_number":54,"context_line":"    export PUPPET_PKG\u003d\"puppet\""}],"source_content_type":"text/x-sh","patch_set":37,"id":"8905dd90_71ea1003","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":67},"in_reply_to":"4b930b50_ac3068d1","updated":"2021-11-22 14:25:53.000000000","message":"Done","commit_id":"83aa36e8677ec658de410d87ccba201c6e3fc647"}],"zuul.d/layout.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8967c1dd8d0dca3399cbaa08beb6a85094c83600","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    check:"},{"line_number":78,"context_line":"      jobs:"},{"line_number":79,"context_line":"        - puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal"},{"line_number":80,"context_line":"        - puppet-openstack-integration-7-scenario001-tempest-centos-8-stream"},{"line_number":81,"context_line":"    gate:"},{"line_number":82,"context_line":"      jobs:"},{"line_number":83,"context_line":"        - puppet-openstack-integration-7-scenario001-tempest-centos-8-stream"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"14694adb_aa806c40","line":80,"range":{"start_line":80,"start_character":10,"end_line":80,"end_character":76},"updated":"2021-11-23 13:43:17.000000000","message":"Can we add centos-9 jobs to individual scenario templates as well ?","commit_id":"eae94e1bef5c111783d67aaab4db4d7e2136acd2"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"ff298288f284e5bb2686944aeb262a7f545e8f15","unresolved":true,"context_lines":[{"line_number":77,"context_line":"    check:"},{"line_number":78,"context_line":"      jobs:"},{"line_number":79,"context_line":"        - puppet-openstack-integration-6-scenario001-tempest-ubuntu-focal"},{"line_number":80,"context_line":"        - puppet-openstack-integration-7-scenario001-tempest-centos-8-stream"},{"line_number":81,"context_line":"    gate:"},{"line_number":82,"context_line":"      jobs:"},{"line_number":83,"context_line":"        - puppet-openstack-integration-7-scenario001-tempest-centos-8-stream"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"f0ca8807_75ae11a3","line":80,"range":{"start_line":80,"start_character":10,"end_line":80,"end_character":76},"in_reply_to":"14694adb_aa806c40","updated":"2021-11-23 14:11:08.000000000","message":"thanks for fixing it","commit_id":"eae94e1bef5c111783d67aaab4db4d7e2136acd2"}]}