)]}'
{"manifests/neutron.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c1ee08642eca5bca3cf4f9d3b4748640f6e5057a","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"      if ($::osfamily \u003d\u003d \u0027RedHat\u0027) and (versioncmp($::operatingsystemmajrelease, \u00279\u0027) \u003e\u003d 0) {"},{"line_number":68,"context_line":"        $loop_ip_cmd \u003d \u0027nmcli conn add type dummy ifname loop1 con-name loop1 ipv4.method manual ipv4.addresses 127.2.0.1/24 autoconnect yes\u0027"},{"line_number":69,"context_line":"        $vif_ip_cmd \u003d \u0027nmcli conn modify br-ex-ovs-interface ipv4.method manual ipv4.addresses 172.24.5.1/24 \u0026\u0026 nmcli conn down br-ex-ovs-interface \u0026\u0026 nmcli conn up br-ex-ovs-interface\u0027"},{"line_number":70,"context_line":"      } else {"},{"line_number":71,"context_line":"        $loop_ip_cmd \u003d \u0027ip link add name loop1 type dummy \u0026\u0026 ip addr add 127.2.0.1/24 dev loop1\u0027"},{"line_number":72,"context_line":"        $vif_ip_cmd \u003d \u0027ip addr add 172.24.5.1/24 dev br-ex \u0026\u0026 ip link set br-ex up\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"19ba214d_97382cac","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":185},"updated":"2021-08-12 15:28:44.000000000","message":"Because we don\u0027t require persistence of this ip, it would be much easier to use the same ip command here. As far as I\u0027ve tested in my C9S vm ip command still works and can add an ip on the interface.","commit_id":"ded4df6e84842cab866aacdd5e0d54e5d0a01be4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c9d5c6ee3bd0dd1db71beff776f0ba705b71f682","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"      if ($::osfamily \u003d\u003d \u0027RedHat\u0027) and (versioncmp($::operatingsystemmajrelease, \u00279\u0027) \u003e\u003d 0) {"},{"line_number":68,"context_line":"        $loop_ip_cmd \u003d \u0027nmcli conn add type dummy ifname loop1 con-name loop1 ipv4.method manual ipv4.addresses 127.2.0.1/24 autoconnect yes\u0027"},{"line_number":69,"context_line":"        $vif_ip_cmd \u003d \u0027nmcli conn modify br-ex-ovs-interface ipv4.method manual ipv4.addresses 172.24.5.1/24 \u0026\u0026 nmcli conn down br-ex-ovs-interface \u0026\u0026 nmcli conn up br-ex-ovs-interface\u0027"},{"line_number":70,"context_line":"      } else {"},{"line_number":71,"context_line":"        $loop_ip_cmd \u003d \u0027ip link add name loop1 type dummy \u0026\u0026 ip addr add 127.2.0.1/24 dev loop1\u0027"},{"line_number":72,"context_line":"        $vif_ip_cmd \u003d \u0027ip addr add 172.24.5.1/24 dev br-ex \u0026\u0026 ip link set br-ex up\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"8046d1a2_e6e23f12","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":185},"in_reply_to":"19ba214d_97382cac","updated":"2021-08-12 15:47:06.000000000","message":"Yea we could probably get away with it here, though does it cause problems using nmcli?","commit_id":"ded4df6e84842cab866aacdd5e0d54e5d0a01be4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2994816a115983fc4d3e8c806fdca72f5490aa76","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"      if ($::osfamily \u003d\u003d \u0027RedHat\u0027) and (versioncmp($::operatingsystemmajrelease, \u00279\u0027) \u003e\u003d 0) {"},{"line_number":68,"context_line":"        $loop_ip_cmd \u003d \u0027nmcli conn add type dummy ifname loop1 con-name loop1 ipv4.method manual ipv4.addresses 127.2.0.1/24 autoconnect yes\u0027"},{"line_number":69,"context_line":"        $vif_ip_cmd \u003d \u0027nmcli conn modify br-ex-ovs-interface ipv4.method manual ipv4.addresses 172.24.5.1/24 \u0026\u0026 nmcli conn down br-ex-ovs-interface \u0026\u0026 nmcli conn up br-ex-ovs-interface\u0027"},{"line_number":70,"context_line":"      } else {"},{"line_number":71,"context_line":"        $loop_ip_cmd \u003d \u0027ip link add name loop1 type dummy \u0026\u0026 ip addr add 127.2.0.1/24 dev loop1\u0027"},{"line_number":72,"context_line":"        $vif_ip_cmd \u003d \u0027ip addr add 172.24.5.1/24 dev br-ex \u0026\u0026 ip link set br-ex up\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"6718d5e3_3b1c03f3","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":185},"in_reply_to":"1a9546ab_9b0e19cb","updated":"2021-08-16 14:25:26.000000000","message":"Another problem was that nmcli doesn\u0027t add but replace the address. So this command removes the ip migrated from the loopback device... We are good as long as the ip is reachable and don\u0027t care about persistence, I replaced this by the ip command.\n\n\u003e I think if the ovs interface is down prior to applying the ip it\u0027d be ok.\nAs far as I\u0027ve tested the ip command works even if the interface is up, so I don\u0027t think we need to keep it down until we apply this IP.\n\n\u003e We should be able to add an ip at the vs_bridge level but i don\u0027t know how much effort we want to put into that\nWe can leave it now, because this is not something already implemented in the existing providers based on network script(or pure ovs commands)","commit_id":"ded4df6e84842cab866aacdd5e0d54e5d0a01be4"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cbac90872e006e411fbc01dc1afda34901838d15","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"      if ($::osfamily \u003d\u003d \u0027RedHat\u0027) and (versioncmp($::operatingsystemmajrelease, \u00279\u0027) \u003e\u003d 0) {"},{"line_number":68,"context_line":"        $loop_ip_cmd \u003d \u0027nmcli conn add type dummy ifname loop1 con-name loop1 ipv4.method manual ipv4.addresses 127.2.0.1/24 autoconnect yes\u0027"},{"line_number":69,"context_line":"        $vif_ip_cmd \u003d \u0027nmcli conn modify br-ex-ovs-interface ipv4.method manual ipv4.addresses 172.24.5.1/24 \u0026\u0026 nmcli conn down br-ex-ovs-interface \u0026\u0026 nmcli conn up br-ex-ovs-interface\u0027"},{"line_number":70,"context_line":"      } else {"},{"line_number":71,"context_line":"        $loop_ip_cmd \u003d \u0027ip link add name loop1 type dummy \u0026\u0026 ip addr add 127.2.0.1/24 dev loop1\u0027"},{"line_number":72,"context_line":"        $vif_ip_cmd \u003d \u0027ip addr add 172.24.5.1/24 dev br-ex \u0026\u0026 ip link set br-ex up\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a9546ab_9b0e19cb","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":185},"in_reply_to":"27cbaa08_30354e1d","updated":"2021-08-12 16:42:50.000000000","message":"yea i\u0027m not a fan of that NetworkManager interaction. I think if the ovs interface is down prior to applying the ip it\u0027d be ok.  We should be able to add an ip at the vs_bridge level but i don\u0027t know how much effort we want to put into that","commit_id":"ded4df6e84842cab866aacdd5e0d54e5d0a01be4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a2707e3d3eb497e00218854d336eb122a975117d","unresolved":true,"context_lines":[{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"      if ($::osfamily \u003d\u003d \u0027RedHat\u0027) and (versioncmp($::operatingsystemmajrelease, \u00279\u0027) \u003e\u003d 0) {"},{"line_number":68,"context_line":"        $loop_ip_cmd \u003d \u0027nmcli conn add type dummy ifname loop1 con-name loop1 ipv4.method manual ipv4.addresses 127.2.0.1/24 autoconnect yes\u0027"},{"line_number":69,"context_line":"        $vif_ip_cmd \u003d \u0027nmcli conn modify br-ex-ovs-interface ipv4.method manual ipv4.addresses 172.24.5.1/24 \u0026\u0026 nmcli conn down br-ex-ovs-interface \u0026\u0026 nmcli conn up br-ex-ovs-interface\u0027"},{"line_number":70,"context_line":"      } else {"},{"line_number":71,"context_line":"        $loop_ip_cmd \u003d \u0027ip link add name loop1 type dummy \u0026\u0026 ip addr add 127.2.0.1/24 dev loop1\u0027"},{"line_number":72,"context_line":"        $vif_ip_cmd \u003d \u0027ip addr add 172.24.5.1/24 dev br-ex \u0026\u0026 ip link set br-ex up\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"27cbaa08_30354e1d","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":185},"in_reply_to":"8046d1a2_e6e23f12","updated":"2021-08-12 15:50:03.000000000","message":"A limitation with nmcli is that it doesn\u0027t apply the change immediately and we need to restart the connection as I updated the command. Unfortunately I could not find any option in nmcli command to make NetworkManager reload the updated defenition.\n\nBenefit of ip command is that the change is applied immediately and we don\u0027t need that down/up steps.","commit_id":"ded4df6e84842cab866aacdd5e0d54e5d0a01be4"}]}