)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"596dc6abfa121db3c2c328862a9500a07ff0365c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Copy current p-o-i project in PUPPETFILE_DIR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we don\u0027t install puppet modules from source"},{"line_number":10,"context_line":"we still need to copy the current p-o-i project"},{"line_number":11,"context_line":"(as we do in [1][2]) in PUPPETFILE_DIR directory"},{"line_number":12,"context_line":"which is \"/etc/puppet/modules\". This dir is in the path"},{"line_number":13,"context_line":"for both RPM installation and source installation [3]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e0d1f99b_c4b8f9a4","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":47},"updated":"2022-02-16 08:44:06.000000000","message":"Can you explain a bit more about the reason.\n\nWhen we don\u0027t install puppet modules from source and install them by packages, we still need to install p-o-i code because there are no packages of it.","commit_id":"c43ffae00da49119547b90e4c31c8e58dc752911"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"596dc6abfa121db3c2c328862a9500a07ff0365c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"which is \"/etc/puppet/modules\". This dir is in the path"},{"line_number":13,"context_line":"for both RPM installation and source installation [3]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch doesn\u0027t change current behavior, as we always"},{"line_number":16,"context_line":"set $MANAGE_PUPPET_MODULES as true [4], and we don\u0027t"},{"line_number":17,"context_line":"override it in [5]."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b2f17cb6_b1c84116","line":15,"range":{"start_line":15,"start_character":42,"end_line":15,"end_character":43},"updated":"2022-02-16 08:44:06.000000000","message":"can we explicitly mention something like \"in CI jobs\"","commit_id":"c43ffae00da49119547b90e4c31c8e58dc752911"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"596dc6abfa121db3c2c328862a9500a07ff0365c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"for both RPM installation and source installation [3]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch doesn\u0027t change current behavior, as we always"},{"line_number":16,"context_line":"set $MANAGE_PUPPET_MODULES as true [4], and we don\u0027t"},{"line_number":17,"context_line":"override it in [5]."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Note that currently, when we enable puppet modules RPM, we install"},{"line_number":20,"context_line":"puppet modules with both RPM and from sources. Puppet modules from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"25c402ab_5a5fd447","line":17,"range":{"start_line":16,"start_character":40,"end_line":17,"end_character":19},"updated":"2022-02-16 08:44:06.000000000","message":"remove this because this is specific to RDO","commit_id":"c43ffae00da49119547b90e4c31c8e58dc752911"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"596dc6abfa121db3c2c328862a9500a07ff0365c","unresolved":true,"context_lines":[{"line_number":16,"context_line":"set $MANAGE_PUPPET_MODULES as true [4], and we don\u0027t"},{"line_number":17,"context_line":"override it in [5]."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Note that currently, when we enable puppet modules RPM, we install"},{"line_number":20,"context_line":"puppet modules with both RPM and from sources. Puppet modules from"},{"line_number":21,"context_line":"RPM goes in \"/usr/share/openstack-puppet/modules\", and modules from"},{"line_number":22,"context_line":"source goes in /etc/puppet/modules [6]. But as the RPM module dir is"},{"line_number":23,"context_line":"first in modulepath [3] (\"earlier directories having priority over"},{"line_number":24,"context_line":"later ones\" [7]) we use RPM ones."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] https://github.com/openstack/puppet-openstack-integration/blob/c8175c5b329d6cea0fb127bde2efe0a52805609a/functions#L92"},{"line_number":27,"context_line":"[2] https://github.com/openstack/puppet-openstack-integration/blob/c8175c5b329d6cea0fb127bde2efe0a52805609a/functions#L77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c1925abd_81a07ee5","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":33},"updated":"2022-02-16 08:44:06.000000000","message":"consider removing this because this is specific to RDO","commit_id":"c43ffae00da49119547b90e4c31c8e58dc752911"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"30c4711c17b9e810c0385e899bac070afa71a4e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a9a389b_d13cf8af","updated":"2022-02-15 11:01:22.000000000","message":"Tested in Wallaby branch with periodic jobs which enables puppet modules RPM https://review.rdoproject.org/r/c/testproject/+/39445","commit_id":"c94c6e91dd13aae8db72cef3e39cc085e619a234"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"596dc6abfa121db3c2c328862a9500a07ff0365c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3bfc42a2_402bda3f","updated":"2022-02-16 08:44:06.000000000","message":"I agree with the change, and understand why you need this.\n\nHowever I\u0027m concerned with the current commit message because it mentions several items specific to RDO and its CI and looks very confusing from view point of Puppet OpenStack\u0027s CI.\n\nPlease find my inline comments and consider removing items very specific to RDO, and \"generalize\" what is explained in the commit message.","commit_id":"c43ffae00da49119547b90e4c31c8e58dc752911"},{"author":{"_account_id":31068,"name":"Joel Capitao","email":"jcapitao@redhat.com","username":"jcapiitao"},"change_message_id":"e266cba8c927b4be0215b28bd90a36d6ed572c95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d47acc94_20d074e0","updated":"2022-02-16 08:22:29.000000000","message":"Note that currently, when we enable puppet modules RPM, we install puppet modules both with RPM and from sources. Puppet modules from RPM goes in \"/usr/share/openstack-puppet/modules\", and modules from source goes in /etc/puppet/modules [1]. But as the RPM module dir is first in modulepath [2] (\"earlier directories having priority over later ones\" [3]) we use RPM ones.\n\n[1] https://github.com/rdo-infra/ansible-role-weirdo-puppet-openstack/blob/4d676307eb52fc33ea8562f57c4d6028ffe1cd02/tasks/main.yml#L121\n[2] https://github.com/rdo-infra/ansible-role-weirdo-puppet-openstack/blob/4d676307eb52fc33ea8562f57c4d6028ffe1cd02/defaults/main.yml#L54\n[3] https://puppet.com/docs/puppet/5.5/dirs_modulepath.html","commit_id":"c43ffae00da49119547b90e4c31c8e58dc752911"}]}