)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"1d167b6df038ec96e9c7695b9ff8b1a1340df808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"32b6990c_68f2486d","updated":"2026-06-02 09:21:23.000000000","message":"recheck","commit_id":"f1a39049e98cd59c3e2ef279ca86b129034ed837"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"042299f66d97842ab46e74e11eceee081b2e5285","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ef758030_95a6f4ac","updated":"2026-06-02 11:33:42.000000000","message":"recheck","commit_id":"bd13495008c99b3d6d521437d1ff10b748848dc0"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"90abdce8_550c2d7c","updated":"2026-06-05 12:38:13.000000000","message":"Hi Tobias,\nThanks a lot for your review. FYI, I do not intend to have this patch merged before all tempest tests for at least 1 or 2scenarios are fixed. I hope I have addressed your suggestions, if you feel that\u0027s not the case, please do reply or engage a discussion on IRC.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"90af32af_7e3e6b28","updated":"2026-06-05 08:43:22.000000000","message":"Some feedback and questions. You might also need to rebase/rework this when [1] goes in and will conflict here.\n\n[1] https://review.opendev.org/c/openstack/puppet-openstack-integration/+/990958","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"a6fbc8a3e5230f84dc1f8840dd5970001bd397e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"a8f913aa_a96f5f17","updated":"2026-06-02 14:02:49.000000000","message":"recheck new packaging fix","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"6cd56f71_e432fe3f","in_reply_to":"90af32af_7e3e6b28","updated":"2026-06-05 12:38:13.000000000","message":"Hi. Just rebased it as that patch merged, thanks for the pointer.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"005fe96c56c6dc3ae4725099195b67077540aaf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"62fa7c1c_b4414bc4","updated":"2026-06-11 11:09:40.000000000","message":"recheck","commit_id":"63a56065a19beafec497ff87cceb1bcf1ceee313"}],"copy_logs.sh":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6b7c7059e503653fdf8528f45d83b1dc39c26450","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Integration tests with RDO puppet package"},{"line_number":45,"context_line":"    PUPPET_MODULES_PATH\u003d\u0027/etc/puppet/modules\u0027"},{"line_number":46,"context_line":"else"},{"line_number":47,"context_line":"    # Integration tests with Debian/Ubuntu puppet package"},{"line_number":48,"context_line":"    PUPPET_MODULES_PATH\u003d\u0027/etc/puppet/code/modules\u0027"},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-sh","patch_set":32,"id":"519295bd_a4cefe12","line":47,"updated":"2026-06-04 23:03:26.000000000","message":"maybe this should just be a elif [ -d \"/etc/puppet/code/modules\" ]?","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"manifests/glance.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  include glance"},{"line_number":49,"context_line":"  include glance::client"},{"line_number":50,"context_line":"  if $facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 {"},{"line_number":51,"context_line":"    $glance_endpoint \u003d \u0027http://127.0.0.1:9292\u0027"},{"line_number":52,"context_line":"  } else {"},{"line_number":53,"context_line":"    $glance_endpoint \u003d \"${openstack_integration::config::base_url}:9292\""},{"line_number":54,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"3f433615_dd65d0f6","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":46},"updated":"2026-06-05 08:43:22.000000000","message":"Why is this hardcoded? It doesn\u0027t support IPv6?","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  include glance"},{"line_number":49,"context_line":"  include glance::client"},{"line_number":50,"context_line":"  if $facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 {"},{"line_number":51,"context_line":"    $glance_endpoint \u003d \u0027http://127.0.0.1:9292\u0027"},{"line_number":52,"context_line":"  } else {"},{"line_number":53,"context_line":"    $glance_endpoint \u003d \"${openstack_integration::config::base_url}:9292\""},{"line_number":54,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"792973be_a0c80df0","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":46},"in_reply_to":"3f433615_dd65d0f6","updated":"2026-06-05 12:38:13.000000000","message":"Indeed. As much as I understand, Glance doesn\u0027t work with only uwsgi, it needs apache with mod_proxy. In production, I\u0027m currently leaving the Eventlet based server, and doing re-encryption using haproxy. I don\u0027t think this is available in this repo. I guess we can try to solve this later, as this is a real concern, though it\u0027s one concern first with upstream Glance, not puppet.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"manifests/nova.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    \u0027Debian\u0027 \u003d\u003e \u0027nova-api-metadata\u0027,"},{"line_number":46,"context_line":"    default  \u003d\u003e undef,"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"  if $facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 {"},{"line_number":49,"context_line":"    user { \u0027nova\u0027:"},{"line_number":50,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":51,"context_line":"      name    \u003d\u003e \u0027nova\u0027,"},{"line_number":52,"context_line":"      gid     \u003d\u003e 64060,"},{"line_number":53,"context_line":"      uid     \u003d\u003e 64060,"},{"line_number":54,"context_line":"      groups  \u003d\u003e [\u0027nova\u0027, \u0027libvirt\u0027, \u0027libvirt-qemu\u0027],"},{"line_number":55,"context_line":"      require \u003d\u003e Anchor[\u0027nova::install::end\u0027],"},{"line_number":56,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::service::begin\u0027],"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  if $openstack_integration::config::ssl {"},{"line_number":61,"context_line":"    openstack_integration::ssl_key { \u0027nova\u0027:"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"e80cbee8_cba6e166","line":58,"range":{"start_line":48,"start_character":1,"end_line":58,"end_character":3},"updated":"2026-06-05 08:43:22.000000000","message":"This feels like a \"hack\" that belongs in the packaging?","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \u0027Debian\u0027 \u003d\u003e \u0027nova-api-metadata\u0027,"},{"line_number":46,"context_line":"    default  \u003d\u003e undef,"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"  if $facts[\u0027os\u0027][\u0027name\u0027] \u003d\u003d \u0027Debian\u0027 {"},{"line_number":49,"context_line":"    user { \u0027nova\u0027:"},{"line_number":50,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":51,"context_line":"      name    \u003d\u003e \u0027nova\u0027,"},{"line_number":52,"context_line":"      gid     \u003d\u003e 64060,"},{"line_number":53,"context_line":"      uid     \u003d\u003e 64060,"},{"line_number":54,"context_line":"      groups  \u003d\u003e [\u0027nova\u0027, \u0027libvirt\u0027, \u0027libvirt-qemu\u0027],"},{"line_number":55,"context_line":"      require \u003d\u003e Anchor[\u0027nova::install::end\u0027],"},{"line_number":56,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::service::begin\u0027],"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  if $openstack_integration::config::ssl {"},{"line_number":61,"context_line":"    openstack_integration::ssl_key { \u0027nova\u0027:"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"2e45f60d_434d338c","line":58,"range":{"start_line":48,"start_character":1,"end_line":58,"end_character":3},"in_reply_to":"e80cbee8_cba6e166","updated":"2026-06-05 12:38:13.000000000","message":"The GID / UID are indeed reserved in Debian for Nova, Cinder and Glance. I added this because otherwise the CI would fail, probably because of scheduling. We can attempt to revisit it later on...","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"manifests/params.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":15,"context_line":"      $mysql_charset       \u003d \u0027utf8mb3\u0027"},{"line_number":16,"context_line":"      case $facts[\u0027os\u0027][\u0027name\u0027] {"},{"line_number":17,"context_line":"        \u0027Debian\u0027: {"},{"line_number":18,"context_line":"          # Without this, debian run is not idempotent."},{"line_number":19,"context_line":"          $mysql_collate   \u003d \u0027utf8mb3_uca1400_ai_ci\u0027"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":"        default: {"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"aefc824d_bcfe2896","line":18,"updated":"2026-06-05 08:43:22.000000000","message":"Hm so it doesn\u0027t respect the collation for a created db?","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      $mysql_charset       \u003d \u0027utf8mb3\u0027"},{"line_number":16,"context_line":"      case $facts[\u0027os\u0027][\u0027name\u0027] {"},{"line_number":17,"context_line":"        \u0027Debian\u0027: {"},{"line_number":18,"context_line":"          # Without this, debian run is not idempotent."},{"line_number":19,"context_line":"          $mysql_collate   \u003d \u0027utf8mb3_uca1400_ai_ci\u0027"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":"        default: {"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"9f30dcff_886fb2c1","line":18,"in_reply_to":"aefc824d_bcfe2896","updated":"2026-06-05 12:38:13.000000000","message":"This is dependent on the version of MariaDB you\u0027re using. In Debian, when one asks for \"utf8mb3_general_ci\" as collate, it is \"utf8mb3_uca1400_ai_ci\" that is being in use by MariaDB. As a consequence, the run is not idempotent without this fix. I guess this may affect other distros, like maybe Ubuntu 26.04.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"manifests/trove.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":95,"context_line":"      workers   \u003d\u003e 2,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"#  } else {"},{"line_number":98,"context_line":"# No trove::wsgi::uwsgi class yet for trove."},{"line_number":99,"context_line":"# Pending: https://review.opendev.org/c/openstack/puppet-trove/+/991049"},{"line_number":100,"context_line":"#   class { \u0027trove::wsgi::uwsgi\u0027:"},{"line_number":101,"context_line":"#      processes \u003d\u003e 2,"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"75e4b813_b84b4243","line":98,"updated":"2026-06-05 08:43:22.000000000","message":"Add a Depends-On to that patch, it should be approved now as well.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":95,"context_line":"      workers   \u003d\u003e 2,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"#  } else {"},{"line_number":98,"context_line":"# No trove::wsgi::uwsgi class yet for trove."},{"line_number":99,"context_line":"# Pending: https://review.opendev.org/c/openstack/puppet-trove/+/991049"},{"line_number":100,"context_line":"#   class { \u0027trove::wsgi::uwsgi\u0027:"},{"line_number":101,"context_line":"#      processes \u003d\u003e 2,"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"d75a537d_fa52bbb5","line":98,"in_reply_to":"75e4b813_b84b4243","updated":"2026-06-05 12:38:13.000000000","message":"The patch is merged, so I removed the comments in my latest patch.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"manifests/watcher.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":101,"context_line":"      ssl_cert  \u003d\u003e $openstack_integration::params::cert_path,"},{"line_number":102,"context_line":"      workers   \u003d\u003e 2,"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"# This depends on https://review.opendev.org/c/openstack/puppet-watcher/+/990311"},{"line_number":105,"context_line":"#  } else {"},{"line_number":106,"context_line":"#    class { \u0027watcher::wsgi::uwsgi\u0027:"},{"line_number":107,"context_line":"#      processes \u003d\u003e 2,"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"b6673f0c_e363fbd8","line":104,"updated":"2026-06-05 08:43:22.000000000","message":"Same, add a Depends-On and uncomment.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":101,"context_line":"      ssl_cert  \u003d\u003e $openstack_integration::params::cert_path,"},{"line_number":102,"context_line":"      workers   \u003d\u003e 2,"},{"line_number":103,"context_line":"    }"},{"line_number":104,"context_line":"# This depends on https://review.opendev.org/c/openstack/puppet-watcher/+/990311"},{"line_number":105,"context_line":"#  } else {"},{"line_number":106,"context_line":"#    class { \u0027watcher::wsgi::uwsgi\u0027:"},{"line_number":107,"context_line":"#      processes \u003d\u003e 2,"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"f90bcdef_dc0f5d3a","line":104,"in_reply_to":"b6673f0c_e363fbd8","updated":"2026-06-05 12:38:13.000000000","message":"Ok, doing that.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"manifests/zaqar.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":87,"context_line":"      workers   \u003d\u003e 2,"},{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":"#  } else {"},{"line_number":90,"context_line":"# No zaqar::wsgi::uwsgi yet for Zaqar"},{"line_number":91,"context_line":"# Pending https://review.opendev.org/c/openstack/puppet-zaqar/+/991052"},{"line_number":92,"context_line":"#   class { \u0027zaqar::wsgi::uwsgi\u0027:"},{"line_number":93,"context_line":"#      processes \u003d\u003e 2,"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"8b1b7b0e_d8fdb379","line":90,"updated":"2026-06-05 08:43:22.000000000","message":"Same.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":87,"context_line":"      workers   \u003d\u003e 2,"},{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":"#  } else {"},{"line_number":90,"context_line":"# No zaqar::wsgi::uwsgi yet for Zaqar"},{"line_number":91,"context_line":"# Pending https://review.opendev.org/c/openstack/puppet-zaqar/+/991052"},{"line_number":92,"context_line":"#   class { \u0027zaqar::wsgi::uwsgi\u0027:"},{"line_number":93,"context_line":"#      processes \u003d\u003e 2,"}],"source_content_type":"text/x-puppet","patch_set":32,"id":"781a31ff_86e3db1a","line":90,"in_reply_to":"8b1b7b0e_d8fdb379","updated":"2026-06-05 12:38:13.000000000","message":"Patch merged, comment removed.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}],"zuul.d/layout.yaml":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"aa20abeab70d55a3bc2a4318592a3bb45543dd11","unresolved":true,"context_lines":[{"line_number":66,"context_line":"        - openvox-openstack-integration-8-scenario004-tempest-centos-9-stream"},{"line_number":67,"context_line":"        - openvox-openstack-integration-8-scenario005-tempest-centos-9-stream"},{"line_number":68,"context_line":"    gate:"},{"line_number":69,"context_line":"      jobs:"},{"line_number":70,"context_line":"        - puppet-openstack-integration-8-scenario001-tempest-centos-9-stream"},{"line_number":71,"context_line":"        - puppet-openstack-integration-8-scenario002-tempest-centos-9-stream"},{"line_number":72,"context_line":"        - puppet-openstack-integration-8-scenario003-tempest-centos-9-stream"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"61e6acaf_c857b8a2","line":69,"updated":"2026-06-05 08:43:22.000000000","message":"We should probably gate on this when this is ready for merge","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"580c004d83c8ee6768b84c2efafbb987f24c30ce","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        - openvox-openstack-integration-8-scenario004-tempest-centos-9-stream"},{"line_number":67,"context_line":"        - openvox-openstack-integration-8-scenario005-tempest-centos-9-stream"},{"line_number":68,"context_line":"    gate:"},{"line_number":69,"context_line":"      jobs:"},{"line_number":70,"context_line":"        - puppet-openstack-integration-8-scenario001-tempest-centos-9-stream"},{"line_number":71,"context_line":"        - puppet-openstack-integration-8-scenario002-tempest-centos-9-stream"},{"line_number":72,"context_line":"        - puppet-openstack-integration-8-scenario003-tempest-centos-9-stream"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"034cea4a_b4e34803","line":69,"in_reply_to":"61e6acaf_c857b8a2","updated":"2026-06-05 12:38:13.000000000","message":"Yeah, I\u0027d love to. Currently, the puppet thing passes, but there are a number of Tempest tests that are failing.","commit_id":"4ac6597ab66b075e1795db05fb9302d30daad9b9"}]}