)]}'
{".gitreview":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"b3c867ae60133c785ac8a6450ec61504b0a1243b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa32b979_39f29c07","updated":"2015-06-20 14:41:49.000000000","message":"maybe you\u0027ve sent this file by mistake?","commit_id":"e45d959897ad317987be850e0c6079cdc4dc10da"}],"specs/kilo/enabling-federation.rst":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":13,"context_line":"/enabling-federation\u003e`_"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a fast way for cloud administrators to"},{"line_number":16,"context_line":"configure their Keystone in order to use Federation. There are two types of"},{"line_number":17,"context_line":"federation in OpenStack:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Federated Keystone: Keystone works as a Service Provider and provides a list"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_8032a4a5","line":16,"updated":"2015-07-02 17:46:42.000000000","message":"we have only one type of Federation, the difference is that Keystone may perform as a Service Provider or Identity Provider","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* New class: Service Provider"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":" Class to configure Keystone as an Service Provider, according to the Apache"},{"line_number":44,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"},{"line_number":45,"context_line":" configuration will be applied according to the module chosen."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_007bf428","line":43,"updated":"2015-07-02 17:46:42.000000000","message":"actually, the choice of protocol comes first: if I choose to use SAML2 I will use mod_shib or mod_mellon, if I choose OpenID Connect I will use mod_auth_openidc","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":" - idp_url                  (None)"},{"line_number":50,"context_line":"   The identity provider url (address and port). This will be used to set the"},{"line_number":51,"context_line":"   configurations in Keystone and Apache."},{"line_number":52,"context_line":" - module                 (None)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_639e8aba","line":49,"updated":"2015-07-02 17:46:42.000000000","message":"can a keystone SP be configured to consume multiple IdPs?","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":49,"context_line":" - idp_url                  (None)"},{"line_number":50,"context_line":"   The identity provider url (address and port). This will be used to set the"},{"line_number":51,"context_line":"   configurations in Keystone and Apache."},{"line_number":52,"context_line":" - module                 (None)"},{"line_number":53,"context_line":"   The name of the apache module to install. This will be used to guide the"},{"line_number":54,"context_line":"   installation and configuration of a Service Provider."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_43a7c60a","line":52,"updated":"2015-07-02 17:46:42.000000000","message":"exemplify the modules here","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":73,"context_line":" - idp_contact_surname            (None)"},{"line_number":74,"context_line":" - idp_contact_email              (None)"},{"line_number":75,"context_line":" - idp_contact_telephone          (None)"},{"line_number":76,"context_line":" - idp_contact_type               (other)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":" Attributes used from keystone class:"},{"line_number":79,"context_line":"  - ssl_ca_key   (/etc/keystone/ssl/private/signing_key.pem)"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_e0a610ad","line":76,"updated":"2015-07-02 17:46:42.000000000","message":"what \"other\" means?","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. note::"},{"line_number":83,"context_line":"  For the Federated Identity feature, the usage of Apache is mandatory."},{"line_number":84,"context_line":"  To know more about some values see reference number two."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. note::"},{"line_number":87,"context_line":"  The packages installed will be according your distribution."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_00a21499","line":84,"updated":"2015-07-02 17:46:42.000000000","message":"which values?","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  The packages installed will be according your distribution."},{"line_number":88,"context_line":"  For example with debian/ubuntu, a Service Provider will need"},{"line_number":89,"context_line":"  ``libapache2-mod-(shib2,auth-openidc,auth-mellon)`` and an Identity Provider"},{"line_number":90,"context_line":"  will need ``pysaml2`` and ``xmlsec1``"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Alternatives"},{"line_number":93,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_000bf42a","line":90,"updated":"2015-07-02 17:46:42.000000000","message":"rephrase this, something like:\n\nThere are some packages that need to be installed. For example, in a Debian/Ubuntu distribution, ```libapache2-mod-(shib2,auth-openidc,auth-mellon)`` is required for the Service Provider, ``pysaml2`` and ``xmlsec1`` for the Identity Provider.","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"dacd3cc5e33f7e6282080510e9b33fa01154ab31","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Deployer impact"},{"line_number":120,"context_line":"---------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Should be explicitly enabled."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The examples of configurations are in the links of this section."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba3cc151_6329aa89","line":122,"updated":"2015-07-02 17:46:42.000000000","message":"what should be explicitly enabled?","commit_id":"35ea763e03662f375a5210d4cb93d46564e45ce0"}],"specs/kilo/enabling-k2k-federation.rst":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"825619fc09d925a5378af1ab8ab39e5812af0ee9","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* New class: Service Provider"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Class to configure Keystone as an Service Provider, by installing the "},{"line_number":67,"context_line":" libapache2-mod-shib2 package and adding the necessary configuration to the "},{"line_number":68,"context_line":" keystone.conf file and to the Keystone virtual host file in apache."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_80fb8746","line":66,"updated":"2015-06-11 03:06:54.000000000","message":"is there any reason to support eventlet (I dont think there is)","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f635195a7e0f9ddb05794f200dcf39b5f9b0fd7c","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* New class: Service Provider"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Class to configure Keystone as an Service Provider, by installing the "},{"line_number":67,"context_line":" libapache2-mod-shib2 package and adding the necessary configuration to the "},{"line_number":68,"context_line":" keystone.conf file and to the Keystone virtual host file in apache."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_5e931c5b","line":66,"in_reply_to":"3afb71cf_80fb8746","updated":"2015-06-11 14:21:18.000000000","message":"Hi Matt, I agree with you and i\u0027m not considering eventlet i\u0027ll make it more clear in the next patch.","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"825619fc09d925a5378af1ab8ab39e5812af0ee9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"   idp_contact_company\u003dig  "},{"line_number":131,"context_line":"   idp_contact_name\u003dIury"},{"line_number":132,"context_line":"   idp_contact_surname\u003dFerreira  "},{"line_number":133,"context_line":"   idp_contact_email\u003diurygregory@gmail.com  "},{"line_number":134,"context_line":"   idp_contact_telephone\u003d555-55-5555  "},{"line_number":135,"context_line":"   idp_contact_type\u003dtechnical "},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_209bb319","line":133,"updated":"2015-06-11 03:06:54.000000000","message":"probably should make up a fake email here using @example.com","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f635195a7e0f9ddb05794f200dcf39b5f9b0fd7c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"   idp_contact_company\u003dig  "},{"line_number":131,"context_line":"   idp_contact_name\u003dIury"},{"line_number":132,"context_line":"   idp_contact_surname\u003dFerreira  "},{"line_number":133,"context_line":"   idp_contact_email\u003diurygregory@gmail.com  "},{"line_number":134,"context_line":"   idp_contact_telephone\u003d555-55-5555  "},{"line_number":135,"context_line":"   idp_contact_type\u003dtechnical "},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_83dedfda","line":133,"in_reply_to":"3afb71cf_209bb319","updated":"2015-06-11 14:21:18.000000000","message":"Done","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"825619fc09d925a5378af1ab8ab39e5812af0ee9","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Dependencies"},{"line_number":219,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* The Keystone version should be stable/kilo."},{"line_number":222,"context_line":"* Keystone need to be configured to run over Apache server."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_a087a3b3","line":221,"updated":"2015-06-11 03:06:54.000000000","message":"or newer?","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f635195a7e0f9ddb05794f200dcf39b5f9b0fd7c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"Dependencies"},{"line_number":219,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* The Keystone version should be stable/kilo."},{"line_number":222,"context_line":"* Keystone need to be configured to run over Apache server."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_a3131b64","line":221,"in_reply_to":"3afb71cf_a087a3b3","updated":"2015-06-11 14:21:18.000000000","message":"I\u0027ll change in the next patch, since federation is stable in Kilo, upcoming releases of OpenStack can use this.","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"825619fc09d925a5378af1ab8ab39e5812af0ee9","unresolved":false,"context_lines":[{"line_number":219,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* The Keystone version should be stable/kilo."},{"line_number":222,"context_line":"* Keystone need to be configured to run over Apache server."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Testing"},{"line_number":225,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_809267f4","line":222,"updated":"2015-06-11 03:06:54.000000000","message":"needs","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f635195a7e0f9ddb05794f200dcf39b5f9b0fd7c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"* The Keystone version should be stable/kilo."},{"line_number":222,"context_line":"* Keystone need to be configured to run over Apache server."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Testing"},{"line_number":225,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3afb71cf_432ea7a5","line":222,"in_reply_to":"3afb71cf_809267f4","updated":"2015-06-11 14:21:18.000000000","message":"Done","commit_id":"6699b326f231ec1b56560e088858ca409b18bb25"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Introduce two new classes, one to configure the Keystone as a Service Provider"},{"line_number":32,"context_line":"and the other to configure as an Identity Provider."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Identity Provider"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_46a450a5","line":32,"updated":"2015-06-15 15:02:12.000000000","message":"Is there any reason to add two classes as part of one spec? I don\u0027t say it\u0027s bad but we could also split it.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Introduce two new classes, one to configure the Keystone as a Service Provider"},{"line_number":32,"context_line":"and the other to configure as an Identity Provider."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Identity Provider"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_b879b495","line":32,"in_reply_to":"fa32b979_46a450a5","updated":"2015-06-15 18:34:21.000000000","message":"Hi Marek,\nI have sent an email to openstack-puppet in May 25, the answers are the reason for have just one spec. \n\nTopic: [Puppet] puppet-keystone federation module\nLink: https://groups.google.com/a/puppetlabs.com/forum/#!searchin/puppet-openstack/%5BPuppet%5D$20puppet-keystone$20federation$20module/puppet-openstack/DG8a_L5LQ0U/F0P5i-Ixd-UJ","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Identity Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as an Identity Provider, by installing the pysaml2"},{"line_number":37,"context_line":" and xmlsec packages and adding the necessary configuration to the"},{"line_number":38,"context_line":" keystone.conf file."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_865a5882","line":36,"updated":"2015-06-15 15:02:12.000000000","message":"Can you specify how the packages would be installed? It will be always packaging system like apt or yum or in this case pip like tool ?","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Identity Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as an Identity Provider, by installing the pysaml2"},{"line_number":37,"context_line":" and xmlsec packages and adding the necessary configuration to the"},{"line_number":38,"context_line":" keystone.conf file."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_9a738580","line":36,"in_reply_to":"fa32b979_865a5882","updated":"2015-06-15 18:34:21.000000000","message":"I was thinking in use the package or exec. Do you think i need to say explicit how i\u0027m going to do this?","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Identity Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as an Identity Provider, by installing the pysaml2"},{"line_number":37,"context_line":" and xmlsec packages and adding the necessary configuration to the"},{"line_number":38,"context_line":" keystone.conf file."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_c612a0b4","line":37,"updated":"2015-06-15 15:02:12.000000000","message":"technically speaking on my ubuntu and debian box the package is called xmlsec1.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Identity Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as an Identity Provider, by installing the pysaml2"},{"line_number":37,"context_line":" and xmlsec packages and adding the necessary configuration to the"},{"line_number":38,"context_line":" keystone.conf file."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_a263c119","line":37,"in_reply_to":"fa32b979_c612a0b4","updated":"2015-06-15 18:34:21.000000000","message":"I\u0027ve forgot the \"1\", sorry.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":" - idp_address                  (None)"},{"line_number":74,"context_line":" - methods                      (external, password, token, oauth1)"},{"line_number":75,"context_line":" - saml2                        (keystone.auth.plugins.mapped.Mapped)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_c6c70011","line":73,"updated":"2015-06-15 15:02:12.000000000","message":"idp_url.\nAnyways, where is this being configured and what idp{address, url} would be - address of Keystone Identity Provider?","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":" - idp_address                  (None)"},{"line_number":74,"context_line":" - methods                      (external, password, token, oauth1)"},{"line_number":75,"context_line":" - saml2                        (keystone.auth.plugins.mapped.Mapped)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_fd440b1c","line":73,"in_reply_to":"fa32b979_c6c70011","updated":"2015-06-15 18:34:21.000000000","message":"When using the module the idp_url can be passed as parameter.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":144,"context_line":" ::"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  [auth]"},{"line_number":147,"context_line":"  methods \u003d external,password,token,oauth1,saml2"},{"line_number":148,"context_line":"  saml2 \u003d keystone.auth.plugins.mapped.Mapped"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"+ file ``/etc/apache2/sites-available/keystone.conf``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_41143a43","line":147,"updated":"2015-06-15 15:02:12.000000000","message":"external is being now deprecated, so please remove it.\nI don\u0027t know if we should enable oauth1 by default.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":144,"context_line":" ::"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  [auth]"},{"line_number":147,"context_line":"  methods \u003d external,password,token,oauth1,saml2"},{"line_number":148,"context_line":"  saml2 \u003d keystone.auth.plugins.mapped.Mapped"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"+ file ``/etc/apache2/sites-available/keystone.conf``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_5d265a69","line":147,"in_reply_to":"fa32b979_41143a43","updated":"2015-06-15 18:34:21.000000000","message":"Ok, i\u0027ve put the example considering the last K2K environment that i had configured.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  [auth]"},{"line_number":147,"context_line":"  methods \u003d external,password,token,oauth1,saml2"},{"line_number":148,"context_line":"  saml2 \u003d keystone.auth.plugins.mapped.Mapped"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"+ file ``/etc/apache2/sites-available/keystone.conf``"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_a12506ac","line":148,"updated":"2015-06-15 15:02:12.000000000","message":"HEADS UP, i think it should be keystone.auth.plugins.mapped.Saml2 - need to double check.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"  [auth]"},{"line_number":147,"context_line":"  methods \u003d external,password,token,oauth1,saml2"},{"line_number":148,"context_line":"  saml2 \u003d keystone.auth.plugins.mapped.Mapped"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"+ file ``/etc/apache2/sites-available/keystone.conf``"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_5de89710","line":148,"in_reply_to":"fa32b979_a12506ac","updated":"2015-06-15 18:34:21.000000000","message":"ok","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"   SetHandler shib"},{"line_number":161,"context_line":"  \u003c/Location\u003e"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  \u003cLocationMatch /v3/OS-FEDERATION/identity_providers/.*?/protocols/saml2/auth\u003e"},{"line_number":164,"context_line":"   ShibRequestSetting requireSession 1"},{"line_number":165,"context_line":"   AuthType shibboleth"},{"line_number":166,"context_line":"   ShibExportAssertion Off"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_2149f65f","line":163,"updated":"2015-06-15 15:02:12.000000000","message":"IMHO  protocols part should be also configurable, so \u0027saml2\u0027 should be some parameter passed as a user input to the module.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"   SetHandler shib"},{"line_number":161,"context_line":"  \u003c/Location\u003e"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"  \u003cLocationMatch /v3/OS-FEDERATION/identity_providers/.*?/protocols/saml2/auth\u003e"},{"line_number":164,"context_line":"   ShibRequestSetting requireSession 1"},{"line_number":165,"context_line":"   AuthType shibboleth"},{"line_number":166,"context_line":"   ShibExportAssertion Off"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_5d2177fa","line":163,"in_reply_to":"fa32b979_2149f65f","updated":"2015-06-15 18:34:21.000000000","message":"I\u0027ll fix in the next patch.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":" ::"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  \u003cSSO entityID\u003d\"https://keystone.idp/v3/OS-FEDERATION/saml2/idp\"\u003e"},{"line_number":185,"context_line":"   SAML2 SAML1"},{"line_number":186,"context_line":"  \u003c/SSO\u003e"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_a1cf46af","line":184,"updated":"2015-06-15 15:02:12.000000000","message":"don\u0027t hardcode keystone.idp, because for sure this is a configurable parameter, right?\n\nAlso, this should be:\n\n\u003cSSO entityID\u003d\"\u003curl\u003e\" ECP\u003dtrue\"\u003e \u003c-- ECP is important.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":" ::"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  \u003cSSO entityID\u003d\"https://keystone.idp/v3/OS-FEDERATION/saml2/idp\"\u003e"},{"line_number":185,"context_line":"   SAML2 SAML1"},{"line_number":186,"context_line":"  \u003c/SSO\u003e"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_3d703672","line":184,"in_reply_to":"fa32b979_a1cf46af","updated":"2015-06-15 18:34:21.000000000","message":"Yes, Keystone.idp is the idp_url.","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"d8d11415587289c50bd4a7ac6225753fd7977e8e","unresolved":false,"context_lines":[{"line_number":185,"context_line":"   SAML2 SAML1"},{"line_number":186,"context_line":"  \u003c/SSO\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  \u003cMetadataProvider type\u003d\"XML\" uri\u003d\"https://keystone.idp/v3/OS-FEDERATION/saml"},{"line_number":189,"context_line":"  2/metadata\"/\u003e"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_01bf12fc","line":188,"updated":"2015-06-15 15:02:12.000000000","message":"don\u0027t hardcode keystone.idp","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2135041d5d1431fb7b0166fe32aacde9b4f4039d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"   SAML2 SAML1"},{"line_number":186,"context_line":"  \u003c/SSO\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  \u003cMetadataProvider type\u003d\"XML\" uri\u003d\"https://keystone.idp/v3/OS-FEDERATION/saml"},{"line_number":189,"context_line":"  2/metadata\"/\u003e"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa32b979_bdd763be","line":188,"in_reply_to":"fa32b979_01bf12fc","updated":"2015-06-15 18:34:21.000000000","message":"Done","commit_id":"dfbb7f94104df34ea2ff9f342ea5491086e70609"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  of trusted Identity Providers so the user can choose one and authenticate."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Keystone to Keystone Federation: in addition to the Service Provider features"},{"line_number":22,"context_line":"  , Keystone can also perform as an Identity Provider."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_035a8c4f","line":22,"updated":"2015-06-30 21:34:15.000000000","message":"is it a typo? the \u0027,\u0027 is separated from \u0027features\u0027.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  of trusted Identity Providers so the user can choose one and authenticate."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Keystone to Keystone Federation: in addition to the Service Provider features"},{"line_number":22,"context_line":"  , Keystone can also perform as an Identity Provider."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_47e29930","line":22,"in_reply_to":"ba3cc151_035a8c4f","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As a cloud administrator, I want a fast and convenient way to configure my"},{"line_number":29,"context_line":"Keystone (version Kilo or newer) as a Service Provider or as an Identity"},{"line_number":30,"context_line":"Provider. Nowadays add extra configurations can be cumbersome and is error"},{"line_number":31,"context_line":"prone."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_e33528f7","line":29,"updated":"2015-06-30 21:34:15.000000000","message":"\u0027Kilo version\u0027 instead of \u0027version Kilo\u0027","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As a cloud administrator, I want a fast and convenient way to configure my"},{"line_number":29,"context_line":"Keystone (version Kilo or newer) as a Service Provider or as an Identity"},{"line_number":30,"context_line":"Provider. Nowadays add extra configurations can be cumbersome and is error"},{"line_number":31,"context_line":"prone."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_27e51537","line":29,"in_reply_to":"ba3cc151_e33528f7","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As a cloud administrator, I want a fast and convenient way to configure my"},{"line_number":29,"context_line":"Keystone (version Kilo or newer) as a Service Provider or as an Identity"},{"line_number":30,"context_line":"Provider. Nowadays add extra configurations can be cumbersome and is error"},{"line_number":31,"context_line":"prone."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_833c5ce3","line":30,"updated":"2015-06-30 21:34:15.000000000","message":"\u0027adding\u0027 instead of \u0027add\u0027 and s/is/if/ ?","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As a cloud administrator, I want a fast and convenient way to configure my"},{"line_number":29,"context_line":"Keystone (version Kilo or newer) as a Service Provider or as an Identity"},{"line_number":30,"context_line":"Provider. Nowadays add extra configurations can be cumbersome and is error"},{"line_number":31,"context_line":"prone."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_87dc2174","line":30,"in_reply_to":"ba3cc151_833c5ce3","updated":"2015-07-02 14:14:53.000000000","message":"i\u0027ll change to adding. s/is/if? i think \"is\" is correct.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* New class: Service Provider"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" Class to configure Keystone as an Service Provider, acording to the protocol"},{"line_number":43,"context_line":" chosen (currently, SAML2 and OpenID Connect are the two protocols that are sup"},{"line_number":44,"context_line":" ported) it will  install the required packages andd add the necessary configur"},{"line_number":45,"context_line":" ation."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_8e0a4320","line":43,"updated":"2015-06-30 21:34:15.000000000","message":"not sure why words are splited and if it\u0027s correct.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* New class: Service Provider"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" Class to configure Keystone as an Service Provider, acording to the protocol"},{"line_number":43,"context_line":" chosen (currently, SAML2 and OpenID Connect are the two protocols that are sup"},{"line_number":44,"context_line":" ported) it will  install the required packages andd add the necessary configur"},{"line_number":45,"context_line":" ation."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_e7d16d58","line":43,"in_reply_to":"ba3cc151_8e0a4320","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":" Class to configure Keystone as an Service Provider, acording to the protocol"},{"line_number":43,"context_line":" chosen (currently, SAML2 and OpenID Connect are the two protocols that are sup"},{"line_number":44,"context_line":" ported) it will  install the required packages andd add the necessary configur"},{"line_number":45,"context_line":" ation."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_ae0dc738","line":44,"updated":"2015-06-30 21:34:15.000000000","message":"extra space after \u0027will\u0027 and typo with \u0027andd\u0027","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":" Class to configure Keystone as an Service Provider, acording to the protocol"},{"line_number":43,"context_line":" chosen (currently, SAML2 and OpenID Connect are the two protocols that are sup"},{"line_number":44,"context_line":" ported) it will  install the required packages andd add the necessary configur"},{"line_number":45,"context_line":" ation."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_a7c7e596","line":44,"in_reply_to":"ba3cc151_ae0dc738","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fabb08240412a3576483d2b57e017e8731d3160a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":" - idp_url                  (None)"},{"line_number":51,"context_line":" - protocol                 (None)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_fbb5cc30","line":50,"updated":"2015-06-30 22:32:46.000000000","message":"explain what this is and what it is used for","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":" - idp_url                  (None)"},{"line_number":51,"context_line":" - protocol                 (None)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_a73845ef","line":50,"in_reply_to":"ba3cc151_fbb5cc30","updated":"2015-07-02 14:14:53.000000000","message":"ok","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fabb08240412a3576483d2b57e017e8731d3160a","unresolved":false,"context_lines":[{"line_number":48,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":" - idp_url                  (None)"},{"line_number":51,"context_line":" - protocol                 (None)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":" Packages that will be installed:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_5b7dd86c","line":51,"updated":"2015-06-30 22:32:46.000000000","message":"explain what this is and what it is used for","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":48,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":" - idp_url                  (None)"},{"line_number":51,"context_line":" - protocol                 (None)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":" Packages that will be installed:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_c73d49de","line":51,"in_reply_to":"ba3cc151_5b7dd86c","updated":"2015-07-02 14:14:53.000000000","message":"ok","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":" Packages that will be installed:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" - protocol is SAML2: ``libapache2-mod-shib2``"},{"line_number":57,"context_line":" - protocol is OpenID: ``libapache2-mod-auth-openidc``"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_4e3c3bc8","line":55,"updated":"2015-06-30 21:34:15.000000000","message":"I don\u0027t know if it\u0027s worth to give package names because they are not the same across all distros.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fabb08240412a3576483d2b57e017e8731d3160a","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":" Packages that will be installed:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" - protocol is SAML2: ``libapache2-mod-shib2``"},{"line_number":57,"context_line":" - protocol is OpenID: ``libapache2-mod-auth-openidc``"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_db56c8d1","line":55,"in_reply_to":"ba3cc151_4e3c3bc8","updated":"2015-06-30 22:32:46.000000000","message":"or, say \"For example: on Ubuntu $version, to install the Apache module that provides Federation support via SAML2 using Shibboleth, install libapache2-mod-shib2\".  etc.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":" Packages that will be installed:"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" - protocol is SAML2: ``libapache2-mod-shib2``"},{"line_number":57,"context_line":" - protocol is OpenID: ``libapache2-mod-auth-openidc``"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_9792f64a","line":55,"in_reply_to":"ba3cc151_db56c8d1","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - ssl_ca_key   (/etc/keystone/ssl/private/signing_key.pem)"},{"line_number":88,"context_line":"  - ssl_ca_certs (/etc/keystone/ssl/certs/signing_cert.pem)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_ae5b872d","line":90,"updated":"2015-06-30 21:34:15.000000000","message":"extra space, and same comment for packaging.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  - ssl_ca_key   (/etc/keystone/ssl/private/signing_key.pem)"},{"line_number":88,"context_line":"  - ssl_ca_certs (/etc/keystone/ssl/certs/signing_cert.pem)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_076571b3","line":90,"in_reply_to":"ba3cc151_ae5b872d","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fabb08240412a3576483d2b57e017e8731d3160a","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":"Keep these setups as they are right now: manually install packages and add"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_3bd814ef","line":93,"updated":"2015-06-30 22:32:46.000000000","message":"So far, there is nothing in here that has anything to do with puppet-keystone or even Keystone.  It\u0027s just about setting up some Apache modules.\n\nWhat about the Keystone mod_wsgi VirtualHost configuration for keystone_wsgi_main and keystone_wsgi_admin?  Or is this meant to work with Keystone using eventlet?  Or both eventlet and wsgi?\n\nWhat about the keystone.conf configuration?\nDoes this require setting federation driver keystone.contrib.federation.backends.sql.Federation?\nauth methods external,password,token,saml2?\nauth saml2 keystone.auth.plugins.mapped.Mapped?\nAdding federation_extension before service_v3 in the pipeline:api_v3 pipeline in keystone-paste.ini?\n\nDoes this require keystone-manage db_sync --extension federation?\n\nWhat about websso/horizon integration?\n/etc/keystone/keystone.conf federation remote_id_attribute $IDPNAME\n/etc/keystone/keystone.conf federation trusted_dashboard http://horizon.host/auth/websso/\n\nWhat about creating a group of federated users e.g.::\n\n    # openstack group create admins\n\nWhat about creating the identity provider in keystone e.g.::\n\n    # openstack identity provider create --enable $name --remote-id https://idp.host/idp/saml2/metadata\n\nDo you need a mapping e.g.::\n\n    # openstack mapping create --rules ${idpname}_mapping.json ${idpname}_mapping\n    # openstack federation protocol create --identity-provider $idpname --mapping ${idpname}_mapping saml2\n\nIs there any other configuration required?","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"b6c83b49a270b1cef3d50f43f0d1267a609da2f0","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":"Keep these setups as they are right now: manually install packages and add"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_7d7e336b","line":93,"in_reply_to":"ba3cc151_2a7b8a8d","updated":"2015-07-02 14:39:17.000000000","message":"Ok.\n\n\u003e Regarding the extra steps, such as create a group to map the federated users, create a mapping and add the IdP/protocol is particular to each deploy - not sure if you want us to add the support to read such information from a file to perform this operations after the federation part is setup?\n\nIs it a necessary part of setting up Keystone to do federated authentication?  Or perhaps it is not necessary for Keystone-to-Keystone federation?\n\nI guess the plan is to have nothing in this bp that\u0027s not already mentioned in http://docs.openstack.org/developer/keystone/configure_federation.htm\nor\nhttp://docs.openstack.org/developer/keystone/extensions/shibboleth.html\nor\nhttp://docs.openstack.org/developer/keystone/extensions/openidc.html\n\nAnd, I need to get the Keystone guys to write up something about using mod_auth_mellon instead of shib or openid.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"ebf6f8a0e3f7145a8931c7388b9617ddd50318de","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":"Keep these setups as they are right now: manually install packages and add"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_2a7b8a8d","line":93,"in_reply_to":"ba3cc151_3bd814ef","updated":"2015-07-02 12:25:34.000000000","message":"Hi Richard, thanks for your comments.\n\nFor keystone to work as a service provider little is required to configure in the keystone side: just update the [auth] section of keystone.conf to add the SAML and/or OIDC auth handlers. Everything else is done in the Apache side (see the note on line 60) - Apache is *required* to have the federation feature in keystone and the eventlet support is being deprecated.\n\nSince Kilo, federation is no longer an extension, so we don\u0027t need to execute the db_sync step.\n\nIn the Identity Provider side (to work with keystone-to-keystone federation), we need basically two steps:\n\n  - configure the [saml] section of keystone.conf\n  - run a keystone-manage command to generate the metadata to be used in the SAML flow\n\nAbout WebSSO, we have several configurations to be made in Horizon + Keystone and I believe it fits another bp/spec.\n\nRegarding the extra steps, such as create a group to map the federated users, create a mapping and add the IdP/protocol is particular to each deploy - not sure if you want us to add the support to read such information from a file to perform this operations after the federation part is setup?","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"8674aa5aa251e1addf395f3c644e1da0467282d9","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":"Keep these setups as they are right now: manually install packages and add"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_c57f65de","line":93,"in_reply_to":"ba3cc151_5253196b","updated":"2015-07-02 15:27:06.000000000","message":"Ok, I see.  So it will be up to the higher level installer/composition layer to call the right puppet-keystone classes and resources to set up the domains/projects/users/groups and do whatever else is necessary to make federation work.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"32a0eceb3064e12bc07f4792e6746d6521027482","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":" Packages that will be installed: ``pysaml2`` and ``xmlsec1``."},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Alternatives"},{"line_number":95,"context_line":"------------"},{"line_number":96,"context_line":"Keep these setups as they are right now: manually install packages and add"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_5253196b","line":93,"in_reply_to":"ba3cc151_7d7e336b","updated":"2015-07-02 15:14:19.000000000","message":"The federation only \"works\" after the mapping/idp/protocol are created in the SP side and the sp resource is added in the IdP side. However I see these steps as part of the deploy itself - I mean, do we configure the domains/projects/users/groups during the regular keystone setup in puppet-keystone?","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fabb08240412a3576483d2b57e017e8731d3160a","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* For OpenID configuration see `Setup OpenID Connect \u003chttp://docs.openstack.org"},{"line_number":144,"context_line":"  /developer/keystone/extensions/openidc.html\u003e`_."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_db824894","line":145,"updated":"2015-06-30 22:32:46.000000000","message":"For mod_auth_mellon, see https://github.com/UNINETT/mod_auth_mellon\n\nI\u0027m not sure, but it looks as though the configuration for Keystone to use mod_auth_mellon is almost the same as to use mod_shib.","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"* For OpenID configuration see `Setup OpenID Connect \u003chttp://docs.openstack.org"},{"line_number":144,"context_line":"  /developer/keystone/extensions/openidc.html\u003e`_."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_073811ee","line":145,"in_reply_to":"ba3cc151_db824894","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"82e5125d32454383738000ff3f2fa4b6bef3a1c8","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Dependencies"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* The Keystone version should be stable/kilo."},{"line_number":180,"context_line":"* Keystone needs to be configured to run over Apache server."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_ee78af91","line":179,"updated":"2015-06-30 21:34:15.000000000","message":"*at least*","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"b0ade5d228913b894afd0eb41df59c5447d785d1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"Dependencies"},{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"* The Keystone version should be stable/kilo."},{"line_number":180,"context_line":"* Keystone needs to be configured to run over Apache server."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba3cc151_4715b9e2","line":179,"in_reply_to":"ba3cc151_ee78af91","updated":"2015-07-02 14:14:53.000000000","message":"Done","commit_id":"cae4ba7a0613e6eda18bc443578369cbbfb83e06"}],"specs/liberty/enabling-federation.rst":[{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Introduce two new classes, one to configure the Keystone as a Service Provider"},{"line_number":32,"context_line":"and the other to configure as an Identity Provider."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Service Provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_c14aa255","line":31,"updated":"2015-07-17 04:16:51.000000000","message":"no the: \"configure the Keystone\" -\u003e \"configure Keystone\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Introduce two new classes, one to configure the Keystone as a Service Provider"},{"line_number":32,"context_line":"and the other to configure as an Identity Provider."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Service Provider"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_e703240c","line":31,"in_reply_to":"9a41bdd9_c14aa255","updated":"2015-07-17 12:42:59.000000000","message":"Done","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Introduce two new classes, one to configure the Keystone as a Service Provider"},{"line_number":32,"context_line":"and the other to configure as an Identity Provider."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_81733ab4","line":32,"updated":"2015-07-17 04:16:51.000000000","message":"add Keystone: \"configure as an\" -\u003e \"configure Keystone as an\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Introduce two new classes, one to configure the Keystone as a Service Provider"},{"line_number":32,"context_line":"and the other to configure as an Identity Provider."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_1c03fb10","line":32,"in_reply_to":"9a41bdd9_81733ab4","updated":"2015-07-17 12:42:59.000000000","message":"Done","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Performance Impact"},{"line_number":111,"context_line":"------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_5ea3cd4f","line":110,"updated":"2015-07-17 04:16:51.000000000","message":"\"Performance impact\" change to a little i to match the other headings","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"None"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Performance Impact"},{"line_number":111,"context_line":"------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_673e34ba","line":110,"in_reply_to":"9a41bdd9_5ea3cd4f","updated":"2015-07-17 12:42:59.000000000","message":"Hello Toby, thanks for the review.\nAbout change to \"i\" to match the other headings, i\u0027ve followed the template in https://github.com/openstack/puppet-openstack-specs/blob/master/specs/template.rst","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  iurygregory"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Work Items"},{"line_number":161,"context_line":"----------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Create a class for Identity Provider configuration which will going to apply"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_1e86a5b9","line":160,"updated":"2015-07-17 04:16:51.000000000","message":"lowercase i: \"items\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":157,"context_line":"  iurygregory"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Work Items"},{"line_number":161,"context_line":"----------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Create a class for Identity Provider configuration which will going to apply"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_47dbf0ed","line":160,"in_reply_to":"9a41bdd9_1e86a5b9","updated":"2015-07-17 12:42:59.000000000","message":"Same comment about \"Performance Impact\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Work Items"},{"line_number":161,"context_line":"----------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Create a class for Identity Provider configuration which will going to apply"},{"line_number":164,"context_line":"  the extra configurations to Keystone configuration file and install all"},{"line_number":165,"context_line":"  necessary packages."},{"line_number":166,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_3e6cc907","line":163,"updated":"2015-07-17 04:16:51.000000000","message":"add \"the\": \"Create a class for Identity\" -\u003e \"Create a class for the Identity\"\n\nreword: \"which will going to apply\" -\u003e \"which will apply\" or \"which is going to apply\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":160,"context_line":"Work Items"},{"line_number":161,"context_line":"----------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Create a class for Identity Provider configuration which will going to apply"},{"line_number":164,"context_line":"  the extra configurations to Keystone configuration file and install all"},{"line_number":165,"context_line":"  necessary packages."},{"line_number":166,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_0762c8d8","line":163,"in_reply_to":"9a41bdd9_3e6cc907","updated":"2015-07-17 12:42:59.000000000","message":"Done","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":161,"context_line":"----------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Create a class for Identity Provider configuration which will going to apply"},{"line_number":164,"context_line":"  the extra configurations to Keystone configuration file and install all"},{"line_number":165,"context_line":"  necessary packages."},{"line_number":166,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."},{"line_number":167,"context_line":"* Create a class for Service Provider and acording to the protocol apply the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_be80d98c","line":164,"updated":"2015-07-17 04:16:51.000000000","message":"add \"the\": \"configurations to Keystone\" -\u003e \"configurations to the Keystone\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":161,"context_line":"----------"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"* Create a class for Identity Provider configuration which will going to apply"},{"line_number":164,"context_line":"  the extra configurations to Keystone configuration file and install all"},{"line_number":165,"context_line":"  necessary packages."},{"line_number":166,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."},{"line_number":167,"context_line":"* Create a class for Service Provider and acording to the protocol apply the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_e7a564b5","line":164,"in_reply_to":"9a41bdd9_be80d98c","updated":"2015-07-17 12:42:59.000000000","message":"Done","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  the extra configurations to Keystone configuration file and install all"},{"line_number":165,"context_line":"  necessary packages."},{"line_number":166,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."},{"line_number":167,"context_line":"* Create a class for Service Provider and acording to the protocol apply the"},{"line_number":168,"context_line":"  necessary configuration."},{"line_number":169,"context_line":"* Write tests to ensure that the Service Provider configuration is valid for"},{"line_number":170,"context_line":"  both protocols (SAML2 and OpenID)"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_1e5b0556","line":167,"updated":"2015-07-17 04:16:51.000000000","message":"add \"a\": \"for Service Provider\" -\u003e \"for a Service Provider\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":164,"context_line":"  the extra configurations to Keystone configuration file and install all"},{"line_number":165,"context_line":"  necessary packages."},{"line_number":166,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."},{"line_number":167,"context_line":"* Create a class for Service Provider and acording to the protocol apply the"},{"line_number":168,"context_line":"  necessary configuration."},{"line_number":169,"context_line":"* Write tests to ensure that the Service Provider configuration is valid for"},{"line_number":170,"context_line":"  both protocols (SAML2 and OpenID)"}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_8734984a","line":167,"in_reply_to":"9a41bdd9_1e5b0556","updated":"2015-07-17 12:42:59.000000000","message":"Done","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Testing"},{"line_number":180,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"* Create rb files for each configuration Identity/Service Provider to ensure"},{"line_number":183,"context_line":"  that all the required packages have been installed and that all applied"},{"line_number":184,"context_line":"  settings are valid."},{"line_number":185,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_01688ab9","line":182,"updated":"2015-07-17 04:16:51.000000000","message":"How about \"Create rb files\" -\u003e \"Create spec tests\" ?\n\nmissing something here.. how about: \"for each configurable parameter used by the new Identity/Service Provider classes\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":179,"context_line":"Testing"},{"line_number":180,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"* Create rb files for each configuration Identity/Service Provider to ensure"},{"line_number":183,"context_line":"  that all the required packages have been installed and that all applied"},{"line_number":184,"context_line":"  settings are valid."},{"line_number":185,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_27f90c4e","line":182,"in_reply_to":"9a41bdd9_01688ab9","updated":"2015-07-17 12:42:59.000000000","message":"Updating","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15313,"name":"Toby Oxborrow","email":"tobyox@cisco.com","username":"toby.oxborrow"},"change_message_id":"a60ebc0f775ed0ad8d973d55d0553f20f0f20193","unresolved":false,"context_lines":[{"line_number":184,"context_line":"  settings are valid."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Add examples in the Puppet-Keystone repository for both classes."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_fe88a1c8","line":187,"updated":"2015-07-17 04:16:51.000000000","message":"lowercase i: \"impact\"","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7705e1e79006f3af590701940442f50848f30fec","unresolved":false,"context_lines":[{"line_number":184,"context_line":"  settings are valid."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Documentation Impact"},{"line_number":188,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"Add examples in the Puppet-Keystone repository for both classes."}],"source_content_type":"text/x-rst","patch_set":13,"id":"9a41bdd9_67ff1435","line":187,"in_reply_to":"9a41bdd9_fe88a1c8","updated":"2015-07-17 12:42:59.000000000","message":"Same comment about Performance Impact","commit_id":"b02d427644820bb24bb4c9eccac7eb7989f4fab8"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"fe91a2a4b86a6384397d8e36711e52f3e9ae5da1","unresolved":false,"context_lines":[{"line_number":167,"context_line":"* Create a class for a Service Provider and acording to the protocol apply the"},{"line_number":168,"context_line":"  necessary configuration."},{"line_number":169,"context_line":"* Write tests to ensure that the Service Provider configuration is valid for"},{"line_number":170,"context_line":"  both modules (Shibboleth, Melon and OpenID)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a50d1a3_604aa385","line":170,"updated":"2015-07-20 15:09:06.000000000","message":"Mellon","commit_id":"61c89853f1ee24370114935a4a46eb9fb05edf1f"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3132320094577781dd346f3d362eaa943e7bff2d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"* Create a class for a Service Provider and acording to the protocol apply the"},{"line_number":168,"context_line":"  necessary configuration."},{"line_number":169,"context_line":"* Write tests to ensure that the Service Provider configuration is valid for"},{"line_number":170,"context_line":"  both modules (Shibboleth, Melon and OpenID)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Dependencies"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3a50d1a3_5b2bd830","line":170,"in_reply_to":"3a50d1a3_604aa385","updated":"2015-07-20 15:17:19.000000000","message":"Done","commit_id":"61c89853f1ee24370114935a4a46eb9fb05edf1f"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c20b75750cb5c141cf7f41c1453cf6f5738bba74","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" - idps_urls                  (None):"},{"line_number":43,"context_line":"   A list containg all the Identity Providers urls. All urls are in format"},{"line_number":44,"context_line":"   \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":45,"context_line":"   and Apache."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a50d1a3_3760d4a4","line":42,"updated":"2015-07-22 18:24:54.000000000","message":"Does a default value of (None) translate to a default value of undef, or no default (i.e. required), or actually the string \u0027None\u0027? Please clarify in this spec.","commit_id":"53a79db113785b8a65f677ea1a3962b895ea4be8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"80c95ee35c10b4952e170c8e5ab12ab76984b639","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" - idps_urls                  (None):"},{"line_number":43,"context_line":"   A list containg all the Identity Providers urls. All urls are in format"},{"line_number":44,"context_line":"   \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":45,"context_line":"   and Apache."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a50d1a3_b7ddc4e1","line":42,"in_reply_to":"3a50d1a3_3760d4a4","updated":"2015-07-22 18:31:18.000000000","message":"my intention is to say that there is no default value, so i\u0027ve put None","commit_id":"53a79db113785b8a65f677ea1a3962b895ea4be8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f749b5ac584778f6b0d2bf7842b79d4d67c78fe0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" - idps_urls                  (None):"},{"line_number":43,"context_line":"   A list containg all the Identity Providers urls. All urls are in format"},{"line_number":44,"context_line":"   \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":45,"context_line":"   and Apache."}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a50d1a3_49894874","line":42,"in_reply_to":"3a50d1a3_b7ddc4e1","updated":"2015-07-22 18:39:02.000000000","message":"I\u0027ll send a patch tonight","commit_id":"53a79db113785b8a65f677ea1a3962b895ea4be8"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c20b75750cb5c141cf7f41c1453cf6f5738bba74","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Deployer impact"},{"line_number":116,"context_line":"---------------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"This feature should be enabled when running puppet-keystone."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"The examples of configurations are in the links of this section."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a50d1a3_97fe88ac","line":118,"updated":"2015-07-22 18:24:54.000000000","message":"Enabled by default? That seems unexpected","commit_id":"53a79db113785b8a65f677ea1a3962b895ea4be8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"80c95ee35c10b4952e170c8e5ab12ab76984b639","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Deployer impact"},{"line_number":116,"context_line":"---------------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"This feature should be enabled when running puppet-keystone."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"The examples of configurations are in the links of this section."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3a50d1a3_f7410c64","line":118,"in_reply_to":"3a50d1a3_97fe88ac","updated":"2015-07-22 18:31:18.000000000","message":"I mean that the user(cloud_admin/cloud operator) should configure the *site.pp* with the class (IdP or SP), like when using ldap.","commit_id":"53a79db113785b8a65f677ea1a3962b895ea4be8"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"489ffd5e7124fff9b7d3eb34e3c30d9fbe22b184","unresolved":false,"context_lines":[{"line_number":119,"context_line":"Deployer impact"},{"line_number":120,"context_line":"---------------------"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"This feature should be enabled when running puppet-keystone."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"The examples of configurations are in the links of this section."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":16,"id":"3a50d1a3_f5d42c48","line":122,"updated":"2015-07-24 16:28:04.000000000","message":"Iury, I think an example like the one you provided in the last patch should be added here for clarification.","commit_id":"7b8a9479a20335528128bf28d46b5872ab35c3a2"},{"author":{"_account_id":6804,"name":"bruce-benjamin","email":"bruce.benjamin@jhuapl.edu","username":"bruce-benjamin"},"change_message_id":"62ac685a84b4207763f34989653ed1e67ef19b56","unresolved":false,"context_lines":[{"line_number":124,"context_line":"---------------------"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"To use this the modules from this feature the cloud operator/admin will need"},{"line_number":127,"context_line":"to apply during or after Keystone is installed and running over apache."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"The examples of configurations added to Keystone and Apache:"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"3a50d1a3_bb169553","line":127,"updated":"2015-07-24 17:26:48.000000000","message":"Iury, you\u0027re still missing something here.  I though that you were going to mention the example of configuring *site.pp* with the class (IdP or SP), unless you have a better example.","commit_id":"1c278be8f4f47ae6127c9d0e2d1ca339755ba5f4"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"91817e82366654425b7e4d621624cbdecbdfa7ab","unresolved":false,"context_lines":[{"line_number":56,"context_line":" file. Currently Keystone can only provide SAML assertions."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":" - idp_entity_id                  (None)"},{"line_number":62,"context_line":" - idp_sso_endpoint               (None)"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3a50d1a3_cfc078e3","line":59,"updated":"2015-07-24 20:00:14.000000000","message":"When I commented about the idps_urls (None) parameter I meant it to apply to all the (None) values here. I still see no explanation of whether (None) means \"no value provided, therefore the parameter is required\" or \"undef is the default value and the parameter is optional\" or \"the default value is the string \u0027None\u0027","commit_id":"161eaac9e12809f2ab904dd7d02c7430faf50805"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"6939a7a4767cdc914a83ec88cfab0ed5d0e3de1f","unresolved":false,"context_lines":[{"line_number":56,"context_line":" file. Currently Keystone can only provide SAML assertions."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":" This class will have the following attributes, default values inside \"()\":"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":" - idp_entity_id                  (None)"},{"line_number":62,"context_line":" - idp_sso_endpoint               (None)"}],"source_content_type":"text/x-rst","patch_set":18,"id":"3a50d1a3_d2ed7b26","line":59,"in_reply_to":"3a50d1a3_cfc078e3","updated":"2015-07-24 20:06:02.000000000","message":"I\u0027m not sure how to handle this.  I don\u0027t think it makes sense to just copy \"Table 7.28. Description of SAML configuration options\" from http://docs.openstack.org/kilo/config-reference/content/keystone-configuration-file.html. \n\nIs there a better way to say \"refer to Table 7.28. Description of SAML configuration options at http://docs.openstack.org/kilo/config-reference/content/keystone-configuration-file.html for more information about IdP attributes\"?","commit_id":"161eaac9e12809f2ab904dd7d02c7430faf50805"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fb714018d485504f264403cfe21dbd1afc699923","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":37,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"},{"line_number":38,"context_line":" configuration will be applied according to the module chosen."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":" This class will have the following attributes:"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_9e7119ab","line":37,"updated":"2015-07-27 09:37:30.000000000","message":"OpenID is protocol name, Shibbolet and Melon are modules for handling SAML2 (protocol). DOn\u0027t mix modules with protocol.","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"9d83b89cf35dfd839569ed8ebf7a1fbc8061bfab","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":37,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"},{"line_number":38,"context_line":" configuration will be applied according to the module chosen."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":" This class will have the following attributes:"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_e5caf34e","line":37,"in_reply_to":"3a50d1a3_9e7119ab","updated":"2015-07-27 17:28:50.000000000","message":"Right.  Instead, take a look how it is described here: http://docs.openstack.org/developer/keystone/configure_federation.html\n\n\"Keystone currently supports two major federation protocols: SAML (with support for the Shibboleth and Mellon implementations), and OpenID Connect.\"","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd63f746da922db55c763242d89284200437dcf4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":37,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"},{"line_number":38,"context_line":" configuration will be applied according to the module chosen."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":" This class will have the following attributes:"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_19bc03ba","line":37,"in_reply_to":"3a50d1a3_e5caf34e","updated":"2015-07-28 12:48:21.000000000","message":"Thanks I\u0027ll update","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fb714018d485504f264403cfe21dbd1afc699923","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    The name of the apache module to install. This will be used to guide the"},{"line_number":50,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":51,"context_line":"    attribute should be the name of one of the modules available. Available"},{"line_number":52,"context_line":"    modules names are: shibboleth, mellon and openid."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* New class: Identity Provider"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_feb93d2f","line":52,"updated":"2015-07-27 09:37:30.000000000","message":"what if I write my own Apache modules handling OpenID connect? Are we going to name it openid2 ?","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd63f746da922db55c763242d89284200437dcf4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    The name of the apache module to install. This will be used to guide the"},{"line_number":50,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":51,"context_line":"    attribute should be the name of one of the modules available. Available"},{"line_number":52,"context_line":"    modules names are: shibboleth, mellon and openid."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* New class: Identity Provider"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_190ac38a","line":52,"in_reply_to":"3a50d1a3_feb93d2f","updated":"2015-07-28 12:48:21.000000000","message":"Well I really don\u0027t know how we can handle this, do you have any idea?","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fb714018d485504f264403cfe21dbd1afc699923","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":51,"context_line":"    attribute should be the name of one of the modules available. Available"},{"line_number":52,"context_line":"    modules names are: shibboleth, mellon and openid."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* New class: Identity Provider"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" Class to configure Keystone as an Identity Provider, by installing the"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_1ee3c934","line":53,"updated":"2015-07-27 09:37:30.000000000","message":"Lot\u0027s of params are missing - entityId of the SP, path of the metadata, some options whether we enable ECP or not.","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd63f746da922db55c763242d89284200437dcf4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":51,"context_line":"    attribute should be the name of one of the modules available. Available"},{"line_number":52,"context_line":"    modules names are: shibboleth, mellon and openid."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* New class: Identity Provider"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" Class to configure Keystone as an Identity Provider, by installing the"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_d9ff7b64","line":53,"in_reply_to":"3a50d1a3_1ee3c934","updated":"2015-07-28 12:48:21.000000000","message":"You say about the params in the keystone.conf or in the configuration of each protocol and module?","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"86e7ea9b96f6c1ca8ec4af626dee589061bd4689","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":51,"context_line":"    attribute should be the name of one of the modules available. Available"},{"line_number":52,"context_line":"    modules names are: shibboleth, mellon and openid."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"* New class: Identity Provider"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" Class to configure Keystone as an Identity Provider, by installing the"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_0b64a2b6","line":53,"in_reply_to":"3a50d1a3_d9ff7b64","updated":"2015-07-28 14:37:27.000000000","message":"I\u0027ll put keystone parameters and the entityId and metadata url. About enable ECP or not, when using Shibboleth the ECP is enable by default.","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"fb714018d485504f264403cfe21dbd1afc699923","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"``site.pp`` example - Keystone as a Service Provider using Mellon::"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":" class { \u0027keystone::service_provider\u0027:"},{"line_number":155,"context_line":"  idps_urls \u003d\u003e \u0027https://ipa.rdodom.test/idp\u0027,"},{"line_number":156,"context_line":"  saml_dir \u003d\u003e \u0027/etc/httpd/saml2/test\u0027,"},{"line_number":157,"context_line":"  http_conf \u003d\u003e \u0027/etc/httpd/conf.d/keystone-mellon.conf\u0027,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_7eabed89","line":154,"updated":"2015-07-27 09:37:30.000000000","message":"what entityId (Service Provider identification in Identity Provider - it\u0027s usually something like http://service-provider.domain.local/shibboleth in Shib\u0027s case) is going to be set there ?","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bd63f746da922db55c763242d89284200437dcf4","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"``site.pp`` example - Keystone as a Service Provider using Mellon::"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":" class { \u0027keystone::service_provider\u0027:"},{"line_number":155,"context_line":"  idps_urls \u003d\u003e \u0027https://ipa.rdodom.test/idp\u0027,"},{"line_number":156,"context_line":"  saml_dir \u003d\u003e \u0027/etc/httpd/saml2/test\u0027,"},{"line_number":157,"context_line":"  http_conf \u003d\u003e \u0027/etc/httpd/conf.d/keystone-mellon.conf\u0027,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_df5bdb84","line":154,"in_reply_to":"3a50d1a3_7eabed89","updated":"2015-07-28 12:48:21.000000000","message":"This example is to setup a SP, i think enityId for the Service Provider is used when we create the SP in the IdP","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"86e7ea9b96f6c1ca8ec4af626dee589061bd4689","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"``site.pp`` example - Keystone as a Service Provider using Mellon::"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":" class { \u0027keystone::service_provider\u0027:"},{"line_number":155,"context_line":"  idps_urls \u003d\u003e \u0027https://ipa.rdodom.test/idp\u0027,"},{"line_number":156,"context_line":"  saml_dir \u003d\u003e \u0027/etc/httpd/saml2/test\u0027,"},{"line_number":157,"context_line":"  http_conf \u003d\u003e \u0027/etc/httpd/conf.d/keystone-mellon.conf\u0027,"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3a50d1a3_0bd6e24e","line":154,"in_reply_to":"3a50d1a3_df5bdb84","updated":"2015-07-28 14:37:27.000000000","message":"My mistake for shibboleth whe really have in shibboleth2.xml the entityId","commit_id":"f63f5f7c3650509693294ded7d4ae1a1663941be"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"b583eab15de8cd9bcfb5330d684f2234162d7d95","unresolved":false,"context_lines":[{"line_number":46,"context_line":" * Required"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  - entityID:"},{"line_number":49,"context_line":"    The Service Provider url."},{"line_number":50,"context_line":"  - idps_urls:"},{"line_number":51,"context_line":"    A list containg all the Identity Providers urls. All urls are in format"},{"line_number":52,"context_line":"    \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a50d1a3_068ed72d","line":49,"updated":"2015-07-28 15:01:14.000000000","message":"With mellon, the entityID doesn\u0027t have to be the SP url, but that is recommended value to use.\n\nI have no idea about OpenID.","commit_id":"97007c5d21ee8340bfa482b33e9273679e720239"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f53906e81b3992536d14f339d0d8959fac43a621","unresolved":false,"context_lines":[{"line_number":46,"context_line":" * Required"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  - entityID:"},{"line_number":49,"context_line":"    The Service Provider url."},{"line_number":50,"context_line":"  - idps_urls:"},{"line_number":51,"context_line":"    A list containg all the Identity Providers urls. All urls are in format"},{"line_number":52,"context_line":"    \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a50d1a3_fca01af6","line":49,"in_reply_to":"3a50d1a3_068ed72d","updated":"2015-07-28 15:21:18.000000000","message":"Ok, according to this site (https://spaces.internet2.edu/display/InCFederation/Entity+IDs) I think entityId only apply to SAML protocol, i have looked at http://docs.openstack.org/developer/keystone/federation/openidc.html and does\u0027t seems to need.","commit_id":"97007c5d21ee8340bfa482b33e9273679e720239"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"b583eab15de8cd9bcfb5330d684f2234162d7d95","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  - metadata_urls:"},{"line_number":55,"context_line":"    A list containg one metadata_url for each Identity Provider in idps_urls."},{"line_number":56,"context_line":"  - protocol:"},{"line_number":57,"context_line":"    The protocol that will be used in"},{"line_number":58,"context_line":"  - module:"},{"line_number":59,"context_line":"    The name of the apache module to install. This will be used to guide the"},{"line_number":60,"context_line":"    installation and configuration of a Service Provider. The value of this"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a50d1a3_c69a2f62","line":57,"updated":"2015-07-28 15:01:14.000000000","message":"Is this incomplete?  It looks like there should be more here?","commit_id":"97007c5d21ee8340bfa482b33e9273679e720239"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f53906e81b3992536d14f339d0d8959fac43a621","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  - metadata_urls:"},{"line_number":55,"context_line":"    A list containg one metadata_url for each Identity Provider in idps_urls."},{"line_number":56,"context_line":"  - protocol:"},{"line_number":57,"context_line":"    The protocol that will be used in"},{"line_number":58,"context_line":"  - module:"},{"line_number":59,"context_line":"    The name of the apache module to install. This will be used to guide the"},{"line_number":60,"context_line":"    installation and configuration of a Service Provider. The value of this"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a50d1a3_9ca1d6f9","line":57,"in_reply_to":"3a50d1a3_c69a2f62","updated":"2015-07-28 15:21:18.000000000","message":"Done","commit_id":"97007c5d21ee8340bfa482b33e9273679e720239"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"69d636be8d68dbe6ea01328f363a9c8277723bf3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As a cloud administrator, I want a fast and convenient way to configure my"},{"line_number":23,"context_line":"Keystone (Kilo version or newer) as a Service Provider or as an Identity"},{"line_number":24,"context_line":"Provider. Nowadays adding extra configurations can be cumbersome and is error"},{"line_number":25,"context_line":"prone."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_b14126ab","line":24,"updated":"2015-07-29 13:45:11.000000000","message":"maybe something like: Nowadays, the manual configuration of such features can be cumbersome and error prone.","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c321c5e8948b3fea33e1528302dc002e61076003","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As a cloud administrator, I want a fast and convenient way to configure my"},{"line_number":23,"context_line":"Keystone (Kilo version or newer) as a Service Provider or as an Identity"},{"line_number":24,"context_line":"Provider. Nowadays adding extra configurations can be cumbersome and is error"},{"line_number":25,"context_line":"prone."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_1d834b04","line":24,"in_reply_to":"3a50d1a3_b14126ab","updated":"2015-07-29 14:39:41.000000000","message":"Done","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"69d636be8d68dbe6ea01328f363a9c8277723bf3","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the protocol"},{"line_number":37,"context_line":" chosen between OpenID and SAML, if SAML is chosen it\u0027s necessary to select"},{"line_number":38,"context_line":" the module that will be used(Shibboleth or Mellon). Packages and extra"},{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":41,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_51e222d6","line":38,"updated":"2015-07-29 13:45:11.000000000","message":"add space here:\n\nused (Shibboleth or Mellon)","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c321c5e8948b3fea33e1528302dc002e61076003","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the protocol"},{"line_number":37,"context_line":" chosen between OpenID and SAML, if SAML is chosen it\u0027s necessary to select"},{"line_number":38,"context_line":" the module that will be used(Shibboleth or Mellon). Packages and extra"},{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":41,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_dd5ba352","line":38,"in_reply_to":"3a50d1a3_51e222d6","updated":"2015-07-29 14:39:41.000000000","message":"Done","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"69d636be8d68dbe6ea01328f363a9c8277723bf3","unresolved":false,"context_lines":[{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":41,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"},{"line_number":42,"context_line":" configuration will be applied according to the module chosen."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":" This class will have the following attributes:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_d18632b8","line":42,"updated":"2015-07-29 13:45:11.000000000","message":"The 3 last sentences are repeating basically the same thing, they are even using the same expressions: \"according to the module chosen\".","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c321c5e8948b3fea33e1528302dc002e61076003","unresolved":false,"context_lines":[{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":" Class to configure Keystone as a Service Provider, according to the Apache"},{"line_number":41,"context_line":" module chosen (Shibboleth, OpenID or Mellon). Packages and extra"},{"line_number":42,"context_line":" configuration will be applied according to the module chosen."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":" This class will have the following attributes:"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_bd601702","line":42,"in_reply_to":"3a50d1a3_d18632b8","updated":"2015-07-29 14:39:41.000000000","message":"Done","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"69d636be8d68dbe6ea01328f363a9c8277723bf3","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":".. note::"},{"line_number":121,"context_line":"  There are some packages that need to be installed. For example, in a Debian/"},{"line_number":122,"context_line":"  Ubuntu distribution, ``libapache2-mod-(shib2,auth-openidc,auth-mellon)`` is"},{"line_number":123,"context_line":"  required for the Service Provider, ``pysaml2`` and ``xmlsec1`` for the"},{"line_number":124,"context_line":"  Identity Provider."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_1c42710f","line":122,"updated":"2015-07-29 13:45:11.000000000","message":"maybe something like:\n\nFor the Service Provider, there are some required packages that need to be installed. For example, in a Debian based distribution: the packages libapache2-mod-shib2 or libapache2-auth-mellon for SAML2 support or  libapache2-auth-openidc for OpenID Connect support.\n\nAnd you add a second note talking about the packages required for the IdP.","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c321c5e8948b3fea33e1528302dc002e61076003","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":".. note::"},{"line_number":121,"context_line":"  There are some packages that need to be installed. For example, in a Debian/"},{"line_number":122,"context_line":"  Ubuntu distribution, ``libapache2-mod-(shib2,auth-openidc,auth-mellon)`` is"},{"line_number":123,"context_line":"  required for the Service Provider, ``pysaml2`` and ``xmlsec1`` for the"},{"line_number":124,"context_line":"  Identity Provider."},{"line_number":125,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"3a50d1a3_fd41bf63","line":122,"in_reply_to":"3a50d1a3_1c42710f","updated":"2015-07-29 14:39:41.000000000","message":"Done","commit_id":"f73bdad708b37e16892af823954bb87bc8e58f7d"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"3a12d7afce3b3c4ca56639dbba84c12b7d9da90a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a fast way for cloud administrators to"},{"line_number":16,"context_line":"configure their Keystone as a Service Provider or Identity Provider in order to"},{"line_number":17,"context_line":"use Federation."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_29aed898","line":17,"updated":"2015-07-30 12:39:39.000000000","message":"Identity Federation","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b15dd987d2f432d0a83db8e283cbd031ebe988c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a fast way for cloud administrators to"},{"line_number":16,"context_line":"configure their Keystone as a Service Provider or Identity Provider in order to"},{"line_number":17,"context_line":"use Federation."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Problem description"},{"line_number":20,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_df1b621b","line":17,"in_reply_to":"3a50d1a3_29aed898","updated":"2015-07-30 13:04:30.000000000","message":"Done","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7434504011114905b65d4c76416c2d8d993d449c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the protocol"},{"line_number":37,"context_line":" chosen between OpenID and SAML, if SAML is chosen it\u0027s necessary to select"},{"line_number":38,"context_line":" the module that will be used (Shibboleth or Mellon). Packages and extra"},{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_b7c9ef7b","line":37,"updated":"2015-07-30 07:18:01.000000000","message":"OpenID Connect\n\n(OpenID is different from OpenID Connect)","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"3a12d7afce3b3c4ca56639dbba84c12b7d9da90a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the protocol"},{"line_number":37,"context_line":" chosen between OpenID and SAML, if SAML is chosen it\u0027s necessary to select"},{"line_number":38,"context_line":" the module that will be used (Shibboleth or Mellon). Packages and extra"},{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_c9cc148d","line":37,"in_reply_to":"3a50d1a3_b7c9ef7b","updated":"2015-07-30 12:39:39.000000000","message":"++","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b15dd987d2f432d0a83db8e283cbd031ebe988c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* New class: Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Class to configure Keystone as a Service Provider, according to the protocol"},{"line_number":37,"context_line":" chosen between OpenID and SAML, if SAML is chosen it\u0027s necessary to select"},{"line_number":38,"context_line":" the module that will be used (Shibboleth or Mellon). Packages and extra"},{"line_number":39,"context_line":" configuration will be applied according to the protocol and module chosen."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_1f71caa8","line":37,"in_reply_to":"3a50d1a3_c9cc148d","updated":"2015-07-30 13:04:30.000000000","message":"Done","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7434504011114905b65d4c76416c2d8d993d449c","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. note::"},{"line_number":118,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":119,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages"},{"line_number":120,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":121,"context_line":"  or ``libapache2-auth-openidc`` for OpenID COnnect support."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_b7e24f00","line":119,"updated":"2015-07-30 07:18:01.000000000","message":"Ubuntu is a Debian based distribution, there are others so you can either cite some more here or just say \"in a Debian based distribution\"","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b15dd987d2f432d0a83db8e283cbd031ebe988c","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. note::"},{"line_number":118,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":119,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages"},{"line_number":120,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":121,"context_line":"  or ``libapache2-auth-openidc`` for OpenID COnnect support."},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_3f9926d1","line":119,"in_reply_to":"3a50d1a3_b7e24f00","updated":"2015-07-30 13:04:30.000000000","message":"Done","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7434504011114905b65d4c76416c2d8d993d449c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":119,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages"},{"line_number":120,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":121,"context_line":"  or ``libapache2-auth-openidc`` for OpenID COnnect support."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. note::"},{"line_number":124,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_77fe07b0","line":121,"updated":"2015-07-30 07:18:01.000000000","message":"s/COnnect/Connect","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b15dd987d2f432d0a83db8e283cbd031ebe988c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":119,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages"},{"line_number":120,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":121,"context_line":"  or ``libapache2-auth-openidc`` for OpenID COnnect support."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":".. note::"},{"line_number":124,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_5f9e72b9","line":121,"in_reply_to":"3a50d1a3_77fe07b0","updated":"2015-07-30 13:04:30.000000000","message":"Done","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"3a12d7afce3b3c4ca56639dbba84c12b7d9da90a","unresolved":false,"context_lines":[{"line_number":123,"context_line":".. note::"},{"line_number":124,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":125,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":126,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. note::"},{"line_number":129,"context_line":"   The apache packages required for the Service Provider will be installed"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_a9bf48a9","line":126,"updated":"2015-07-30 12:39:39.000000000","message":"so why not enforce it in your Puppet module?","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1b15dd987d2f432d0a83db8e283cbd031ebe988c","unresolved":false,"context_lines":[{"line_number":123,"context_line":".. note::"},{"line_number":124,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":125,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":126,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":".. note::"},{"line_number":129,"context_line":"   The apache packages required for the Service Provider will be installed"}],"source_content_type":"text/x-rst","patch_set":22,"id":"3a50d1a3_ff23be56","line":126,"in_reply_to":"3a50d1a3_a9bf48a9","updated":"2015-07-30 13:04:30.000000000","message":"It will be enforced in the module.","commit_id":"2a1261d25340347c0cbcdae244b586ed221b618e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3703fb38ab27ae7f9071915f83376d942df2de3e","unresolved":false,"context_lines":[{"line_number":37,"context_line":" using OpenID Connect or SAML as the protocol. For each way to configure we"},{"line_number":38,"context_line":" will have a  puppet class with the proper attributes."},{"line_number":39,"context_line":" Packages and extra configuration will be applied according to the choice"},{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_d35b6a53","line":40,"updated":"2015-08-03 19:40:18.000000000","message":"Would be nice to provide external references. Are they Apache 2 licensed?","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"c9263e39ac9e93b3e8a8dfa159d856d6674ba64a","unresolved":false,"context_lines":[{"line_number":37,"context_line":" using OpenID Connect or SAML as the protocol. For each way to configure we"},{"line_number":38,"context_line":" will have a  puppet class with the proper attributes."},{"line_number":39,"context_line":" Packages and extra configuration will be applied according to the choice"},{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_d6483830","line":40,"in_reply_to":"1a4dcd0f_d35b6a53","updated":"2015-08-03 19:46:10.000000000","message":"The references/links are provided in the spec starting at line 196.  Is this not sufficient?","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"694acd154078734312c5291585f30d5b411045e9","unresolved":false,"context_lines":[{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - entityID:"},{"line_number":46,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_13b0f2f3","line":43,"updated":"2015-08-03 19:37:41.000000000","message":"This should not be Shibboleth specific.","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c9e074757c0ecaa35fb4936362a86a7c8b298cd6","unresolved":false,"context_lines":[{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - entityID:"},{"line_number":46,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_16b9c0e9","line":43,"in_reply_to":"1a4dcd0f_13b0f2f3","updated":"2015-08-03 19:51:09.000000000","message":"Hi Richard,\nMy intention is just to provide an example of possible attributes for an option of Service Provider.","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"a43bf3a7f0e9a81e62437b582d7bed8bde003f4a","unresolved":false,"context_lines":[{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - entityID:"},{"line_number":46,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_d6c7d843","line":43,"in_reply_to":"1a4dcd0f_16b9c0e9","updated":"2015-08-03 19:54:57.000000000","message":"Ok.  Then please make it clear that this is an example.","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"dc956b3cdf97f680ff5a84ef289080c927162441","unresolved":false,"context_lines":[{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - entityID:"},{"line_number":46,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_76db641c","line":43,"in_reply_to":"1a4dcd0f_16b9c0e9","updated":"2015-08-03 19:56:03.000000000","message":"s/using Shibboleth/using Shibboleth or Mellon ?","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"f4bd57a223ff1c71b4bac5c6929d1cd768c83187","unresolved":false,"context_lines":[{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" When chosen to configure Keystone using Shibboleth we can have the"},{"line_number":43,"context_line":" following attributes:"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  - entityID:"},{"line_number":46,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1a4dcd0f_1640e055","line":43,"in_reply_to":"1a4dcd0f_76db641c","updated":"2015-08-03 20:07:25.000000000","message":"yes, then omit \"protocol\" because in that case the protocol will be SAML.","commit_id":"b0579c35613f49476e39013bbb94d984fdc34b98"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enabling Federation"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":":tags: federation, liberty"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"`bp enabling-federation \u003chttps://blueprints.launchpad.net/puppet-keystone/+spec"},{"line_number":13,"context_line":"/enabling-federation\u003e`_"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_c87ff964","line":10,"updated":"2015-08-04 19:03:34.000000000","message":"not sure liberty is useful to be part of tags","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Enabling Federation"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":":tags: federation, liberty"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"`bp enabling-federation \u003chttps://blueprints.launchpad.net/puppet-keystone/+spec"},{"line_number":13,"context_line":"/enabling-federation\u003e`_"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_546940bd","line":10,"in_reply_to":"1a4dcd0f_c87ff964","updated":"2015-08-04 20:27:19.000000000","message":"I\u0027ll remove in the next patch.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"`bp enabling-federation \u003chttps://blueprints.launchpad.net/puppet-keystone/+spec"},{"line_number":13,"context_line":"/enabling-federation\u003e`_"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a fast way for cloud administrators to"},{"line_number":16,"context_line":"configure their Keystone as a Service Provider or Identity Provider in order to"},{"line_number":17,"context_line":"use Identity Federation."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_e83755ae","line":15,"updated":"2015-08-04 19:03:34.000000000","message":"fast or efficient","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"`bp enabling-federation \u003chttps://blueprints.launchpad.net/puppet-keystone/+spec"},{"line_number":13,"context_line":"/enabling-federation\u003e`_"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a fast way for cloud administrators to"},{"line_number":16,"context_line":"configure their Keystone as a Service Provider or Identity Provider in order to"},{"line_number":17,"context_line":"use Identity Federation."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_3f8c8d7e","line":15,"in_reply_to":"1a4dcd0f_e83755ae","updated":"2015-08-04 20:27:19.000000000","message":"s/fast/efficient or add efficient?","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Keystone as a Service Provider can be configured in three different ways"},{"line_number":37,"context_line":" using OpenID Connect or SAML as the protocol. For each way to configure we"},{"line_number":38,"context_line":" will have a  puppet class with the proper attributes."},{"line_number":39,"context_line":" Packages and extra configuration will be applied according to the choice"},{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_08d72124","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":14},"updated":"2015-08-04 19:03:34.000000000","message":"two spaces between \u0027a\u0027 and \u0027puppet\u0027","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":" Keystone as a Service Provider can be configured in three different ways"},{"line_number":37,"context_line":" using OpenID Connect or SAML as the protocol. For each way to configure we"},{"line_number":38,"context_line":" will have a  puppet class with the proper attributes."},{"line_number":39,"context_line":" Packages and extra configuration will be applied according to the choice"},{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_74ab1cd7","line":38,"in_reply_to":"1a4dcd0f_08d72124","updated":"2015-08-04 20:27:19.000000000","message":"Done","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":57,"context_line":"    attribute should be the name of one of the modules available."},{"line_number":58,"context_line":"    Available modules name are: shibboleth and mellon."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Identity Provider"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":" There will be a class to configure Keystone as an Identity Provider, by"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_aee8757d","line":59,"updated":"2015-08-04 19:03:34.000000000","message":"I would like to document how you are going to implement the classes. ie: class name.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":57,"context_line":"    attribute should be the name of one of the modules available."},{"line_number":58,"context_line":"    Available modules name are: shibboleth and mellon."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Identity Provider"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":" There will be a class to configure Keystone as an Identity Provider, by"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_34eef4b4","line":59,"in_reply_to":"1a4dcd0f_aee8757d","updated":"2015-08-04 20:27:19.000000000","message":"service_provider","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":63,"context_line":" installing the necessary packages and adding the necessary configuration"},{"line_number":64,"context_line":" to the keystone.conf file. Currently Keystone can only provide SAML"},{"line_number":65,"context_line":" assertions."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":" As attributes for this class we can have:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_ceeb8177","line":66,"updated":"2015-08-04 19:03:34.000000000","message":"Same comment here.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":63,"context_line":" installing the necessary packages and adding the necessary configuration"},{"line_number":64,"context_line":" to the keystone.conf file. Currently Keystone can only provide SAML"},{"line_number":65,"context_line":" assertions."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":" As attributes for this class we can have:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_d42b10ea","line":66,"in_reply_to":"1a4dcd0f_ceeb8177","updated":"2015-08-04 20:27:19.000000000","message":"identity_provider","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":117,"context_line":"  For example, in a Debian based distribution: the packages"},{"line_number":118,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":119,"context_line":"  or ``libapache2-auth-openidc`` for OpenID Connect support."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":".. note::"},{"line_number":122,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_6b3b3fd2","line":119,"updated":"2015-08-04 19:03:34.000000000","message":"You\u0027ll use ensure_resource when declaring the packages, to make sure to avoid any duplicated resource if someone already defined this resource in the catalog.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":117,"context_line":"  For example, in a Debian based distribution: the packages"},{"line_number":118,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":119,"context_line":"  or ``libapache2-auth-openidc`` for OpenID Connect support."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":".. note::"},{"line_number":122,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_5a4087a5","line":119,"in_reply_to":"1a4dcd0f_6b3b3fd2","updated":"2015-08-04 20:27:19.000000000","message":"Ok","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":121,"context_line":".. note::"},{"line_number":122,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":123,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":124,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. note::"},{"line_number":127,"context_line":"   The apache packages required for the Service Provider will be installed"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_cb2373a6","line":124,"updated":"2015-08-04 19:03:34.000000000","message":"You\u0027ll use ensure_resource when declaring the packages, to make sure to avoid any duplicated resource if someone already defined this resource in the catalog.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":121,"context_line":".. note::"},{"line_number":122,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":123,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":124,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. note::"},{"line_number":127,"context_line":"   The apache packages required for the Service Provider will be installed"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_7a3b0339","line":124,"in_reply_to":"1a4dcd0f_cb2373a6","updated":"2015-08-04 20:27:19.000000000","message":"Ok","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":123,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":124,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. note::"},{"line_number":127,"context_line":"   The apache packages required for the Service Provider will be installed"},{"line_number":128,"context_line":"   using the defined type ``apache::mod`` from puppetlabs-apache, according"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_8bac8b36","line":125,"updated":"2015-08-04 19:03:34.000000000","message":"I also think they should be dependencies of Keystone packaging itself. Have you checked/contacted OpenStack packages maintainers to see if they already add these packages in dependency?","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":123,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":124,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. note::"},{"line_number":127,"context_line":"   The apache packages required for the Service Provider will be installed"},{"line_number":128,"context_line":"   using the defined type ``apache::mod`` from puppetlabs-apache, according"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_9fdda144","line":125,"in_reply_to":"1a4dcd0f_8bac8b36","updated":"2015-08-04 20:27:19.000000000","message":"I had to install this packages when installing the controller node and when using DevStack (both version Kilo)","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"``site.pp`` example - Keystone as a Service Provider using Mellon::"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":" class { \u0027keystone::mellon\u0027:"},{"line_number":167,"context_line":"  idps_urls \u003d\u003e \u0027https://ipa.rdodom.test/idp\u0027,"},{"line_number":168,"context_line":"  saml_dir \u003d\u003e \u0027/etc/httpd/saml2/test\u0027,"},{"line_number":169,"context_line":"  http_conf \u003d\u003e \u0027/etc/httpd/conf.d/keystone-mellon.conf\u0027,"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_2e59c55a","line":166,"updated":"2015-08-04 19:03:34.000000000","message":"I don\u0027t like that because to configure Mellon, we use some parameters that are common if we use another Service provider.\nI think we should rather create a class ::keystone::federation::service_provider with all parameters to configure a Service provider.\n\nSome of them will be useless when using a Service provider or another, but if we use undef, or OpenStack defaults, that\u0027s not a big deal.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"``site.pp`` example - Keystone as a Service Provider using Mellon::"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":" class { \u0027keystone::mellon\u0027:"},{"line_number":167,"context_line":"  idps_urls \u003d\u003e \u0027https://ipa.rdodom.test/idp\u0027,"},{"line_number":168,"context_line":"  saml_dir \u003d\u003e \u0027/etc/httpd/saml2/test\u0027,"},{"line_number":169,"context_line":"  http_conf \u003d\u003e \u0027/etc/httpd/conf.d/keystone-mellon.conf\u0027,"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_da2b37ea","line":166,"in_reply_to":"1a4dcd0f_2e59c55a","updated":"2015-08-04 20:27:19.000000000","message":"Done","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":197,"context_line":"  \u003chttp://docs.openstack.org/developer/keystone/federation/openidc.html\u003e`_."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* For mod_auth_mellon, see `Setup Mellon"},{"line_number":200,"context_line":"  \u003chttp://docs.openstack.org/developer/keystone/federation/mellon.html\u003e`_."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_191e9163","line":200,"updated":"2015-08-04 19:03:34.000000000","message":"We need to be clear here at how we will configure Apache.\n\n* How to configure Keystone to access to Service Provider? Creating ::keystone::wsgi::apache::service_provider? or using ::keystone::federation::service_provider (example here) and making sure it\u0027s configuring Apache? We also need to be flexible enough to support other webservers or systems (nginx, etc). So like Keystone WSGI support, we need to split the code.\n\n* Are you going to provide manifest to configure the providers themselves ? (ie: install OpenID server, etc). IMHO, it should not be the case, and up to the enduser composition layer.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":197,"context_line":"  \u003chttp://docs.openstack.org/developer/keystone/federation/openidc.html\u003e`_."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"* For mod_auth_mellon, see `Setup Mellon"},{"line_number":200,"context_line":"  \u003chttp://docs.openstack.org/developer/keystone/federation/mellon.html\u003e`_."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_5a4c0742","line":200,"in_reply_to":"1a4dcd0f_191e9163","updated":"2015-08-04 20:27:19.000000000","message":"I think we can use keystone::federation::service_provider and make sure the apache is configured. About the support for other webservers i\u0027ll check with Steve Martinelli tomorrow.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":233,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"* The Keystone version should be at least stable/kilo."},{"line_number":236,"context_line":"* Keystone needs to be configured to run over Apache server."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Testing"},{"line_number":239,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_f977259d","line":236,"updated":"2015-08-04 19:03:34.000000000","message":"how are going to do that? Are you going to use `require` ? We have to take care with that, and make sure the enduser can runs something else but Apache.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":233,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"* The Keystone version should be at least stable/kilo."},{"line_number":236,"context_line":"* Keystone needs to be configured to run over Apache server."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Testing"},{"line_number":239,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_5f5f1941","line":236,"in_reply_to":"1a4dcd0f_f977259d","updated":"2015-08-04 20:27:19.000000000","message":"I\u0027ll double check if the use of apache is mandatory for Federation (for K2K is)","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":238,"context_line":"Testing"},{"line_number":239,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"* Create spec tests  files for each configurable parameter used by the new"},{"line_number":242,"context_line":"  Identity/Service Provider classes, to ensure that all applied settings"},{"line_number":243,"context_line":"  are valid."},{"line_number":244,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_d9826952","line":241,"updated":"2015-08-04 19:03:34.000000000","message":"useless space between \u0027tests\u0027 and \u0027files\u0027.\nI also want to see functional testing with acceptance.\nMaybe a simple use case would be a good start.","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"Testing"},{"line_number":239,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"* Create spec tests  files for each configurable parameter used by the new"},{"line_number":242,"context_line":"  Identity/Service Provider classes, to ensure that all applied settings"},{"line_number":243,"context_line":"  are valid."},{"line_number":244,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_5ab1678e","line":241,"in_reply_to":"1a4dcd0f_d9826952","updated":"2015-08-04 20:27:19.000000000","message":"Done","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cde247300d92e86a1c9a9e883a5f71b7980c6d9","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Documentation Impact"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Add examples in the Puppet-Keystone repository for both classes."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_997ce173","line":248,"updated":"2015-08-04 19:03:34.000000000","message":"please lowercase puppet-keystone","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"060f1e33ec5d14368701bfffd5270a787addeea8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"Documentation Impact"},{"line_number":246,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"Add examples in the Puppet-Keystone repository for both classes."},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":25,"id":"1a4dcd0f_df8fa921","line":248,"in_reply_to":"1a4dcd0f_997ce173","updated":"2015-08-04 20:27:19.000000000","message":"Done","commit_id":"814555bef6e25442389d91bb68d6726892619db8"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"`bp enabling-federation \u003chttps://blueprints.launchpad.net/puppet-keystone/+spec"},{"line_number":13,"context_line":"/enabling-federation\u003e`_"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a efficient way for cloud administrators"},{"line_number":16,"context_line":"to configure their Keystone as a Service Provider or Identity Provider in order"},{"line_number":17,"context_line":"to use Identity Federation."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_6094438a","line":15,"updated":"2015-08-12 18:32:45.000000000","message":"an efficient","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"`bp enabling-federation \u003chttps://blueprints.launchpad.net/puppet-keystone/+spec"},{"line_number":13,"context_line":"/enabling-federation\u003e`_"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The purpose of this spec is to provide a efficient way for cloud administrators"},{"line_number":16,"context_line":"to configure their Keystone as a Service Provider or Identity Provider in order"},{"line_number":17,"context_line":"to use Identity Federation."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_d87e6718","line":15,"in_reply_to":"1a4dcd0f_6094438a","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" There will be a class service_provider to configure Keystone as a Service"},{"line_number":37,"context_line":" Provider, there are two major protocols (OpenID Connect and SAML) and three"},{"line_number":38,"context_line":" different ways to configure: OpenID Connect, Shibboleth and Mellon."},{"line_number":39,"context_line":" Packages and extra configuration will be applied according to the choice"},{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_c0d2f75b","line":37,"updated":"2015-08-12 18:32:45.000000000","message":"Provider. There","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* Service Provider"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":" There will be a class service_provider to configure Keystone as a Service"},{"line_number":37,"context_line":" Provider, there are two major protocols (OpenID Connect and SAML) and three"},{"line_number":38,"context_line":" different ways to configure: OpenID Connect, Shibboleth and Mellon."},{"line_number":39,"context_line":" Packages and extra configuration will be applied according to the choice"},{"line_number":40,"context_line":" made, the three possible choices are: OpenID Connect, Mellon and Shibboleth."}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_d8a507a2","line":37,"in_reply_to":"1a4dcd0f_c0d2f75b","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"},{"line_number":46,"context_line":"    an absolute URL."},{"line_number":47,"context_line":"  - idps_urls:"},{"line_number":48,"context_line":"    A list containg all the Identity Providers urls. All urls are in format"},{"line_number":49,"context_line":"    \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":50,"context_line":"    and Apache. This list should contain one or more urls to be valid."},{"line_number":51,"context_line":"  - metadata_urls:"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_40c7c795","line":48,"updated":"2015-08-12 18:32:45.000000000","message":"containing","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Is the globally unique name for a SAML entity, must be a URI and should be"},{"line_number":46,"context_line":"    an absolute URL."},{"line_number":47,"context_line":"  - idps_urls:"},{"line_number":48,"context_line":"    A list containg all the Identity Providers urls. All urls are in format"},{"line_number":49,"context_line":"    \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":50,"context_line":"    and Apache. This list should contain one or more urls to be valid."},{"line_number":51,"context_line":"  - metadata_urls:"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_98abff74","line":48,"in_reply_to":"1a4dcd0f_40c7c795","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":50,"context_line":"    and Apache. This list should contain one or more urls to be valid."},{"line_number":51,"context_line":"  - metadata_urls:"},{"line_number":52,"context_line":"    A list containg one metadata_url for each Identity Provider in idps_urls."},{"line_number":53,"context_line":"  - protocol:"},{"line_number":54,"context_line":"    The protocol used to provide Federation. There is support for two"},{"line_number":55,"context_line":"    protocols: OpenID Connect and SAML"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_204f1b35","line":52,"updated":"2015-08-12 18:32:45.000000000","message":"containing","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    \u003caddress\u003e:\u003cport\u003e. This will be used to set the configurations in Keystone"},{"line_number":50,"context_line":"    and Apache. This list should contain one or more urls to be valid."},{"line_number":51,"context_line":"  - metadata_urls:"},{"line_number":52,"context_line":"    A list containg one metadata_url for each Identity Provider in idps_urls."},{"line_number":53,"context_line":"  - protocol:"},{"line_number":54,"context_line":"    The protocol used to provide Federation. There is support for two"},{"line_number":55,"context_line":"    protocols: OpenID Connect and SAML"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_78e2b3d6","line":52,"in_reply_to":"1a4dcd0f_204f1b35","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    The protocol used to provide Federation. There is support for two"},{"line_number":55,"context_line":"    protocols: OpenID Connect and SAML"},{"line_number":56,"context_line":"  - module:"},{"line_number":57,"context_line":"    The name of the apache module to install. This will be used to guide the"},{"line_number":58,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":59,"context_line":"    attribute should be the name of one of the modules available."},{"line_number":60,"context_line":"    Available modules name are: shibboleth and mellon."}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_40758761","line":57,"updated":"2015-08-12 18:32:45.000000000","message":"Apache","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    The protocol used to provide Federation. There is support for two"},{"line_number":55,"context_line":"    protocols: OpenID Connect and SAML"},{"line_number":56,"context_line":"  - module:"},{"line_number":57,"context_line":"    The name of the apache module to install. This will be used to guide the"},{"line_number":58,"context_line":"    installation and configuration of a Service Provider. The value of this"},{"line_number":59,"context_line":"    attribute should be the name of one of the modules available."},{"line_number":60,"context_line":"    Available modules name are: shibboleth and mellon."}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_58dfb70c","line":57,"in_reply_to":"1a4dcd0f_40758761","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":121,"context_line":"  For example, in a Debian based distribution: the packages"},{"line_number":122,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":123,"context_line":"  or ``libapache2-auth-openidc`` for OpenID Connect support."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_a027ab61","line":123,"updated":"2015-08-12 18:32:45.000000000","message":"and","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":121,"context_line":"  For example, in a Debian based distribution: the packages"},{"line_number":122,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":123,"context_line":"  or ``libapache2-auth-openidc`` for OpenID Connect support."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_18804ff6","line":123,"in_reply_to":"1a4dcd0f_a027ab61","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5efeb9ed991ba94d96d62e6710aa1f77d284c9e2","unresolved":false,"context_lines":[{"line_number":184,"context_line":" }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"The examples of configurations added to Keystone and Apache:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"**For Identity Provider:**"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_20eb9bdd","line":187,"updated":"2015-08-12 18:32:45.000000000","message":"Below are examples of configurations ...\n\nExamples of the configurations added to Keystone and Apache can be found below:","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2f01285a374aa5cb7a48c95409315f4939e9250a","unresolved":false,"context_lines":[{"line_number":184,"context_line":" }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"The examples of configurations added to Keystone and Apache:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"**For Identity Provider:**"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a4dcd0f_781713a3","line":187,"in_reply_to":"1a4dcd0f_20eb9bdd","updated":"2015-08-12 21:02:48.000000000","message":"Done","commit_id":"41f7c056f100500977e52ae9003603e24ce47404"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f6e72762ece492ffc014eedb956acb0e846fe582","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  For the Service Provider, there are some packages that need to be installed."},{"line_number":121,"context_line":"  For example, in a Debian based distribution: the packages"},{"line_number":122,"context_line":"  ``libapache2-mod-shib2`` or ``libapache-mod-auth-mellon`` for SAML2 support"},{"line_number":123,"context_line":"  and ``libapache2-auth-openidc`` for OpenID Connect support."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":"  For the Identity Provider, there are some packages that need to be installed."}],"source_content_type":"text/x-rst","patch_set":27,"id":"fa1b9901_e2353e46","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":31},"updated":"2015-08-18 13:34:11.000000000","message":"Reading this, it seems not clear to me who actually needs the packages.\n\nIs it:\n\n* keystone itself to communicate with SP backend?\n\n* the SP backend itself?","commit_id":"cb071f35b2338ec343a9bffdfc31f03838af789c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f6e72762ece492ffc014eedb956acb0e846fe582","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  and ``libapache2-auth-openidc`` for OpenID Connect support."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":".. note::"},{"line_number":126,"context_line":"  For the Identity Provider, there are some packages that need to be installed."},{"line_number":127,"context_line":"  For example, in a Debian/Ubuntu distribution: the packages ``pysaml2`` and"},{"line_number":128,"context_line":"  ``xmlsec1`` are necessary."},{"line_number":129,"context_line":""}],"source_content_type":"text/x-rst","patch_set":27,"id":"fa1b9901_227a56f2","line":126,"updated":"2015-08-18 13:34:11.000000000","message":"Same question, are those packages needed by keystone itself? If yes, it should be mentioned here.","commit_id":"cb071f35b2338ec343a9bffdfc31f03838af789c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f6e72762ece492ffc014eedb956acb0e846fe582","unresolved":false,"context_lines":[{"line_number":168,"context_line":"``site.pp`` example - Keystone as a Service Provider using Mellon::"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":" class { \u0027keystone::federation::service_provider\u0027:"},{"line_number":171,"context_line":"  idps_urls \u003d\u003e \u0027https://ipa.rdodom.test/idp\u0027,"},{"line_number":172,"context_line":"  saml_dir \u003d\u003e \u0027/etc/httpd/saml2/test\u0027,"},{"line_number":173,"context_line":"  http_conf \u003d\u003e \u0027/etc/httpd/conf.d/keystone-mellon.conf\u0027,"},{"line_number":174,"context_line":"  service \u003d\u003e \u0027keystone\u0027,"}],"source_content_type":"text/x-rst","patch_set":27,"id":"fa1b9901_02a39250","line":171,"updated":"2015-08-18 13:34:11.000000000","message":"maybe you could align the \u003d\u003e to be more friendly to read.","commit_id":"cb071f35b2338ec343a9bffdfc31f03838af789c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f6e72762ece492ffc014eedb956acb0e846fe582","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"Examples of the configurations added to Keystone and Apache can be found below:"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"**For Identity Provider:**"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"See topic `Keystone as an Identity Provider (IdP) \u003chttp://docs.openstack.org/de"},{"line_number":192,"context_line":"veloper/keystone/configure_federation.html\u003e`_."}],"source_content_type":"text/x-rst","patch_set":27,"id":"fa1b9901_82548221","line":189,"updated":"2015-08-18 13:34:11.000000000","message":"any example of manifest?","commit_id":"cb071f35b2338ec343a9bffdfc31f03838af789c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f6e72762ece492ffc014eedb956acb0e846fe582","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"* Create a class for the Identity Provider configuration which will apply"},{"line_number":229,"context_line":"  the extra configurations to the Keystone configuration file and install all"},{"line_number":230,"context_line":"  necessary packages."},{"line_number":231,"context_line":"* Write tests to ensure that the Identity Provider configuration is valid."},{"line_number":232,"context_line":"* Create a class for a Service Provider and acording to the protocol apply the"},{"line_number":233,"context_line":"  necessary configuration."}],"source_content_type":"text/x-rst","patch_set":27,"id":"fa1b9901_e2121e62","line":230,"updated":"2015-08-18 13:34:11.000000000","message":"packages for which purpose? deploying openid? or just make keystone working with the backends?","commit_id":"cb071f35b2338ec343a9bffdfc31f03838af789c"}]}