)]}'
{"id":"openstack%2Fpuppet-openstack_extras~195909","triplet_id":"openstack%2Fpuppet-openstack_extras~master~Ib6d17869f915171787c4f79679f5731edd3341de","project":"openstack/puppet-openstack_extras","branch":"master","topic":"195801","hashtags":[],"change_id":"Ib6d17869f915171787c4f79679f5731edd3341de","subject":"Fix source_defaults unit tests","status":"MERGED","created":"2015-06-26 08:02:02.000000000","updated":"2015-06-26 15:35:32.000000000","submitted":"2015-06-26 15:35:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5d45bd8419eec4a16b0aa5238bbe03ad1e3fd953","_number":195909,"virtual_id_number":195909,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2015-06-26 15:35:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2015-06-26 15:30:30.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-06-26 15:28:34.000000000","_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2015-06-26 15:30:30.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-26 15:28:34.000000000","updated_by":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"reviewer":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"state":"REVIEWER"},{"updated":"2015-06-26 15:30:30.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2015-06-26 15:35:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"eb5a50ee2400265329788adf857ee4f9ea3baae4","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2015-06-26 08:02:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"329cfe91af9288a70a5b23bed4a3b3d7715d8efb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 08:05:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack_extras-puppet-lint http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-lint/7a25aa6/ : SUCCESS in 28s\n- gate-puppet-openstack_extras-puppet-syntax http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-syntax/5a8d2da/ : SUCCESS in 7s\n- gate-puppet-openstack_extras-puppet-unit-3.3 http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-unit-3.3/0052edf/ : SUCCESS in 1m 01s\n- gate-puppet-openstack_extras-puppet-unit-3.4 http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-unit-3.4/f916d8d/ : SUCCESS in 36s\n- gate-puppet-openstack_extras-puppet-unit-3.6 http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-unit-3.6/2d5d0a7/ : SUCCESS in 43s\n- gate-puppet-openstack_extras-puppet-unit-3.7 http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-unit-3.7/e68879d/ : SUCCESS in 1m 06s\n- gate-puppet-openstack_extras-puppet-unit-4.0 http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-unit-4.0/b26a6f2/ : SUCCESS in 52s\n- gate-puppet-openstack_extras-puppet-syntax-future http://logs.openstack.org/09/195909/1/check/gate-puppet-openstack_extras-puppet-syntax-future/334d294/ : SUCCESS in 36s","accounts_in_message":[],"_revision_number":1},{"id":"1191ad3c3fff3ec3d34e847ced9e6c002cc3d3e0","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-06-26 13:02:44.000000000","message":"Patch Set 1: Code-Review+1\n\nthis patch is good after we decide how to fix the \u0027apt-get update\u0027 relationship issue.","accounts_in_message":[],"_revision_number":1},{"id":"2cabeb4f3e972d5f1ef6fe2e814fd193d749cdef","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2015-06-26 15:21:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c56754cef467d8d7c29da6950641d2a6d5da5bdb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 15:27:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstack_extras-puppet-lint http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-lint/44afedc/ : SUCCESS in 33s\n- gate-puppet-openstack_extras-puppet-syntax http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-syntax/1ec8efe/ : SUCCESS in 1m 21s\n- gate-puppet-openstack_extras-puppet-unit-3.3 http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-unit-3.3/537f81d/ : SUCCESS in 35s\n- gate-puppet-openstack_extras-puppet-unit-3.4 http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-unit-3.4/8e2ef82/ : SUCCESS in 43s\n- gate-puppet-openstack_extras-puppet-unit-3.6 http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-unit-3.6/1cdf74e/ : SUCCESS in 57s\n- gate-puppet-openstack_extras-puppet-unit-3.7 http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-unit-3.7/48986c7/ : SUCCESS in 43s\n- gate-puppet-openstack_extras-puppet-unit-4.0 http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-unit-4.0/c682593/ : SUCCESS in 44s\n- gate-puppet-openstack_extras-puppet-syntax-future http://logs.openstack.org/09/195909/2/check/gate-puppet-openstack_extras-puppet-syntax-future/b3d3f42/ : SUCCESS in 27s","accounts_in_message":[],"_revision_number":2},{"id":"73a00df95b2a8009301c070b7b5c05a6ec3c05c2","author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"date":"2015-06-26 15:28:34.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c9065f1f4721cac7842f87b8e148c860157dc3dd","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-06-26 15:30:30.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1da812ddd4e12c5cbaeae0524038e1b39d340199","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 15:30:36.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2166ed250020d6f00f5a6a638e3eada69a56ba6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 15:35:32.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-openstack_extras-puppet-lint http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-lint/cc6a974/ : SUCCESS in 33s\n- gate-puppet-openstack_extras-puppet-syntax http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-syntax/4f21d90/ : SUCCESS in 9s\n- gate-puppet-openstack_extras-puppet-unit-3.3 http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-unit-3.3/caec183/ : SUCCESS in 1m 00s\n- gate-puppet-openstack_extras-puppet-unit-3.4 http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-unit-3.4/888ad1a/ : SUCCESS in 1m 10s\n- gate-puppet-openstack_extras-puppet-unit-3.6 http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-unit-3.6/bc2f295/ : SUCCESS in 53s\n- gate-puppet-openstack_extras-puppet-unit-3.7 http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-unit-3.7/37b4a2b/ : SUCCESS in 54s\n- gate-puppet-openstack_extras-puppet-unit-4.0 http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-unit-4.0/2a6a0af/ : SUCCESS in 51s\n- gate-puppet-openstack_extras-puppet-syntax-future http://logs.openstack.org/09/195909/2/gate/gate-puppet-openstack_extras-puppet-syntax-future/5c761b3/ : SUCCESS in 37s","accounts_in_message":[],"_revision_number":2},{"id":"d6b7435811be6ac259e20468eb3f41b432d71458","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-26 15:35:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d193b48e4a705b26a2703d9fed2dd9c935d91541","revisions":{"16cb6d46dc6c75e835ec946f6524d5563a4806c9":{"kind":"REWORK","_number":1,"created":"2015-06-26 08:02:02.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/09/195909/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack_extras","ref":"refs/changes/09/195909/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/1"}}},"commit":{"parents":[{"commit":"4c3df6266edf487d9e9b17a764e0bc07430581b5","subject":"Restore apt-get update relationship","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/4c3df6266edf487d9e9b17a764e0bc07430581b5"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2015-06-26 07:55:37.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2015-06-26 07:55:37.000000000","tz":-420},"subject":"Fix source_defaults unit tests","message":"Fix source_defaults unit tests\n\nThe $source_defaults parameter only has meaning if $source_hash is also\nset, otherwise create_resources will not create any resources. Without\nthis patch, the rspec-puppet tests for the source_defaults parameter\nonly tested the values of the apt::source resources that were not\ncreated with create_resources and were therefore not using the\n$source_defaults. The tests were passing because the default value of\nthe include_src parameter for apt::source is true, but the\n$source_defaults parameter was never exercised. This patch corrects\nthose tests to actually use a $source_hash parameter and test\nuser-provided resources, not the default ones.\n\nChange-Id: Ib6d17869f915171787c4f79679f5731edd3341de\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/16cb6d46dc6c75e835ec946f6524d5563a4806c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/16cb6d46dc6c75e835ec946f6524d5563a4806c9"}]},"branch":"refs/heads/master"},"d193b48e4a705b26a2703d9fed2dd9c935d91541":{"kind":"REWORK","_number":2,"created":"2015-06-26 15:21:13.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/09/195909/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack_extras","ref":"refs/changes/09/195909/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/09/195909/2"}}},"commit":{"parents":[{"commit":"f68fc295243fbaf1693a1f6a6591d7386fdeae51","subject":"repo: install keyring with an exec","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/f68fc295243fbaf1693a1f6a6591d7386fdeae51"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2015-06-26 07:55:37.000000000","tz":-420},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2015-06-26 15:17:56.000000000","tz":-420},"subject":"Fix source_defaults unit tests","message":"Fix source_defaults unit tests\n\nThe $source_defaults parameter only has meaning if $source_hash is also\nset, otherwise create_resources will not create any resources. Without\nthis patch, the rspec-puppet tests for the source_defaults parameter\nonly tested the values of the apt::source resources that were not\ncreated with create_resources and were therefore not using the\n$source_defaults. The tests were passing because the default value of\nthe include_src parameter for apt::source is true, but the\n$source_defaults parameter was never exercised. This patch corrects\nthose tests to actually use a $source_hash parameter and test\nuser-provided resources, not the default ones.\n\nChange-Id: Ib6d17869f915171787c4f79679f5731edd3341de\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/d193b48e4a705b26a2703d9fed2dd9c935d91541"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/d193b48e4a705b26a2703d9fed2dd9c935d91541"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}