)]}'
{"manifests/repo/debian/debian.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"02ef0dbe738d94b7e602373fd7a3515f1eeded32","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      notify      \u003d\u003e Exec[\u0027apt_update\u0027],"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":"    apt::source { $::openstack_extras::repo::debian::params::whz_name:"},{"line_number":51,"context_line":"      location \u003d\u003e $::openstack_extras::repo::debian::params::whz_location,"},{"line_number":52,"context_line":"      release  \u003d\u003e \"stretch-${release}-backports\","},{"line_number":53,"context_line":"      repos    \u003d\u003e $::openstack_extras::repo::debian::params::whz_repos,"},{"line_number":54,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf659307_6c0a5c20","line":51,"range":{"start_line":51,"start_character":18,"end_line":51,"end_character":73},"updated":"2018-04-03 20:35:37.000000000","message":"This needs to be the the \"https://whatever${release}.foo\" for the $release param from this class to be honored when it\u0027s evaluated. What\u0027s happening in this version is that since the $release is queens in params, this will always be the queens url.  You could switch it to a template in the params and use a function like regsubst(...) to just swap out the release.  The same problem exists for $::openstack_extras::repo::debian::params::whz_name\n\nFor example if you set $::openstack_extras::repo::debian::params::whz_name to \u0027foo-RELEASE-bar\u0027 and then you can regsubst($::openstack_extras::repo::debian::params::whz_name, \u0027/RELEASE/\u0027, $release, G)\n\n\nhttps://puppet.com/docs/puppet/5.4/function.html#regsubst\n\nThough it\u0027s probably just easier to move the string here instead","commit_id":"f9b19a0371ba5f6d98339f6b3ccb819a2593d034"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49c70415616acf7ec6f17df279a3d4e0de11f584","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"# [*deb_location*]"},{"line_number":34,"context_line":"#   (optional) Debian package repository location."},{"line_number":35,"context_line":"#   Defaults to $::openstack_extras::repo::debian::params::deb_location"},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# \u003d\u003d\u003d DEPRECATED"},{"line_number":38,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_8c58c956","line":35,"range":{"start_line":35,"start_character":16,"end_line":35,"end_character":71},"updated":"2018-04-06 16:29:57.000000000","message":"This was also out of date","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"59f959979a0fb61e018643aa89441ea68583c502","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# [*manage_whz*]"},{"line_number":40,"context_line":"#   (optional) Whether or not to add the default Debian Stretch APT source"},{"line_number":41,"context_line":"#   Replaced by $manage_deb instead."},{"line_number":42,"context_line":"#   Defaults to true"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class openstack_extras::repo::debian::debian("},{"line_number":45,"context_line":"  $release         \u003d $::openstack_extras::repo::debian::params::release,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_ccd9e1f4","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":20},"updated":"2018-04-06 16:24:06.000000000","message":"Can probably remove this","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49c70415616acf7ec6f17df279a3d4e0de11f584","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# [*manage_whz*]"},{"line_number":40,"context_line":"#   (optional) Whether or not to add the default Debian Stretch APT source"},{"line_number":41,"context_line":"#   Replaced by $manage_deb instead."},{"line_number":42,"context_line":"#   Defaults to true"},{"line_number":43,"context_line":"#"},{"line_number":44,"context_line":"class openstack_extras::repo::debian::debian("},{"line_number":45,"context_line":"  $release         \u003d $::openstack_extras::repo::debian::params::release,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_cc5ec144","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":20},"in_reply_to":"bf659307_ccd9e1f4","updated":"2018-04-06 16:29:57.000000000","message":"Done","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"59f959979a0fb61e018643aa89441ea68583c502","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $source_hash     \u003d {},"},{"line_number":48,"context_line":"  $source_defaults \u003d {},"},{"line_number":49,"context_line":"  $package_require \u003d false,"},{"line_number":50,"context_line":"  $deb_location    \u003d \"http://${::lsbdistcodename}-${release}.debian.net/debian\","},{"line_number":51,"context_line":"  # DEPRECATED"},{"line_number":52,"context_line":"  $manage_whz      \u003d undef,"},{"line_number":53,"context_line":") inherits openstack_extras::repo::debian::params {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_8cfc493f","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":80},"updated":"2018-04-06 16:24:06.000000000","message":"I think it would be cleaner if we used $::openstack_extras::repo::debian::params::deb_location","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49c70415616acf7ec6f17df279a3d4e0de11f584","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  $source_hash     \u003d {},"},{"line_number":48,"context_line":"  $source_defaults \u003d {},"},{"line_number":49,"context_line":"  $package_require \u003d false,"},{"line_number":50,"context_line":"  $deb_location    \u003d \"http://${::lsbdistcodename}-${release}.debian.net/debian\","},{"line_number":51,"context_line":"  # DEPRECATED"},{"line_number":52,"context_line":"  $manage_whz      \u003d undef,"},{"line_number":53,"context_line":") inherits openstack_extras::repo::debian::params {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_2c4add7f","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":80},"in_reply_to":"bf659307_8cfc493f","updated":"2018-04-06 16:29:57.000000000","message":"Yea if we used the one from params, the $release param here would end up with always having queens or whatever. Specifying it here allows for the $release var to be updated and the url to be generated correctly.","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"}],"manifests/repo/debian/params.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97bf4ea1eb3d1463f348b2a08f27b06a6e20ea3f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  $uca_repos             \u003d \u0027main\u0027"},{"line_number":12,"context_line":"  $uca_required_packages \u003d \u0027ubuntu-cloud-keyring\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  $whz_name              \u003d \"stretch-${::openstack_extras::repo::debian::params::release}-backports\""},{"line_number":15,"context_line":"  $whz_location          \u003d \"http://stretch-${::openstack_extras::repo::debian::params::release}.debian.net/debian\""},{"line_number":16,"context_line":"  $whz_repos             \u003d \u0027main\u0027"},{"line_number":17,"context_line":"  $whz_required_packages \u003d \u0027openstack-backports-archive-keyring\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bf659307_69100e01","line":14,"range":{"start_line":14,"start_character":38,"end_line":14,"end_character":87},"updated":"2018-04-03 19:58:35.000000000","message":"just use ${release} here since this is referencing this class","commit_id":"b682d0aad5ed825a5dac2048c2bd2f49df13951c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"97bf4ea1eb3d1463f348b2a08f27b06a6e20ea3f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $uca_required_packages \u003d \u0027ubuntu-cloud-keyring\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  $whz_name              \u003d \"stretch-${::openstack_extras::repo::debian::params::release}-backports\""},{"line_number":15,"context_line":"  $whz_location          \u003d \"http://stretch-${::openstack_extras::repo::debian::params::release}.debian.net/debian\""},{"line_number":16,"context_line":"  $whz_repos             \u003d \u0027main\u0027"},{"line_number":17,"context_line":"  $whz_required_packages \u003d \u0027openstack-backports-archive-keyring\u0027"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bf659307_29f696d8","line":15,"range":{"start_line":15,"start_character":45,"end_line":15,"end_character":94},"updated":"2018-04-03 19:58:35.000000000","message":"same","commit_id":"b682d0aad5ed825a5dac2048c2bd2f49df13951c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"02ef0dbe738d94b7e602373fd7a3515f1eeded32","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  $uca_repos             \u003d \u0027main\u0027"},{"line_number":12,"context_line":"  $uca_required_packages \u003d \u0027ubuntu-cloud-keyring\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  $whz_name              \u003d \"stretch-${release}-backports\""},{"line_number":15,"context_line":"  $whz_location          \u003d \"http://stretch-${release}.debian.net/debian\""},{"line_number":16,"context_line":"  $whz_repos             \u003d \u0027main\u0027"},{"line_number":17,"context_line":"  $whz_required_packages \u003d \u0027openstack-backports-archive-keyring\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf659307_6947ae78","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":57},"updated":"2018-04-03 20:35:37.000000000","message":"So this should be static.  It\u0027s just the name for the repo which is why for UCA we have \u0027ubuntu-cloud-archive\u0027. The actual release info needs to go elsewhere. What\u0027s happening is that this is essentially static.","commit_id":"f9b19a0371ba5f6d98339f6b3ccb819a2593d034"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"02ef0dbe738d94b7e602373fd7a3515f1eeded32","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $uca_required_packages \u003d \u0027ubuntu-cloud-keyring\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  $whz_name              \u003d \"stretch-${release}-backports\""},{"line_number":15,"context_line":"  $whz_location          \u003d \"http://stretch-${release}.debian.net/debian\""},{"line_number":16,"context_line":"  $whz_repos             \u003d \u0027main\u0027"},{"line_number":17,"context_line":"  $whz_required_packages \u003d \u0027openstack-backports-archive-keyring\u0027"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bf659307_e952de34","line":15,"range":{"start_line":15,"start_character":27,"end_line":15,"end_character":72},"updated":"2018-04-03 20:35:37.000000000","message":"So if this is going to be dynamic based on the release, this logic needs to live in the repo file itself. What you could do is just use this as a \u0027template\u0027 for the url generation instead.","commit_id":"f9b19a0371ba5f6d98339f6b3ccb819a2593d034"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a8c6cf30ca07ecd36d4d7904f3c5580bbfe6f3ec","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $uca_required_packages \u003d \u0027ubuntu-cloud-keyring\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  $deb_name              \u003d \u0027debian-openstack-backports\u0027"},{"line_number":15,"context_line":"  $deb_location          \u003d \"http://${::lsbdistcodename}-${release}.debian.net/debian\""},{"line_number":16,"context_line":"  $deb_repos             \u003d \u0027main\u0027"},{"line_number":17,"context_line":"  $deb_required_packages \u003d \u0027openstack-backports-archive-keyring\u0027"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_47f7318c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":85},"updated":"2018-04-03 22:09:45.000000000","message":"probably could just delete this since i moved it to the other class.","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"59f959979a0fb61e018643aa89441ea68583c502","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  $uca_required_packages \u003d \u0027ubuntu-cloud-keyring\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  $deb_name              \u003d \u0027debian-openstack-backports\u0027"},{"line_number":15,"context_line":"  $deb_location          \u003d \"http://${::lsbdistcodename}-${release}.debian.net/debian\""},{"line_number":16,"context_line":"  $deb_repos             \u003d \u0027main\u0027"},{"line_number":17,"context_line":"  $deb_required_packages \u003d \u0027openstack-backports-archive-keyring\u0027"},{"line_number":18,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bf659307_ace02d98","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":85},"in_reply_to":"bf659307_47f7318c","updated":"2018-04-06 16:24:06.000000000","message":"Why don\u0027t we keep this and drop the hard coded value in the other file?","commit_id":"9b63dc312ee289681106573d542b7c3a1e4a0ead"}]}