)]}'
{"id":"openstack%2Fpuppet-openstack_extras~638862","triplet_id":"openstack%2Fpuppet-openstack_extras~master~Ifa0c404af3868e87668f4587febd41617eb4ba1c","project":"openstack/puppet-openstack_extras","branch":"master","topic":"validate_legacy","hashtags":[],"change_id":"Ifa0c404af3868e87668f4587febd41617eb4ba1c","subject":"Use validate_legacy","status":"MERGED","created":"2019-02-23 21:28:01.000000000","updated":"2019-02-25 18:28:17.000000000","submitted":"2019-02-25 18:28:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"638862-1551119297753-c64e651f","meta_rev_id":"228101f55e4edf8db18f80e8396d1fca91c66cdc","_number":638862,"virtual_id_number":638862,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-02-25 18:28:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-02-23 22:30:17.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":2,"date":"2019-02-25 06:31:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":2,"date":"2019-02-25 17:05:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2019-02-25 17:05:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-23 22:30:17.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-02-25 06:31:20.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-02-25 17:05:22.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-02-25 18:28:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"47b2d55580e396a26478a476704073b4f3ad920b","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-02-23 21:28:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d611d4da6c48547b3c4d94fef4be4ffff6a1cfcd","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-02-23 22:30:17.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/62/638862/1/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/d141d88/ : SUCCESS in 53m 47s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/62/638862/1/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/2e13cae/ : SUCCESS in 47m 17s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/62/638862/1/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/4f25428/ : SUCCESS in 59m 35s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/62/638862/1/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/88e9a30/ : SUCCESS in 46m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"15279a584d02ed4c453f12f77fb19b474474737c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-23 22:45:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-lint-ubuntu-bionic/dcbd075/ : SUCCESS in 6m 40s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-syntax-4-ubuntu-bionic/9869719/ : SUCCESS in 4m 05s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-syntax-5-ubuntu-bionic/4e7a2fe/ : SUCCESS in 6m 27s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-syntax-6-ubuntu-bionic/21d1d15/ : SUCCESS in 3m 11s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/62/638862/1/check/puppet-openstack-unit-4.8-centos-7/8be4d73/ : SUCCESS in 9m 32s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/62/638862/1/check/puppet-openstack-unit-5.5-centos-7/c75618a/ : SUCCESS in 14m 59s\n- puppet-openstack-unit-6.0-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-unit-6.0-ubuntu-bionic/9e6272e/ : SUCCESS in 7m 43s\n- puppet-openstack-unit-latest-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-unit-latest-ubuntu-bionic/930a94d/ : FAILURE in 5m 58s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/6304696/ : SUCCESS in 1h 11m 01s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/1fa5585/ : SUCCESS in 59m 22s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/fc374e3/ : SUCCESS in 57m 13s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic/4bdcec0/ : SUCCESS in 43m 59s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/858b3e1/ : SUCCESS in 47m 29s\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/d0a93dd/ : SUCCESS in 49m 09s\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/ecd39b1/ : SUCCESS in 1h 05m 31s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic http://logs.openstack.org/62/638862/1/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/8ca79d6/ : SUCCESS in 35m 43s (non-voting)\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/62/638862/1/check/puppet-openstack-beaker-centos-7/35a6d9a/ : SUCCESS in 10m 35s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/62/638862/1/check/puppet-openstack-beaker-ubuntu-bionic/daf72cf/ : SUCCESS in 7m 40s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f211f8a8fc5aaee0b644ef259f7efcf48aa16cc1","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-02-25 06:31:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1a2f9bf341aa4edaae021f32d6ffd8a6103b2dfb","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-02-25 17:05:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"2c0b3b8fb4734fbd8deb2be0542198d0105cb0cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 17:05:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"be93700ae8765393ba1583773ebaffa7f5e13b56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 18:28:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"56c736818389b44dd7162c2d95c2a5ead65b26bd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 18:28:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-lint-ubuntu-bionic/0c25e46/ : SUCCESS in 4m 02s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-syntax-4-ubuntu-bionic/26de767/ : SUCCESS in 4m 58s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-syntax-5-ubuntu-bionic/6176ae3/ : SUCCESS in 5m 32s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-syntax-6-ubuntu-bionic/89b73f3/ : SUCCESS in 4m 26s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/62/638862/1/gate/puppet-openstack-unit-4.8-centos-7/dde0acb/ : SUCCESS in 9m 59s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/62/638862/1/gate/puppet-openstack-unit-5.5-centos-7/172bda7/ : SUCCESS in 10m 03s\n- puppet-openstack-unit-6.0-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-unit-6.0-ubuntu-bionic/a00067d/ : SUCCESS in 7m 08s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/62/638862/1/gate/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/50f66fb/ : SUCCESS in 49m 40s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/62/638862/1/gate/puppet-openstack-integration-5-scenario002-tempest-centos-7/d7b6af8/ : SUCCESS in 1h 02m 25s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/62/638862/1/gate/puppet-openstack-integration-5-scenario003-tempest-centos-7/5ae0247/ : SUCCESS in 1h 12m 57s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic/108bae3/ : SUCCESS in 46m 38s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/5d2e660/ : SUCCESS in 46m 39s\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/b729ca5/ : SUCCESS in 50m 35s\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/62/638862/1/gate/puppet-openstack-beaker-centos-7/9b27f88/ : SUCCESS in 16m 07s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/62/638862/1/gate/puppet-openstack-beaker-ubuntu-bionic/e467523/ : SUCCESS in 14m 14s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9330559217a98a85e73b58958a9e673d3beba368","revisions":{"9330559217a98a85e73b58958a9e673d3beba368":{"kind":"REWORK","_number":1,"created":"2019-02-23 21:28:01.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/62/638862/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack_extras","ref":"refs/changes/62/638862/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/62/638862/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/62/638862/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/62/638862/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/62/638862/1"}}},"commit":{"parents":[{"commit":"521062171893e1d6ec1dcd6545a173925b98b241","subject":"Modify puppet version 4 to 5","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/521062171893e1d6ec1dcd6545a173925b98b241"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2019-02-23 21:27:37.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2019-02-23 21:27:37.000000000","tz":60},"subject":"Use validate_legacy","message":"Use validate_legacy\n\nThis changes all the puppet 3 validate_* functions\nto use the validate_legacy function.\n\nThe validate_legacy function has been available since\nabout three years but require Puppet \u003e\u003d 4.4.0 and since\nthere is Puppet 4.10.12 as latest we should assume people\nare running a fairly new Puppet 4 version.\n\nThis is the first step to then remove all validate function\ncalls and use proper types for parameter as described in spec [1].\n\n[1] https://review.openstack.org/#/c/568929/\n\nChange-Id: Ifa0c404af3868e87668f4587febd41617eb4ba1c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/9330559217a98a85e73b58958a9e673d3beba368"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/9330559217a98a85e73b58958a9e673d3beba368"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
