)]}'
{"id":"openstack%2Fpuppet-openstack_extras~708034","triplet_id":"openstack%2Fpuppet-openstack_extras~master~Ibd56e93ad7f398b04ec7fb9281af5d42d0e1548f","project":"openstack/puppet-openstack_extras","branch":"master","hashtags":[],"change_id":"Ibd56e93ad7f398b04ec7fb9281af5d42d0e1548f","subject":"Cleanup and improve testing","status":"MERGED","created":"2020-02-16 20:33:11.000000000","updated":"2020-02-17 21:51:32.000000000","submitted":"2020-02-17 21:51:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"708034-1581976292542-b4850ae3","meta_rev_id":"c68fe20f9118dec7efd28b60f552807921a27e7a","_number":708034,"virtual_id_number":708034,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-17 21:51:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2020-02-16 23:25:03.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2020-02-17 20:32:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2020-02-17 20:32:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-16 23:25:03.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-02-17 20:32:49.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2020-02-17 21:51:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"771f5cc4d502e998b7bfdd7d1b7912e5425555e2","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2020-02-16 20:33:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4ac418cea63e286a7333d08093b7d915a00e5d54","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-16 21:56:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3cc066b1fff14ed6a802707cecb8b315 : SUCCESS in 5m 25s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/63ed44520f6f4d7ebd9f7162b8292924 : SUCCESS in 5m 02s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1ebd4a69e88c4c2a97c8ec88f838d13e : SUCCESS in 5m 05s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/7b35a3e7fabc482ea6222be9784678f3 : SUCCESS in 10m 05s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/29435fdeeb5e476f86b7ad275d2291fa : SUCCESS in 7m 44s\n- puppet-openstack-unit-latest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/6da74847186449969e39db919ba4af27 : SUCCESS in 7m 51s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/a0c9baded72d46b1be07919a2672d7ac : SUCCESS in 57m 03s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/3565a6223c49444ba954dcee00ae4d19 : SUCCESS in 1h 04m 14s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/d4c2d32deacd4ff685edd414eabc04e6 : SUCCESS in 1h 02m 29s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/1ace28e00eee4f6cae2d4eeb5eda9342 : SUCCESS in 48m 10s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/3507b9f912904b5bb1785471a02ca68c : SUCCESS in 49m 05s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9fa199602c0141f89273194ba3304e82 : SUCCESS in 51m 26s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/fd3358dfb46e4d27b656952bb1c0f9cb : SUCCESS in 38m 47s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/fee845eec6294f8d903a6072eec86aac : SUCCESS in 38m 01s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/202137ad9bde414bb88e37906df53cf6 : SUCCESS in 1h 03m 04s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/aa53ed96cb8f47daaf132e09f5db1b72 : SUCCESS in 59m 57s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/bb8e759cd73b421691ecb3bd9a2dfa30 : SUCCESS in 1h 19m 09s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-centos-8 https://zuul.opendev.org/t/openstack/build/0330987174d84ad3aebc051e5311635d : SUCCESS in 41m 58s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/69c2e12b495646d6878d7ab97c99b988 : SUCCESS in 11m 35s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/aa7e0866b19e44f0a85d72424a5d38d3 : SUCCESS in 13m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"639b0fd608d61664b8a5049f46610f333ff8f32e","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-02-16 23:25:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"77ed4fa8790372af0940ae6da523b4d0df0c312b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2020-02-17 20:32:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6049a848a0316ba2c3169372e24a0e976b5d3bed","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-17 20:33:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a5e65f4c51ce416cef3b3fbaf8a7f2c86ca60a42","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-17 21:51:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c68fe20f9118dec7efd28b60f552807921a27e7a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-17 21:51:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9c4f9307fa9b4d08bb1f41b61d02ab26 : SUCCESS in 5m 54s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/11b7b3148f3c4dd7bb1a5f3a09fef9a0 : SUCCESS in 6m 19s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e8f165edcddc4f97b1d356538a005a61 : SUCCESS in 6m 11s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/406763609f2445e4a7d0aebbbce133fe : SUCCESS in 12m 25s\n- puppet-openstack-unit-6.11-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/1e9329eb9664417aa431300e2c99cd6e : SUCCESS in 9m 55s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/647977596bae495ebacd7ac79bf9796c : SUCCESS in 1h 01m 17s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/c2474313caa743aca2aa5139a2ea5bc3 : SUCCESS in 1h 09m 07s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/772490dfa52048bcaba7fb8c6ac69910 : SUCCESS in 1h 12m 04s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/4c7b52a24c784a1085f69b65b01c6d5b : SUCCESS in 54m 15s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/0a8487a7cdf74e46a28668e2a4fe874f : SUCCESS in 12m 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6616e79e192ab39512ddb200a83fce5e241c834f","revisions":{"6616e79e192ab39512ddb200a83fce5e241c834f":{"kind":"REWORK","_number":1,"created":"2020-02-16 20:33:11.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/34/708034/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack_extras","ref":"refs/changes/34/708034/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/34/708034/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/34/708034/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/34/708034/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack_extras refs/changes/34/708034/1"}}},"commit":{"parents":[{"commit":"1c072a304ea9a5f791223d617ed2a49754690903","subject":"Set show_diff to false for auth_file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/1c072a304ea9a5f791223d617ed2a49754690903"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2020-02-16 20:32:14.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2020-02-16 20:32:14.000000000","tz":60},"subject":"Cleanup and improve testing","message":"Cleanup and improve testing\n\nSmall improvements to testing, some cleanup\nin formatting and changing the default value\nfor the password parameter by making it required\nand removing the undef default value (instead\nof using fail).\n\nChange-Id: Ibd56e93ad7f398b04ec7fb9281af5d42d0e1548f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/6616e79e192ab39512ddb200a83fce5e241c834f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_extras/commit/6616e79e192ab39512ddb200a83fce5e241c834f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}