)]}'
{"manifests/repo/redhat/redhat.pp":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ec298b1f9de0ee975a3a2ec8937ba47c7739fe18","unresolved":true,"context_lines":[{"line_number":98,"context_line":"  $manage_priorities \u003d true,"},{"line_number":99,"context_line":"  $centos_mirror_url \u003d \u0027http://mirror.centos.org\u0027,"},{"line_number":100,"context_line":"  $update_packages   \u003d false,"},{"line_number":101,"context_line":"  $stream            \u003d false,"},{"line_number":102,"context_line":") inherits openstack_extras::repo::redhat::params {"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  validate_legacy(String, \u0027validate_string\u0027, $release)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"366c102a_d6040ed3","line":101,"range":{"start_line":101,"start_character":23,"end_line":101,"end_character":28},"updated":"2021-04-16 12:21:06.000000000","message":"I agree to use \"false\" as default considering that we would need to backport this to older branches.\n\nHowever I think we should change the default during this cycle regarding the fact that RDO no longer provides release for CentOS8.","commit_id":"1deae5e3a12f53c5ac697006b89aba2ad9598f31"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ec298b1f9de0ee975a3a2ec8937ba47c7739fe18","unresolved":true,"context_lines":[{"line_number":116,"context_line":"  $_gpgkey_defaults \u003d merge($::openstack_extras::repo::redhat::params::gpgkey_defaults, $gpgkey_defaults)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"  $os_major \u003d $::os[\u0027release\u0027][\u0027major\u0027]"},{"line_number":119,"context_line":"  $os_major_real \u003d $stream ? {"},{"line_number":120,"context_line":"    true    \u003d\u003e \"${os_major}-stream\","},{"line_number":121,"context_line":"    default \u003d\u003e $os_major"},{"line_number":122,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ccb37e1a_6d0a51bd","line":119,"range":{"start_line":119,"start_character":3,"end_line":119,"end_character":16},"updated":"2021-04-16 12:21:06.000000000","message":"How about renaming this parameter as centos_major since this naming is only valid for CentOS ?","commit_id":"1deae5e3a12f53c5ac697006b89aba2ad9598f31"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"e6cc2f2f15c5be1b7e02674ce28c0b2fc020749c","unresolved":true,"context_lines":[{"line_number":146,"context_line":"  if $manage_virt and ($::operatingsystem !\u003d \u0027Fedora\u0027) {"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    if Integer.new($os_major) \u003e\u003d 8 {"},{"line_number":149,"context_line":"      $virt_baseurl \u003d \"${centos_mirror_url}/centos/${centos_major}/virt/\\$basearch/advanced-virtualization/\""},{"line_number":150,"context_line":"    } else {"},{"line_number":151,"context_line":"      $virt_baseurl \u003d \"${centos_mirror_url}/centos/${centos_major}/virt/\\$basearch/kvm-common/\""},{"line_number":152,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7164d2ce_2152eb11","line":149,"range":{"start_line":149,"start_character":83,"end_line":149,"end_character":106},"updated":"2021-04-19 07:41:49.000000000","message":"Looks like its moved?\nhttp://mirror.centos.org/centos/8-stream/virt/x86_64/advancedvirt-common","commit_id":"b696bc887e04d4711ee434bb90edaeb13cdc3961"}]}