)]}'
{"id":"openstack%2Fpuppet-openstack_spec_helper~700075","triplet_id":"openstack%2Fpuppet-openstack_spec_helper~stable%2Fstein~I332741d21c0a532f3f99abffcf27e122b06c62d1","project":"openstack/puppet-openstack_spec_helper","branch":"stable/stein","topic":"stein/lint2","hashtags":[],"change_id":"I332741d21c0a532f3f99abffcf27e122b06c62d1","subject":"Revert \"Disable relative_classname_inclusion\"","status":"MERGED","created":"2019-12-19 21:38:18.000000000","updated":"2019-12-20 14:29:13.000000000","submitted":"2019-12-19 23:52:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"700075-1576799539916-cc347a4a","meta_rev_id":"f190545553c22c780500e0c91bb1ab5e2afb3c12","_number":700075,"virtual_id_number":700075,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-19 23:52:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2019-12-19 23:00:55.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2019-12-19 23:00:55.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2019-12-19 21:38:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-19 21:38:18.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2019-12-19 23:00:55.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-12-19 23:52:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"537341515a9d8dc684b32d5aec8f2e36462a4f36","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-12-19 21:38:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c12063e36f3468b1ff73adca2562d5d5ad0ff496","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 22:16:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-libraries-puppet-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5ba83e95cbbb488fbd7584f38e25afb7 : SUCCESS in 10m 10s\n- puppet-openstack-libraries-puppet-syntax-4-centos-7 https://zuul.opendev.org/t/openstack/build/1a50c3dd345d4d36a6208265736d3573 : SUCCESS in 10m 20s\n- puppet-openstack-libraries-puppet-syntax-5-centos-7 https://zuul.opendev.org/t/openstack/build/43c31e45d4f440429b8ea9234fc036dd : SUCCESS in 11m 38s\n- puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9935cc09d2c94ef78ec57ded5db5acc2 : SUCCESS in 8m 37s\n- puppet-openstack-libraries-puppet-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/8d6543cb9be14532ace03c6af73f7ca7 : SUCCESS in 33m 35s\n- puppet-openstack-libraries-puppet-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/be6de11c1eb54b2983b724ba5ed78009 : SUCCESS in 23m 44s\n- puppet-openstack-libraries-puppet-beaker-rspec-centos-7 https://zuul.opendev.org/t/openstack/build/1e9ace4f37734ec79d7792018bd0751f : SUCCESS in 36m 00s\n- puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/40191f9cc30f415ead45e6b626b564fd : FAILURE in 22m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dd3e838447f2a81c32c084fcb9ade653551e3b58","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-12-19 23:00:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"887e740d6eefb3a70acd63db774fd05d0f159c09","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 23:01:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"51c89d1c5927d7cb83bde9ae9e78733f9c1cb2a9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 23:52:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"711f42149a18a7e64f12c5ae8409c231a71ced92","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-19 23:52:19.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-libraries-puppet-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/190fbbb06d994d0f98ef0daaf31744ef : SUCCESS in 6m 35s\n- puppet-openstack-libraries-puppet-syntax-4-centos-7 https://zuul.opendev.org/t/openstack/build/c4798b8775de48f6b0f454b8ddb7dadb : SUCCESS in 9m 23s\n- puppet-openstack-libraries-puppet-syntax-5-centos-7 https://zuul.opendev.org/t/openstack/build/77c805ba3d0e4fbea116c6dc84043154 : SUCCESS in 9m 23s\n- puppet-openstack-libraries-puppet-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/c1ea80ee3a9f4316a647b4f330da1d0f : SUCCESS in 7m 30s\n- puppet-openstack-libraries-puppet-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/fdaff8d446d44ba3a2a4cc0c6cb57c9e : SUCCESS in 26m 53s\n- puppet-openstack-libraries-puppet-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/f0c37a87c8ae49b2b3c2bd808e9effa7 : SUCCESS in 24m 54s\n- puppet-openstack-libraries-puppet-beaker-rspec-centos-7 https://zuul.opendev.org/t/openstack/build/57286cf847644b259658ec8a5296f99a : SUCCESS in 26m 00s\n- puppet-openstack-libraries-puppet-beaker-rspec-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3c53a8d6587d4061b70fb3c116ce464c : FAILURE in 21m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0a89185ead1538986b7bf40c87d36c8a331f2ce6","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2019-12-20 03:08:15.000000000","message":"Patch Set 1:\n\nI guess the problem is that we have an independent Rakefile for instack-undercloud which doesn\u0027t disable relative_name_inclusions,\nand this is the reason why we see failure in CI for instack_undercloud.\n https://github.com/openstack/instack-undercloud/blob/stable/rocky/Rakefile\n\nWe can confirm that puppet-foo projects inherits test configurations defined in spec helper, and properly disables relative_name_inclusions.\n Example: https://review.opendev.org/#/c/700087/\n\nHowever, I agree with this reverting because we might want to have packages pinned instead of implementing complicated rules.","accounts_in_message":[],"_revision_number":1},{"id":"a7885389061ef6b5a2f3411505f029551570d148","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-12-20 14:29:13.000000000","message":"Patch Set 1:\n\nno the issue was we were including the master version of this repo in instack-undercloud for rocky/queens. That needed to be fixed and then this revert would take effect","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f76918391c9b56535e733633dc5eaa8013085429","revisions":{"f76918391c9b56535e733633dc5eaa8013085429":{"kind":"REWORK","_number":1,"created":"2019-12-19 21:38:18.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/75/700075/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstack_spec_helper","ref":"refs/changes/75/700075/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstack_spec_helper refs/changes/75/700075/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstack_spec_helper refs/changes/75/700075/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstack_spec_helper refs/changes/75/700075/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstack_spec_helper refs/changes/75/700075/1"}}},"commit":{"parents":[{"commit":"e7e50db6cd6336a827422b14e079ee3d67b9e20c","subject":"Disable relative_classname_inclusion","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_spec_helper/commit/e7e50db6cd6336a827422b14e079ee3d67b9e20c"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-12-19 21:38:18.000000000","tz":0},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-12-19 21:38:18.000000000","tz":0},"subject":"Revert \"Disable relative_classname_inclusion\"","message":"Revert \"Disable relative_classname_inclusion\"\n\nThis reverts commit e7e50db6cd6336a827422b14e079ee3d67b9e20c.\n\nFor stable branches we want to keep 1.0.0 because we won\u0027t\nbe backporting the relative class name changes.\n\nChange-Id: I332741d21c0a532f3f99abffcf27e122b06c62d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_spec_helper/commit/f76918391c9b56535e733633dc5eaa8013085429"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstack_spec_helper/commit/f76918391c9b56535e733633dc5eaa8013085429"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}