)]}'
{"metadata.json":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2fe92b46111c38999b11351078adceb9b3e3eb00","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":35,"context_line":"    { \"name\": \"puppetlabs/mysql\", \"version_requirement\": \"\u003e\u003d3.0.0 \u003c4.0.0\" },"},{"line_number":36,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":37,"context_line":"    { \"name\": \"puppetlabs/rabbitmq\", \"version_requirement\": \"\u003e\u003d2.0.2 \u003c5.2.2\" },"},{"line_number":38,"context_line":"    { \"name\": \"puppetlabs/postgresql\", \"version_requirement\": \"\u003e\u003d3.3.0 \u003c5.0.0\" }"},{"line_number":39,"context_line":"  ]"},{"line_number":40,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"3afb71cf_105d81ec","line":37,"updated":"2015-06-11 18:50:19.000000000","message":"rabbitmq 5.2.2 uses apt \u003c2 so there shouldn\u0027t be any reason to use \u003c5.2.2. https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/5.2.2/metadata.json#L52\n\nThis should bind on a major version. If we need to pin apt, it can be added as another dependency.","commit_id":"427da080f091e4e74874799eeb41fd6bd333bb3c"}],"spec/acceptance/mysql_spec.rb":[{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"1ec7cbc4610ee4ad0af0629b5a03ed52dfc06467","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    describe \u0027listing databases\u0027 do"},{"line_number":29,"context_line":"      expect(shell(\"mysql -e \u0027show databases;\u0027|grep -q beaker\").exit_code).to be_zero"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_5e47951d","line":29,"updated":"2015-06-11 15:40:14.000000000","message":"All expects needs to be in an `it` block or a `before`/`after` block. Describe \u0026 context shouldn\u0027t contain test stuff.","commit_id":"3a842202e109fa3a4f76e628d0db9c23bf454a2d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"98db92db73fb8318d3645c54acf07a92387348cb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    describe \u0027listing databases\u0027 do"},{"line_number":29,"context_line":"      expect(shell(\"mysql -e \u0027show databases;\u0027|grep -q beaker\").exit_code).to be_zero"},{"line_number":30,"context_line":"    end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_f9865b15","line":29,"in_reply_to":"3afb71cf_5e47951d","updated":"2015-06-11 16:02:59.000000000","message":"Done","commit_id":"3a842202e109fa3a4f76e628d0db9c23bf454a2d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2fe92b46111c38999b11351078adceb9b3e3eb00","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      it \u0027should list beaker database\u0027 do"},{"line_number":30,"context_line":"        expect(shell(\"mysql -e \u0027show databases;\u0027|grep -q beaker\").exit_code).to be_zero"},{"line_number":31,"context_line":"      end"},{"line_number":32,"context_line":"    end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  end"},{"line_number":35,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3afb71cf_706ef597","line":32,"updated":"2015-06-11 18:50:19.000000000","message":"Not sure how this change is related","commit_id":"427da080f091e4e74874799eeb41fd6bd333bb3c"}],"spec/acceptance/rabbitmq_spec.rb":[{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"1ec7cbc4610ee4ad0af0629b5a03ed52dfc06467","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    end"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    describe \u0027list rabbitmq resources\u0027 do"},{"line_number":52,"context_line":"      shell(\u0027rabbitmqctl list_users\u0027) do |r|"},{"line_number":53,"context_line":"        it { expect(r.stdout).to match(/^beaker/) }"},{"line_number":54,"context_line":"        it { expect(r.stdout).not_to match(/^guest/) }"},{"line_number":55,"context_line":"        it { expect(r.exit_code).to eq(0) }"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_5ef555c9","line":52,"updated":"2015-06-11 15:40:14.000000000","message":"Shell is a command that needs to be run in an `it` block also.","commit_id":"3a842202e109fa3a4f76e628d0db9c23bf454a2d"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"25acc331a547604d97090a5ed8e6e060dd56c4dc","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        shell(\u0027rabbitmqctl list_permissions\u0027) do |r|"},{"line_number":60,"context_line":"          expect(r.stdout).to match(/^beaker\\t\\.\\*\\t\\.\\*\\t\\.\\*$/)"},{"line_number":61,"context_line":"          expect(r.stdout).to eq(0)"},{"line_number":62,"context_line":"        end"},{"line_number":63,"context_line":"      end"},{"line_number":64,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3afb71cf_15cfb3b4","line":61,"updated":"2015-06-11 18:25:16.000000000","message":"This should be `expect(r.exit_code).to eq(0)`","commit_id":"66e655b19605d16ea80daeb84d41ceccd6eb3ba1"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d90deaf4184a562ba9655d2aeeb54f774ce9f29e","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        shell(\u0027rabbitmqctl list_permissions\u0027) do |r|"},{"line_number":60,"context_line":"          expect(r.stdout).to match(/^beaker\\t\\.\\*\\t\\.\\*\\t\\.\\*$/)"},{"line_number":61,"context_line":"          expect(r.stdout).to eq(0)"},{"line_number":62,"context_line":"        end"},{"line_number":63,"context_line":"      end"},{"line_number":64,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"3afb71cf_d556bbcd","line":61,"in_reply_to":"3afb71cf_15cfb3b4","updated":"2015-06-11 18:26:54.000000000","message":"Done","commit_id":"66e655b19605d16ea80daeb84d41ceccd6eb3ba1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2fe92b46111c38999b11351078adceb9b3e3eb00","unresolved":false,"context_lines":[{"line_number":61,"context_line":"          expect(r.exit_code).to eq(0)"},{"line_number":62,"context_line":"        end"},{"line_number":63,"context_line":"      end"},{"line_number":64,"context_line":"    end"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  end"},{"line_number":67,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3afb71cf_70f5d5c9","line":64,"updated":"2015-06-11 18:50:19.000000000","message":"Why are these changes necessary?","commit_id":"427da080f091e4e74874799eeb41fd6bd333bb3c"}],"spec/spec_helper_acceptance.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"2fe92b46111c38999b11351078adceb9b3e3eb00","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      # install library modules from the forge"},{"line_number":29,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-mysql\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":30,"context_line":"      # pin puppetlabs-rabbitmq 5.2.1 to make sure we use puppetlabs-apt \u003c 2.X"},{"line_number":31,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-rabbitmq\u0027,\u0027--version\u0027,\u00275.2.1\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":32,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-apache\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":33,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-postgresql\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":34,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027stahnma-epel\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"3afb71cf_50f099c9","line":31,"updated":"2015-06-11 18:50:19.000000000","message":"5.2.2 installs apt \u003c2 https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/5.2.2/metadata.json#L52\n\nCould just install without a version and we can pin when a problem comes up.","commit_id":"427da080f091e4e74874799eeb41fd6bd333bb3c"}]}