)]}'
{"lib/puppet/provider/openstack/credentials.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"1b73079729c48ae2fd4f26f9a44afd81d12782c6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    list \u003d KEYS.delete_if { |key, val| key \u003d\u003d :identity_api_version }"},{"line_number":47,"context_line":"    list.each do |key, val|"},{"line_number":48,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":49,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa32b979_74975490","line":46,"updated":"2015-06-24 02:26:06.000000000","message":"This still deletes :identity_api_version from the global variable KEYS.  This seems wrong.","commit_id":"b2e283bc17d0f175c21db6b91bba154f0c512a08"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"65e7722ef8811ed66ad2468e32631413cb8e9203","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    list \u003d KEYS.delete_if { |key, val| key \u003d\u003d :identity_api_version }"},{"line_number":47,"context_line":"    list.each do |key, val|"},{"line_number":48,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":49,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa32b979_94c21884","line":46,"in_reply_to":"fa32b979_74975490","updated":"2015-06-24 02:27:28.000000000","message":"Also, KEYS is an array - key, val makes it seem as though you are expecting a hash?","commit_id":"b2e283bc17d0f175c21db6b91bba154f0c512a08"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"14f895e44dff76fc5f0a2fb4233e419be31cbd92","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    list \u003d KEYS.delete_if { |key, val| key \u003d\u003d :identity_api_version }"},{"line_number":47,"context_line":"    list.each do |key, val|"},{"line_number":48,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":49,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa32b979_f431240c","line":46,"in_reply_to":"fa32b979_74975490","updated":"2015-06-24 02:59:51.000000000","message":"Oh you\u0027re right! For some reason I believe there was Array#delete_if! equivalent.","commit_id":"b2e283bc17d0f175c21db6b91bba154f0c512a08"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"14f895e44dff76fc5f0a2fb4233e419be31cbd92","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  end"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    list \u003d KEYS.delete_if { |key, val| key \u003d\u003d :identity_api_version }"},{"line_number":47,"context_line":"    list.each do |key, val|"},{"line_number":48,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":49,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa32b979_d413c063","line":46,"in_reply_to":"fa32b979_94c21884","updated":"2015-06-24 02:59:51.000000000","message":"Right again, even though the second parameter is ignored it\u0027s not needed! Thanks!","commit_id":"b2e283bc17d0f175c21db6b91bba154f0c512a08"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"ef523a48156c284488a7dfb1c69f73fa2cae880e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    keys \u003d KEYS"},{"line_number":47,"context_line":"    keys.delete_if { |key| key \u003d\u003d :identity_api_version }"},{"line_number":48,"context_line":"    keys.each do |key|"},{"line_number":49,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":50,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa32b979_7c4884b3","line":47,"updated":"2015-06-24 14:02:32.000000000","message":"No::\n\n    $ irb\n    irb(main):001:0\u003e KEYS \u003d [1, 2, 3]\n    \u003d\u003e [1, 2, 3]\n    irb(main):002:0\u003e keys \u003d KEYS\n    \u003d\u003e [1, 2, 3]\n    irb(main):007:0\u003e keys.delete(1)\n    \u003d\u003e 1\n    irb(main):008:0\u003e keys\n    \u003d\u003e [2, 3]\n    irb(main):009:0\u003e KEYS\n    \u003d\u003e [2, 3]","commit_id":"da2776bc96b88d7a800603411a77bdbb3d1a9ab4"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"91b3bd2d4419c823e23a6341c1fcf4f55cbdf79f","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    keys \u003d KEYS"},{"line_number":47,"context_line":"    keys.delete_if { |key| key \u003d\u003d :identity_api_version }"},{"line_number":48,"context_line":"    keys.each do |key|"},{"line_number":49,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":50,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa32b979_81a626bf","line":47,"in_reply_to":"fa32b979_7c4884b3","updated":"2015-06-24 22:28:28.000000000","message":"Yeah, needs to be duplicated, somehow when I tested it worked so I didn\u0027t","commit_id":"da2776bc96b88d7a800603411a77bdbb3d1a9ab4"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"7bcefaeeba54e85eaba8e348fe7a5fc725b32391","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  def unset"},{"line_number":46,"context_line":"    keys \u003d KEYS"},{"line_number":47,"context_line":"    keys.delete_if { |key| key \u003d\u003d :identity_api_version }"},{"line_number":48,"context_line":"    keys.each do |key|"},{"line_number":49,"context_line":"      set(key, \u0027\u0027) if self.instance_variable_defined?(\"@#{key}\".to_sym)"},{"line_number":50,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"fa32b979_619762ec","line":47,"updated":"2015-06-24 22:37:29.000000000","message":"Nope - still deletes from KEYS","commit_id":"90e1c485c2347177af6a37918bcabe63831a6d33"}],"spec/unit/provider/openstack/credentials_spec.rb":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"dbf3357b90da9b2af32e63e050db217f8ba3f48a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        expect(creds.token).to eq(\u0027token\u0027)"},{"line_number":58,"context_line":"        expect(creds.url).to eq(\u0027url\u0027)"},{"line_number":59,"context_line":"        expect(creds.identity_api_version).to eq(\u0027identity_api_version\u0027)"},{"line_number":60,"context_line":"      end"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  end"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa32b979_6de8c9b3","line":60,"updated":"2015-06-24 15:27:28.000000000","message":"This doesn\u0027t call unset.","commit_id":"da2776bc96b88d7a800603411a77bdbb3d1a9ab4"},{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"82420cfe15fb306d401e491db082404fc6d1ac59","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        expect(creds.token).to eq(\u0027token\u0027)"},{"line_number":58,"context_line":"        expect(creds.url).to eq(\u0027url\u0027)"},{"line_number":59,"context_line":"        expect(creds.identity_api_version).to eq(\u0027identity_api_version\u0027)"},{"line_number":60,"context_line":"      end"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  end"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa32b979_8d62ed3c","line":60,"in_reply_to":"fa32b979_6de8c9b3","updated":"2015-06-24 15:28:55.000000000","message":"And it should expect auth_url, etc. to eq \u0027\u0027.","commit_id":"da2776bc96b88d7a800603411a77bdbb3d1a9ab4"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"91b3bd2d4419c823e23a6341c1fcf4f55cbdf79f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        expect(creds.token).to eq(\u0027token\u0027)"},{"line_number":58,"context_line":"        expect(creds.url).to eq(\u0027url\u0027)"},{"line_number":59,"context_line":"        expect(creds.identity_api_version).to eq(\u0027identity_api_version\u0027)"},{"line_number":60,"context_line":"      end"},{"line_number":61,"context_line":"    end"},{"line_number":62,"context_line":"  end"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa32b979_c1a66eaa","line":60,"in_reply_to":"fa32b979_6de8c9b3","updated":"2015-06-24 22:28:28.000000000","message":"Fixing it...","commit_id":"da2776bc96b88d7a800603411a77bdbb3d1a9ab4"}]}