)]}'
{"id":"openstack%2Fpuppet-openstacklib~202574","triplet_id":"openstack%2Fpuppet-openstacklib~master~I0eeebde3aac2662cc7e69bfad7f8d2481463a218","project":"openstack/puppet-openstacklib","branch":"master","topic":"inifile_proxy_provider_acceptance","hashtags":[],"change_id":"I0eeebde3aac2662cc7e69bfad7f8d2481463a218","subject":"Allow the use of an ensure_absent_val param","status":"MERGED","created":"2015-07-16 13:57:06.000000000","updated":"2015-08-18 15:43:14.000000000","submitted":"2015-08-18 15:43:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3945262043de091dba0902fbe70656d802f726b5","_number":202574,"virtual_id_number":202574,"owner":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"value":2,"date":"2015-08-18 15:43:13.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},{"value":0,"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":0,"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"recommended":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"all":[{"value":0,"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},{"value":1,"date":"2015-08-18 15:18:21.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},{"value":0,"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},{"value":1,"date":"2015-08-18 14:09:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":2,"date":"2015-08-18 12:47:29.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2015-08-18 15:29:15.000000000","_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":1,"date":"2015-08-18 12:59:57.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":0,"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"all":[{"value":0,"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":0,"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"value":0,"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},{"value":0,"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},{"value":0,"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2015-08-18 15:29:15.000000000","_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},{"value":0,"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"value":0,"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-07-16 16:34:28.000000000","updated_by":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"reviewer":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"state":"REVIEWER"},{"updated":"2015-07-16 16:34:53.000000000","updated_by":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"reviewer":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"state":"REVIEWER"},{"updated":"2015-07-16 16:35:01.000000000","updated_by":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"reviewer":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"state":"REVIEWER"},{"updated":"2015-07-28 15:06:47.000000000","updated_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"reviewer":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"state":"REVIEWER"},{"updated":"2015-08-07 17:21:15.000000000","updated_by":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"reviewer":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"state":"REVIEWER"},{"updated":"2015-08-07 17:43:28.000000000","updated_by":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"reviewer":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"state":"REVIEWER"},{"updated":"2015-08-10 12:25:25.000000000","updated_by":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"reviewer":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"state":"REVIEWER"},{"updated":"2015-08-11 13:42:38.000000000","updated_by":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"reviewer":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"state":"REVIEWER"},{"updated":"2015-08-12 14:16:50.000000000","updated_by":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"reviewer":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"state":"REVIEWER"},{"updated":"2015-08-18 12:47:29.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2015-08-18 12:59:57.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2015-08-18 14:09:53.000000000","updated_by":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"reviewer":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"state":"REVIEWER"},{"updated":"2015-08-18 15:18:21.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2015-08-18 15:29:15.000000000","updated_by":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"reviewer":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"state":"REVIEWER"},{"updated":"2015-08-18 15:43:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"46f12af9baea59c42ffc768f955796738547c294","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-07-16 13:57:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"67a80b5a3f06bd34e23ea26e4e1b6bee626b1545","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-16 15:22:17.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/74/202574/1/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/69b65a8/ : SUCCESS in 1h 15m 55s","accounts_in_message":[],"_revision_number":1},{"id":"54c20b3a6c0c55685f4425b16c043f508c928a55","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-16 15:49:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-lint/6a594c5/ : SUCCESS in 21m 17s\n- gate-puppet-openstacklib-puppet-syntax-3 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-syntax-3/e2810ae/ : SUCCESS in 21m 44s\n- gate-puppet-openstacklib-puppet-syntax-4 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-syntax-4/b026ed3/ : SUCCESS in 20m 13s\n- gate-puppet-openstacklib-puppet-unit-3.3 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-3.3/9bf5bd0/ : SUCCESS in 4m 09s\n- gate-puppet-openstacklib-puppet-unit-3.4 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-3.4/03f314f/ : SUCCESS in 4m 13s\n- gate-puppet-openstacklib-puppet-unit-3.6 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-3.6/a2cf6ee/ : SUCCESS in 5m 25s\n- gate-puppet-openstacklib-puppet-unit-3.7 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-3.7/ad063db/ : SUCCESS in 4m 09s\n- gate-puppet-openstacklib-puppet-unit-3.8 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-3.8/f4483a1/ : SUCCESS in 4m 16s\n- gate-puppet-openstacklib-puppet-unit-4.0 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-4.0/336889c/ : SUCCESS in 3m 58s\n- gate-puppet-openstacklib-puppet-unit-latest http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-unit-latest/8ce4072/ : SUCCESS in 4m 10s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/14633ce/ : SUCCESS in 7m 41s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/b722cf5/ : SUCCESS in 5m 21s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/e54c600/ : SUCCESS in 12m 48s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/c00a2a1/ : SUCCESS in 8m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6583a17145cd47273798a5c860f522e66632ee68","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-07-16 16:26:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4508fb4aefba87079f0114aa55ae189a7332a681","author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"date":"2015-07-16 16:33:07.000000000","message":"Patch Set 2:\n\nlooks good, but is there some additional logic/setting (perhaps internal to puppet?) that `ensure \u003d\u003e absent` does?","accounts_in_message":[],"_revision_number":2},{"id":"60002959ded5897baba974c2474e8b02db6f48cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-16 17:43:50.000000000","message":"Patch Set 2:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/74/202574/2/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/9715924/ : SUCCESS in 1h 11m 40s","accounts_in_message":[],"_revision_number":2},{"id":"7a4b7fb04800212d714af8e34c10d8aa516c42a6","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2015-07-16 19:26:30.000000000","message":"Patch Set 2: Code-Review-2\n\nThere are configs where an empty value is valid and required. An example of such config is dhcp_domain in nova.conf:\nhttp://docs.openstack.org/kilo/config-reference/content/list-of-compute-config-options.html","accounts_in_message":[],"_revision_number":2},{"id":"d484316d27ac21f54d64a4068b99f692f2a888e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-16 20:42:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-lint/bdf27a8/ : SUCCESS in 3m 26s\n- gate-puppet-openstacklib-puppet-syntax-3 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-syntax-3/6601f35/ : SUCCESS in 3m 30s\n- gate-puppet-openstacklib-puppet-syntax-4 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-syntax-4/0e7af11/ : SUCCESS in 3m 25s\n- gate-puppet-openstacklib-puppet-unit-3.3 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-3.3/0761251/ : SUCCESS in 4m 24s\n- gate-puppet-openstacklib-puppet-unit-3.4 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-3.4/f5f6c18/ : SUCCESS in 4m 01s\n- gate-puppet-openstacklib-puppet-unit-3.6 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-3.6/87c0d1e/ : SUCCESS in 4m 29s\n- gate-puppet-openstacklib-puppet-unit-3.7 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-3.7/dc80a2b/ : SUCCESS in 3m 56s\n- gate-puppet-openstacklib-puppet-unit-3.8 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-3.8/41448b8/ : SUCCESS in 4m 03s\n- gate-puppet-openstacklib-puppet-unit-4.0 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-4.0/861c75c/ : SUCCESS in 3m 32s\n- gate-puppet-openstacklib-puppet-unit-latest http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-unit-latest/48c155c/ : SUCCESS in 3m 26s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/2e2c8d2/ : SUCCESS in 8m 46s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/d80652e/ : SUCCESS in 6m 35s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/b2b053f/ : SUCCESS in 13m 32s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/2/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/062e099/ : SUCCESS in 12m 47s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6a43693fa221a74a1cb4a162392b43476486a656","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-23 21:30:42.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"b0d6861efd8ca621b84b98c1b53c451b5e7af5ba","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-07-27 08:28:04.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"73fb1d2c4ad5cea4902a8817b3b9da77f32bfcf5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-27 08:48:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-lint/0b32780/ : SUCCESS in 3m 47s\n- gate-puppet-openstacklib-puppet-syntax-3 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-syntax-3/1b7c766/ : SUCCESS in 3m 24s\n- gate-puppet-openstacklib-puppet-syntax-4 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-syntax-4/c32e39d/ : SUCCESS in 3m 15s\n- gate-puppet-openstacklib-puppet-unit-3.3 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-3.3/42e2354/ : SUCCESS in 3m 52s\n- gate-puppet-openstacklib-puppet-unit-3.4 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-3.4/f573054/ : SUCCESS in 3m 27s\n- gate-puppet-openstacklib-puppet-unit-3.6 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-3.6/86ae977/ : SUCCESS in 3m 39s\n- gate-puppet-openstacklib-puppet-unit-3.7 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-3.7/fb29cfc/ : SUCCESS in 4m 13s\n- gate-puppet-openstacklib-puppet-unit-3.8 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-3.8/e880d7e/ : SUCCESS in 4m 34s\n- gate-puppet-openstacklib-puppet-unit-4.0 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-4.0/8ce9f9c/ : SUCCESS in 3m 57s\n- gate-puppet-openstacklib-puppet-unit-latest http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-unit-latest/3740d04/ : SUCCESS in 3m 58s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/1d258fe/ : SUCCESS in 6m 36s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/cd46a4f/ : SUCCESS in 4m 42s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/95e4617/ : FAILURE in 5m 54s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/3/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/9350596/ : SUCCESS in 7m 28s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"ab82e8e5382f39aa8a80df0345e2b89b85bcb199","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-27 09:39:22.000000000","message":"Patch Set 3:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/74/202574/3/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/1bf5039/ : FAILURE in 1h 11m 11s","accounts_in_message":[],"_revision_number":3},{"id":"bd677c6d2374e11da2ac6a895d34f399e39466d2","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-07-27 12:50:18.000000000","message":"Patch Set 3:\n\ncan we have unit testing and *maybe* acceptance tests (not required but would be great).","accounts_in_message":[],"_revision_number":3},{"id":"9446747bfb21cc4c90ed0b58d5aff503935c6890","author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"date":"2015-07-27 14:43:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"072a3fdac85e0d26ad7b0d6594f8fe5e462a7d25","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2015-07-28 15:06:47.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3},{"id":"8701de6ab1ca25eb5aafc4474e78b4abf5a5f6a6","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2015-07-29 20:42:05.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"f1c2a357a94d141c905dfb0a703f336d04aec5c7","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2015-08-04 07:25:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"58ed2778836aa47cb703b0b49d5384152215aa0f","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-05 11:07:15.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"923a3c0f0f07655c0d4ad65be7a38bd15e8fe94a","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-05 11:08:37.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c1e60c338b91778133a4908f4b95d0e7d4efeb72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-05 11:51:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-lint/82b45cc/ : SUCCESS in 2m 44s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/a6b42c3/ : SUCCESS in 2m 46s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/75292ae/ : SUCCESS in 4m 05s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/2be73ba/ : SUCCESS in 3m 25s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/f534500/ : SUCCESS in 3m 42s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/c21443e/ : SUCCESS in 3m 28s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/af9a60a/ : SUCCESS in 3m 12s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/107ca48/ : SUCCESS in 3m 17s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/7952036/ : SUCCESS in 3m 15s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/2ddf726/ : SUCCESS in 3m 40s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/511adf9/ : SUCCESS in 6m 01s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/fa2d95a/ : SUCCESS in 5m 38s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/9be8954/ : FAILURE in 9m 07s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/5/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/0c1334a/ : FAILURE in 9m 54s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"db283aa9c977bbaa78a4b724e5ab25e7d90ea1d8","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2015-08-05 12:32:40.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"a7a3abe5037b3f6e8327c376e08210696325f86f","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-05 13:54:37.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"9269ce2749f4463bee06e0edfee168f6e7fc5d5d","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-05 14:57:37.000000000","message":"Patch Set 6:\n\n@Emilien: I am not sure to know how the behavior can be tested here in this commit. openstack_config is not meant to be called directly, hence the type provide no parameters. Except running Puppet::Type.new(:openstack_config), I am not sure what can be tested.\n\nOn the other hand, the behavior of the functionality this review brings can be tested on our modules. Here is an example with puppet-keystone[1]\n\n[1]","accounts_in_message":[],"_revision_number":6},{"id":"08b675406ccb79dd86694d65642d9ae40634b660","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-05 14:57:49.000000000","message":"Patch Set 6:\n\n[1] https://review.openstack.org/#/c/202513/7/spec/acceptance/keystone_config_spec.rb,cm","accounts_in_message":[],"_revision_number":6},{"id":"3269c35994d457ce58ea26b5a30755e90466c03c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-05 15:52:43.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-lint/1d0b204/ : SUCCESS in 2m 43s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/aff6cc2/ : SUCCESS in 3m 12s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/454d2a6/ : SUCCESS in 2m 45s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/05a067c/ : SUCCESS in 3m 29s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/8386d41/ : SUCCESS in 3m 45s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/4bacadd/ : SUCCESS in 4m 05s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/18c3139/ : SUCCESS in 3m 19s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/80c77a7/ : SUCCESS in 3m 23s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/3c9c852/ : SUCCESS in 4m 17s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/86e29e9/ : SUCCESS in 2m 53s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/da5457f/ : SUCCESS in 7m 42s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/bc6ba04/ : SUCCESS in 6m 26s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/be7a88a/ : FAILURE in 10m 13s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/6/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/cfb988e/ : FAILURE in 8m 54s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"991de6268f26363283a0160f4ca1fe31e6d7ee60","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-08-07 16:01:07.000000000","message":"Patch Set 6: Code-Review-1\n\nLooks good, but in this case we need specify ensure_absent_val several times in one class, because sometimes ensure_absent_val can be \u0027undef\u0027, but \u0027false\u0027 in another cases.\n\nI\u0027d prefer use \u0027ensure \u003d\u003e absent\u0027 instead of setting ensure_absent_val.","accounts_in_message":[],"_revision_number":6},{"id":"b1df0c91b0f69297eb1bd352bd5ed611b4ff5cca","author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"date":"2015-08-07 17:21:15.000000000","message":"Patch Set 6:\n\nDenis, the intent is that all those \u0027undef\u0027 and \u0027false\u0027 values that are in modules currently will be converted to \u0027\u003cSERVICE DEFAULT\u003e\u0027.  In addition, any parameters that are intended set to values that match the service default will be set to this also.  That way we can avoid the if/else clause currently required for every one of these situations.","accounts_in_message":[],"_revision_number":6},{"id":"5821b424f837a28e96854ed1f9a226bf62dc743b","author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"date":"2015-08-07 17:43:28.000000000","message":"Patch Set 6:\n\n(1 comment)\n\nAre there going to be spec tests?  functional tests?","accounts_in_message":[],"_revision_number":6},{"id":"888bf0f6e9d950c81e90170ced341e70e338ec58","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-08-07 17:59:18.000000000","message":"Patch Set 6:\n\nClayton, so, will be replaced all default parameters, which by default have no any params and which can be undefined? All another parameters will not be changed, right?","accounts_in_message":[],"_revision_number":6},{"id":"2711feccf537a088cbbb42424451eb21fe4ee8d9","author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"date":"2015-08-07 18:16:12.000000000","message":"Patch Set 6:\n\nI\u0027m sorry Denis, I don\u0027t understand the question.  Can you rephrase?\n\nParameters that translate directly into config file directives that current ly have puppet class level defaults will generally be replaced with the string \u0027\u003cSERVICE DEFAULT\u003e\u0027 if the underlying service has a reasonable default for that value.  That means Puppet won\u0027t write a value and will remove it if it\u0027s there, since the user hasn\u0027t asked for it to set to something specific.  This allows the Puppet module maintainers to avoid having keep the default values in the classes in sync with the service config file defaults.","accounts_in_message":[],"_revision_number":6},{"id":"dd79feac934b747fabe0fe1556e934a8ae024229","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-08-07 21:56:55.000000000","message":"Patch Set 6: -Code-Review\n\nClayton, sorry for unclear question, but you gave me the answer.\n\n\u003e\u003e That means Puppet won\u0027t write a value and will remove it if it\u0027s there, since the user hasn\u0027t asked for it to set to something specific.\n\nIt was exactly what i want to know. Thank you!","accounts_in_message":[],"_revision_number":6},{"id":"d8e72d57a40706a38c48dde553f52cd6c28bdfa6","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2015-08-10 11:56:07.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"4d1cd7f91c54633e644fc5e64fe7ba23e18f1669","author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"date":"2015-08-10 12:25:25.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"22132786e0655d50dab3e19608237764301f5abb","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-08-11 13:42:19.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"8dbe60c4bbfebb3e02722b414e16a402b4dad454","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-08-11 13:44:29.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"661ee769bc5af3568e77609f006eeaa52f747d35","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-11 13:58:05.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-lint/be629dd/ : SUCCESS in 2m 32s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/9b5b60b/ : SUCCESS in 3m 02s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/832d313/ : SUCCESS in 2m 54s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/fcb3dfe/ : SUCCESS in 3m 26s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/5cf0932/ : SUCCESS in 2m 54s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/2d4d93e/ : SUCCESS in 3m 44s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/d926a2c/ : SUCCESS in 3m 10s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/f533c7d/ : SUCCESS in 3m 11s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/10c298f/ : SUCCESS in 2m 57s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/2a1e027/ : SUCCESS in 3m 01s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/87e795f/ : SUCCESS in 5m 39s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/823ee42/ : SUCCESS in 6m 06s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/8fa6847/ : FAILURE in 11m 48s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/7/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/d2f9e4d/ : FAILURE in 8m 16s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"d6e359ddbf1528b9c7fb53021f4f616a8767463d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-11 20:17:45.000000000","message":"Patch Set 7:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/74/202574/7/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/2dcc8d5/ : FAILURE in 8m 01s","accounts_in_message":[],"_revision_number":7},{"id":"8d95faf9768cd00c21c5614ecc9d064519c49c9a","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-13 10:13:35.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"ae237d896c6190c6841d1fd60334ba4b98b62c0a","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2015-08-13 10:17:25.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"8a74b942fe7991a68d2f31e4e352e4f0c256de55","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2015-08-13 12:07:51.000000000","message":"Patch Set 7: Code-Review+1","accounts_in_message":[],"_revision_number":7},{"id":"226ed34664c989e56f5797b9236876141717a845","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-14 10:44:06.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"4d6109b02c4cd1bcc6e5d918ebeca94c64b5d132","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 10:56:24.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-lint/34468a0/ : SUCCESS in 2m 44s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/9bc15a7/ : SUCCESS in 2m 30s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/d770996/ : SUCCESS in 2m 50s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/8aef14f/ : SUCCESS in 3m 42s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/2974dd5/ : SUCCESS in 3m 14s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/bd04e18/ : SUCCESS in 3m 10s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/45be12f/ : SUCCESS in 4m 08s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/9c2ad04/ : SUCCESS in 3m 40s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/441ec5f/ : SUCCESS in 3m 21s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/566c32e/ : SUCCESS in 3m 17s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/23067c7/ : SUCCESS in 5m 40s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/af7b4ff/ : SUCCESS in 5m 01s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/1d2e4a3/ : SUCCESS in 9m 21s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/8/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/ae3d132/ : FAILURE in 8m 25s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"0061256031427897ee3b2a5fad3aa242323b697a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-14 12:02:14.000000000","message":"Patch Set 8:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/74/202574/8/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/fa001bb/ : SUCCESS in 1h 17m 44s","accounts_in_message":[],"_revision_number":8},{"id":"07c1c4063c88331813307ddcc849e9b0af53b06f","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-18 07:40:52.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"c5931382ced95d928f95b9f5404ac6348ae34d2a","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-08-18 07:47:06.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"5a82e5d7051b3ca09e075971d462377d12df81db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-18 08:01:58.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-lint/36d7d91/ : SUCCESS in 3m 24s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/c513883/ : SUCCESS in 2m 44s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/1e5e35c/ : SUCCESS in 2m 33s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/43a79ad/ : SUCCESS in 3m 38s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/eeac0a3/ : SUCCESS in 3m 25s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/bf21bab/ : SUCCESS in 3m 57s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/832c4ca/ : SUCCESS in 3m 15s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/d320dfc/ : SUCCESS in 3m 21s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/85031c3/ : SUCCESS in 2m 57s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/d572294/ : SUCCESS in 3m 03s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/2aa100e/ : SUCCESS in 5m 39s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/81292cf/ : SUCCESS in 5m 41s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/9a552e6/ : SUCCESS in 8m 34s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/74/202574/10/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/f5e850a/ : SUCCESS in 8m 40s (non-voting)","accounts_in_message":[],"_revision_number":10},{"id":"638d54012d4765fea7adb43a6412f74cff9db832","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-18 09:07:00.000000000","message":"Patch Set 10:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/74/202574/10/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/89f8774/ : SUCCESS in 1h 19m 31s","accounts_in_message":[],"_revision_number":10},{"id":"992a9185e9a8b12bc52876f223a5028686f13008","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-08-18 12:47:29.000000000","message":"Patch Set 10: Code-Review+2","accounts_in_message":[],"_revision_number":10},{"id":"45afadf1a2cc0024d2fc9f5223c50e51ed235ee6","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2015-08-18 12:59:57.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"ffa5c3ebe414acecc394f61e66c4b79eb3f9ded9","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2015-08-18 14:09:53.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"e8b2bb12582c1b3ada6224d03e8fc229f4529eca","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2015-08-18 15:18:21.000000000","message":"Patch Set 10: Code-Review+1","accounts_in_message":[],"_revision_number":10},{"id":"016543a04493481a6af9c1a20b9a3d68b1052c88","author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"date":"2015-08-18 15:29:15.000000000","message":"Patch Set 10: Code-Review+2 Workflow+1\n\nThanks Yanis, great change!!","accounts_in_message":[],"_revision_number":10},{"id":"987d8824bbda78bffc293eb87073d880dcd38123","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-18 15:29:43.000000000","message":"Patch Set 10: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":10},{"id":"006328a71c7cb3507bcb7e92d8c45b1709a5b6d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-18 15:43:13.000000000","message":"Patch Set 10: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-lint/3917aa3/ : SUCCESS in 3m 00s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/5606196/ : SUCCESS in 2m 51s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/d976291/ : SUCCESS in 2m 29s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/4630ea5/ : SUCCESS in 3m 14s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/7045d9f/ : SUCCESS in 3m 15s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/85bd123/ : SUCCESS in 3m 18s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/e31ae6d/ : SUCCESS in 3m 30s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/f90f7a7/ : SUCCESS in 3m 23s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/830c54b/ : SUCCESS in 3m 01s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/a5a6afd/ : SUCCESS in 5m 44s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/74/202574/10/gate/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/974d6ea/ : SUCCESS in 5m 33s","accounts_in_message":[],"_revision_number":10},{"id":"22df401f62e58e8fd4f90fc31f6ae5600ef0cafe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-08-18 15:43:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"3b85306d042292713d0fd89fa508e0a0fbf99671","revisions":{"cd50ef0979d4053753818887909ed5d7716ba709":{"kind":"REWORK","_number":1,"created":"2015-07-16 13:57:06.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/1"}}},"commit":{"parents":[{"commit":"05f4cbdf6bfe484e83bd68ff619ee68dfe4dc83b","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/05f4cbdf6bfe484e83bd68ff619ee68dfe4dc83b"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027nil\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027nil\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified. \u0027nil\u0027 being a valid value in some case, this is why\nit has been parametrized.\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/cd50ef0979d4053753818887909ed5d7716ba709"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/cd50ef0979d4053753818887909ed5d7716ba709"}]},"branch":"refs/heads/master"},"3e9ff4a50e702e1f69b889b65907fa4268b032bb":{"kind":"REWORK","_number":2,"created":"2015-07-16 16:26:12.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/2"}}},"commit":{"parents":[{"commit":"05f4cbdf6bfe484e83bd68ff619ee68dfe4dc83b","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/05f4cbdf6bfe484e83bd68ff619ee68dfe4dc83b"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 16:24:36.000000000","tz":120},"subject":"Allow to ensure absent a config when value set to empty string","message":"Allow to ensure absent a config when value set to empty string\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when the empty\nstring keyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e \u0027\u0027 }\n\nwould mean the same as\n\nkeystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3e9ff4a50e702e1f69b889b65907fa4268b032bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3e9ff4a50e702e1f69b889b65907fa4268b032bb"}]},"branch":"refs/heads/master"},"d81d3128158ff28b54414eea0605459b29e0602c":{"kind":"REWORK","_number":3,"created":"2015-07-27 08:28:04.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/3"}}},"commit":{"parents":[{"commit":"f754ef3bcf05177e50375c6464231214f66f83f8","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f754ef3bcf05177e50375c6464231214f66f83f8"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-27 08:27:03.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/d81d3128158ff28b54414eea0605459b29e0602c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/d81d3128158ff28b54414eea0605459b29e0602c"}]},"branch":"refs/heads/master"},"da612a5587ddcb60cc11f20fde4f2285b537cd58":{"kind":"REWORK","_number":4,"created":"2015-08-05 11:07:15.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/4"}}},"commit":{"parents":[{"commit":"f754ef3bcf05177e50375c6464231214f66f83f8","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f754ef3bcf05177e50375c6464231214f66f83f8"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-08-05 11:07:05.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/da612a5587ddcb60cc11f20fde4f2285b537cd58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/da612a5587ddcb60cc11f20fde4f2285b537cd58"}]},"branch":"refs/heads/master"},"3012225ab42119cd3799bec4b4eef08aaea2f60a":{"kind":"REWORK","_number":5,"created":"2015-08-05 11:08:37.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/5"}}},"commit":{"parents":[{"commit":"f754ef3bcf05177e50375c6464231214f66f83f8","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f754ef3bcf05177e50375c6464231214f66f83f8"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-08-05 11:08:26.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3012225ab42119cd3799bec4b4eef08aaea2f60a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3012225ab42119cd3799bec4b4eef08aaea2f60a"}]},"branch":"refs/heads/master"},"888454c591d7af0cd381682478142fe28c0dea57":{"kind":"REWORK","_number":6,"created":"2015-08-05 13:54:37.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/6"}}},"commit":{"parents":[{"commit":"f754ef3bcf05177e50375c6464231214f66f83f8","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f754ef3bcf05177e50375c6464231214f66f83f8"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-08-05 13:54:25.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/888454c591d7af0cd381682478142fe28c0dea57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/888454c591d7af0cd381682478142fe28c0dea57"}]},"branch":"refs/heads/master"},"dd3f5ee9d2b1340ed648ad0525469d61367214f2":{"kind":"REWORK","_number":7,"created":"2015-08-11 13:42:19.000000000","uploader":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"ref":"refs/changes/74/202574/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/7"}}},"commit":{"parents":[{"commit":"f754ef3bcf05177e50375c6464231214f66f83f8","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f754ef3bcf05177e50375c6464231214f66f83f8"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Denis Egorenko","email":"degorenko@mirantis.com","date":"2015-08-11 13:42:18.000000000","tz":180},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nAlso added new tests for openstack_config provider.\n\nCo-Authored-By: Denis Egorenko \u003cdegorenko@mirantis.com\u003e\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/dd3f5ee9d2b1340ed648ad0525469d61367214f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/dd3f5ee9d2b1340ed648ad0525469d61367214f2"}]},"branch":"refs/heads/master"},"64423da397db4b9995802b928e5e3128ba8821ad":{"kind":"REWORK","_number":8,"created":"2015-08-14 10:44:06.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/8"}}},"commit":{"parents":[{"commit":"9ce94f1fa618c774041293f8ed08174673f49b50","subject":"update openstacklib reference","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/9ce94f1fa618c774041293f8ed08174673f49b50"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-08-14 10:43:36.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/64423da397db4b9995802b928e5e3128ba8821ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/64423da397db4b9995802b928e5e3128ba8821ad"}]},"branch":"refs/heads/master"},"99af4e95cedfe4a197600be74ed84c535e55eefe":{"kind":"REWORK","_number":9,"created":"2015-08-18 07:40:52.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/9"}}},"commit":{"parents":[{"commit":"f754ef3bcf05177e50375c6464231214f66f83f8","subject":"Add a proxy inifile provider","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f754ef3bcf05177e50375c6464231214f66f83f8"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-08-18 07:40:32.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nAlso added new tests for openstack_config provider\n\nCo-Authored-By: Denis Egorenko \u003cdegorenko@mirantis.com\u003e\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/99af4e95cedfe4a197600be74ed84c535e55eefe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/99af4e95cedfe4a197600be74ed84c535e55eefe"}]},"branch":"refs/heads/master"},"3b85306d042292713d0fd89fa508e0a0fbf99671":{"kind":"TRIVIAL_REBASE","_number":10,"created":"2015-08-18 07:47:06.000000000","uploader":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"ref":"refs/changes/74/202574/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/74/202574/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/74/202574/10"}}},"commit":{"parents":[{"commit":"9ce94f1fa618c774041293f8ed08174673f49b50","subject":"update openstacklib reference","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/9ce94f1fa618c774041293f8ed08174673f49b50"}]}],"author":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-07-16 13:53:33.000000000","tz":120},"committer":{"name":"Yanis Guenane","email":"yguenane@redhat.com","date":"2015-08-18 07:46:19.000000000","tz":120},"subject":"Allow the use of an ensure_absent_val param","message":"Allow the use of an ensure_absent_val param\n\nThis commit aims to add a new feature for the ini_setting provider, this\nfeature aims to simulate the ensure \u003d\u003e absent behavior when a specific\nkeyword is specified.\n\nCurrently a pattern we have is\n\nif $myvar {\n  keystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n} else {\n  keystone_config { \u0027SECTION/setting\u0027 : ensure \u003d\u003e absent }\n}\n\nIf one has dozens or hundreds of parameters to handle then it can easily\nmake the manifest hard to read.\n\nThe solution offer here would turn the above example in something like\n\nKeystone_config {\n  ensure_absent_val \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027 # It is the default\n}\n\nkeystone_config { \u0027SECTION/setting\u0027 : value \u003d\u003e $myvar }\n\nIf `$myvar` is \u0027\u003cSERVICE DEFAULT\u003e\u0027 then it will act as if `ensure \u003d\u003e absent` would\nhave been specified.\n\nAlso added new tests for openstack_config provider\n\nCo-Authored-By: Denis Egorenko \u003cdegorenko@mirantis.com\u003e\n\nChange-Id: I0eeebde3aac2662cc7e69bfad7f8d2481463a218\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3b85306d042292713d0fd89fa508e0a0fbf99671"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3b85306d042292713d0fd89fa508e0a0fbf99671"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}