)]}'
{"id":"openstack%2Fpuppet-openstacklib~224187","triplet_id":"openstack%2Fpuppet-openstacklib~master~Ic0665485d855225aaa522074e4505d704b0c513b","project":"openstack/puppet-openstacklib","branch":"master","topic":"service_default","hashtags":[],"change_id":"Ic0665485d855225aaa522074e4505d704b0c513b","subject":"Create service_default function","status":"ABANDONED","created":"2015-09-16 16:33:37.000000000","updated":"2015-10-05 12:40:12.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a0439a6b3fbffcdb1071a465bcc41f764e227ee4","_number":224187,"virtual_id_number":224187,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},{"value":1,"date":"2015-09-16 17:28:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"disliked":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":-1,"date":"2015-10-01 14:28:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2015-09-18 08:05:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":1,"date":"2015-09-17 09:15:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"value":1,"date":"2015-09-17 13:24:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2015-09-19 14:19:19.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"value":-1,"date":"2015-09-23 00:30:28.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},{"value":1,"date":"2015-09-22 15:02:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-09-22 15:27:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},{"value":0,"date":"2015-09-22 15:02:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-16 17:28:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-09-17 09:15:00.000000000","updated_by":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"reviewer":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"state":"REVIEWER"},{"updated":"2015-09-17 13:24:22.000000000","updated_by":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"reviewer":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"state":"REVIEWER"},{"updated":"2015-09-18 08:05:33.000000000","updated_by":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"reviewer":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"state":"REVIEWER"},{"updated":"2015-09-19 14:19:19.000000000","updated_by":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"reviewer":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"state":"REVIEWER"},{"updated":"2015-09-22 15:02:03.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"},{"updated":"2015-09-23 00:30:28.000000000","updated_by":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"reviewer":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"state":"REVIEWER"},{"updated":"2015-10-01 14:28:46.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"}],"messages":[{"id":"6dfeedf3e0ab5a1939dab0d31a3a157b751124a9","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2015-09-16 16:33:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"15bb73868fad8f7a408cdf19afa1cab44cd88c71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-16 16:41:46.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/87/224187/1/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/7f7d11c/ : FAILURE in 7m 31s","accounts_in_message":[],"_revision_number":1},{"id":"15dbfaa64bfa546b65476158e283b7605bcad355","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-16 17:28:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-lint/9852dcf/ : SUCCESS in 1m 04s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/fa3cfee/ : SUCCESS in 2m 53s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/237476d/ : SUCCESS in 2m 43s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/ddef964/ : SUCCESS in 4m 07s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/97f2d6d/ : SUCCESS in 4m 28s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/bae0018/ : SUCCESS in 2m 58s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/8f38f2a/ : SUCCESS in 3m 15s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/eb418a1/ : SUCCESS in 3m 35s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/a5342d3/ : SUCCESS in 3m 44s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/27c07ea/ : SUCCESS in 3m 16s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/9e4df9b/ : SUCCESS in 5m 10s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/c079945/ : SUCCESS in 5m 32s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/4332d5b/ : SUCCESS in 9m 57s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/09accb5/ : SUCCESS in 7m 31s (non-voting)\n- gate-puppet-openstack-integration-dsvm-trusty http://logs.openstack.org/87/224187/1/check/gate-puppet-openstack-integration-dsvm-trusty/abf8cca/ : SUCCESS in 18m 50s (non-voting)\n- gate-puppet-openstack-integration-dsvm-centos7 http://logs.openstack.org/87/224187/1/check/gate-puppet-openstack-integration-dsvm-centos7/c009c9a/ : FAILURE in 9m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8d4094c8611c1032b1e2a46eb971dffced5a812d","author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"date":"2015-09-17 09:15:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6bdd1266012a8700d651457fdec48531f052dfd2","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2015-09-17 13:24:22.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f582e9a15420f1739bc0a87c9a5a4e9bc58f5a0d","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-09-18 08:05:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d394e90fbd13b5c0be5fc59ed6f94eab2831f5a1","author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"date":"2015-09-19 14:19:19.000000000","message":"Patch Set 1: Code-Review+1\n\nGood idea, Alex!","accounts_in_message":[],"_revision_number":1},{"id":"4f681e2fc2e04b49415df38337f1c719cb1ba7b0","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2015-09-22 15:02:37.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d535d5af4d5d0a1dc28ceef27216ea8e0c135916","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2015-09-22 15:27:11.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"5fbe27d110fed720c9bca6faa5de2f2f73ad8b17","author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"date":"2015-09-23 00:30:28.000000000","message":"Patch Set 1: Code-Review-1\n\nSee my response to the list thread.\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-September/075202.html","accounts_in_message":[],"_revision_number":1},{"id":"0d22a9934afee04eb69495ad7f35e918f455e427","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-10-01 14:28:46.000000000","message":"Patch Set 1: Code-Review-1\n\nThanks for this work, but I would vote for using the facter approach.","accounts_in_message":[],"_revision_number":1},{"id":"964d6d9983c8893bafbc23fc73736e3bfe7c0193","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2015-10-05 12:40:12.000000000","message":"Abandoned\n\nwent with a fact instead","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"217162e8581a15f8e0dcffcb3cd58373547e8439","revisions":{"217162e8581a15f8e0dcffcb3cd58373547e8439":{"kind":"REWORK","_number":1,"created":"2015-09-16 16:33:37.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/87/224187/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/87/224187/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/87/224187/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/87/224187/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/87/224187/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/87/224187/1"}}},"commit":{"parents":[{"commit":"74de9e1d3434e35e2ef7277090738533f27c0099","subject":"Create is_service_default function","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/74de9e1d3434e35e2ef7277090738533f27c0099"}]}],"author":{"name":"Alex Schultz","email":"aschultz@mirantis.com","date":"2015-09-16 16:19:19.000000000","tz":-300},"committer":{"name":"Alex Schultz","email":"aschultz@mirantis.com","date":"2015-09-16 16:19:19.000000000","tz":-300},"subject":"Create service_default function","message":"Create service_default function\n\nThis change creates a parser function that can be used in place of the\nstring \u0027\u003cSERVICE DEFAULT\u003e\u0027 for class parameters or anywhere someone\nwould want to specify the string within puppet code.\n\nThings like:\n class openstack::class (\n    $param_user \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027,\n    $param_pass \u003d \u0027\u003cSERVICE DEFAULT\u003e\u0027) { ... }\n\nCan be replaced with:\n  class openstack::class (\n    $param_user \u003d service_default(),\n    $param_pass \u003d service_default()) { ...  }\n\nLeveraging this function instead of the constant use \u0027\u003cSERVICE DEFAULT\u003e\u0027\nallows for easy refactoring and reduces the posibility for typos to make\nit past reviews. Ideally it would be awesome if we could create our own\ncustom puppet reserved word or a constant but since you cannot do this,\na parser function allows for similar functionality.\n\nChange-Id: Ic0665485d855225aaa522074e4505d704b0c513b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/217162e8581a15f8e0dcffcb3cd58373547e8439"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/217162e8581a15f8e0dcffcb3cd58373547e8439"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}