)]}'
{"id":"openstack%2Fpuppet-openstacklib~228662","triplet_id":"openstack%2Fpuppet-openstacklib~master~Iab80390eae5f47eae78c11bfec54fa44f01b1451","project":"openstack/puppet-openstacklib","branch":"master","topic":"servicedefault_params_pattern","hashtags":[],"change_id":"Iab80390eae5f47eae78c11bfec54fa44f01b1451","subject":"[WIP] Adds a params class for common data.","status":"ABANDONED","created":"2015-09-28 23:27:27.000000000","updated":"2015-10-07 20:22:44.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4852de59f1763946f35458ec5dbf057c4980ef3f","_number":228662,"virtual_id_number":228662,"owner":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2015-09-28 23:55:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":-1,"date":"2015-10-01 14:34:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"all":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-09-28 23:56:10.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-28 23:55:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-01 14:34:54.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"}],"messages":[{"id":"281d8536de015ee27f554638da3b5a9549c2e147","author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"date":"2015-09-28 23:27:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fbd91cb1882ce756fcdb2085a81017d94f106160","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-28 23:55:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-lint/50f396f/ : SUCCESS in 56s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/39e3254/ : SUCCESS in 3m 00s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/e84c067/ : SUCCESS in 2m 51s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/50541c6/ : SUCCESS in 3m 22s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/00e2fe8/ : SUCCESS in 3m 13s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/85f70c0/ : SUCCESS in 3m 03s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/21320ae/ : SUCCESS in 3m 06s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/0cf44cc/ : SUCCESS in 3m 43s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/1a8cfc5/ : SUCCESS in 3m 05s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/dff8b22/ : SUCCESS in 3m 06s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/e589cbe/ : SUCCESS in 5m 20s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/6e0369c/ : SUCCESS in 5m 40s\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-trusty/537f39a/ : SUCCESS in 10m 00s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-upgrade-dsvm-centos7/ba83dd7/ : SUCCESS in 7m 45s (non-voting)\n- gate-puppet-openstack-integration-dsvm-trusty http://logs.openstack.org/62/228662/1/check/gate-puppet-openstack-integration-dsvm-trusty/c29559d/ : SUCCESS in 20m 05s (non-voting)\n- gate-puppet-openstack-integration-dsvm-centos7 http://logs.openstack.org/62/228662/1/check/gate-puppet-openstack-integration-dsvm-centos7/441c88f/ : FAILURE in 23m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"298251ae59c9caece2984e9763697dcfafbc9627","author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"date":"2015-09-28 23:56:10.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"ea91eb79b874e342a3f344a3a4dc317d1ca677ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-29 01:07:50.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ironic-overcloud-f21puppet-nonha http://logs.openstack.org/62/228662/1/check-tripleo/gate-tripleo-ironic-overcloud-f21puppet-nonha/b2bc098/ : SUCCESS in 1h 40m 16s","accounts_in_message":[],"_revision_number":1},{"id":"6aff2a7605ab2c09a824c595e0030ea3ee421b7c","author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"date":"2015-09-29 14:41:55.000000000","message":"Topic set to servicedefault_params_pattern","accounts_in_message":[],"_revision_number":1},{"id":"1af90b0edfc8e8df08a22b0a638f35e11acd4c49","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-10-01 14:34:54.000000000","message":"Patch Set 1: Code-Review-1\n\nI do prefer the facter approach, but this is only my vote.","accounts_in_message":[],"_revision_number":1},{"id":"4852de59f1763946f35458ec5dbf057c4980ef3f","author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"date":"2015-10-07 20:22:44.000000000","message":"Abandoned\n\nWe decided that the define type trade off was to high.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"be139fa9a4edca1631ff5004d904284c5b7efe8e","revisions":{"be139fa9a4edca1631ff5004d904284c5b7efe8e":{"kind":"REWORK","_number":1,"created":"2015-09-28 23:27:27.000000000","uploader":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"ref":"refs/changes/62/228662/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/62/228662/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/62/228662/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/62/228662/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/62/228662/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/62/228662/1"}}},"commit":{"parents":[{"commit":"f189ec154a7a11721539e841ea2a61850cbddfeb","subject":"Merge \"Allow to path custom fragment to vhost\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f189ec154a7a11721539e841ea2a61850cbddfeb"}]}],"author":{"name":"Cody Herriges","email":"cody@herriges.org","date":"2015-09-28 23:24:27.000000000","tz":-420},"committer":{"name":"Cody Herriges","email":"cody@herriges.org","date":"2015-09-28 23:27:25.000000000","tz":-420},"subject":"[WIP] Adds a params class for common data.","message":"[WIP] Adds a params class for common data.\n\n  This commit will add a simple params class that sets the\n  $servicedefault variable.  The intention is that this class will be\n  inherited by all other Puppet OpenStack modules\u0027 params classes.\n\n  Without this change, we need to place the static string \u0027\u003cSERVICE\n  DEFAULT\u003e\u0027 everywhere and if we ever want to change what that string\n  is, we need to change it everywhere.\n\nChange-Id: Iab80390eae5f47eae78c11bfec54fa44f01b1451\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/be139fa9a4edca1631ff5004d904284c5b7efe8e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/be139fa9a4edca1631ff5004d904284c5b7efe8e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}