)]}'
{"id":"openstack%2Fpuppet-openstacklib~262438","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Fliberty~I7ef078b76ac6cd7bea42a0ac92b383cefd47167a","project":"openstack/puppet-openstacklib","branch":"stable/liberty","topic":"puppet/liberty","hashtags":[],"change_id":"I7ef078b76ac6cd7bea42a0ac92b383cefd47167a","subject":"Update os_database_connection with extra param","status":"MERGED","created":"2015-12-30 09:55:55.000000000","updated":"2016-01-07 10:59:23.000000000","submitted":"2016-01-07 10:59:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"be701111e18f07d47da47558a6b9ab0a2adbd302","_number":262438,"virtual_id_number":262438,"owner":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"value":2,"date":"2016-01-07 10:59:23.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},{"value":0,"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2015-12-31 12:33:11.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":1,"date":"2015-12-30 10:08:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-12-30 14:34:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},{"value":2,"date":"2016-01-07 10:47:10.000000000","_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":1,"date":"2015-12-30 14:09:27.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},{"value":1,"date":"2016-01-07 10:47:10.000000000","_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-30 10:08:25.000000000","updated_by":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"reviewer":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"state":"REVIEWER"},{"updated":"2015-12-30 14:09:27.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2015-12-30 14:34:48.000000000","updated_by":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"reviewer":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"state":"REVIEWER"},{"updated":"2015-12-31 12:33:11.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2016-01-07 10:47:10.000000000","updated_by":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"reviewer":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"state":"REVIEWER"},{"updated":"2016-01-07 10:59:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5fdc5c04def3529857c7b1397eba2d5775af9936","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2015-12-30 09:55:55.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"a0030c76fe299c9cc6b8b352cadef814fb251e7e","author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"date":"2015-12-30 10:08:25.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"64892f1ecce30873da45f990061747d5d0d8b522","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-30 10:27:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-lint/d4823fa/ : SUCCESS in 30s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/b71cabe/ : SUCCESS in 2m 55s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/97fcca7/ : SUCCESS in 2m 58s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/364aafc/ : SUCCESS in 4m 28s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/c0d2a4d/ : SUCCESS in 4m 49s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/aea3e28/ : SUCCESS in 4m 35s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/63c0a47/ : SUCCESS in 4m 38s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/b86b492/ : SUCCESS in 4m 19s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/a63b2e6/ : SUCCESS in 4m 12s\n- gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-unit-latest-dsvm-centos7/5f98746/ : SUCCESS in 5m 00s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/fcd150e/ : SUCCESS in 11m 01s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/4a6ae82/ : SUCCESS in 5m 39s\n- gate-puppet-openstack-integration-scenario001-tempest-dsvm-trusty http://logs.openstack.org/38/262438/1/check/gate-puppet-openstack-integration-scenario001-tempest-dsvm-trusty/68e1096/ : SUCCESS in 30m 06s (non-voting)\n- gate-puppet-openstack-integration-scenario001-tempest-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstack-integration-scenario001-tempest-dsvm-centos7/9d81eb8/ : FAILURE in 13m 46s (non-voting)\n- gate-puppet-openstack-integration-scenario002-tempest-dsvm-trusty http://logs.openstack.org/38/262438/1/check/gate-puppet-openstack-integration-scenario002-tempest-dsvm-trusty/1e3b5fa/ : SUCCESS in 27m 56s (non-voting)\n- gate-puppet-openstack-integration-scenario002-tempest-dsvm-centos7 http://logs.openstack.org/38/262438/1/check/gate-puppet-openstack-integration-scenario002-tempest-dsvm-centos7/85009f3/ : SUCCESS in 25m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"982b8e27a94551747e8e7dd788d5876077f16ced","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-30 11:19:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/38/262438/1/check-tripleo/gate-tripleo-ci-f22-nonha/3bd42da/ : SUCCESS in 1h 23m 22s","accounts_in_message":[],"_revision_number":1},{"id":"c5feeb31f3e7eaac46f23c4898a3885418b0cceb","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2015-12-30 14:09:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ed5a26675d9f2eda2ed4a7e52b0b7c258f00709a","author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"date":"2015-12-30 14:34:48.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"64cf6fa26bbd501e27490e113789c87e28e2b9f1","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-12-31 12:33:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"fbbcf8956fff95d1aa6a9a2044aa7d5265095e4c","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2016-01-06 00:12:17.000000000","message":"Topic changed from I7ef078b76ac6cd7bea42a0ac92b383cefd47167a to puppet/liberty","accounts_in_message":[],"_revision_number":1},{"id":"7082fe15f0b43d075f1e1e17baa1c1f6dbe48ede","author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"date":"2016-01-07 10:47:10.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d6d3be62fc5698646c5738397e239945a10c2314","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 10:47:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5bbfb31046e7c8d90aaeb7ca0d7c567e761d44f4","date":"2016-01-07 10:59:23.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"be701111e18f07d47da47558a6b9ab0a2adbd302","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 10:59:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-lint/6ab9884/ : SUCCESS in 27s\n- gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-syntax-3-dsvm-centos7/188c858/ : SUCCESS in 3m 07s\n- gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-syntax-4-dsvm-centos7/cddb628/ : SUCCESS in 3m 09s\n- gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-unit-3.3-dsvm-centos7/0526cfc/ : SUCCESS in 4m 45s\n- gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-unit-3.4-dsvm-centos7/4931f72/ : SUCCESS in 5m 22s\n- gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-unit-3.6-dsvm-centos7/ef464c0/ : SUCCESS in 4m 47s\n- gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-unit-3.7-dsvm-centos7/404828f/ : SUCCESS in 4m 52s\n- gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-unit-3.8-dsvm-centos7/ac7cbd2/ : SUCCESS in 4m 40s\n- gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-unit-4.0-dsvm-centos7/6bab613/ : SUCCESS in 4m 51s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-trusty/29fdd03/ : SUCCESS in 5m 47s\n- gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7 http://logs.openstack.org/38/262438/1/gate/gate-puppet-openstacklib-puppet-beaker-rspec-dsvm-centos7/2012f24/ : SUCCESS in 9m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"247553cf382083fb85ca7987ee7d3cf208ec3e64","revisions":{"247553cf382083fb85ca7987ee7d3cf208ec3e64":{"kind":"REWORK","_number":1,"created":"2015-12-30 09:55:55.000000000","uploader":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"ref":"refs/changes/38/262438/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/38/262438/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/38/262438/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/38/262438/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/38/262438/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/38/262438/1"}}},"commit":{"parents":[{"commit":"142f9d1be907c45115ea4d92277278a682fb53f7","subject":"Fix unit tests failing against Puppet 4.3.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/142f9d1be907c45115ea4d92277278a682fb53f7"}]}],"author":{"name":"Michael Polenchuk","email":"mpolenchuk@mirantis.com","date":"2015-12-25 12:46:30.000000000","tz":180},"committer":{"name":"Denis Egorenko","email":"degorenko@mirantis.com","date":"2015-12-30 09:55:55.000000000","tz":0},"subject":"Update os_database_connection with extra param","message":"Update os_database_connection with extra param\n\nAdd support for providing additional parameters to be used when\nconstructing the database uri. This change adds an \u0027extra\u0027 parameter\nwhich is a hash that will be joined together when constructing the\ndatabase uri. It should be noted that the charset option, which can be\nprovided as a standalone option, will override charset when passed in\nthe \u0027extra\u0027 parameter. This is to maintain backwards compatibility.\n\nUsage Example:\n  os_database_connection({\n    ...\n    extra \u003d\u003e { \u0027charset\u0027 \u003d\u003e \u0027utf-8\u0027, \u0027read_timeout\u0027 \u003d\u003e 60 }\n  })\n\nChange-Id: I7ef078b76ac6cd7bea42a0ac92b383cefd47167a\nCo-Authored-By: Alex Schultz \u003caschultz@mirantis.com\u003e\n(cherry picked from commit bad1c6514a896532114703bdc2abd59edbf124a1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/247553cf382083fb85ca7987ee7d3cf208ec3e64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/247553cf382083fb85ca7987ee7d3cf208ec3e64"}]},"branch":"refs/heads/stable/liberty"}},"requirements":[],"submit_records":[],"submit_requirements":[]}