)]}'
{"lib/puppet/provider/openstack.rb":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"f219a3d388abe0ad7430928085b21a4c2b9a2a64","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  def self.openstack(*args)"},{"line_number":48,"context_line":"    begin"},{"line_number":49,"context_line":"      action \u003d args[1]"},{"line_number":50,"context_line":"      Timeout.timeout(command_timeout action) do"},{"line_number":51,"context_line":"        openstack_command *args"},{"line_number":52,"context_line":"      end"},{"line_number":53,"context_line":"    rescue Timeout::Error"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"ba0121b8_f5a8a8dd","line":50,"updated":"2016-03-29 23:31:14.000000000","message":"Missing a comma here?","commit_id":"e7c9254bc79186412be8dbf38599d373ec58fafd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"273c0b59b346ce7c87be6cc4acae3868fb4fa6a3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  def self.openstack(*args)"},{"line_number":47,"context_line":"    begin"},{"line_number":48,"context_line":"      action \u003d args[1]"},{"line_number":49,"context_line":"      Timeout.timeout(command_timeout, action) do"},{"line_number":50,"context_line":"        openstack_command *args"},{"line_number":51,"context_line":"      end"},{"line_number":52,"context_line":"    rescue Timeout::Error"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba0121b8_a37265ab","line":49,"updated":"2016-03-30 10:51:58.000000000","message":"should not it be command_timeout(action) ?","commit_id":"eaf915d0ed667ad59f14d14088ddd3f5fa2d170a"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"2c820423be60baab38b249778f25560639bc615e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  def self.openstack(*args)"},{"line_number":47,"context_line":"    begin"},{"line_number":48,"context_line":"      action \u003d args[1]"},{"line_number":49,"context_line":"      Timeout.timeout(command_timeout, action) do"},{"line_number":50,"context_line":"        openstack_command *args"},{"line_number":51,"context_line":"      end"},{"line_number":52,"context_line":"    rescue Timeout::Error"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba0121b8_e49bb170","line":49,"in_reply_to":"ba0121b8_0e9526dd","updated":"2016-03-30 14:29:37.000000000","message":"You\u0027re right, I misread","commit_id":"eaf915d0ed667ad59f14d14088ddd3f5fa2d170a"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"8ffb5f16b50bc105d17902a0400ddfd6c6eafb20","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  def self.openstack(*args)"},{"line_number":47,"context_line":"    begin"},{"line_number":48,"context_line":"      action \u003d args[1]"},{"line_number":49,"context_line":"      Timeout.timeout(command_timeout, action) do"},{"line_number":50,"context_line":"        openstack_command *args"},{"line_number":51,"context_line":"      end"},{"line_number":52,"context_line":"    rescue Timeout::Error"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba0121b8_cee84ee5","line":49,"in_reply_to":"ba0121b8_a37265ab","updated":"2016-03-30 14:17:21.000000000","message":"No, command_timeout returns the value for the timeout, it doesn\u0027t execute the command with a timeout.","commit_id":"eaf915d0ed667ad59f14d14088ddd3f5fa2d170a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3ad381267e8041ed460e25b1489645b992bff2ae","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  def self.openstack(*args)"},{"line_number":47,"context_line":"    begin"},{"line_number":48,"context_line":"      action \u003d args[1]"},{"line_number":49,"context_line":"      Timeout.timeout(command_timeout, action) do"},{"line_number":50,"context_line":"        openstack_command *args"},{"line_number":51,"context_line":"      end"},{"line_number":52,"context_line":"    rescue Timeout::Error"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"ba0121b8_0e9526dd","line":49,"in_reply_to":"ba0121b8_cee84ee5","updated":"2016-03-30 14:20:00.000000000","message":"Looking at command_timeout is see adding a new parameter to function - action. And based on this action it returns different values. I don\u0027t see where we set action for this function. Then, it always will be 20.","commit_id":"eaf915d0ed667ad59f14d14088ddd3f5fa2d170a"}]}