)]}'
{"manifests/policy/policyrcd.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"383801aee017a03a0d3aa29fc457f4f5670e4b25","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# \u003d\u003d Class: openstacklib::policy::policyrcd"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*services*]"},{"line_number":21,"context_line":"# (optional) The services that should be in the policy-rc.d shell script"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_c4a6d552","line":18,"updated":"2016-04-21 20:10:51.000000000","message":"please use another namespace.\nopenstacklib::policy is already used for API policies, which has nothing related to packaging policy.","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c35283ee9a1f4a4de0b76a98e04b0f76488d961d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# \u003d\u003d Class: openstacklib::policy::policyrcd"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*services*]"},{"line_number":21,"context_line":"# (optional) The services that should be in the policy-rc.d shell script"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_a23909db","line":18,"in_reply_to":"1a122d0e_c4a6d552","updated":"2016-04-21 20:42:13.000000000","message":"Done","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"383801aee017a03a0d3aa29fc457f4f5670e4b25","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# \u003d\u003d Class: openstacklib::policy::policyrcd"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*services*]"},{"line_number":21,"context_line":"# (optional) The services that should be in the policy-rc.d shell script"},{"line_number":22,"context_line":"# that should not autostart on install."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class openstacklib::policy::policyrcd("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_646c2109","line":21,"updated":"2016-04-21 20:10:51.000000000","message":"make it required.","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c35283ee9a1f4a4de0b76a98e04b0f76488d961d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# \u003d\u003d Class: openstacklib::policy::policyrcd"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*services*]"},{"line_number":21,"context_line":"# (optional) The services that should be in the policy-rc.d shell script"},{"line_number":22,"context_line":"# that should not autostart on install."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class openstacklib::policy::policyrcd("}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_422475ae","line":21,"in_reply_to":"1a122d0e_646c2109","updated":"2016-04-21 20:42:13.000000000","message":"Done","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"383801aee017a03a0d3aa29fc457f4f5670e4b25","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# that should not autostart on install."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class openstacklib::policy::policyrcd("},{"line_number":25,"context_line":"  $services \u003d [\u0027keystone\u0027]"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_447125e0","line":25,"updated":"2016-04-21 20:10:51.000000000","message":"drop default param","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c35283ee9a1f4a4de0b76a98e04b0f76488d961d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# that should not autostart on install."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class openstacklib::policy::policyrcd("},{"line_number":25,"context_line":"  $services \u003d [\u0027keystone\u0027]"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_621ff15b","line":25,"in_reply_to":"1a122d0e_447125e0","updated":"2016-04-21 20:42:13.000000000","message":"Done","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"383801aee017a03a0d3aa29fc457f4f5670e4b25","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    File[\u0027/usr/sbin/policy-rc.d\u0027] -\u003e Package\u003c| tag \u003d\u003d \u0027openstack\u0027 |\u003e"},{"line_number":40,"context_line":"  } else {"},{"line_number":41,"context_line":"    warning(\u0027Including policyrcd should only be done on debian os family.\u0027)"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_e480318e","line":41,"updated":"2016-04-21 20:10:51.000000000","message":"drop the else and warning, otherwise we\u0027ll have warning everywhere.","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c35283ee9a1f4a4de0b76a98e04b0f76488d961d","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    File[\u0027/usr/sbin/policy-rc.d\u0027] -\u003e Package\u003c| tag \u003d\u003d \u0027openstack\u0027 |\u003e"},{"line_number":40,"context_line":"  } else {"},{"line_number":41,"context_line":"    warning(\u0027Including policyrcd should only be done on debian os family.\u0027)"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_022a7d7e","line":41,"in_reply_to":"1a122d0e_e480318e","updated":"2016-04-21 20:42:13.000000000","message":"Done","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"}],"releasenotes/notes/manage_policy_rc_d_file-747510db06792d52.yaml":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3b6c59c17f76654653b968f1d627ce7ad263caad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Replace this text with content to appear at the"},{"line_number":4,"context_line":"    top of the section for this release. All of the"},{"line_number":5,"context_line":"    prelude content is merged together and then rendered"},{"line_number":6,"context_line":"    separately from the items listed in other parts of"},{"line_number":7,"context_line":"    the file, so the text needs to be worded so that"},{"line_number":8,"context_line":"    both the prelude and the other items make sense"},{"line_number":9,"context_line":"    when read independently. This may mean repeating"},{"line_number":10,"context_line":"    some details. Not every release note"},{"line_number":11,"context_line":"    requires a prelude. Usually only notes describing"},{"line_number":12,"context_line":"    major features or adding release theme details should"},{"line_number":13,"context_line":"    have a prelude."},{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - Add a class that takes an array of services that can be"},{"line_number":16,"context_line":"    configured to not autostart on package install. The most"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_cb0ec2e4","line":13,"range":{"start_line":2,"start_character":0,"end_line":13,"end_character":19},"updated":"2016-04-22 13:45:01.000000000","message":"should be removed i guess :)","commit_id":"8de083438783050ed26f5e17b7f24649496bf879"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"32e8ea8cba3ec8ad5a257126618f8253a7a12601","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Replace this text with content to appear at the"},{"line_number":4,"context_line":"    top of the section for this release. All of the"},{"line_number":5,"context_line":"    prelude content is merged together and then rendered"},{"line_number":6,"context_line":"    separately from the items listed in other parts of"},{"line_number":7,"context_line":"    the file, so the text needs to be worded so that"},{"line_number":8,"context_line":"    both the prelude and the other items make sense"},{"line_number":9,"context_line":"    when read independently. This may mean repeating"},{"line_number":10,"context_line":"    some details. Not every release note"},{"line_number":11,"context_line":"    requires a prelude. Usually only notes describing"},{"line_number":12,"context_line":"    major features or adding release theme details should"},{"line_number":13,"context_line":"    have a prelude."},{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - Add a class that takes an array of services that can be"},{"line_number":16,"context_line":"    configured to not autostart on package install. The most"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a122d0e_b7564504","line":13,"range":{"start_line":2,"start_character":0,"end_line":13,"end_character":19},"in_reply_to":"1a122d0e_cb0ec2e4","updated":"2016-04-22 14:42:26.000000000","message":"doh! ok fixed.","commit_id":"8de083438783050ed26f5e17b7f24649496bf879"}],"spec/classes/openstacklib_policy_policyrcd_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"383801aee017a03a0d3aa29fc457f4f5670e4b25","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    describe \"with default value\" do"},{"line_number":44,"context_line":"  "},{"line_number":45,"context_line":"      it \u0027creates policy-rc.d file\u0027 do"},{"line_number":46,"context_line":"        verify_contents(catalogue, \u0027/usr/sbin/policy-rc.d\u0027, ["},{"line_number":47,"context_line":"          \u0027#!/bin/bash\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1a122d0e_c47d35b3","line":44,"updated":"2016-04-21 20:10:51.000000000","message":"trailing space","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c35283ee9a1f4a4de0b76a98e04b0f76488d961d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    end"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    describe \"with default value\" do"},{"line_number":44,"context_line":"  "},{"line_number":45,"context_line":"      it \u0027creates policy-rc.d file\u0027 do"},{"line_number":46,"context_line":"        verify_contents(catalogue, \u0027/usr/sbin/policy-rc.d\u0027, ["},{"line_number":47,"context_line":"          \u0027#!/bin/bash\u0027,"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1a122d0e_023b9d9d","line":44,"in_reply_to":"1a122d0e_c47d35b3","updated":"2016-04-21 20:42:13.000000000","message":"Done","commit_id":"c58df46094c3ff5797ba451cb6b67af51e34316e"}]}