)]}'
{"manifests/service_validation.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"cea22b7caa5d8e8845e7889cf685d22b6fe41706","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fail (\u0027Only one parameter should be declared: onlyif or unless\u0027)"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $onlyif {"},{"line_number":72,"context_line":"    exec { \"execute ${service_name} validation\":"},{"line_number":73,"context_line":"      path      \u003d\u003e $path,"},{"line_number":74,"context_line":"      provider  \u003d\u003e $provider,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_34b60df9","line":71,"updated":"2016-07-07 15:11:04.000000000","message":"This entire block doesn\u0027t need to exist. Since you have undef as the defaults, you can just include onlyif \u003d\u003e $onlyif, unless \u003d\u003e $unless and they get ignored if set to undef\nI tested this out with:\n\n$onlyif \u003d undef\n$unless \u003d undef\nexec { \u0027testing\u0027:\n  path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027, ],\n  command \u003d\u003e \u0027echo test\u0027,\n  onlyif  \u003d\u003e $onlyif,\n  unless  \u003d\u003e $unless,\n}","commit_id":"fc60e96be8c8690599050a90581461c88e04a9e9"},{"author":{"_account_id":13344,"name":"Oleksiy Molchanov","email":"omolchanov@mirantis.com","username":"cvieri.lviv"},"change_message_id":"b848b29a30f68343bd421a319e0d63109fd66a43","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    fail (\u0027Only one parameter should be declared: onlyif or unless\u0027)"},{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $onlyif {"},{"line_number":72,"context_line":"    exec { \"execute ${service_name} validation\":"},{"line_number":73,"context_line":"      path      \u003d\u003e $path,"},{"line_number":74,"context_line":"      provider  \u003d\u003e $provider,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_b48dddd4","line":71,"in_reply_to":"1aa78d24_34b60df9","updated":"2016-07-07 15:15:55.000000000","message":"Thanks for pointing this.","commit_id":"fc60e96be8c8690599050a90581461c88e04a9e9"}],"spec/defines/openstacklib_service_validation_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7106ecc73515d97ad469b58ef5774b9ccdeae4ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  let :required_params do"},{"line_number":25,"context_line":"    { :command \u003d\u003e \u0027nova list\u0027 }"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  shared_examples \u0027openstacklib::service_validation examples\u0027 do"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1aa78d24_357259ae","side":"PARENT","line":26,"updated":"2016-07-08 10:57:49.000000000","message":"it\u0027s common parameter, let\u0027s do not remove it. Just use \u0027before\u0027/\u0027merge\u0027 functions.","commit_id":"413a6149bd64a1e3678c426bd37799f8a7c91821"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"76979656be7b07de3812b7e13603dcd66d39d345","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      let :params do"},{"line_number":51,"context_line":"        required_params.delete(:command)"},{"line_number":52,"context_line":"      end"},{"line_number":53,"context_line":"      it { expect { is_expected.to raise_error(Puppet::Error) } }"},{"line_number":54,"context_line":"    end"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1aa78d24_ee8ee9ce","side":"PARENT","line":53,"updated":"2016-07-11 14:47:55.000000000","message":"why you removed this expect?","commit_id":"413a6149bd64a1e3678c426bd37799f8a7c91821"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0392beda7fd1f43334e6ee31560f4494f88433a8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      let :params do"},{"line_number":51,"context_line":"        required_params.delete(:command)"},{"line_number":52,"context_line":"      end"},{"line_number":53,"context_line":"      it { expect { is_expected.to raise_error(Puppet::Error) } }"},{"line_number":54,"context_line":"    end"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"1aa78d24_67821702","side":"PARENT","line":53,"updated":"2016-07-11 16:38:39.000000000","message":"do not change this test please :)","commit_id":"e4253e04b5101b28dd60dae6904148b548a78f30"}]}