)]}'
{"id":"openstack%2Fpuppet-openstacklib~390990","triplet_id":"openstack%2Fpuppet-openstacklib~master~I86bae2b16026e15b6e4445f3749419b8802bc94d","project":"openstack/puppet-openstacklib","branch":"master","topic":"rspec-puppet-facts","hashtags":[],"change_id":"I86bae2b16026e15b6e4445f3749419b8802bc94d","subject":"Improve tests with rspec-puppet-facts","status":"MERGED","created":"2016-10-26 23:42:13.000000000","updated":"2016-10-27 23:54:10.000000000","submitted":"2016-10-27 23:54:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"950c7df0d841c72c7cd25e095d78497539c562f9","_number":390990,"virtual_id_number":390990,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2016-10-27 23:54:10.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},{"value":0,"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"all":[{"value":2,"date":"2016-10-27 09:51:14.000000000","_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":2,"date":"2016-10-27 22:49:49.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-27 13:48:19.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2016-10-27 15:27:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},{"value":0,"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"value":1,"date":"2016-10-27 22:49:49.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},{"value":0,"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-26 23:46:51.000000000","updated_by":{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},"reviewer":{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2016-10-27 09:51:14.000000000","updated_by":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"reviewer":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"state":"REVIEWER"},{"updated":"2016-10-27 13:48:19.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2016-10-27 15:27:38.000000000","updated_by":{"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},"reviewer":{"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},"state":"REVIEWER"},{"updated":"2016-10-27 22:49:49.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2016-10-27 23:54:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7cd88cb276a7fdb7e0cedd0b84d73fc87e0c980a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2016-10-26 23:42:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b1a2f5245deeaeb0413ff2a6130c30eb1eb3849","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2016-10-26 23:46:28.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0c8228e56b94b60e6fec696d719a893dd157909f","author":{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2016-10-26 23:46:51.000000000","message":"Patch Set 2:\n\nBuild Failed \n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron/5786/ : FAILURE\n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library/3694/ : FAILURE\n\n* master.puppet-openstack.fuel.noop https://ci.fuel-infra.org/job/master.puppet-openstack.fuel.noop/5850/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"9d34fe002df90e332e23e8a6c47f5d6954691cc0","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2016-10-26 23:50:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9807d30c2f410ef35ff9c4714bec2eca0cfd8498","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-27 00:35:13.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-lint/b853e3c/ : SUCCESS in 1m 17s\n- gate-puppet-openstacklib-puppet-syntax-3-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-syntax-3-centos-7/9ad47c5/ : SUCCESS in 1m 35s\n- gate-puppet-openstacklib-puppet-syntax-4-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-syntax-4-centos-7/f80c10c/ : SUCCESS in 1m 35s\n- gate-puppet-openstacklib-puppet-unit-3.6-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-unit-3.6-centos-7/d2f0673/ : SUCCESS in 4m 06s\n- gate-puppet-openstacklib-puppet-unit-3.8-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-unit-3.8-centos-7/7efaa8e/ : SUCCESS in 4m 02s\n- gate-puppet-openstacklib-puppet-unit-4.5-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-unit-4.5-centos-7/d144b62/ : SUCCESS in 4m 02s\n- gate-puppet-openstacklib-puppet-unit-latest-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-unit-latest-centos-7/7493c32/ : SUCCESS in 3m 38s (non-voting)\n- gate-puppet-openstacklib-puppet-beaker-rspec-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-beaker-rspec-centos-7/56e5366/ : SUCCESS in 4m 20s\n- gate-puppet-openstacklib-puppet-beaker-rspec-ubuntu-xenial http://logs.openstack.org/90/390990/3/check/gate-puppet-openstacklib-puppet-beaker-rspec-ubuntu-xenial/a2942c6/ : SUCCESS in 9m 58s\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7/c6f8bfb/ : SUCCESS in 32m 30s\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/aec1ed9/ : SUCCESS in 40m 35s\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/90/390990/3/check/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/2488d18/ : SUCCESS in 27m 50s\n- gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/90/390990/3/check/gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/e28f05f/ : SUCCESS in 20m 19s\n- gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/90/390990/3/check/gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/c7d93f5/ : SUCCESS in 24m 35s\n- gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/90/390990/3/check/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/452e154/ : SUCCESS in 20m 18s\n- gate-tripleo-ci-centos-7-nonha-multinode http://logs.openstack.org/90/390990/3/check/gate-tripleo-ci-centos-7-nonha-multinode/1b6b64d/ : SUCCESS in 44m 59s","accounts_in_message":[],"_revision_number":3},{"id":"955285d981ac9faca55099261ed5bd0218d7cac8","author":{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2016-10-27 01:36:29.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library/3693/ : FAILURE\n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron/5785/ : SUCCESS\n\n* master.puppet-openstack.fuel.noop https://ci.fuel-infra.org/job/master.puppet-openstack.fuel.noop/5849/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ab76f44f33ac6b19189991d58648e0f5bedff1f3","author":{"_account_id":8971,"name":"Fuel CI","username":"fuel-ci","inactive":true,"tags":["SERVICE_USER"]},"date":"2016-10-27 02:01:06.000000000","message":"Patch Set 3:\n\nBuild Successful \n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.smoke_neutron/5787/ : SUCCESS\n\n* master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library https://ci.fuel-infra.org/job/master.puppet-openstack.fuel-library.pkgs.ubuntu.review_in_fuel_library/3695/ : SUCCESS\n\n* master.puppet-openstack.fuel.noop https://ci.fuel-infra.org/job/master.puppet-openstack.fuel.noop/5851/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"f093b43b935067cf40c3468350e9bd7b1ec950da","author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"date":"2016-10-27 09:51:14.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"7d8cffd332c8f910cb1f40163db905abddf46915","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2016-10-27 13:48:19.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"2a2cc74df6cc890da8ca390eb25c8811f5eeab7e","author":{"_account_id":14007,"name":"Maksym Yatsenko","email":"myatsenko@mirantis.com","username":"myatsenko"},"date":"2016-10-27 15:27:38.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"6832e6e5698143ff0efa687f2557a13f875553ef","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2016-10-27 22:49:49.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"30f50977126318ba7ff2a2729d0f7686b5892496","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-27 22:49:59.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"37f1ffca24afed7617a8e42b9ec97dd86350ca43","date":"2016-10-27 23:54:10.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"cd0251179182d010633f2d2074fe0ac1c2391c08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-27 23:54:10.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-openstacklib-puppet-lint http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-lint/4dd0edd/ : SUCCESS in 1m 48s\n- gate-puppet-openstacklib-puppet-syntax-3-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-syntax-3-centos-7/c779f5d/ : SUCCESS in 1m 40s\n- gate-puppet-openstacklib-puppet-syntax-4-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-syntax-4-centos-7/a72ab1e/ : SUCCESS in 1m 36s\n- gate-puppet-openstacklib-puppet-unit-3.6-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-unit-3.6-centos-7/bbe926b/ : SUCCESS in 7m 33s\n- gate-puppet-openstacklib-puppet-unit-3.8-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-unit-3.8-centos-7/5707214/ : SUCCESS in 3m 37s\n- gate-puppet-openstacklib-puppet-unit-4.5-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-unit-4.5-centos-7/987ce0d/ : SUCCESS in 4m 56s\n- gate-puppet-openstacklib-puppet-beaker-rspec-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-beaker-rspec-centos-7/9985e94/ : SUCCESS in 4m 43s\n- gate-puppet-openstacklib-puppet-beaker-rspec-ubuntu-xenial http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstacklib-puppet-beaker-rspec-ubuntu-xenial/e94e9b7/ : SUCCESS in 4m 28s\n- gate-puppet-openstack-integration-4-scenario001-tempest-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstack-integration-4-scenario001-tempest-centos-7/1c85130/ : SUCCESS in 50m 04s\n- gate-puppet-openstack-integration-4-scenario002-tempest-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/f6f1fbc/ : SUCCESS in 54m 29s\n- gate-puppet-openstack-integration-4-scenario003-tempest-centos-7 http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstack-integration-4-scenario003-tempest-centos-7/b2149ae/ : SUCCESS in 43m 08s\n- gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial/0a02a56/ : SUCCESS in 20m 42s\n- gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial/3e470a9/ : SUCCESS in 24m 06s\n- gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial http://logs.openstack.org/90/390990/3/gate/gate-puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial/7a0f1dd/ : SUCCESS in 23m 21s\n- gate-tripleo-ci-centos-7-nonha-multinode http://logs.openstack.org/90/390990/3/gate/gate-tripleo-ci-centos-7-nonha-multinode/19b0106/ : SUCCESS in 46m 28s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"525d77195ec5b2aa83c531b3e0e25431a089b646","revisions":{"38aa9c625f960a31f5e4a57ceeb6d8771ae304ee":{"kind":"REWORK","_number":1,"created":"2016-10-26 23:42:13.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/90/390990/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/390990/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/1"}}},"commit":{"parents":[{"commit":"a5f39c6233376d9d4351600bf9adcdefa4bf21d3","subject":"Change worker defaults to ::os_workers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/a5f39c6233376d9d4351600bf9adcdefa4bf21d3"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2016-10-26 23:40:15.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2016-10-26 23:40:15.000000000","tz":-360},"subject":"Improve tests with rspec-puppet-facts","message":"Improve tests with rspec-puppet-facts\n\nThis change updates the tests to use rspec-puppet-facts when doing\ndifferent OS testing. Additionally as part of this change, there are\nimprovements to the openstacklib::policycrd testing which uncovered\nissues with the verify_contents catalog test. The verify_contents calls\nhave been replaced with heredocs to better test when multiple services\nare excluded.\n\nChange-Id: I86bae2b16026e15b6e4445f3749419b8802bc94d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/38aa9c625f960a31f5e4a57ceeb6d8771ae304ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/38aa9c625f960a31f5e4a57ceeb6d8771ae304ee"}]},"branch":"refs/heads/master"},"582e97ef755e8ffe0381f363f7b70aad44bb4e76":{"kind":"REWORK","_number":2,"created":"2016-10-26 23:46:28.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/90/390990/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/390990/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/2"}}},"commit":{"parents":[{"commit":"a5f39c6233376d9d4351600bf9adcdefa4bf21d3","subject":"Change worker defaults to ::os_workers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/a5f39c6233376d9d4351600bf9adcdefa4bf21d3"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2016-10-26 23:40:15.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2016-10-26 23:46:24.000000000","tz":-360},"subject":"Improve tests with rspec-puppet-facts","message":"Improve tests with rspec-puppet-facts\n\nThis change updates the tests to use rspec-puppet-facts when doing\ndifferent OS testing. Additionally as part of this change, there are\nimprovements to the openstacklib::policycrd testing which uncovered\nissues with the verify_contents catalog test. The verify_contents calls\nhave been replaced with heredocs to better test when multiple services\nare excluded.\n\nChange-Id: I86bae2b16026e15b6e4445f3749419b8802bc94d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/582e97ef755e8ffe0381f363f7b70aad44bb4e76"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/582e97ef755e8ffe0381f363f7b70aad44bb4e76"}]},"branch":"refs/heads/master"},"525d77195ec5b2aa83c531b3e0e25431a089b646":{"kind":"REWORK","_number":3,"created":"2016-10-26 23:50:02.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/90/390990/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/90/390990/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/90/390990/3"}}},"commit":{"parents":[{"commit":"a5f39c6233376d9d4351600bf9adcdefa4bf21d3","subject":"Change worker defaults to ::os_workers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/a5f39c6233376d9d4351600bf9adcdefa4bf21d3"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2016-10-26 23:40:15.000000000","tz":-360},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2016-10-26 23:49:59.000000000","tz":-360},"subject":"Improve tests with rspec-puppet-facts","message":"Improve tests with rspec-puppet-facts\n\nThis change updates the tests to use rspec-puppet-facts when doing\ndifferent OS testing. Additionally as part of this change, there are\nimprovements to the openstacklib::policycrd testing which uncovered\nissues with the verify_contents catalog test. The verify_contents calls\nhave been replaced with heredocs to better test when multiple services\nare excluded.\n\nChange-Id: I86bae2b16026e15b6e4445f3749419b8802bc94d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/525d77195ec5b2aa83c531b3e0e25431a089b646"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/525d77195ec5b2aa83c531b3e0e25431a089b646"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
