)]}'
{"README.md":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"75d3ae6cf7b567b172cec004a9c70134808659bd","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"```"},{"line_number":231,"context_line":"Puppet::Type.type(:\u003cmodule\u003e_config).provide("},{"line_number":232,"context_line":"  :ini_setting,"},{"line_number":233,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ini_setting)"},{"line_number":234,"context_line":") do"},{"line_number":235,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"ba2be162_b6532d16","line":232,"updated":"2017-03-03 23:13:27.000000000","message":"So I don\u0027t think this is correct. openstackconfig is necessary if the config uses something like MultiStrOpt.  We have a mix because we\u0027ve only converted some of the providers where we actually use this more complex functionality. I have a feeling techincally we shoul dbe leaving this as openstack_config but changing to .provider(:ruby) but i\u0027m not 100%","commit_id":"84d9d50a540c1a8cc46b614b4ae3d520afbca3fc"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"045c238c351ff85d812f2031a010ddf8f3b8ff24","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"```"},{"line_number":231,"context_line":"Puppet::Type.type(:\u003cmodule\u003e_config).provide("},{"line_number":232,"context_line":"  :ini_setting,"},{"line_number":233,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ini_setting)"},{"line_number":234,"context_line":") do"},{"line_number":235,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"dfeb2761_041bebcf","line":232,"in_reply_to":"ba2be162_7c16e54c","updated":"2017-04-04 17:21:19.000000000","message":"After further review i think you\u0027re right as openstackconfig is in the utils and we\u0027re exposing openstack_config via ini_setting or ruby.  We\u0027ve got more instances of ini_setting than openstackconfig as well. Probably need to clean those up","commit_id":"84d9d50a540c1a8cc46b614b4ae3d520afbca3fc"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"c31ab4dc052fb6b59966ab3b34ac601e42a9e689","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"```"},{"line_number":231,"context_line":"Puppet::Type.type(:\u003cmodule\u003e_config).provide("},{"line_number":232,"context_line":"  :ini_setting,"},{"line_number":233,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:openstack_config).provider(:ini_setting)"},{"line_number":234,"context_line":") do"},{"line_number":235,"context_line":"```"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"ba2be162_7c16e54c","line":232,"in_reply_to":"ba2be162_b6532d16","updated":"2017-03-05 21:05:03.000000000","message":"Doesn\u0027t the provider type explained at L245 would be the one allowing MultiStrOpt?? Check L269-272 please.","commit_id":"84d9d50a540c1a8cc46b614b4ae3d520afbca3fc"}]}