)]}'
{"id":"openstack%2Fpuppet-openstacklib~529891","triplet_id":"openstack%2Fpuppet-openstacklib~master~I9a24dc9f74cb3b59508b12e63a078068c26c1442","project":"openstack/puppet-openstacklib","branch":"master","topic":"os-worker","hashtags":[],"change_id":"I9a24dc9f74cb3b59508b12e63a078068c26c1442","subject":"Switch to Facter.flush","status":"MERGED","created":"2017-12-22 22:11:54.000000000","updated":"2017-12-26 16:04:05.000000000","submitted":"2017-12-23 00:07:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"529891-1513987679048-da110e64","meta_rev_id":"e50c8729cbd0dc8c59ea8e042f28413f851a136a","_number":529891,"virtual_id_number":529891,"owner":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2017-12-23 00:07:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2017-12-22 23:50:47.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2017-12-22 23:50:47.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-22 23:50:47.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2017-12-23 00:07:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1bdbaf211b0187babe748b9a2d572afb95b10684","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2017-12-22 22:11:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f83f04e00b50ec82d307927e201af7d4e8615ea9","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-12-22 22:14:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c4b695aa4cea18f4743be7184ebd1aea6889b7f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-22 22:28:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-beaker-rspec-centos-7 http://logs.openstack.org/91/529891/1/check/legacy-puppet-beaker-rspec-centos-7/a073812/ : SUCCESS in 12m 20s\n- legacy-puppet-beaker-rspec http://logs.openstack.org/91/529891/1/check/legacy-puppet-beaker-rspec/09d0772/ : SUCCESS in 7m 22s\n- puppet-openstack-lint http://logs.openstack.org/91/529891/1/check/puppet-openstack-lint/f817009/ : SUCCESS in 3m 18s\n- puppet-openstack-syntax-4 http://logs.openstack.org/91/529891/1/check/puppet-openstack-syntax-4/bd054c1/ : SUCCESS in 4m 00s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/91/529891/1/check/puppet-openstack-unit-4.8-centos-7/359aac7/ : SUCCESS in 14m 47s\n- puppet-openstack-unit-latest-centos-7 http://logs.openstack.org/91/529891/1/check/puppet-openstack-unit-latest-centos-7/cb13f6c/ : SUCCESS in 12m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bc3280d2c418343d0872db0a61480dab5105d0b2","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2017-12-22 22:30:04.000000000","message":"Patch Set 1:\n\nrecheck lets see if we can test run on a rax node","accounts_in_message":[],"_revision_number":1},{"id":"7f33901ed08a487534dbe6379b9f5aec30793d49","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2017-12-22 22:31:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0c2a4ebad441362456233052a5d254e467698e26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-22 22:55:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-beaker-rspec-centos-7 http://logs.openstack.org/91/529891/2/check/legacy-puppet-beaker-rspec-centos-7/c0c3dde/ : SUCCESS in 22m 13s\n- legacy-puppet-beaker-rspec http://logs.openstack.org/91/529891/2/check/legacy-puppet-beaker-rspec/9c11e02/ : SUCCESS in 9m 23s\n- puppet-openstack-lint http://logs.openstack.org/91/529891/2/check/puppet-openstack-lint/40f3ede/ : SUCCESS in 4m 25s\n- puppet-openstack-syntax-4 http://logs.openstack.org/91/529891/2/check/puppet-openstack-syntax-4/3595a13/ : SUCCESS in 3m 57s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/91/529891/2/check/puppet-openstack-unit-4.8-centos-7/fc34d8f/ : SUCCESS in 8m 31s\n- puppet-openstack-unit-latest-centos-7 http://logs.openstack.org/91/529891/2/check/puppet-openstack-unit-latest-centos-7/0507052/ : SUCCESS in 7m 13s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"0813c525fba9cab3e7b2945db7e5c92d81b2c273","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-12-22 23:50:47.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"f482f0f868d7390429ddf3d6dfed75482f7d7350","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-22 23:50:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"69a567b1b308b960aba6a115cb6392cb8cd3ed12","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-23 00:07:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- legacy-puppet-beaker-rspec-centos-7 http://logs.openstack.org/91/529891/2/gate/legacy-puppet-beaker-rspec-centos-7/d1d0b4e/ : SUCCESS in 12m 25s\n- legacy-puppet-beaker-rspec http://logs.openstack.org/91/529891/2/gate/legacy-puppet-beaker-rspec/aefb4b9/ : SUCCESS in 6m 10s\n- puppet-openstack-lint http://logs.openstack.org/91/529891/2/gate/puppet-openstack-lint/02bcc44/ : SUCCESS in 2m 51s\n- puppet-openstack-syntax-4 http://logs.openstack.org/91/529891/2/gate/puppet-openstack-syntax-4/b557409/ : SUCCESS in 2m 35s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/91/529891/2/gate/puppet-openstack-unit-4.8-centos-7/5b531ad/ : SUCCESS in 10m 51s","accounts_in_message":[],"_revision_number":2},{"id":"081f7a88dbe4e5203b2b50b229503c41b3ec0658","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-23 00:07:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"f4ea763d59867c83dc8c7a82b9c42250575358da","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-12-26 16:03:44.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/pike as commit ad4d6b304e9e63cd9dd4f5c8c800b43ac7e6b88e","accounts_in_message":[],"_revision_number":2},{"id":"6defd7800d64ba29460452b4e169f4d2ddfcd130","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-12-26 16:04:05.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ocata as commit 76c9017ea2d9ef29c43b35acbdf8e822603ae54b","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b5bd19a630c843f063175dbfc2c7d5e62f7976ae","revisions":{"f44a0619bdc93eb602e4bdc6052aeadfb7f5c5b0":{"kind":"REWORK","_number":1,"created":"2017-12-22 22:11:54.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/91/529891/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/91/529891/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/1"}}},"commit":{"parents":[{"commit":"e5005dc4ff40d75c5600723eb9a5b967aefb4a92","subject":"Ensure os_workers_large fact returns an Integer","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/e5005dc4ff40d75c5600723eb9a5b967aefb4a92"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2017-12-22 22:11:34.000000000","tz":-420},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2017-12-22 22:11:34.000000000","tz":-420},"subject":"Reduce the number of facter.clears","message":"Reduce the number of facter.clears\n\nWe only need to do it before the tests, not before and after.\n\nChange-Id: I9a24dc9f74cb3b59508b12e63a078068c26c1442\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f44a0619bdc93eb602e4bdc6052aeadfb7f5c5b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/f44a0619bdc93eb602e4bdc6052aeadfb7f5c5b0"}]},"branch":"refs/heads/master"},"b5bd19a630c843f063175dbfc2c7d5e62f7976ae":{"kind":"REWORK","_number":2,"created":"2017-12-22 22:31:52.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/91/529891/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/91/529891/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/91/529891/2"}}},"commit":{"parents":[{"commit":"e5005dc4ff40d75c5600723eb9a5b967aefb4a92","subject":"Ensure os_workers_large fact returns an Integer","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/e5005dc4ff40d75c5600723eb9a5b967aefb4a92"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2017-12-22 22:11:34.000000000","tz":-420},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2017-12-22 22:31:47.000000000","tz":-420},"subject":"Switch to Facter.flush","message":"Switch to Facter.flush\n\nFacter.clear clears all cached values and removes all facts from memory\nwhere Facter.flush just clears the cached values. This should reduce the\ntime it takes to actually run the unit tests as it all the other facts\nwe\u0027re touching won\u0027t be removed from memory.\n\nAlso we only need to do it before the tests, not before and after.\n\nChange-Id: I9a24dc9f74cb3b59508b12e63a078068c26c1442\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/b5bd19a630c843f063175dbfc2c7d5e62f7976ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/b5bd19a630c843f063175dbfc2c7d5e62f7976ae"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}