)]}'
{"id":"openstack%2Fpuppet-openstacklib~530120","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Fpike~I9a24dc9f74cb3b59508b12e63a078068c26c1442","project":"openstack/puppet-openstacklib","branch":"stable/pike","topic":"os-worker-stable/pike","hashtags":[],"change_id":"I9a24dc9f74cb3b59508b12e63a078068c26c1442","subject":"Switch to Facter.flush","status":"MERGED","created":"2017-12-26 16:03:44.000000000","updated":"2017-12-26 17:24:50.000000000","submitted":"2017-12-26 17:24:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"530120-1514309090917-9ff2a9fc","meta_rev_id":"12a96d9366deb16c5b2f7b2ee50cbe0690380a8e","_number":530120,"virtual_id_number":530120,"owner":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2017-12-26 17:24:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":2,"date":"2017-12-26 17:05:40.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":1,"date":"2017-12-26 17:05:40.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"date":"2017-12-26 16:03:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-26 16:03:44.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2017-12-26 17:24:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6c9844b14abff7313f29b2a0d37cf1dad8cec9e5","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-12-26 16:03:44.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"d3dae521eb23c9a3319cf487da33ea720f125a53","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-26 16:21:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-beaker-rspec-centos-7 http://logs.openstack.org/20/530120/1/check/legacy-puppet-beaker-rspec-centos-7/129da9a/ : SUCCESS in 13m 18s\n- legacy-puppet-beaker-rspec http://logs.openstack.org/20/530120/1/check/legacy-puppet-beaker-rspec/8145291/ : SUCCESS in 8m 30s\n- puppet-openstack-lint http://logs.openstack.org/20/530120/1/check/puppet-openstack-lint/6303e2e/ : SUCCESS in 3m 31s\n- puppet-openstack-syntax-4 http://logs.openstack.org/20/530120/1/check/puppet-openstack-syntax-4/93d867d/ : SUCCESS in 2m 47s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/20/530120/1/check/puppet-openstack-unit-4.8-centos-7/de8ddca/ : SUCCESS in 8m 46s","accounts_in_message":[],"_revision_number":1},{"id":"7c21d950e35bb8d404bb3f37f5756f30fddfe5de","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2017-12-26 17:05:40.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"841d705136939a20476ffc04f52f7e90cd4b8aab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-26 17:05:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6c2dfb648e0206638fb0e613a1a3920dd7d52bf5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-26 17:24:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- legacy-puppet-beaker-rspec-centos-7 http://logs.openstack.org/20/530120/1/gate/legacy-puppet-beaker-rspec-centos-7/af29808/ : SUCCESS in 14m 58s\n- legacy-puppet-beaker-rspec http://logs.openstack.org/20/530120/1/gate/legacy-puppet-beaker-rspec/cc02e10/ : SUCCESS in 9m 16s\n- puppet-openstack-lint http://logs.openstack.org/20/530120/1/gate/puppet-openstack-lint/94c3724/ : SUCCESS in 3m 30s\n- puppet-openstack-syntax-4 http://logs.openstack.org/20/530120/1/gate/puppet-openstack-syntax-4/e49ddae/ : SUCCESS in 3m 42s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/20/530120/1/gate/puppet-openstack-unit-4.8-centos-7/eaccd99/ : SUCCESS in 9m 57s","accounts_in_message":[],"_revision_number":1},{"id":"7e7f17a62193228793bd38fbc347b37d2c90be85","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-26 17:24:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ad4d6b304e9e63cd9dd4f5c8c800b43ac7e6b88e","revisions":{"ad4d6b304e9e63cd9dd4f5c8c800b43ac7e6b88e":{"kind":"REWORK","_number":1,"created":"2017-12-26 16:03:44.000000000","uploader":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"ref":"refs/changes/20/530120/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/20/530120/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/20/530120/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/20/530120/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/20/530120/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/20/530120/1"}}},"commit":{"parents":[{"commit":"127cc458efc5844eb096beef134c04d052ffe0ad","subject":"Ensure os_workers_large fact returns an Integer","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/127cc458efc5844eb096beef134c04d052ffe0ad"}]}],"author":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2017-12-22 22:11:34.000000000","tz":-420},"committer":{"name":"Emilien Macchi","email":"emilien@redhat.com","date":"2017-12-26 16:03:44.000000000","tz":0},"subject":"Switch to Facter.flush","message":"Switch to Facter.flush\n\nFacter.clear clears all cached values and removes all facts from memory\nwhere Facter.flush just clears the cached values. This should reduce the\ntime it takes to actually run the unit tests as it all the other facts\nwe\u0027re touching won\u0027t be removed from memory.\n\nAlso we only need to do it before the tests, not before and after.\n\nChange-Id: I9a24dc9f74cb3b59508b12e63a078068c26c1442\n(cherry picked from commit b5bd19a630c843f063175dbfc2c7d5e62f7976ae)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/ad4d6b304e9e63cd9dd4f5c8c800b43ac7e6b88e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/ad4d6b304e9e63cd9dd4f5c8c800b43ac7e6b88e"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
