)]}'
{"manifests/openstackclient.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"56a56bc5df42f7d7f66c9a3c417bd536bb68b0bb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    Debian, and python-openstackclient on other distributions"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"class openstacklib::openstackclient("},{"line_number":16,"context_line":"  $package_name   \u003d \u0027\u0027,"},{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":"){"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_ae32360e","line":16,"updated":"2018-08-31 16:00:26.000000000","message":"Use undef","commit_id":"14317d4f0ce84e089e31bde989cc605598b19589"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"b5dd1f8f74f7f0731c07c77395cfdcd372159176","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    Debian, and python-openstackclient on other distributions"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"class openstacklib::openstackclient("},{"line_number":16,"context_line":"  $package_name   \u003d \u0027\u0027,"},{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":"){"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_7d67e4b8","line":16,"in_reply_to":"3f79a3b5_ae32360e","updated":"2018-09-01 09:53:08.000000000","message":"hm, I do not like undefs ...\n\nBut it\u0027s all done.","commit_id":"14317d4f0ce84e089e31bde989cc605598b19589"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"56a56bc5df42f7d7f66c9a3c417bd536bb68b0bb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    $_openstackclient_package_name \u003d $::os_package_type ? {"},{"line_number":22,"context_line":"      \u0027debian\u0027 \u003d\u003e \u0027python3-openstackclient\u0027,"},{"line_number":23,"context_line":"      default  \u003d\u003e \u0027python-openstackclient\u0027,"},{"line_number":24,"context_line":"    }"},{"line_number":25,"context_line":"  } else {"},{"line_number":26,"context_line":"    $_openstackclient_package_name \u003d $package_name"},{"line_number":27,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_4e3922f0","line":24,"updated":"2018-08-31 16:00:26.000000000","message":"You should leave this alone","commit_id":"14317d4f0ce84e089e31bde989cc605598b19589"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"56a56bc5df42f7d7f66c9a3c417bd536bb68b0bb","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  } else {"},{"line_number":26,"context_line":"    $_openstackclient_package_name \u003d $package_name"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  ensure_packages($_openstackclient_package_name, {"},{"line_number":30,"context_line":"    \u0027ensure\u0027 \u003d\u003e $package_ensure,"},{"line_number":31,"context_line":"    \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_6e3c1ee1","line":28,"updated":"2018-08-31 16:00:26.000000000","message":"Then you can do $openstack_package_name_real \u003d pick($package_name, $openstack_package_name)","commit_id":"14317d4f0ce84e089e31bde989cc605598b19589"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"56a56bc5df42f7d7f66c9a3c417bd536bb68b0bb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    $_openstackclient_package_name \u003d $package_name"},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  ensure_packages($_openstackclient_package_name, {"},{"line_number":30,"context_line":"    \u0027ensure\u0027 \u003d\u003e $package_ensure,"},{"line_number":31,"context_line":"    \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":32,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f79a3b5_0e232ac0","line":29,"updated":"2018-08-31 16:00:26.000000000","message":"$openstackclient_package_name_real","commit_id":"14317d4f0ce84e089e31bde989cc605598b19589"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"eb678ebda76e274a20bd2810cb6f1782ce9f1653","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#  [*package_ensure*]"},{"line_number":8,"context_line":"#    (Optional) Ensure state of the openstackclient package."},{"line_number":9,"context_line":"#    Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#  [*package_name*]"},{"line_number":11,"context_line":"#    (Optional) The name of the package to install"},{"line_number":12,"context_line":"#    Defaults to undef which will use python3-openstackclient on"},{"line_number":13,"context_line":"#    Debian, and python-openstackclient on other distributions"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_9d3d202e","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":2},"updated":"2018-09-01 11:39:47.000000000","message":"Missing an empty \u0027#\u0027 line here","commit_id":"daaf377209dd483570d3520741ef07989eeaacd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"eb678ebda76e274a20bd2810cb6f1782ce9f1653","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    Debian, and python-openstackclient on other distributions"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"class openstacklib::openstackclient("},{"line_number":16,"context_line":"  $package_name   \u003d undef,"},{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":"){"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_7d4284ad","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":26},"updated":"2018-09-01 11:39:47.000000000","message":"$package_name \u003d $::openstacklib::params::openstackclient_package_name","commit_id":"daaf377209dd483570d3520741ef07989eeaacd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"eb678ebda76e274a20bd2810cb6f1782ce9f1653","unresolved":false,"context_lines":[{"line_number":15,"context_line":"class openstacklib::openstackclient("},{"line_number":16,"context_line":"  $package_name   \u003d undef,"},{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":"){"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $openstackclient_package_name \u003d $::os_package_type ? {"},{"line_number":21,"context_line":"    \u0027debian\u0027 \u003d\u003e \u0027python3-openstackclient\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_1d1350ba","line":18,"updated":"2018-09-01 11:39:47.000000000","message":"inherits openstacklib::params","commit_id":"daaf377209dd483570d3520741ef07989eeaacd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"eb678ebda76e274a20bd2810cb6f1782ce9f1653","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":"){"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $openstackclient_package_name \u003d $::os_package_type ? {"},{"line_number":21,"context_line":"    \u0027debian\u0027 \u003d\u003e \u0027python3-openstackclient\u0027,"},{"line_number":22,"context_line":"    default  \u003d\u003e \u0027python-openstackclient\u0027,"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  ensure_packages(pick($package_name,$openstackclient_package_name), {"},{"line_number":26,"context_line":"    \u0027ensure\u0027 \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_bd381c3b","line":23,"range":{"start_line":20,"start_character":2,"end_line":23,"end_character":3},"updated":"2018-09-01 11:39:47.000000000","message":"IMO should move this logic to params class, then set the parameter to that default value....","commit_id":"daaf377209dd483570d3520741ef07989eeaacd4"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"0a6e7300e22bb53b90450a8ec60ed549364c8728","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":"){"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $openstackclient_package_name \u003d $::os_package_type ? {"},{"line_number":21,"context_line":"    \u0027debian\u0027 \u003d\u003e \u0027python3-openstackclient\u0027,"},{"line_number":22,"context_line":"    default  \u003d\u003e \u0027python-openstackclient\u0027,"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  ensure_packages(pick($package_name,$openstackclient_package_name), {"},{"line_number":26,"context_line":"    \u0027ensure\u0027 \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_60b73b3c","line":23,"range":{"start_line":20,"start_character":2,"end_line":23,"end_character":3},"in_reply_to":"3f79a3b5_bd381c3b","updated":"2018-09-01 13:20:51.000000000","message":"well this module does not have a parameters file yet.\nbut I can add one.\nbtw: this code was written by you ;) (I8a0c5dfa9274dca167ad3bb33ab151fb693f5d4d)","commit_id":"daaf377209dd483570d3520741ef07989eeaacd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"eb678ebda76e274a20bd2810cb6f1782ce9f1653","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    default  \u003d\u003e \u0027python-openstackclient\u0027,"},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  ensure_packages(pick($package_name,$openstackclient_package_name), {"},{"line_number":26,"context_line":"    \u0027ensure\u0027 \u003d\u003e $package_ensure,"},{"line_number":27,"context_line":"    \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":28,"context_line":"  })"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3f79a3b5_5d4788bd","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":67},"updated":"2018-09-01 11:39:47.000000000","message":"...and skip all this pick stuff and use $package_name","commit_id":"daaf377209dd483570d3520741ef07989eeaacd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2fedfbf20bb4d18748b0ae185dd9bd9dc8951bcc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"#  [*package_name*]"},{"line_number":12,"context_line":"#    (Optional) The name of the package to install"},{"line_number":13,"context_line":"#    Defaults to $openstacklib::params::openstackclient_package_name"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"class openstacklib::openstackclient("},{"line_number":16,"context_line":"  $package_name   \u003d $openstacklib::params::openstackclient_package_name,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_6284915e","line":13,"updated":"2018-09-09 20:13:16.000000000","message":"nit \"::\"","commit_id":"8288bbd4c788d344cbbdf3a2b5bc39e926fc6bd4"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2fedfbf20bb4d18748b0ae185dd9bd9dc8951bcc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    Defaults to $openstacklib::params::openstackclient_package_name"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"class openstacklib::openstackclient("},{"line_number":16,"context_line":"  $package_name   \u003d $openstacklib::params::openstackclient_package_name,"},{"line_number":17,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":18,"context_line":") inherits openstacklib::params {"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_82876d61","line":16,"updated":"2018-09-09 20:13:16.000000000","message":"nit \"::\"","commit_id":"8288bbd4c788d344cbbdf3a2b5bc39e926fc6bd4"}],"manifests/params.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"2fedfbf20bb4d18748b0ae185dd9bd9dc8951bcc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# These parameters need to be accessed from several locations and"},{"line_number":4,"context_line":"# should be considered to be constant"},{"line_number":5,"context_line":"class openstacklib::params {"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"  $openstackclient_package_name \u003d $::os_package_type ? {"},{"line_number":8,"context_line":"    \u0027debian\u0027 \u003d\u003e \u0027python3-openstackclient\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_c2afa5dd","line":5,"updated":"2018-09-09 20:13:16.000000000","message":"nit: empty \"#\" line","commit_id":"8288bbd4c788d344cbbdf3a2b5bc39e926fc6bd4"}]}