)]}'
{"id":"openstack%2Fpuppet-openstacklib~638863","triplet_id":"openstack%2Fpuppet-openstacklib~master~I70b9cafad10ec5abfc0166feb01c49adbd1f517d","project":"openstack/puppet-openstacklib","branch":"master","topic":"validate_legacy","hashtags":[],"change_id":"I70b9cafad10ec5abfc0166feb01c49adbd1f517d","subject":"Use validate_legacy","status":"MERGED","created":"2019-02-23 21:31:20.000000000","updated":"2019-02-25 19:43:31.000000000","submitted":"2019-02-25 19:43:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"638863-1551123811528-c64e651f","meta_rev_id":"0fc773ef5938fc2bff1ae7a2a19ce074a7f3c453","_number":638863,"virtual_id_number":638863,"owner":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-02-25 19:43:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-02-23 22:20:47.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"all":[{"value":2,"date":"2019-02-25 06:30:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":2,"date":"2019-02-25 17:06:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"value":1,"date":"2019-02-25 17:06:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-23 22:20:47.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-02-25 06:30:58.000000000","updated_by":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"reviewer":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"state":"REVIEWER"},{"updated":"2019-02-25 17:06:13.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-02-25 19:43:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"65629aa54c7070b39f7498848385909c8824b80f","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-02-23 21:31:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1fe6fa51b6e3a2095aa8632e7f3d1f2b4d15bc89","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-02-23 22:20:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-integration-5-scenario001-tempest-fedora-28 http://logs.rdoproject.org/63/638863/1/openstack-check-rdo/puppet-openstack-integration-5-scenario001-tempest-fedora-28/6e40834/ : SUCCESS in 44m 05s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-fedora-28 http://logs.rdoproject.org/63/638863/1/openstack-check-rdo/puppet-openstack-integration-5-scenario002-tempest-fedora-28/1a985de/ : SUCCESS in 40m 04s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-fedora-28 http://logs.rdoproject.org/63/638863/1/openstack-check-rdo/puppet-openstack-integration-5-scenario003-tempest-fedora-28/e2fed5f/ : SUCCESS in 46m 50s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-fedora-28 http://logs.rdoproject.org/63/638863/1/openstack-check-rdo/puppet-openstack-integration-5-scenario004-tempest-fedora-28/af0badd/ : SUCCESS in 26m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"12826af8d31c6cc4b8bce44ce935f84ecadedda4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-23 23:30:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-lint-ubuntu-bionic/4fbba5b/ : SUCCESS in 4m 11s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-syntax-4-ubuntu-bionic/dc8ab51/ : SUCCESS in 5m 21s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-syntax-5-ubuntu-bionic/2533cf2/ : SUCCESS in 3m 45s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-syntax-6-ubuntu-bionic/bcfcdb8/ : SUCCESS in 4m 19s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/63/638863/1/check/puppet-openstack-unit-4.8-centos-7/5027d26/ : SUCCESS in 10m 13s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/63/638863/1/check/puppet-openstack-unit-5.5-centos-7/e60d654/ : SUCCESS in 15m 19s\n- puppet-openstack-unit-6.0-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-unit-6.0-ubuntu-bionic/7a72890/ : SUCCESS in 8m 44s\n- puppet-openstack-unit-latest-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-unit-latest-ubuntu-bionic/d318dc1/ : FAILURE in 6m 52s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/1654cbf/ : SUCCESS in 1h 02m 06s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario002-tempest-centos-7/b74eea1/ : SUCCESS in 1h 08m 19s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario003-tempest-centos-7/726fb4f/ : SUCCESS in 1h 00m 45s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic/321c570/ : SUCCESS in 55m 48s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/fae2093/ : SUCCESS in 48m 39s\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/8dfc5e3/ : SUCCESS in 1h 01m 59s\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic/e29ad7a/ : SUCCESS in 43m 55s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic http://logs.openstack.org/63/638863/1/check/puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic/c40b9e5/ : SUCCESS in 46m 29s (non-voting)\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/63/638863/1/check/puppet-openstack-beaker-centos-7/7cbdac6/ : SUCCESS in 17m 21s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/63/638863/1/check/puppet-openstack-beaker-ubuntu-bionic/3ef4096/ : SUCCESS in 9m 39s (non-voting)\n- tripleo-puppet-ci-centos-7-standalone http://logs.openstack.org/63/638863/1/check/tripleo-puppet-ci-centos-7-standalone/0b0987e/ : SUCCESS in 1h 54m 00s","accounts_in_message":[],"_revision_number":1},{"id":"2573ded4230033a853338efff61a23c331702cdc","author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"date":"2019-02-25 06:30:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"aeefc0a6b43642261ecd583b1f0538b1ad8b2787","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-02-25 17:06:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"678b3b707072de8937d977cb832999b69caef71a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 17:06:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9fafb83cbe57c1493e92f26ccec253a4557bf1ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 19:43:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"deeaa9977961be0be838abfc1ab4f4625356f9f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-25 19:43:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-lint-ubuntu-bionic/a1fbbd0/ : SUCCESS in 4m 15s\n- puppet-openstack-syntax-4-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-syntax-4-ubuntu-bionic/206e057/ : SUCCESS in 3m 51s\n- puppet-openstack-syntax-5-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-syntax-5-ubuntu-bionic/ae492b9/ : SUCCESS in 4m 47s\n- puppet-openstack-syntax-6-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-syntax-6-ubuntu-bionic/d34a51f/ : SUCCESS in 4m 05s\n- puppet-openstack-unit-4.8-centos-7 http://logs.openstack.org/63/638863/1/gate/puppet-openstack-unit-4.8-centos-7/f8ba364/ : SUCCESS in 18m 49s\n- puppet-openstack-unit-5.5-centos-7 http://logs.openstack.org/63/638863/1/gate/puppet-openstack-unit-5.5-centos-7/89399c7/ : SUCCESS in 18m 32s\n- puppet-openstack-unit-6.0-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-unit-6.0-ubuntu-bionic/4d69ef3/ : SUCCESS in 11m 46s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous http://logs.openstack.org/63/638863/1/gate/puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous/adbe09f/ : SUCCESS in 58m 23s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 http://logs.openstack.org/63/638863/1/gate/puppet-openstack-integration-5-scenario002-tempest-centos-7/cd01d32/ : SUCCESS in 58m 47s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 http://logs.openstack.org/63/638863/1/gate/puppet-openstack-integration-5-scenario003-tempest-centos-7/f03a765/ : SUCCESS in 1h 05m 22s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic/d5542fb/ : SUCCESS in 41m 45s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic/9291f87/ : SUCCESS in 51m 35s\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic/ce3dbe2/ : SUCCESS in 56m 44s\n- puppet-openstack-beaker-centos-7 http://logs.openstack.org/63/638863/1/gate/puppet-openstack-beaker-centos-7/d84258b/ : SUCCESS in 15m 22s\n- puppet-openstack-beaker-ubuntu-bionic http://logs.openstack.org/63/638863/1/gate/puppet-openstack-beaker-ubuntu-bionic/4e8a8fc/ : SUCCESS in 13m 10s (non-voting)\n- tripleo-puppet-ci-centos-7-standalone http://logs.openstack.org/63/638863/1/gate/tripleo-puppet-ci-centos-7-standalone/21a5370/ : SUCCESS in 2h 23m 15s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6bdeca8d21e57384e231fc2f739425b605a323f7","revisions":{"6bdeca8d21e57384e231fc2f739425b605a323f7":{"kind":"REWORK","_number":1,"created":"2019-02-23 21:31:20.000000000","uploader":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"ref":"refs/changes/63/638863/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/63/638863/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/63/638863/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/63/638863/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/63/638863/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/63/638863/1"}}},"commit":{"parents":[{"commit":"5d0b6b51c42a39bfde165f3e88c4c3fa94396798","subject":"Merge \"Update puppetlabs-mysql dependency to min 6.0.0\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/5d0b6b51c42a39bfde165f3e88c4c3fa94396798"}]}],"author":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2019-02-23 21:31:06.000000000","tz":60},"committer":{"name":"Tobias Urdin","email":"tobias.urdin@binero.se","date":"2019-02-23 21:31:06.000000000","tz":60},"subject":"Use validate_legacy","message":"Use validate_legacy\n\nThis changes all the puppet 3 validate_* functions\nto use the validate_legacy function.\n\nThe validate_legacy function has been available since\nabout three years but require Puppet \u003e\u003d 4.4.0 and since\nthere is Puppet 4.10.12 as latest we should assume people\nare running a fairly new Puppet 4 version.\n\nThis is the first step to then remove all validate function\ncalls and use proper types for parameter as described in spec [1].\n\n[1] https://review.openstack.org/#/c/568929/\n\nChange-Id: I70b9cafad10ec5abfc0166feb01c49adbd1f517d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/6bdeca8d21e57384e231fc2f739425b605a323f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/6bdeca8d21e57384e231fc2f739425b605a323f7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}