)]}'
{"id":"openstack%2Fpuppet-openstacklib~682821","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Fstein~I55e587ea5c83338ae989aa56f1f379079eb02e08","project":"openstack/puppet-openstacklib","branch":"stable/stein","hashtags":[],"change_id":"I55e587ea5c83338ae989aa56f1f379079eb02e08","subject":"Restore defaults for combine and failonfail in openstack command","status":"MERGED","created":"2019-09-18 08:12:49.000000000","updated":"2019-10-08 15:28:21.000000000","submitted":"2019-10-08 15:28:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682821-1570548501010-8e81ebfc","meta_rev_id":"a40d6133deca7c831e97f161370b5fa033665c87","_number":682821,"virtual_id_number":682821,"owner":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-08 15:28:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":2,"date":"2019-10-08 06:50:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-10-08 14:02:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2019-10-08 08:08:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":1,"date":"2019-10-08 14:02:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-08 06:50:00.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-10-08 08:08:50.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-10-08 14:02:05.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-10-08 15:28:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"62b70d9a1eb06d5db2c2778d002aec5b56ec4232","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-09-18 08:12:49.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"c71e6e3e975863dcc7d5214ba8c0afa72504a7e9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 10:24:56.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/26ad26243cff4613848159c523916b6f : SUCCESS in 6m 45s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/955cd45ae0544a84a14605f1bc2a7f27 : SUCCESS in 6m 06s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/b9efacc9b5324ea7bcad1730c7ca7b87 : SUCCESS in 4m 37s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/4584d635a8da4ef2b613f849b621280b : SUCCESS in 5m 53s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/21b2adb1d5e54ad8a40c1e9ed7774007 : SUCCESS in 20m 19s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/047d0280c9e34116b20745c37ef0112c : SUCCESS in 17m 23s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/8420dab7316a4bc2b0fe98d97e47b702 : SUCCESS in 1h 00m 19s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/2d968dccc6cd4f1aa5baec654aeb0a2e : FAILURE in 1h 05m 14s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/9e2cbd0212254d03a87b2812b5575f1a : SUCCESS in 1h 01m 26s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/9c655dc06ab340c4896cd2407b85ee1e : SUCCESS in 47m 22s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/aa6063e539664ef9a20922d816f8ee19 : FAILURE in 22m 08s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/58b5998a18b149f0ac9910b6ab03505a : FAILURE in 24m 57s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/faa91bcf504948bda61badde3a499618 : FAILURE in 37m 13s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/a8fc497476214e21a25fd05ed88e74c4 : FAILURE in 26m 55s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/aa7667f047a84b2c872cb06e1ae81fb5 : SUCCESS in 15m 49s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0b03cd0cd25449b69e1953566fa02fbf : FAILURE in 11m 27s (non-voting)\n- tripleo-puppet-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/ac882da6517a4c53ba29b63cfca2e13c : SUCCESS in 2h 05m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7571170f781ed9158a931367624d9e001804b6ab","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-07 21:07:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3c4c3ff500d79b0c94d754f41d48f90aa6652515","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-07 23:32:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9a4c4185aa974f529edc452c7065f069 : SUCCESS in 4m 21s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/709d80620ba244ff867fb3d7dc2ff084 : SUCCESS in 4m 01s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/caaa50e231534b3c8fad1d91ee0d4712 : SUCCESS in 4m 09s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/cd2641e4cbc046598a2d2fbd39ce1eef : SUCCESS in 4m 00s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/d0923f17c2dc41beab7ada41868ccea5 : SUCCESS in 19m 16s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/e0f240e934bf4d4990a5def6405a0131 : SUCCESS in 17m 21s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/675d3a7528c148b3ab65f41d72ddb4c1 : SUCCESS in 55m 28s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/576cd68df90f4d74b9ca792399c4c486 : SUCCESS in 1h 00m 50s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/83ca813679004968b85bfe46f55d43a9 : SUCCESS in 1h 02m 02s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-nautilus https://zuul.opendev.org/t/openstack/build/cafd4511b51e43caabcd6ac1b055b362 : SUCCESS in 44m 53s (non-voting)\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/7df19e1aff9b482bb1bfbcf16d17265e : FAILURE in 30m 28s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/3153ac33fc364d93bd63d58a3e9ee29f : FAILURE in 21m 15s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/ac3f82e2a40245598bff5d903760c8c2 : FAILURE in 19m 02s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/ee7d6ab576e24fba9cb1ae01d2d092ca : FAILURE in 30m 22s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/c5202b43cb38465cb9355d48902e2f91 : SUCCESS in 13m 20s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/14532a6bd76347d8bd1ee09d3595ca4f : FAILURE in 9m 06s (non-voting)\n- tripleo-puppet-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/beab2b50675d4739be9ae184d9106a69 : SUCCESS in 2h 14m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"568fc45e2b7b0bdfd7e9e342c9ae9455fe153ac6","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-08 06:50:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b5e8685a4b1d248c7bfd6b3f259532014fe2dcc9","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-10-08 08:08:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d1f8e3b912da0e192fdc96beda2e9bcd5e1d9ec1","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-08 14:02:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"377b1cd0f3a32ec3bf5639b39ecef3773b1028eb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 14:02:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"862ea00e9c4ee1cf71eb74467c570f5e146b0e9b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 15:28:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/85a68d6d09764752921db916bc261455 : SUCCESS in 5m 21s\n- puppet-openstack-syntax-4-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9a63c35199534705993139af54d59b8d : SUCCESS in 4m 00s\n- puppet-openstack-syntax-5-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/20d3cd7d37a54099853090e0b75b6a82 : SUCCESS in 4m 49s\n- puppet-openstack-syntax-6-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/e34c7c4055974503a8e9238177ff3185 : SUCCESS in 3m 57s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/9baaa456846142ecb1803ac8738e9dfd : SUCCESS in 18m 18s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/01d43a1ccde7463eb844ec3071758ca1 : SUCCESS in 19m 25s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/264ecd4fb3754b7cafc0fc2668e825e4 : SUCCESS in 53m 59s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/fd6adc9be8274ebda613dc970a0f9b9c : SUCCESS in 1h 20m 16s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/ef11fc97fb144889b64f1f7e5f873dc4 : SUCCESS in 58m 17s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/d284ae77746b4f518dbadeeafe4e9b3e : SUCCESS in 13m 38s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/5ea1c73106e74952b7a1438e4bf5569f : FAILURE in 11m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a40d6133deca7c831e97f161370b5fa033665c87","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 15:28:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cf84ba5d79179d6c6b18e40fe706b970cda65377","revisions":{"cf84ba5d79179d6c6b18e40fe706b970cda65377":{"kind":"REWORK","_number":1,"created":"2019-09-18 08:12:49.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/21/682821/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/21/682821/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/21/682821/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/21/682821/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/21/682821/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/21/682821/1"}}},"commit":{"parents":[{"commit":"3719ca1465425c7c1e586d17d2e0a95cc61351ee","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/3719ca1465425c7c1e586d17d2e0a95cc61351ee"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2019-09-16 16:52:52.000000000","tz":120},"committer":{"name":"Javier Peña","email":"jpena@redhat.com","date":"2019-09-18 08:12:49.000000000","tz":0},"subject":"Restore defaults for combine and failonfail in openstack command","message":"Restore defaults for combine and failonfail in openstack command\n\n[1] added \"override_locale: false\" to the openstack command executions,\nto respect the current locale. This had an unintended side effect,\nsince it changed the values for failonfail and combine to false in\nthat same execution, as described in [2].\n\nWe should ensure that openstack command failures are respected, so\nthis commit restores that behavior.\n\n[1] - https://review.opendev.org/640997\n[2] - https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L139-L143\n\nChange-Id: I55e587ea5c83338ae989aa56f1f379079eb02e08\n(cherry picked from commit 726b06cdb49426719a13be3f02bcce72a697484c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/cf84ba5d79179d6c6b18e40fe706b970cda65377"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/cf84ba5d79179d6c6b18e40fe706b970cda65377"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}