)]}'
{"id":"openstack%2Fpuppet-openstacklib~682822","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Frocky~I55e587ea5c83338ae989aa56f1f379079eb02e08","project":"openstack/puppet-openstacklib","branch":"stable/rocky","hashtags":[],"change_id":"I55e587ea5c83338ae989aa56f1f379079eb02e08","subject":"Restore defaults for combine and failonfail in openstack command","status":"MERGED","created":"2019-09-18 08:12:58.000000000","updated":"2019-09-19 05:57:45.000000000","submitted":"2019-09-19 05:57:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682822-1568872665446-f612c5ef","meta_rev_id":"5e76195ffb99efc949da768ba8038d7987320adc","_number":682822,"virtual_id_number":682822,"owner":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-19 05:57:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-19 04:19:15.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-19 04:19:15.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-19 04:19:15.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-09-19 05:57:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9d62f4b20bbaf2837d14f18050d6fe8a21a21ce3","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-09-18 08:12:58.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"51e55e6483ad623a3062569c31fd24cad98e285e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 10:17:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/12fe7b9e61724c2ba4f78eaab4b920fb : SUCCESS in 5m 29s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/9718560530984eb29813d88c93d24578 : SUCCESS in 4m 51s\n- puppet-openstack-syntax-5 https://zuul.opendev.org/t/openstack/build/d459d20971ba40c697228de4817be5b0 : SUCCESS in 4m 47s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/bb694bd947ff4cc19ae5d79d458a6386 : SUCCESS in 19m 29s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/b5bc72876a134b23a634b2a541110db3 : SUCCESS in 53m 43s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/485195eb9c8d466c97957d2499015a94 : SUCCESS in 1h 03m 45s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/7c4ece737121485f9a37d78c42e8cafa : SUCCESS in 1h 05m 07s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic https://zuul.opendev.org/t/openstack/build/c40ff55f56774aa695be033f60508836 : SUCCESS in 48m 51s\n- puppet-openstack-integration-5-scenario001-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/5cff950fbf8d4fa886773ee508bebe8c : TIMED_OUT in 1h 31m 23s (non-voting)\n- puppet-openstack-integration-5-scenario002-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/13b0b419311e4b2b9bcf4e4639ed8bf1 : TIMED_OUT in 1h 30m 47s (non-voting)\n- puppet-openstack-integration-5-scenario003-tempest-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/bcee4c082ef5419fa7a6407b0537b1f0 : TIMED_OUT in 1h 31m 25s (non-voting)\n- puppet-openstack-integration-5-scenario004-tempest-ubuntu-bionic-mimic https://zuul.opendev.org/t/openstack/build/6d72989e282b4efba867282224cad7d8 : TIMED_OUT in 1h 30m 50s (non-voting)\n- puppet-openstack-integration-4-scenario001-tempest-debian-stable-luminous https://zuul.opendev.org/t/openstack/build/cb2d0aae92ec4bc9a6b49f2ee9716739 : TIMED_OUT in 1h 30m 55s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-debian-stable https://zuul.opendev.org/t/openstack/build/1d5f26c052a24156891087b9d967f16f : FAILURE in 54m 20s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-debian-stable https://zuul.opendev.org/t/openstack/build/bad9e4d6b1f147e0b5f4136accee2173 : TIMED_OUT in 1h 30m 59s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-debian-stable-luminous https://zuul.opendev.org/t/openstack/build/9486960b7ca145a791a205f899228c1b : TIMED_OUT in 1h 30m 42s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/8f8197b5cf044fef91971b16bd440aa4 : SUCCESS in 16m 24s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/9de118b6f75146dd934e5e84989e76a6 : SUCCESS in 9m 29s","accounts_in_message":[],"_revision_number":1},{"id":"2fb7e05a7f7df039a5caa28606119f510a3e8d95","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-09-19 04:19:15.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ed36b8368bd09b9a988c3c2bd8e14b7ac5261d07","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 04:19:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e29f14936be9e4318c0c15ed3bcc8d79bee58bd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 05:57:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/dd298ebf85c64a24a12b2d4bd8a216d7 : SUCCESS in 4m 49s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/147cae3f2e9b471fbceb76d018c49a6e : SUCCESS in 5m 01s\n- puppet-openstack-syntax-5 https://zuul.opendev.org/t/openstack/build/a86f3c34ad26427ca6f5a59d47e84fdb : SUCCESS in 4m 21s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/a38fd4ebde5b46acbb0cdf68ae62e862 : SUCCESS in 17m 33s\n- puppet-openstack-integration-5-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/779b79040e534c3ab28d334407392c61 : SUCCESS in 1h 05m 02s\n- puppet-openstack-integration-5-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/2d876cef849b474d9bf0942bb7e1e215 : SUCCESS in 1h 00m 45s\n- puppet-openstack-integration-5-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/7f889d94de5f45398e6db1b38aaedd80 : SUCCESS in 57m 24s\n- puppet-openstack-integration-5-scenario004-tempest-centos-7-mimic https://zuul.opendev.org/t/openstack/build/a14c5c26d44e486ab9bd2976fe78dc89 : SUCCESS in 46m 15s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/0374f733583441bfb53f4b4885003cb5 : SUCCESS in 14m 38s\n- puppet-openstack-beaker-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/53b7cd49dcfa4fdc9e82a36ba4e615c0 : SUCCESS in 8m 35s","accounts_in_message":[],"_revision_number":1},{"id":"5e76195ffb99efc949da768ba8038d7987320adc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 05:57:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"64d5aec21674c60e61f4f4d8b0c694eed05b91b5","revisions":{"64d5aec21674c60e61f4f4d8b0c694eed05b91b5":{"kind":"REWORK","_number":1,"created":"2019-09-18 08:12:58.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/22/682822/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/22/682822/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/22/682822/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/22/682822/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/22/682822/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/22/682822/1"}}},"commit":{"parents":[{"commit":"05a84dddfa749499424eef3d13c420d5ca8b21fe","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/05a84dddfa749499424eef3d13c420d5ca8b21fe"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2019-09-16 16:52:52.000000000","tz":120},"committer":{"name":"Javier Peña","email":"jpena@redhat.com","date":"2019-09-18 08:12:58.000000000","tz":0},"subject":"Restore defaults for combine and failonfail in openstack command","message":"Restore defaults for combine and failonfail in openstack command\n\n[1] added \"override_locale: false\" to the openstack command executions,\nto respect the current locale. This had an unintended side effect,\nsince it changed the values for failonfail and combine to false in\nthat same execution, as described in [2].\n\nWe should ensure that openstack command failures are respected, so\nthis commit restores that behavior.\n\n[1] - https://review.opendev.org/640997\n[2] - https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L139-L143\n\nChange-Id: I55e587ea5c83338ae989aa56f1f379079eb02e08\n(cherry picked from commit 726b06cdb49426719a13be3f02bcce72a697484c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/64d5aec21674c60e61f4f4d8b0c694eed05b91b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/64d5aec21674c60e61f4f4d8b0c694eed05b91b5"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}