)]}'
{"id":"openstack%2Fpuppet-openstacklib~682823","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Fqueens~I55e587ea5c83338ae989aa56f1f379079eb02e08","project":"openstack/puppet-openstacklib","branch":"stable/queens","hashtags":[],"change_id":"I55e587ea5c83338ae989aa56f1f379079eb02e08","subject":"Restore defaults for combine and failonfail in openstack command","status":"MERGED","created":"2019-09-18 08:13:10.000000000","updated":"2019-10-08 15:28:21.000000000","submitted":"2019-10-08 15:28:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682823-1570548501694-bad3269c","meta_rev_id":"d386be800fe62c8931cb7d3edf3982dc0395423c","_number":682823,"virtual_id_number":682823,"owner":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-08 15:28:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"all":[{"value":2,"date":"2019-10-08 06:50:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":2,"date":"2019-10-08 14:02:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2019-10-08 08:09:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"value":1,"date":"2019-10-08 14:02:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-08 06:50:05.000000000","updated_by":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"reviewer":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"state":"REVIEWER"},{"updated":"2019-10-08 08:09:17.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-10-08 14:02:12.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-10-08 15:28:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"79621c922b3ccd86fa01c11007bf6607c9624aaa","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-09-18 08:13:10.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"6228a292e26eaaaf260ad17a87714de8b300fd8e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 10:19:39.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/606bf54c9ac64339a68a447983e41ad5 : SUCCESS in 6m 11s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/fe4e120b3c7340be943f53da4bf2958e : SUCCESS in 4m 29s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/a369bc6755f948b287facca8d93f486f : SUCCESS in 11m 09s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/43ada502e1354f2fa4813cd3cac858fa : SUCCESS in 18m 33s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/36d90bc85cff402b805feb5f2ddfb66c : SUCCESS in 1h 03m 03s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/1292915a4ab34c09b378546badd5d6ce : SUCCESS in 1h 06m 27s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/f542703d4ccf4aeda749b8949139ebe2 : FAILURE in 47m 09s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/7250adb3342a4849b3dacfd9657b110a : SUCCESS in 47m 53s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/219a86e66c564ba1b9651e27a5b751d7 : TIMED_OUT in 1h 30m 44s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/058cc494b07c48c9bdd45f68283b0ea1 : TIMED_OUT in 1h 30m 52s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/5cec582a11b34817b729cc1bcabd9da8 : TIMED_OUT in 1h 30m 50s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/1e1e9ef6dfad4cb9b64d63edacd5fddd : TIMED_OUT in 1h 31m 07s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/a24da959216545e8875b247318cf7c84 : SUCCESS in 15m 39s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/54b17d8c9bff49ff8c7aecd004a37a48 : SUCCESS in 15m 08s","accounts_in_message":[],"_revision_number":1},{"id":"e96ab2370d949f70e324716f2830e17190fbba53","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-07 21:07:51.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"f2393a0f7a21d17f7c67350c4ada0de3a853d9bb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-07 22:44:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/7fd7722c60da463fbeaa7052abf74504 : SUCCESS in 5m 44s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/74d926617b7f417986ab5326371bcc2b : SUCCESS in 4m 24s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/45b8468748cd4c3b9971f212cbc41003 : SUCCESS in 12m 18s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/85227e60cf2a47a0bd6927da223a9c62 : SUCCESS in 11m 11s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/458a1cad6db54d468ac2fe207bd49d2d : SUCCESS in 59m 39s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/882ef6027a434774aa342edb7c3f7f9d : SUCCESS in 1h 00m 01s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/ea05889fd92f4e5eb419804e182a3218 : SUCCESS in 58m 55s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/7685cbdca4314a7ebca52a0f82e81750 : SUCCESS in 44m 15s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/127077a6078a4288b839086e6c4cb252 : TIMED_OUT in 1h 30m 53s (non-voting)\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/b8d73bbe2bbb4752b766a091b0ad0b6f : TIMED_OUT in 1h 30m 45s (non-voting)\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/4a20b371a5da4f5cb8f7a7e9b1d20c62 : TIMED_OUT in 1h 31m 16s (non-voting)\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial-luminous https://zuul.opendev.org/t/openstack/build/88a1c97c126e43428b416b62b999e64f : TIMED_OUT in 1h 31m 07s (non-voting)\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/21e7409169e440e0a156fc07b3d11e3f : SUCCESS in 12m 11s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/bb6ba75d6a1b4956ae2207e8542e84e8 : SUCCESS in 15m 44s","accounts_in_message":[],"_revision_number":1},{"id":"727736ac0c434876e5d209cca3ac64e90e7514a8","author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"date":"2019-10-08 06:50:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f538af59ca43c643b54eaf4c7170a27a3ebe35f6","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-10-08 08:09:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8acd4f5899dc118e3dbd3baf7798fc84b996738b","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-08 14:02:12.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bdfbbb62b5501c1d2f76edf472bc6093caa4b535","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 14:02:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"886e4753e2610729facb498fe20557b67485195a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 15:28:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/c7690edb7ae242c5b2565b7e046c75ee : SUCCESS in 5m 08s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/17a6dc6db403477385dc87c7aefcc992 : SUCCESS in 5m 12s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/e8d7fd7ec19b47c6908e7a946e35e70e : SUCCESS in 15m 29s\n- puppet-openstack-unit-5.5-centos-7 https://zuul.opendev.org/t/openstack/build/e084cea37e3443c89ec737f1f841af3e : SUCCESS in 12m 15s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/6c277d19d6b64a59ae0d956553a2aac0 : SUCCESS in 1h 03m 22s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/fdd24af419b64864829667d78b3e8513 : SUCCESS in 1h 10m 57s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/a066a56186904a35b6c6eb8b8c5523c7 : SUCCESS in 1h 16m 42s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7-luminous https://zuul.opendev.org/t/openstack/build/c2f41a024896455ba3b7bcf8c1e35b17 : SUCCESS in 51m 18s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/253c2a805a8647c696a0b1e4bd9cb95c : SUCCESS in 14m 19s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/0fe4c1450ed44724a45b981fb1807185 : SUCCESS in 10m 32s","accounts_in_message":[],"_revision_number":1},{"id":"d386be800fe62c8931cb7d3edf3982dc0395423c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-08 15:28:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b62d3c6da8b695d113a1a5f8ade53cc891f8621e","revisions":{"b62d3c6da8b695d113a1a5f8ade53cc891f8621e":{"kind":"REWORK","_number":1,"created":"2019-09-18 08:13:10.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/23/682823/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/23/682823/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/23/682823/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/23/682823/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/23/682823/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/23/682823/1"}}},"commit":{"parents":[{"commit":"66ffd3d816f765903ae74d292f76a13ecaee4656","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/66ffd3d816f765903ae74d292f76a13ecaee4656"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2019-09-16 16:52:52.000000000","tz":120},"committer":{"name":"Javier Peña","email":"jpena@redhat.com","date":"2019-09-18 08:13:10.000000000","tz":0},"subject":"Restore defaults for combine and failonfail in openstack command","message":"Restore defaults for combine and failonfail in openstack command\n\n[1] added \"override_locale: false\" to the openstack command executions,\nto respect the current locale. This had an unintended side effect,\nsince it changed the values for failonfail and combine to false in\nthat same execution, as described in [2].\n\nWe should ensure that openstack command failures are respected, so\nthis commit restores that behavior.\n\n[1] - https://review.opendev.org/640997\n[2] - https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L139-L143\n\nChange-Id: I55e587ea5c83338ae989aa56f1f379079eb02e08\n(cherry picked from commit 726b06cdb49426719a13be3f02bcce72a697484c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/b62d3c6da8b695d113a1a5f8ade53cc891f8621e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/b62d3c6da8b695d113a1a5f8ade53cc891f8621e"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}