)]}'
{"id":"openstack%2Fpuppet-openstacklib~682824","triplet_id":"openstack%2Fpuppet-openstacklib~stable%2Fpike~I55e587ea5c83338ae989aa56f1f379079eb02e08","project":"openstack/puppet-openstacklib","branch":"stable/pike","hashtags":[],"change_id":"I55e587ea5c83338ae989aa56f1f379079eb02e08","subject":"Restore defaults for combine and failonfail in openstack command","status":"ABANDONED","created":"2019-09-18 08:13:18.000000000","updated":"2019-10-07 21:08:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5e3ab81a62eb9156db528ca9bf6417a8ef87c416","_number":682824,"virtual_id_number":682824,"owner":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2019-09-18 09:40:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-18 09:40:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e1e095b4ac3a5eb9c4e2546b92369866d4f1dbdf","author":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"date":"2019-09-18 08:13:18.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"e6df033fb1cf78df390cc4a2d580df9aeb093d83","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 09:40:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- puppet-openstack-lint https://zuul.opendev.org/t/openstack/build/b7d2d2bd098340c38b8bfcf10bad842c : RETRY_LIMIT in 2m 36s\n- puppet-openstack-syntax-4 https://zuul.opendev.org/t/openstack/build/342b1cece75c4758bb6757f352432b92 : RETRY_LIMIT in 1m 47s\n- puppet-openstack-unit-4.8-centos-7 https://zuul.opendev.org/t/openstack/build/75e38a95d9c04c30946268bb45308e8b : RETRY_LIMIT in 7m 00s\n- puppet-openstack-integration-4-scenario001-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/94a8452454b849a9920a7c5ddf08a92c : RETRY_LIMIT in 5m 48s\n- puppet-openstack-integration-4-scenario002-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/24be5cb96d6a4dbb9fdee13a69d326ab : RETRY_LIMIT in 4m 54s\n- puppet-openstack-integration-4-scenario003-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/b97d5150c18845229900ce00d0a6661a : RETRY_LIMIT in 4m 43s\n- puppet-openstack-integration-4-scenario004-tempest-centos-7 https://zuul.opendev.org/t/openstack/build/c99b07a8a9d24ef88d0909be2b33da8c : RETRY_LIMIT in 6m 28s\n- puppet-openstack-integration-4-scenario001-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/f40f6a1a0e664590965f4ef5dfe6dfb6 : RETRY_LIMIT in 3m 44s\n- puppet-openstack-integration-4-scenario002-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/3aeb340269624750ad5427795ffe2b22 : RETRY_LIMIT in 2m 53s\n- puppet-openstack-integration-4-scenario003-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/58e4e807ec2f471f828dac15e4afaa62 : RETRY_LIMIT in 3m 53s\n- puppet-openstack-integration-4-scenario004-tempest-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/4201920b8bf04bb1aa0b3d57687f7542 : RETRY_LIMIT in 6m 14s\n- puppet-openstack-beaker-centos-7 https://zuul.opendev.org/t/openstack/build/54367f6010bf456c89551e5c9cfd18a1 : RETRY_LIMIT in 5m 17s\n- puppet-openstack-beaker-xenial https://zuul.opendev.org/t/openstack/build/e74751ae7c224165a25d553914679cfd : RETRY_LIMIT in 4m 42s","accounts_in_message":[],"_revision_number":1},{"id":"5e3ab81a62eb9156db528ca9bf6417a8ef87c416","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-10-07 21:08:23.000000000","message":"Abandoned\n\npike should no longer be patched","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4d0e91cf6e14bfa732b1319e95b4ce9d193d9f83","revisions":{"4d0e91cf6e14bfa732b1319e95b4ce9d193d9f83":{"kind":"REWORK","_number":1,"created":"2019-09-18 08:13:18.000000000","uploader":{"_account_id":13294,"name":"Javier Peña","email":"jpena@redhat.com","username":"jpena"},"ref":"refs/changes/24/682824/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/puppet-openstacklib","ref":"refs/changes/24/682824/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/24/682824/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/24/682824/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/puppet-openstacklib refs/changes/24/682824/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/puppet-openstacklib refs/changes/24/682824/1"}}},"commit":{"parents":[{"commit":"8eb102c622c3756da60d5ed15baf159638e639f1","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/8eb102c622c3756da60d5ed15baf159638e639f1"}]}],"author":{"name":"Javier Pena","email":"jpena@redhat.com","date":"2019-09-16 16:52:52.000000000","tz":120},"committer":{"name":"Javier Peña","email":"jpena@redhat.com","date":"2019-09-18 08:13:18.000000000","tz":0},"subject":"Restore defaults for combine and failonfail in openstack command","message":"Restore defaults for combine and failonfail in openstack command\n\n[1] added \"override_locale: false\" to the openstack command executions,\nto respect the current locale. This had an unintended side effect,\nsince it changed the values for failonfail and combine to false in\nthat same execution, as described in [2].\n\nWe should ensure that openstack command failures are respected, so\nthis commit restores that behavior.\n\n[1] - https://review.opendev.org/640997\n[2] - https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/execution.rb#L139-L143\n\nChange-Id: I55e587ea5c83338ae989aa56f1f379079eb02e08\n(cherry picked from commit 726b06cdb49426719a13be3f02bcce72a697484c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/4d0e91cf6e14bfa732b1319e95b4ce9d193d9f83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/puppet-openstacklib/commit/4d0e91cf6e14bfa732b1319e95b4ce9d193d9f83"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}