)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"6003d661cec0121579be8cf534dc93696dbd4394","unresolved":false,"context_lines":[{"line_number":15,"context_line":"faster application loading."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] https://review.opendev.org/#/q/status:merged+project:openstack/tripleo-heat-templates+branch:master+topic:bug/1842687"},{"line_number":18,"context_line":"Related-Bug: #1843555"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I27e37e30823c4312d9d7a93f18fe0f930ce70c49"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_0ffcca3c","line":18,"range":{"start_line":18,"start_character":13,"end_line":18,"end_character":21},"updated":"2019-10-03 12:28:03.000000000","message":"https://bugs.launchpad.net/tripleo/+bug/1846322","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e096fc9f0167d55f02e923f6cd61c403deb7f4d1","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_6f845eb2","line":293,"updated":"2019-10-03 12:23:14.000000000","message":"any chance to integrate this code directly in the ::apache::vhost?\n\nalso can you add unit tests please?","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5abee080b7b56f2cf2dfe08cb8a5a04891dc46eb","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_056ca99a","line":293,"in_reply_to":"3fa7e38b_12f2ad9b","updated":"2019-10-03 13:51:39.000000000","message":"Why should we duplicate info/data? Using this simple boolean allows to set all the right values, with a clean override that, actually, meets puppet practices.","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"ffe2b9b4a0fc0d9cf0aed5a88b0ae701d4f76a01","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_cf2f92a5","line":293,"in_reply_to":"3fa7e38b_6f845eb2","updated":"2019-10-03 12:30:27.000000000","message":"err, where are all the unit tests? https://github.com/openstack/puppet-openstacklib/tree/master/spec/classes","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"0b0f481858eadfeb6fc6f5f3f09acb8a9c340850","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_720e8133","line":293,"in_reply_to":"3fa7e38b_6f845eb2","updated":"2019-10-03 12:36:23.000000000","message":"hm, not really for the integration, since it\u0027s an optional addition. Unless we want to enforce it?\nThe apache::vhost definition DOES have wsgi_import_script, but it has to be a path, meaning it will be harder to implement it properly (i.e. modification of the upper puppet-(nova|...) in order to allow to pass that value, and so on).\n\nDoing this override line 330 and following allows a smooth addition without much pain, without endless \"if\" things in order to generate variables. It\u0027s the puppet way.\n\n\nAs for unit testing: yeah, of course. Forget about it ^^\u0027.","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"e0f4359531874dc2c17a6fd1892deaa0a09d8ac6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_12f2ad9b","line":293,"in_reply_to":"3fa7e38b_720e8133","updated":"2019-10-03 13:11:13.000000000","message":"Hm I don\u0027t like that approach, can\u0027t we supply those as parameters with the same default value as puppetlabs-apache has and simply expose that where you need it?","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"0b0f481858eadfeb6fc6f5f3f09acb8a9c340850","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_121b8d73","line":293,"in_reply_to":"3fa7e38b_cf2f92a5","updated":"2019-10-03 12:36:23.000000000","message":"It\u0027s a definition, not a class, hence: https://github.com/openstack/puppet-openstacklib/blob/master/spec/defines/openstacklib_wsgi_apache_spec.rb","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e9d8c76167c530e6ceef88ec72f1fbb2c61e02ae","unresolved":false,"context_lines":[{"line_number":290,"context_line":"    $wsgi_script_aliases_real \u003d $wsgi_script_aliases_default"},{"line_number":291,"context_line":"  }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":294,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"},{"line_number":295,"context_line":"    servername                  \u003d\u003e $servername,"},{"line_number":296,"context_line":"    ip                          \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3fa7e38b_af17b651","line":293,"in_reply_to":"3fa7e38b_cf2f92a5","updated":"2019-10-03 12:34:14.000000000","message":"ah, it\u0027s a define :-)","commit_id":"a1e213b3b38fc8cdeb83f79f84172470728fe546"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"d5a5496badb0c361d5ff4144008eb1c4fac8c3e7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"#   WSGIChunkedRequest option in the vhost."},{"line_number":135,"context_line":"#   Defaults to undef"},{"line_number":136,"context_line":"#"},{"line_number":137,"context_line":"# [*wsgi_import_script*]"},{"line_number":138,"context_line":"#   (Optional) Activate WSGIImportScript option."},{"line_number":139,"context_line":"#   Defaults to false"},{"line_number":140,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3fa7e38b_3a02e20a","line":137,"range":{"start_line":137,"start_character":4,"end_line":137,"end_character":22},"updated":"2019-10-08 09:46:23.000000000","message":"What if the script to import isn\u0027t the standard wsgi module e.g because it doesn\u0027t perform init correctly on import?\n\nI guess we could address that issue later if it ever comes up. However it might be best to change this param name and leave \"wsgi_import_script\" available.","commit_id":"3225b9c4fc8f5226034dbce4660df6851cdad2a0"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b9dfc19d61bd5d5b1843cac85b12d152e8fbcefd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"#"},{"line_number":141,"context_line":"# [*wsgi_import_script*]"},{"line_number":142,"context_line":"#   (Optional) WSGIImportScript path."},{"line_number":143,"context_line":"#   Defaults to undef"},{"line_number":144,"context_line":"#"},{"line_number":145,"context_line":"# [*wsgi_import_script_options*]"},{"line_number":146,"context_line":"#   (Optional) Sets WSGIImportScript options."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_7cc0522b","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":21},"updated":"2019-10-08 15:05:35.000000000","message":"nit: could explain the default behaviour when it\u0027s not set","commit_id":"52177548332be67fa495010950575e545df45f40"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39335f2c22c1feca44b74706a68642acf70e4de0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"#"},{"line_number":141,"context_line":"# [*wsgi_import_script*]"},{"line_number":142,"context_line":"#   (Optional) WSGIImportScript path."},{"line_number":143,"context_line":"#   Defaults to undef"},{"line_number":144,"context_line":"#"},{"line_number":145,"context_line":"# [*wsgi_import_script_options*]"},{"line_number":146,"context_line":"#   (Optional) Sets WSGIImportScript options."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_022e8df9","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":21},"in_reply_to":"3fa7e38b_7cc0522b","updated":"2019-10-09 06:16:01.000000000","message":"hmm right. Will update it, and address Alex comment as well.","commit_id":"52177548332be67fa495010950575e545df45f40"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d9db43945e739e2db5df02f5b833c3a19c2fb387","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    error_log_syslog            \u003d\u003e $error_log_syslog,"},{"line_number":338,"context_line":"  }"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"  if $set_wsgi_import_script {"},{"line_number":341,"context_line":"    if $wsgi_import_script {"},{"line_number":342,"context_line":"      $load_path \u003d $wsgi_import_script"},{"line_number":343,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_6230ace9","line":340,"updated":"2019-10-08 15:20:38.000000000","message":"why aren\u0027t we just moving this above the apache::vhost since it has the same default values as that resource then set it there?","commit_id":"52177548332be67fa495010950575e545df45f40"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39335f2c22c1feca44b74706a68642acf70e4de0","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    error_log_syslog            \u003d\u003e $error_log_syslog,"},{"line_number":338,"context_line":"  }"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"  if $set_wsgi_import_script {"},{"line_number":341,"context_line":"    if $wsgi_import_script {"},{"line_number":342,"context_line":"      $load_path \u003d $wsgi_import_script"},{"line_number":343,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_42eec5b4","line":340,"in_reply_to":"3fa7e38b_6230ace9","updated":"2019-10-09 06:16:01.000000000","message":"because we probably don\u0027t want to enable this by default, and would make the reading less easy with a more complicated \"if-else-foo\" block. Here, we take profit of what puppet provides for easy overrides, making it smooth, easy to understand and maintain.","commit_id":"52177548332be67fa495010950575e545df45f40"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d0a87b30f3f8613e5c34683b8d46199342a474be","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      $load_options \u003d $wsgi_import_script_options"},{"line_number":348,"context_line":"    } else {"},{"line_number":349,"context_line":"      $load_options \u003d {"},{"line_number":350,"context_line":"          process-group     \u003d\u003e $wsgi_daemon_process,"},{"line_number":351,"context_line":"          application-group \u003d\u003e $wsgi_application_group,"},{"line_number":352,"context_line":"        }"},{"line_number":353,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_a176a5d7","line":350,"range":{"start_line":350,"start_character":10,"end_line":350,"end_character":23},"updated":"2019-10-08 14:43:31.000000000","message":"nit: I would wrap the keys in quotes","commit_id":"52177548332be67fa495010950575e545df45f40"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"39335f2c22c1feca44b74706a68642acf70e4de0","unresolved":false,"context_lines":[{"line_number":347,"context_line":"      $load_options \u003d $wsgi_import_script_options"},{"line_number":348,"context_line":"    } else {"},{"line_number":349,"context_line":"      $load_options \u003d {"},{"line_number":350,"context_line":"          process-group     \u003d\u003e $wsgi_daemon_process,"},{"line_number":351,"context_line":"          application-group \u003d\u003e $wsgi_application_group,"},{"line_number":352,"context_line":"        }"},{"line_number":353,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3fa7e38b_a234594b","line":350,"range":{"start_line":350,"start_character":10,"end_line":350,"end_character":23},"in_reply_to":"3fa7e38b_a176a5d7","updated":"2019-10-09 06:16:01.000000000","message":"will do with the doc update/correction.","commit_id":"52177548332be67fa495010950575e545df45f40"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2ffa0a07b9eb2f476496026d0bb6cf9d3f2adbf5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"#   (Optional) WSGIImportScript path."},{"line_number":143,"context_line":"#   Defaults to undef"},{"line_number":144,"context_line":"#   If not set and set_wsgi_import_script is true, takes"},{"line_number":145,"context_line":"#   $wsgi_script_aliases_real[$path_real] as value"},{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"# [*wsgi_import_script_options*]"},{"line_number":148,"context_line":"#   (Optional) Sets WSGIImportScript options."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_742298bb","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":41},"updated":"2019-10-09 12:00:58.000000000","message":"nit: that\u0027s really an internal implementation detail. In this context \"If not set and set_wsgi_import_script is true, defaults to the WSGI application module path\" would be clearer.","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e44e60bb81615289f33e42a2fae8dfe6ec4e0a5b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"#   (Optional) WSGIImportScript path."},{"line_number":143,"context_line":"#   Defaults to undef"},{"line_number":144,"context_line":"#   If not set and set_wsgi_import_script is true, takes"},{"line_number":145,"context_line":"#   $wsgi_script_aliases_real[$path_real] as value"},{"line_number":146,"context_line":"#"},{"line_number":147,"context_line":"# [*wsgi_import_script_options*]"},{"line_number":148,"context_line":"#   (Optional) Sets WSGIImportScript options."}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_9dcdf731","line":145,"range":{"start_line":145,"start_character":4,"end_line":145,"end_character":41},"in_reply_to":"3fa7e38b_742298bb","updated":"2019-10-09 14:23:35.000000000","message":"Done","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2ffa0a07b9eb2f476496026d0bb6cf9d3f2adbf5","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        }"},{"line_number":324,"context_line":"    }"},{"line_number":325,"context_line":"  } else {"},{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_946954f9","line":326,"range":{"start_line":326,"start_character":5,"end_line":326,"end_character":17},"updated":"2019-10-09 12:00:58.000000000","message":"nit: convention would be to name this $wsgi_import_script_options_real","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e44e60bb81615289f33e42a2fae8dfe6ec4e0a5b","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        }"},{"line_number":324,"context_line":"    }"},{"line_number":325,"context_line":"  } else {"},{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_5ddbffeb","line":326,"range":{"start_line":326,"start_character":5,"end_line":326,"end_character":17},"in_reply_to":"3fa7e38b_946954f9","updated":"2019-10-09 14:23:35.000000000","message":"Done","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2ffa0a07b9eb2f476496026d0bb6cf9d3f2adbf5","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    }"},{"line_number":325,"context_line":"  } else {"},{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_b46ed0fd","line":327,"range":{"start_line":327,"start_character":5,"end_line":327,"end_character":14},"updated":"2019-10-09 12:00:58.000000000","message":"nit: convention would be to name this $wsgi_import_script_real","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e44e60bb81615289f33e42a2fae8dfe6ec4e0a5b","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    }"},{"line_number":325,"context_line":"  } else {"},{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_7dd83bee","line":327,"range":{"start_line":327,"start_character":5,"end_line":327,"end_character":14},"in_reply_to":"3fa7e38b_b46ed0fd","updated":"2019-10-09 14:23:35.000000000","message":"Done","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2ffa0a07b9eb2f476496026d0bb6cf9d3f2adbf5","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":332,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_14a8041e","line":329,"range":{"start_line":329,"start_character":2,"end_line":329,"end_character":43},"updated":"2019-10-09 12:00:58.000000000","message":"nit: are the comments necessary?","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"e44e60bb81615289f33e42a2fae8dfe6ec4e0a5b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":332,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_3dde43da","line":329,"range":{"start_line":329,"start_character":2,"end_line":329,"end_character":43},"in_reply_to":"3fa7e38b_14a8041e","updated":"2019-10-09 14:23:35.000000000","message":"I\u0027d rather ensure later editors know what\u0027s going on in there.","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"2978293cd370b60bfdfb3ad9d091022c7e3a790c","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    $load_options \u003d undef"},{"line_number":327,"context_line":"    $load_path \u003d undef"},{"line_number":328,"context_line":"  }"},{"line_number":329,"context_line":"  # End of WSGIImportScript related options"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"  ::apache::vhost { $service_name:"},{"line_number":332,"context_line":"    ensure                      \u003d\u003e \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3fa7e38b_e379ecfb","line":329,"range":{"start_line":329,"start_character":2,"end_line":329,"end_character":43},"in_reply_to":"3fa7e38b_3dde43da","updated":"2019-10-09 15:43:46.000000000","message":"alright, but if they don\u0027t know what\u0027s going on when they read \"if $set_wsgi_import_script {\" and \"}\" then they have much bigger problems ;-)","commit_id":"fd3302979e34fd80296fad870d7b29a503bd36f7"}]}